- 29 Apr, 2019 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9286adcb0f7e..bbed4577964d git log 9286adcb0f7e..bbed4577964d --date=short --no-merges --format='%ad %ae %s' 2019-04-29 cwallez@chromium.org Texture: Add validation that the mip chain can't be too large Created with: gclient setdep -r src/third_party/dawn@bbed4577964d The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel BUG=chromium:954769 TBR=cwallez@chromium.org Change-Id: Ie307b4471d59976c6dfeb4c8f7d5d2fec98a1062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654860}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e670fd97951a..c0c7d36e80b4 git log e670fd97951a..c0c7d36e80b4 --date=short --no-merges --format='%ad %ae %s' 2019-04-29 alessiob@webrtc.org RNN VAD: clean-up unit tests 2019-04-29 henrika@webrtc.org Revert "Piping audio interruption metrics to API layer" 2019-04-29 danilchap@webrtc.org Remove deprecated AudioDeviceModule factory 2019-04-29 peah@webrtc.org Only create AECm when needed 2019-04-29 nisse@webrtc.org Delete unused StartAecDump method with filename argument 2019-04-29 ilnik@webrtc.org Make FrameBuffer be able to signal if it's trivially convertible to I420 2019-04-29 nisse@webrtc.org Delete deprecated version of AudioPacketizationCallback::SendData. 2019-04-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 982e2994..8ce20eb9 (654706:654807) 2019-04-28 ilnik@webrtc.org Crash with error message if failed to allocate memory via AlignedMalloc 2019-04-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 59aee65d..982e2994 (654597:654706) 2019-04-27 mellem@webrtc.org Stop DCHECK which occurs in ANA BitrateController when overhead is zero. 2019-04-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9e7b598a..59aee65d (654486:654597) 2019-04-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 19227549..9e7b598a (654383:654486) 2019-04-26 srte@webrtc.org Revert "Reland "Improving robustness of feedback matching code in event log parser."" 2019-04-26 nisse@webrtc.org Delete unused methods of VCMJitterEstimator 2019-04-26 henrik.lundin@webrtc.org Piping audio interruption metrics to API layer 2019-04-26 nisse@webrtc.org Deprecate RTPFragmentationHeader argument to AudioPacketizationCallback::SendData Created with: gclient setdep -r src/third_party/webrtc@c0c7d36e80b4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:930186,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9bc479c92351a47b0450f64980b2e80704433d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587443Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d235eb236573..8c4839fee907 git log d235eb236573..8c4839fee907 --date=short --no-merges --format='%ad %ae %s' 2019-04-29 perezju@chromium.org Reland "[trace_data] Add AddTraceFileFor method" Created with: gclient setdep -r src/third_party/catapult@8c4839fee907 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:928278 TBR=eyaich@chromium.org Change-Id: I3e7cecc5dd485b4a4d29e4bbed52472c04053d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586994Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a278d06..9b91e472 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic1398a4ad4d3d5085a03bb28689e991464c021f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587835Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654857}
-
Owen Min authored
"RetainingOneShotTimer doesn't repeat the task itself like *OneShotTimer*" This should be *RepeatingTimer* as OneShotTimer doesn't repeat. Change-Id: I087bd65d83f1652d1baca71550f009c8dc5c18ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586541 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#654856}
-
Adithya Srinivasan authored
This reverts commit 7e9b4790. Reason for revert: Causing test failure on Msan bot https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12589 Original change's description: > Ash Tray: Add fade out animation for notification controls when sliding. > > This change removes a double slide animation when the user flings to > dismiss a notification. > > TEST=manually verified, new unit test > BUG=933640 > > Change-Id: I7f9f4e558dfa53e8acf0abdbd86cf4449c1ea891 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583344 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654564} TBR=tengs@chromium.org,tetsui@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 933640 Change-Id: Idb4c0f5be2dfc764db01b702ccd7a938b565ed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588435Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#654855}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib537f20a24673cabcf9e4da617d559916610d56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587445Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc94e79eb7b6..d425dee662d1 git log bc94e79eb7b6..d425dee662d1 --date=short --no-merges --format='%ad %ae %s' 2019-04-29 robertphillips@google.com Enable opList sorting everywhere Created with: gclient setdep -r src/third_party/skia@d425dee662d1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I9058b88ad67c53c9f313a6c0196e53d4fc0de287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588195Reviewed-by:
-
Amr Aboelkher authored
- Check for the policy's pref value before appending its switch Bug: 949184 Change-Id: Ib25e61ada0ba0592e6b91619313ec402c5a8a062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578605 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#654852}
-
Gauthier Ambard authored
The provider is used to install overrides. Reland of https://crrev.com/c/1584265 Bug: 954570 Change-Id: I424b6d59c702094020fec20495145f76b6c18646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587886Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#654851}
-
Xi Han authored
Rename profile_policy_connector_factory.h(cc) to profile_policy_connector_builder.h(cc). We can preserve the history of this file. Bug: 937469 Change-Id: I91d8957370824d58869999e8f6ad0cadd2ea3e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585462 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#654850}
-
Elly Fong-Jones authored
This does not remove the backing code or feature. Bug: 957297 Change-Id: I2dcb70048963d2ab31d5780a051f423f1cc231d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585538 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#654849}
-
Leonard Grey authored
This gets called a *lot* when fetching colors while painting which assumes it's cheap. In fact, it's responsible for about 25% of paint time on Windows and ~6% on Mac (per profiling in the field). Bug: 950063 Change-Id: I57905fffeb51b884a0e94bac28e10b05caacd180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565063Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#654848}
-
Stephane Zermatten authored
Before this change, WebController would attempt to scroll an element to be clicked using the same logic as used to focus on an element. This produced strange behavior on some websites, when zoomed, with the element to click appearing and disappearing from the viewport. This is a likely cause of reported issues with clicking when zoomed in. With this change, WebController calls ScrollIntoViewIfNeeded instead of trying to scroll nicely. It results in stabler behavior when zoomed: It removes the flickering of element to click that was observed. Bug: b/123958732 Change-Id: Id890737ffe48ee6ed21061222a65c2488041b73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587027Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#654847}
-
Wojciech Dzierżanowski authored
Each Web Worker runs on a separate worker thread, and each worker has an associated URLLoaderThrottleProvider. When spawning a nested worker, the outer worker's throttle provider is cloned on the outer worker's thread and then used on the inner worker's thread. To accomodate this scenario: - Postpone the creation of DataReductionProxyThrottleManager until a moment when we are running on the target thread. This makes sure the DataReductionProxyThrottleConfigObserver binding is used on the same thread that it's created on. - Postpone the binding of DataReductionProxy until a moment when we are running on the target thread. DataReductionProxyPtrInfo serves as a holder of the interface request that can move between threads. Bug: 942011 Change-Id: Ieed17fb499bbcb0545e3e0323f751c1ea55a33d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565873Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#654846}
-
Xi Han authored
In this CL, we add a getter in Profile to access ProfilePolicyConnector, which is owned by Profile. With this CL, ProfilePolicyConnector should always be accessed via Profile::GetProfilePolicyConnector(). Bug: 937469 Change-Id: I7a6104f4a09be01b6e35663b7989d0bc01afd629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572366 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#654845}
-
Dominik Röttsches authored
Font scanning and lookup table construction is only required for font local matching pre Windows 10. If the timeout is hit, no local font matching will be performed on this particular pre Win 10 system. Previously we had this set to 15 seconds, which did mean timeouts on a number of systems, but also previously the render was waiting synchronously for a result, which is no longer the case. Experimentally raise this to 150 to see what scanning times are occuring in the field. Since the renderer is no longer synchronously waiting, in order to avoid startup jank due to contention, reduce priority to BEST_EFFORT. Currently only active behind an experiment configuration. Bug: 889864, 931366 Change-Id: I19da2ef1e826b8c72a7ea6f0d22814e3e1c35366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581627 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#654844}
-
Eric Stevenson authored
To move shared Java code into TrichromeLibrary, a single Proguard run needs to include the Java code from TrichromeChrome, TrichromeLibrary, and TrichromeWebView. This CL implements synchronized proguard by: * Adding dependencies between the 3 APKs * Making the library APK compute the union of all Java dependencies using .build_configs * Running dexsplitter to create dex files for each of the 3 APKs Two temporary targets, trichrome_library_for_bundle_apk and trichrome_webview_for_bundle_apk, are added so that we can support both the bundle and non-bundle version of TrichromeChrome until we remove support for the APK version. Change-Id: Ib77e22d50de3f64152c95f3a8cf7328a308a7e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554898 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#654843}
-
Xida Chen authored
This CL creates a new virtual test suite for Off-thread PaintWorklet, the specific flag that is enabled is OffMainThreadCSSPaint. Bug: 953271 Change-Id: Ibc73102d1f6193d0b1dade53dfbae2270d9aa04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568951Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#654842}
-
Dave Tapuska authored
V8 change has landed. TestExpectations for the change can be removed BUG=948257 Change-Id: If71dc39daf5037a530a74e3d3dc8401b492fffd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577995 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#654841}
-
Vadym Doroshenko authored
Crowdsourcing is based on signatures not domains, but when Chrome receives server-response, it knows the domain. Since in most cases all forms on the site have the same requirements, it's possible to use crowdsourcing password requirements for other forms. This CL implements this. 1.It makes applying of password requirements more robust: as soon as requirements found for one form on some site, they would be available for all forms, this makes generation more robust when the form signature changed after form load. 2.As a result of this CL crowdsourcing password requirements will be used on iOS. Bug: 886583, 956982, 846694 Change-Id: Ib18f072913ec3ac4e25c855c62f6f8772e294454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584290Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#654840}
-
Kevin Ellis authored
Previously a missing start time or timeline would result in current time being computed as zero rather than null. In addition, the ordering of checks in current time was not to spec. Note that this patch does not fully address the failures in the setting-current-time-of-an-animation test. The remaining failure is due to incorrect handling of play state (pause vs pending) and missing API (animation.pending and animation.updatePlaybackRate). Bug: 818196, 771722 Change-Id: I363d22f9c4098eac6dbc92a3aac4076378de7adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573662Reviewed-by:
-
Alex Clarke authored
This patch introduces the debug only option to log when the run loop quits which is useful in diagnosing flaky tests. Unfortunately the new bool in SequenceManager::Settings is enough to make the clang plugin decide it needs an out of line constructor / destructor. We can't do that because the existing brace style initalizations no longer compile, so we refactor to use a builder pattern. Bug: 863341 Change-Id: I33fc28fa72fce4beead8a6c524d9f2aab93cf1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581802Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#654838}
-
Chris Hamilton authored
This integrates the recently added TaskAnnotator IPC message decoration into Mojo and legacy IPC handlers. This causes all PendingTask objects to be decorated with a program counter that uniquely identifies the IPC message that was being handled when that task was posted. This work is discussed in the following design doc: https://docs.google.com/document/d/1soCnDaQUug_Q4oadX1YxynjzookCh9Aj1fL-HOCwnEY/edit?pli=1# The net binary size impact is O(50kB) across platforms, which after much discussion was deemed a reasonable trade off. BUG=950668 Change-Id: Ibf36cf177b09f8ed8919fd19caebce137249c4c6 Binary-Size: Increase due to new instrumentation. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586318 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#654837}
-
about://flagsMikel Astiz authored
The feature toggles, which have been enabled for some time now, are about to be removed. As a prior step, we remove them from about://flags. Bug: 933874 Change-Id: I121bc774b73cb6dc35436c1438d6eba8d568788d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587568 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#654836}
-
Yannic Bonenberger authored
[docs] Remove duplicate command and add instruction how to retrieve full history after fetching with `--no-history` R=dtapuska@chromium.org Change-Id: Iea9f3fb760e313d4ed90ec362d368b71202ddec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584278Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Cr-Commit-Position: refs/heads/master@{#654835}
-
David Jean authored
Remove banned initializer list usage in new password form manager. Bug: 956581 Change-Id: I11c5bf077d003016baf2007d702aea29aa65a0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587566Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#654834}
-
Michael Lippautz authored
Bug: 957461 Change-Id: I24c54ad9a06e70acb87bfdaa424a678ebd8fbd84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587029Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#654833}
-
Mikel Astiz authored
We are about to remove the feature toggles, which have been enabled by default for some time, so let's start removing test coverage in sync integration tests. Bug: 933874 Change-Id: I7e1265ff5f59deb514c09d3ce9f988db0706ab96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587598 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
This test tests navigator.mediaDevices.getSupportedConstraints(), but navigator.mediaDevices has recently become SecureContext in the spec, so the test should be run with HTTPS. Bug: 957546 Change-Id: I70608398481b1891eee77ecd8361aa9f03ac87ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587031Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#654831}
-
Annie Sullivan authored
Also fix code links in documentation. TBR=crouleau@chromium.org,tdresser@chromium.org Change-Id: Id9be6d9342d29d34a4d5c4aaa399915e5e7c3516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587838Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#654830}
-
Peter Wen authored
Create a new directory for code that features can depend on without needing to depend on chrome_java: //chrome/android/public Having a new directory allows DEPS to make sure that new code in public/ does not depend on code in features/ or java/. The first example is lifecycle. These interfaces do not directly depend on chrome_java implementations. Breaking them out makes that fact clear and allows other features to register lifecycle callbacks without depending on chrome_java. Bug: 846440 Change-Id: I101a927a6be2c18d2dda57c6997ac9b33c4d366d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581823Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#654829}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I9e67aa85d12ddbfc25b02f2ed687db432cff24b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587442Reviewed-by:
-
Henrik Grunell authored
This is to allow mocking the OS calls in tests. Introduces an wrapper interface, a function for tests to inject their own implementation, and an internal implementation that wraps the actual OS calls used if a wrapper for testing has not been set. Change-Id: Iaebf3a274a7a0f5c89f8b50a16fc0c84acc025c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565321Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#654827}
-
David Roger authored
This CL is a code cleanup of the multilogin code. The code is split in two new classes, and should be a lot clearer. The retry logic has been revisited, and in particular a potential infinite loop was removed: in the previous code, a "invalid tokens" response was always retried. The code was relying on Android (GMSCore) to invalidate and evict the access token, so that the same token is not retried endlessly. However, in case of a GMSCore bug, an infinite loop may happen. We don't have a proof that this was happening, but as we have seen a large number of errors coming from a few devices, this CL adds protection against this and only retries once. Change-Id: I097b6104f12f6abb65b1a30f75d753cef6610c17 Bug: 957536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572131 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#654826}
-
Armando Miraglia authored
The state "muted" was removed as exposed interface in JavaScript in 2017. Since the related bug has already been closed and marked as fixed, this CL removes the state and the associated comment from the IDL since stale. BUG=651414 Change-Id: I972c00cc4e59410e18391fad10c74af9d5131d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587881Reviewed-by:
-
Jérôme Lebel authored
Adding footer with: "For more settings that relate to privacy, security, and data collection, see Sync and Google Services.", in Private settings. With a link in the string to open the Sync and Google Services settings. https://drive.google.com/open?id=1MNsIMDmYlsb9TKDLSSYpblCXpD1x4Mmj Bug: 956731 Change-Id: Icd918df58039f9b0d676982c3e3c01a22fbca109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587885 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#654824}
-
Javier Ernesto Flores Robles authored
Bug: 951303, 951300 Change-Id: I5d880dcaf978a725aa809dc9befa26b9a91c47da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581584 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#654823}
-
Stephane Zermatten authored
Before this change, it was possible to successfully submit an invalid CVC from CardUnmaskPrompt, by using the virtual keyboard submit button instead of hitting "Confirm". After this change, hitting the submit button on the virtual keyboard only works once a valid CVC has been input. Bug: b/129732958 Change-Id: I0318d805f30d81a8ffbff7c823e5f41d5c2f881a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587877Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#654822}
-
Morten Stenshorne authored
If we need to reattach any OBJECT when entering printing, we cannot wait for the resource to load again. This was especially bad for LayoutNG, which switches the document back to legacy layout for printing, so that everything gets reattached, so that no OBJECT would print. To fix this, allow ContentFrame() to be re-used when re-attaching. Bug: 913929 Change-Id: I3b11b0550a775c8df1c0449c2438569aa8219091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1459542Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
