- 08 Sep, 2020 40 commits
-
-
Antonio Sartori authored
Bug: 1094909 Change-Id: Ia823b00ae5f62188547f714026d7dece11b9933e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351771 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#804872}
-
Alice Wang authored
This CL fixes the threading bug for ChromeBackupAgent. Bug: 1121344 Change-Id: I1fb2e1935ac602db70a660dc468bf89016f0873f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391142 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#804871}
-
Gauthier Ambard authored
The test is flaky on iOS 12. Fixed: 1095534 Change-Id: I31acfa4187a3e14edd76914131d08b35beff30ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396115 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804870}
-
Alexander Timin authored
WebContentsImpl is a major class responsible for routing many events between different parts of //content and between //content and the rest of the codebase (e.g. //chrome and //components). Add trace events to all non-trivial methods to ensure that it's possible to understand the execution flow from reading the trace. Together with crrev.com/2343269 this in particular would allow the user of the tracing to know which WebContentsObserver notifications were dispatched. R=nasko@chromium.org BUG=1043616 Change-Id: If00550c233ab16186a2ebf9f4042c5f1fd457fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240326 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#804869}
-
Pavol Marko authored
Adds additional errors to the cert provisioning result: BAD_PUBLIC_KEY: the backend has performed some checks on the client-provided public key and did not accept it. Also improve comment. Bug: 1045895 Test: compiles Change-Id: I161519c831829677ce911ca190569e4fcbf5d207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390907Reviewed-by:
Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#804868}
-
Kent Tamura authored
- This directory depends on html/parser:parser, which is a part of "core", but "core" didn't expose it. This CL has no behavior changes. Bug: 800764 Change-Id: I54c621d93b0fc3959197d88ec7363f2670060e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397456 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#804867}
-
Victor Hugo Vianna Silva authored
The motivation is that AndroidSyncSettings will soon have different behaviors depending on Chrome's startup state, so we need to be able to fake the appropriate state in tests before actually constructing the object. We also take the time to update some documentation of this class that became inaccurate with crrev.com/c/2366895. Bug: 1125622 Change-Id: I7fd0399bcb49024f151b78c7a234f99601481948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396335 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#804866}
-
Antonio Sartori authored
After reimplementing Content-Security-Policy: Embedded Enforcement in services/network, I forgot to port some unit tests for the subsumption algorithm from blink. Bug: 1094909 Change-Id: Idfc2a47d791f6eb85190757e12933fffe270cb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349298 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
-
Michael Lippautz authored
CTWP is a weak ref used on a different thread than the object has been original been allocated on. Using the object directly is inherently unsafe as garbage collection only consider the stack of the thread the heap is attached to. For that reason, working on an object must require a strong reference. Note that this does not rule out issues, as the originating thread may terminate in which case even the strong CrossThreadPersistent does not keep the object alive. Nonetheless, the only valid use case of a CTWP should be weakly pointing to an object. The CL introduces a Lock() call, similar to std::weak_ptr::Lock() with the same semantics: The reference (CTP) needs to be check against cleared'ness before the object can be used. Blink: Most use cases rely on external synchronizations when accessing a CTWP, so this change merely hardens the API but likely does not fix any real issues. Bug: 1125495 Change-Id: Ib859df5e9c5f418aa36797c4bd9a444de8c82b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391231 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#804864}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cafd6b657827..5422981b71e3 2020-09-08 chrche@microsoft.com [network] Fix Null Pointer Exception with data grid createCells If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0923c2f56d0465e18e02ea2a7fd99d272b1f9c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397012Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804863}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599436335-52e1c862010d0691dd04c2a7a430ef4fc681e61e.profdata to chrome-mac-master-1599544645-2607fe83108ec346cd143f52f7129c53aeca332a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I900e99e7be26b49c75ffdfa8d8e1e2b556b14710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397663Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic99591d89663524d2391a5d134474b4f4267548f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397014Reviewed-by:
-
Side Yilmaz authored
AsyncInitializationActivity preconnects with always regular profile, even called in incognito. However preconnect should be blocked for OTR profiles, since LoadingPredictorFactory doesn't support OTR profiles. This CL checks the extras of intent and blocks the preconnect if there is any extra related to incognito. Note that, this code block will be called by IncognitoCCT that has non-primary OTR profile. Hence, we need to block this flow not to cause data leakage from OTR profiles to regular profile. Bug: 1041781, 1075562 Change-Id: I1365bdfa9b63c8e904740d3ffaccc34a628b6caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379892Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804860}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/390014529fa1..cd54c8385c31 2020-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 72f6b99c29f2 to 07d44b97cf65 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I473225281685b5c5c9d9e8032f04ab249f90c251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397657Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit 7e47f6d4. Reason for revert: Possible culprit of failures on Linux Tests (dbg)(1) First failing build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/b8870138525564824400 All failing tests have the following lines: LaunchProcess: failed to execvp: xdg-desktop-menu No such file or directory LaunchProcess: failed to execvp: xdg-icon-resource Original change's description: > Improved error reporting when execvp fails > > Currently the execvp fails for a launch process it does not give > much diagnosis. This change reports the errno reason why the execvp > failed. This has been useful in finding simple naming errors. > > Change-Id: Ifcc33c87931535019d8509234818c9d995fa4b9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383292 > Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804383} TBR=penghuang@chromium.org,dcheng@chromium.org,rsesek@chromium.org,fangzhoug@chromium.org,petermcneeley@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I1b39de8b004e4318560c8a304043057d040f2e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397476Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#804858}
-
danielng authored
Some minor changes for cleaning up some of the installer code and making it more testable. Unit tests being introduced here CL:2392163 and browser tests here CL:2392285. Tests: Tested manually on my test device and ran the new tests. Bug: b:161650651 Change-Id: Ia241ec790096b33b56b54fcb579b08eef3a9ace8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391891 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#804857}
-
Antonio Sartori authored
This CL adds one missing step to the Subsume algorithm of the services/network Content-Security-Policy module, checking the plugin-types directives Although the plugin-types directive is ignored in the current version of the spec https://w3c.github.io/webappsec-cspee, subsumption is already being checked in the blink module, and we reimplement the same logic here. Bug: 1094909 Change-Id: Iae43bac96b111667623cad923f913165c8f02c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346356 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
This CL adds the MVC elements of the incognito interstitial view and also adds the functionality of the "Learn more" and "Continue" buttons. This CL also adds Robolectric tests to tests the Incognito Interstitial delegate. The instrumentation tests would be followed up later. The strings to the incognito interstitial would be added later. Bug: 1120350, 1119280 Change-Id: I2c212029a6d440f95c074c04b068223dacaaba4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359032Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#804855}
-
Rakina Zata Amni authored
The equality of the "cross origin isolated" value should not be checked if it's still speculative, and some other cases covered by IsSiteInstanceCompatibleWithCoopCoepCrossOriginIsolation. Bug: 1107814, 1096135 Change-Id: I37152bbc348d598dc4612666bfc181da60e75555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385255 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#804854}
-
Jose Dapena Paz authored
Bug: 957519 Change-Id: I7b763c1d5dee77d3a2b12f5169d6ad86e5dcbc7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394164 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804853}
-
phillis authored
This is a reland for https://chromium-review.googlesource.com/c/chromium/src/+/2198369. It adds test for the flow of initiating uninstall and accept/cancel the uninstall action. It also fixes a bug that the autoconfirm for testing is called before the widget is instantiated by |constrained_window::CreateBrowserModalDialogViews| Bug: 1073258 Change-Id: Id0f1fff4bdaa4901b50b3d3c12271d54ad1c2e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382952 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#804852}
-
Gauthier Ambard authored
This CL makes sure that the status bar appearance is correctly updated when switching mode (icognito/normal) through opening a new tab. The status bar theme is chosen based on the childViewControllerForStatusBarStyle property of the TabGrid. The notification of UIKit is done at the same time as the child view controller is updated. Fixed: 1122239 Change-Id: I847c4d1d70148cabbd824e4bdb40b7aa6fd50847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395735Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#804851}
-
Fergus Dall authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/8152eec38dd1..fd5a98f6204f $ git log 8152eec38..fd5a98f62 --date=short --no-merges --format='%ad %ae %s' 2020-08-20 hollingum vm_tools: Make concierge boot vm's that are DLCs. 2020-08-19 hashimoto arc: Add arc-host-clock-service Created with: roll-dep src/third_party/cros_system_api Bug: 953544 Change-Id: I1db8914d3d850a43e838c15ac6542433cd695e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397124 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/611a52108b01..390014529fa1 2020-09-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from fd16dd07 to e96bb06c (177 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Ie137578331eb02fee3f40d53ac7a2affe2774d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397005Reviewed-by:
-
Alice Boxhall authored
This is a reland of b89144a4 Original change's description: > Add pixel test for AccessibilityFocusHighlight based on FocusRingBrowserTest > > AX-Relnotes: n/a > > Bug: 1114959 > Change-Id: Ib6d9f51a04fa8059dc6bd6192d182b8e0244367d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352451 > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803007} TBR=ellyjones@chromium.org,jarhar@chromium.org Bug: 1114959 Change-Id: Iafc75d4e55624eb77b76b82c3336fb714635e18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393411 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#804848}
-
Giovanni Ortuño Urquidi authored
This reverts commit 41e61b9b. Reason for revert: Breaks linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8230 Original change's description: > Add four finger swipe gesture commands to move from pane to pane > > See go/chromevox-touch-gestures > > R=akihiroota@chromium.org > > AX-Relnotes: Adds four finger swipe for ChromeVox to move among on-screen panes (launcher, status tray, web page, etc). > Bug: 1124454 > Test: browser_tests --gtest_filter=ChromeVox*.SwipeLeftRight* > Change-Id: Ie8a98c53d456e3a2e632f4307622494f8f82f3e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379458 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804466} TBR=oshima@chromium.org,lazyboy@chromium.org,dtseng@chromium.org,akihiroota@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1124454 Change-Id: If061e3c3dd1df6df8eb28685d6cceda17807a5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397379Reviewed-by:
-
Eric Willigers authored
We now record the ShareTarget manifest members in the database. https://w3c.github.io/web-share-target/level-2/#sharetarget-and-its-members This CL has no behavior changes outside the database. Bug: 1125880 Change-Id: I630b4942357bfe26025497a134c56ca560e98943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396056 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#804846}
-
tby authored
There are two issues affecting suggested files ranking only on branded builds: 1. Some arc apps return apps all with the same score. This is unexpected and crowds out files, which are ranked by slotting file results between app results (for legacy reasons) 2. Policy chips like continue reading, assistant, arc reinstall, or the release notes aren't accounted for when determining the number of chips available for ranked results, also leading to files being crowded out. This CL fixes these issues with minor tweaks to the ranking algorithm. Bug: 1124452 Change-Id: Ie6ac40797d5dca1ac47eac131ca5c0cbf76048bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395319Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#804845}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0c069f3956ff..cafd6b657827 2020-09-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4a1054a7b8c38e78a5e5b8b2ee11db67575dfc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397002Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit 7138b785. Reason for revert: Suspected of breaking SitePerProcessBrowserTest.TwoSubframesCreatePopupMenuWidgetsSimultaneously First failing build: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/b8869837198909294608 BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x559ad6eab7c9 base::debug::CollectStackTrace() #1 0x559ad6e2def3 base::debug::StackTrace::StackTrace() #2 0x559ad6ab8a96 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fe4e02044c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x559ad9fe3f7b views::DesktopWindowTreeHostPlatform::Show() #5 0x559ad9fb9a14 views::Widget::Show() #6 0x559ad9fdf230 views::(anonymous namespace)::DesktopNativeWidgetAuraWindowParentingClient::GetDefaultParent() #7 0x559ad6e0ee49 aura::client::ParentWindowWithContext() #8 0x559ad66b0c08 content::RenderWidgetHostViewAura::InitAsPopup() #9 0x559ad67c22ae content::WebContentsImpl::ShowCreatedWidget() Original change's description: > ozone/wayland: Fix drop down menus for touch events. > > In case of touch events, we may not find currently focused windows > as menu windows might be created on touch up events. Thus, > GetCurrentFocusedWindow returns nullptr. > > To fix that, use a concept of a currently active window. That is, > Wayland sets a window to "active" state if it has had a focus. > There can be only one focused window at a time. > > Thus, if there is no a focused window, use currently active window > as a parent. That's the best effort one could make to find a parent > window for a newly created non-toplevel window. At some point, > it might be worth reconsidering the design and make aura always pass > parent widgets for new windows if applicable. > > Bug: 1123521 > Change-Id: Ib9479632e049df082ed17e3089680006a32f19fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385279 > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#804674} TBR=tonikitoo@igalia.com,msisov@igalia.com,nickdiego@igalia.com Change-Id: I07fc59524cca2e61553c43eec4d566cc99a62286 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1123521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397301Reviewed-by:
-
Shik Chen authored
This CL sets model_id for built-in USB cameras and shows camera name, id (USB pid:vid), and resolution in expert mode preview overlay. Bug: b/167127091 Test: Manually check expert mode result Change-Id: I860152cd1e044e2f224a346134e6bdc81ebe5b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397037Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#804842}
-
Giovanni Ortuño Urquidi authored
Flaky on windows. TBR=yangguo@chromium.org Bug: 1061052 Change-Id: I710f6f2c09b17c27b88f1c017278d804c83b12e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397062Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes |LayoutText::SetTextWithOffset()| to use fast path in case of using generated break opportunities for spaces after newline in same layout text. There are three cases we use generated break opportunities: 1. In white-space:pre-wrap: leading spaces after newline 2. In white-space:pre-wrap: spaces after newline 3. collapsible space after newline in white-space:pre-wrap <b><i><s>ab\n</s></i>\n</b> The CL[1] makes |LayoutText::SetTextWithOffset()| to use slow path because of it is hard to handle case 3 even if we can handle case 1 and 2. In this CL, we use fast path for case 1 and 2 but case 3. [1] http://crrev.com/c/2395136: Make LayoutText::SetTextWithOffset() to use slow path for generated break opportunities Bug: 1125640, 1125641 Change-Id: I22ee9c1aa6b7ff5f57c08524ee7ac704ecb5db6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397036Reviewed-by:Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804840}
-
Koji Ishii authored
EditingNG has some instabilities such as <crbug.com/1121885>. In order to help users who turn on "Experimental Web Platform features" from hitting these issues, this patch changes EditingNG back from "experimental" to "test". Once ourstanding issues were resolved, we will change it back to "experimental". This is a revert of r791809 <crrev.com/c/2319947>. Some rebaselines are needed because these tests do not seem to honor "test" status. Bug: 707656, 1125477 Change-Id: I433200cb7fb450036a631ee8ed578ab395413540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390936Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804839}
-
Darren Shen authored
Add a new file containing protobufs to communicate between Chrome and the new native input engine. Add an OnFocus proto message. Send the OnFocus proto when focusing on an input field. Bug: 1019541 Change-Id: Ia890efb881f92bfb5fe161208c83c9ed3a6368f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370885Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#804838}
-
Mitch McDermott authored
Previously, files of equal timestamps were being sorted in their loaded order. To further align with the Files app, this CL instead sorts equal timestamped files lexicogrpahically by their names. Bug: b/159959835 Change-Id: Idbcd9e540f3ac9afeb4bea6056a8110e248b10a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397118 Commit-Queue: Mitchell McDermott <mcdermottm@google.com> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#804837}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599492790-48f26b1814d8ee70ca5f6f24d850f389c1625719.profdata to chrome-win32-master-1599525924-8e0161c47f5f22554f3324d544d18a882035921a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I644d7751653741b7f55458845d3c89225e9ef8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396999Reviewed-by:
-
Nicholas Hollingum authored
In crrev.com/c/2277694, mouse movement events on CrOS will have ordinal motion. We add a flag that will be used to control whether Exo reads those, or just continues to use accelerated motion. We want a flag in the short term because the hardware units we get on CrOS are too small, and we require some investigation in how to scale them appropriately. Bug: b/161755250 Change-Id: I3ac45b020d033a8fe180789bd979e7a50a68e0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370683 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#804835}
-
Siye Liu authored
We introduced interim composition character highlight for Windows in crrev.com/780377. However, we need to revert to previous UI (solid underline) due to strong user request. Bug: 1124602 Change-Id: Ia4ac41f9719fabb4fcdf6171f94d242472009689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394195Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d3b36eb57c37..6f29c57c715c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia5e3befc77d0b0dd1c8326a3d276c09853b31a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397277Reviewed-by:
-
