- 20 Feb, 2020 40 commits
-
-
Wez authored
NetworkChangeNotifierFuchsia #includes the fuchsia.netstack FIDL header in a header that is published by the //net target, requiring that the fuchsia.netstack dependency is itself public. TBR=mmenke Bug: b/149757507, 1050703 Change-Id: I6bc7088817fd0180b1da85d3c40c0ca7a548fc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066719Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#743186}
-
Mason Freed authored
*** SHERIFFS: if this CL triggers a flaky layout test, PLEASE do not *** revert this CL. Instead, please disable the offending test(s) and *** add them to the crbug.com/1053725 section of TestExpectations. I *** will then take care of them as I fix up the remainder of these *** tests. Feel free to cc me if you create a bug. Thanks. This CL enables the FormControlsRefresh flag by default on all Desktop platforms. The launch bug is crbug.com/1051552. Because many layout tests use form controls, including tests that are not directly testing form controls, this CL requires many tests to be rebaselined. The bug at [1] tracks the effort to re-baseline all of these tests and remove these new lines from TestExpectations. This will be done in pieces, to reduce the code review burden. The bug at [2] tracks cleaning up some of these tests eventually, as there are new tests (see [3]) that directly test the appearance of the new form controls, and those likely supersede many rebaselines in this CL. However, I would like to get this landed first, as it might require several Revert/Reland cycles to get landed for good, and then I can come back and do the cleanup. [1] https://crbug.com/1053725 [2] https://crbug.com/1034611 [3] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/virtual/controls-refresh/ Bug: 1012108, 1053725, 1034611, 1051552 Change-Id: I2d6da06c21567506cf1fc601b90c686c74310376 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063530 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#743185}
-
David Van Cleve authored
This CL bumps the expiry milestone for the reduced-referrer-granularity about flag to M85, so that it can be around during an M82 rollout of the new default referrer policy and two milestones' worth of subsequent enterprise policy lifetime. Change-Id: If8fe6fed2691c1dafea45bb891f15abd2b702eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043130 Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#743184}
-
Mustafa Emre Acer authored
This CL adds a new bucket to Download.InitiatedByWindowOpener to indicate that a download is initiated by a same-site but cross-origin opener of that tab. E.g., if a tab subdomain1.example.com opens another tab subdomain2.example.com and then navigates it to a download, this CL will now record the download as kSameSite instead of kCrossOrigin. This is added because latest number from Canary for the kCrossOrigin bucket is unexpectedly large. I suspect this is caused by sites serving their downloads on subdomains. This would previously go to the kCrossOrigin bucket but it now goes under kSameSite bucket. Bug: 121259 Change-Id: Idf142448b052a342df057982cfb79b0669fbd229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065252 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743183}
-
Christopher Thompson authored
Enables LegacyTLSEnforced feature in the testing config, for the new study name (to fix server side config errors). Previously crrev.com/c/2056936 updated the feature flag but not the study name. Change-Id: Ibf55717fe10c87f9ea264c2e8fcc9355c537abc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065407Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#743182}
-
Weilun Shi authored
Extend the expiry date of UMA.LowEntropySourceValue to 2020-09-01. Bug: 1043734 Change-Id: If3eef672679dfed159e807b19458d22a831e32a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066101 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#743181}
-
Donn Denman authored
Extends the expiry of two histograms that we expect to be critical in the Longpress and Translation experiments. BUG=1053120 Change-Id: If9bfaa1defc88ed1bb5e6b3d5e6ac47bbe93c35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063357 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#743180}
-
Robert Kaplow authored
Bug: 1053153, 1037311, 1037121 Change-Id: Ia5347d3279f2ab52cf21591f7ac9b8ac30321cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062939Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#743179}
-
Tanya Gupta authored
This prevents the app from crashing when the user navigates to the setting page. Change-Id: I4c48d8996694a681d27bf423e5212eaf82de29ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046711 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#743178}
-
Allen Bauer authored
Bug: 648382 Change-Id: I4db6eb8cfd081c1dde3998db2f1264f0adf42cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065350 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#743177}
-
Kevin McNee authored
SwapWebContents is implemented by WebContentsDelegates and is used in portal activations as well as having several chrome/ layer uses. We'll need portal specific code in this method, so we now have the WebContentsDelegate method be specific to portals, instead of bloating the content API. The chrome/ implementations can then add portal specific code and then swap. Other callers in chrome/ can call chrome/ implementations' swap methods directly without going through the content API. Bug: None Change-Id: I12106a43e5b7dc510f0f044fea378e0b66df2afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053400 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743176}
-
Martin Šrámek authored
This experiment was enabled in fieldtrial_testing_config, because it was being rolled out in Chrome M80. However, the experiment with a same name is being reused in M81/M82 code, where it's disabled again for the time being, and so it should be disabled in fieldtrial_testing_config too. Bug: 1032584 Change-Id: Ic903f1c082350d7067aaadbafee49b73772a21a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064998 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#743175}
-
Alex Ilin authored
These histograms are still useful until we update AccountManagerFacade to cache account ids together with emails. Fixed: 1053141 Change-Id: Ifcf2208d15b0692789d8ebdd5f20863397d1e641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066742 Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#743174}
-
Robert Sesek authored
Bug: 778325 Change-Id: I2ab991daf1eac20daed33feb6009b3cebe4c446e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065590Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#743173}
-
Jeff Yoon authored
host_app defaults to 'NO_PATH' via run.py, but the check doesn't include this in shard_utils.py. Including this check and printing the host_app in this logic. This only is triggered for gtest_type tests for iOS that are sharded by Swarming, thus, having those environment variables set. Change-Id: If9cfcb707866e23ef416ee6be32b54dd48eb7910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045375 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#743172}
-
Sorin Jianu authored
Change-Id: Ie7cbfe1ef76d0cbb26535748488fd4a2c3c1b1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065396 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#743171}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df5f7f9e4e1a..c6be40a04209 git log df5f7f9e4e1a..c6be40a04209 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 treehugger-gerrit@google.com Merge "Stringify errors from libunwindstack." 2020-02-20 treehugger-gerrit@google.com Merge "Log errors enabling / disabling tracing." 2020-02-20 fmayer@google.com Merge "LOG on HardResetFtraceState." 2020-02-20 primiano@google.com Merge "UI: Add CSP policy" 2020-02-20 treehugger-gerrit@google.com Merge "core: Add DCHECKs for process ID to TraceWriter (+1 in TraceBuffer)" Created with: gclient setdep -r src/third_party/perfetto@c6be40a04209 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iaff45e3848cafe6ea1062c597e8242627558602e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743170}
-
Mark Pearson authored
Bug: 1053130 Change-Id: Ifb56bd19472e57ff0e318b2da26b3f79e4b4244c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061109 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#743169}
-
Maksim Ivanov authored
This fixes the regression that the input field wasn't auto-focused when the smart card PIN dialog (<security-token-pin>) is shown during the SAML login. The regression was introduced in https://crrev.com/c/1968989, which erroneously changed the focus to be set synchronously. This didn't work, because in practice this happens too early, while the dialog still has the "hidden" attribute - because Polymer doesn't guarantee the order of updates triggered by the changes in |pinDialogParameters_|. The fix is to schedule the focus assignment to be done asynchronously (soon), so that this happens after Polymer updates all properties synchronously. Bug: TODO Test: enroll Chromebook under domain with smart card settings, start SAML login via the smart card, wait until the PIN dialog appears, verify that the PIN input field is auto-focused Change-Id: I2f1b4961867f735ac00290cd0cb62cb10fc3d33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047167 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#743168}
-
Greg Thompson authored
BUG=1054342 R=bcwhite@chromium.org Change-Id: Icb07c344efbef1592730dce1ca40bc0079e378e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066542 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#743167}
-
liberato@chromium.org authored
This reverts commit 62751ae7. Reason for revert: MediaCodec tends to tell us things that aren't exactly true. Plus, overlay promotion get skipped. Bug: 1054174, 1049192 Original change's description: > Plumb color space from MediaCodec to MCVD. > > Bug: 1049192 > Change-Id: I49ca6860718a2a015cfccf07150bd3aa4344b781 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042042 > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740406} TBR=dalecurtis@chromium.org,liberato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049192 Change-Id: I97b1ab9ade5477d992b8a6fc5e7ecbd7cb84f7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065339Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#743166}
-
Michael Lippautz authored
- Hide GCInfoTable for most users as the table is mostly an implementation detail. - Provide a type alias GCInfoIndex. - Functional: Use relaxed memory order when reading the index in the fast path. The setup is done under lock and the index retrieval itself should not be used for external synchronization. Change-Id: I5f4ac9c6493520e2b719f9fc867e3337fd7b0937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062440 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743165}
-
Mikel Astiz authored
This reverts commit 7a6d0761. Reason for revert: the underlying issue that caused the revert was addressed in crrev.com/c/2062328 by lowercasing GUIDs that are populated via sync's originator client item ID. Bug: 1052789 Original change's description: > Revert "Enforce lower-case use of GUIDs for sync" > > This reverts commit b6a3c9f3. > > Reason for revert: bookmarks created around 2016, between [M44..M51] > use an uppercase GUID as originator client item ID. > > Original change's description: > > Enforce lower-case use of GUIDs for sync > > > > base::GenerateGUID() produces lower-case GUIDs and they should get > > exposed to the sync protocol exclusively in this canonical form to avoid > > running into issues. > > > > This patch replaces all occurrences in sync codebase with: > > git grep -l 'IsValidGUID' -- components/sync* | \ > > xargs sed -i 's/IsValidGUID/IsValidGUIDOutputString/g' > > > > In addition, the implicit GUIDs used for bookmark sync, in particular > > for permanent nodes, are updated to adopt lower-case GUIDs. These are > > never committed to the server so there are no backward-compatibility > > considerations. > > > > Change-Id: I0d0468f3475e1a27a161e2af15853c757f53e201 > > Bug: 978430 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054154 > > Reviewed-by: Marc Treib <treib@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#741381} > > TBR=sky@chromium.org,treib@chromium.org,mastiz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 978430 > Change-Id: If3a135e24cb61d15cfc7616dd1160e76ce9dd3e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061749 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742118} TBR=sky@chromium.org,treib@chromium.org,mastiz@chromium.org Bug: 978430 Change-Id: I9bb6813c5b3edba7b6204e515475d6e644212c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064931Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743164}
-
Alison Maher authored
As per the following spec resolution, SVG text no longer should be adjusted in forced colors mode by default. https://github.com/w3c/csswg-drafts/issues/3855 Bug: 970285 Change-Id: I11a785f64ca6f7e7840b17d6b59d4ce9b9f8b4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055431Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743163}
-
Sylvain Defresne authored
Bug: 1049042 Change-Id: Ib5932f00c2b100aec03240f994370748ff8d2a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065730Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743162}
-
Aaron Krajeski authored
Waiting for the compositor "activation" means that we cannot parallelize the layers. Create an experiment here to remove it. Tests and perf with this WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/2057346 Bug: 1046463 Change-Id: I7631a84eca45e2ce20de51628c8c652108ba6cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056933 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#743161}
-
Justin Cohen authored
The intent handler for SearchInChromeIntent and OpenInChromeIntent both assumed the intents would only happen while the app was backgrounded. This worked since that's usually true, and the startupInformation would be processed when the app was foregrounded. However, OpenInChromeIntents can be chained, and presumably this is also true for SearchInChromeIntent, which means the first in the chain will trigger while the app is backgrounded, and the remainder when the app is in the foreground. Instead of assuming the foregrounding step will process startupInformation, let the logic flow to -continueUserActivityURL. Bug: 1051783 Change-Id: Ia61334ac33995030744c1316f5accef2eae15b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062097Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#743160}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0cd68ab14a08..4386ad19fb62 git log 0cd68ab14a08..4386ad19fb62 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 csmartdalton@google.com Add GrOpsRenderPass::bindPipeline() 2020-02-20 robertphillips@google.com Add private GrContext::compile API (take 2) 2020-02-20 robertphillips@google.com Revert "Add private GrContext::compile API" 2020-02-20 reed@google.com clean up leftovers from 3d samples Created with: gclient setdep -r src/third_party/skia@4386ad19fb62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Ie4a82096603ce5005e5812a1ff48e37abe90a493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743159}
-
Lijin Shen authored
Google sans is commonly used in button texts and headlines. For style consistency across the clank, this CL updates the font style of the button from Roboto to Google sans. Bug: 1053602 Change-Id: I189a968487ae89a5c27f1b25ca426143de3a8e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063415Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743158}
-
Mikhail Atuchin authored
The problem is that browser_tests depends on //chrome:chrome_dll. After changing one file (lets say in ch/br/) both chrome.dll and browser_tests.exe will be linked. It's unnecessary and takes a lot of time. The CL remove the redundant dependency. Change-Id: I9886bbfc149e89bf42d27d976383d08f2262fed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066739 Auto-Submit: Mikhail Atuchin <atuchin@yandex-team.ru> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#743157}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Iac5e02b8c3c890274cdaf13237dd551c173c6ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067259Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743156}
-
Mason Freed authored
The [1] CL caused renderer/core to depend on base, without adding deps for that dependency. The actual dependency is just on ui/base:features, so this CL makes that change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1984748 Fixed: 1052085 Change-Id: Ia1fdd06903e920148d26943f4c860dcce0b243aa Bug: 1052085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063630Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#743155}
-
Eldar Rello authored
Bug: chromium:1032987 Change-Id: I450c68280a8ab8b0b2bbaa5fa31e0245dbfba780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066625 Commit-Queue: Eldar Rello <elrello@microsoft.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#743154}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8e303f0eba46..a139c005963b git log 8e303f0eba46..a139c005963b --date=short --first-parent --format='%ad %ae %s' 2020-02-20 vapier@chromium.org repo_util: add more encoding=utf-8 settings when we capture output 2020-02-20 vapier@chromium.org puppet_metrics_unittest: fix test assert for Python 3 2020-02-19 dburger@chromium.org Manual fix up of ge_build_config.json and config --update. 2020-02-19 dburger@chromium.org Add command line option to specify chrome preload directory. 2020-02-19 vapier@chromium.org cros_build_lib: run: drop error_code_ok backwards compat 2020-02-19 vapier@chromium.org cbuildbot_launch: switch to python3 only 2020-02-19 tcwang@google.com afdo: Fix Python3 compatibility of toolchain_util.py 2020-02-19 vapier@chromium.org contrib: force all modules to be python3 only Created with: gclient setdep -r src/third_party/chromite@a139c005963b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I47e7a860c8e0b62431016e4810fdbb4b03ebd053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066799Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743153}
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //media/muxers/ to Once or Repeating Bug: 1007809 Change-Id: I9d412676b0c9386de89d400e2126af2e20745821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065333Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#743152}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1cd8b3dcc1d..a9f14d4ed59b Created with: gclient setdep -r src-internal@a9f14d4ed59b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9aa7e7cfadcd93b44c457528e3604e10f6e51c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066800Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743151}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e161c4dd654..cdda76d1c88e git log 2e161c4dd654..cdda76d1c88e --date=short --first-parent --format='%ad %ae %s' 2020-02-20 phoglund@webrtc.org Make scenario unittests faster. Created with: gclient setdep -r src/third_party/webrtc@cdda76d1c88e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic20c8f8f9bbf410b30cbf3376c82ee613b12ea11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743150}
-
Elly Fong-Jones authored
This change removes CryptoModulePasswordDialogView::{Accept,Cancel} and replaces them with explicit callbacks. It also changes the behavior (hence the separate CL): the old code used to explicitly clear the password entry field's text on the closure path. I can't find any good reason why this would be done, and views::TextField has never guaranteed that setting the text will cause the old text to be securely erased from memory. In any case, if we want that behavior, it should happen in //ui/views, not here. Bug: 1011446 Change-Id: I3b81438511cf8eb3e52241543024ec081c467636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062887 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#743149}
-
Benoît Lizé authored
kSimpleCacheEvictionWithSize was launched in M63, time to remove the feature from the codebase :). Bug: 736437 Change-Id: I7e1ffd378a011eca0c414ccf712e9aceb4297704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066897Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#743148}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6afd7913..099ad342 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If17ef0a9d699b4078629bbfd6d10d0bedd6ced5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066857Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743147}
-