GitLab

crrev.com/c/1847432 introduced the bug that VaapiWrapper is destroyed when
VaapiWrapper::CreateContextAndSurfaces is successful. This CL fixes the wrong
check on the return value.

Bug: 1009297, 1005205
Test: https://appr.tc/?debug=loopback&vsc=vp8&video=maxWidth=640,maxHeight=360,minWidth=640,minHeight=360&debug=loopback
Change-Id: I9a31b305c991cee5e28139d307f87430c20b45e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862880Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706287}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/821fe40443ea..120275e84dca


Created with:
  gclient setdep -r src-internal@120275e84dca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ia1f8a53d516202af8748cb0e66d2592e8119c741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864089Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706286}

This test is already passing for blink but some other browsers fail.

This test is a clone of simple.html but moves the color inline.

Bug: 1014400
Change-Id: I4810222d43f99ae229afa58458e1830202b7d444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862134Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706285}

Use more C++11. Along the way, also use base::Contains() in more places
and improve STL usage.

Change-Id: I34e96d3d9801bcdf30f0f10eea2f5ca91ed43508
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863157Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706284}

of defaultTests because lockScreen test changes the session state.

Bug: None
Test: No functionality change.
Change-Id: I3c6f6353525e97b6a547684066f26a30d8c9f3cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862718
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706283}

Add the AIRA role of "alert" to the "selected file is too big" error
message. This should convince screen readers to announce the error. It's
time sensitive (per aira "alert" role guidelines) because if the user
presses "Send" before hearing the alert, they won't know the file wasn't
sent. Not perfect (if the user chooses another file that is too big, the
error is not re-announced), but better than what we have currently.

Also add aira-describedby to the attach file window, so that the screen
readers treat "File will be sent to Google for debugging" as an extra
description of the field.

BUG=chromium:1005559, chromium:1005528
TEST=ChromeVox on ChromeOS. "Selected file is too big" was announced
after selecting a large file. (Took a long time, but it was announced).
"File will be sent to Google for debugging" was spoken after "Attach
file No file chosen".

R=afakhry@chromium.org

Change-Id: Ic60b811cd1902e6e621048ed6e9ab6da838ba267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863363Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706282}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/22f14e2a1c49..ac6afeb999e9

git log 22f14e2a1c49..ac6afeb999e9 --date=short --no-merges --format='%ad %ae %s'
2019-10-16 gbiv@google.com afdo: add indirect call redaction to merged profiles
2019-10-16 vapier@chromium.org cros_build_lib.run: drop old signal workaround
2019-10-16 vapier@chromium.org wrapper: require Python 2.7.5+ and 3.4+
2019-10-16 vapier@chromium.org run_tests: turn on more python3 coverage
2019-10-15 vapier@chromium.org signer_payloads_client: read hashes as binary data

Created with:
  gclient setdep -r src/third_party/chromite@ac6afeb999e9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I4d8c00b371bee014b1686c9e41b4a56d50e386eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864099Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706281}

Since high confidence allowlist is currently not available on GMSCore,
we plan to have it hardcoded in our code. This is similar to what we
have done for CSD allowlist.

Bug: 1014202
Change-Id: I5489b3d4ed56b8dd7ad7a79ea205b403b444a077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860980Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706280}

* Use GetPreferredSize() where applicable instead of CalculatePreferredSize()
* Format
* Remove unnecessary and now-outdated section-divider comment blocks
* Use AddChildView(unique_ptr)
* Remove duplicated code
* Shorten
* Don't bother with named constants that add no clarity
* Fix comments
* Use GetCornerRadiusMetric()
* Remove dead code
* Use in-declaration initializers

Bug: none
Change-Id: I3850f944311eb7521ab5827accfc9720532979a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856925
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706279}

The global |kRawData| std::map constant have to be initialized when the
program starts. Instead, make it a static local by wrapping it in a
GetRawData() function so the map is initialized on first use instead.
This remove 14 static initializers.

Along the way, make some globals fully const, use |kKeyMapCount| in more
places instead of hardcoding its value, simplify some code, and make the
modified files free of lint errors.

Bug: 537099
Change-Id: I1b6d059f608db108bb4ecb672119a5f43634bef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824067Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706278}

This adds if statement to cause a software encoder fallback if non GBM based
VideoFrame is given in native input mode. This CL also changes DCHECK_EQs to
if-statements in MojoVideoEncodeAccelerator. It is because, if the conditions
are false, it causes a renderer process crash.

Bug: 1014209
Test: webrtc.DecodeAccelUsedVP8
Change-Id: I7aefe0c8e37dae5f086c6f0ce49651a3816194d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862355Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706277}

Use the standard creation path for KeyedServices.

Bug: 268984
Change-Id: Id4a555cad9a64d00376e16cc1d072f2bf39b0e3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852578Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706276}

This isn't needed as of http://crrev.com/186382

BUG=
TBR=sky@chromium.org

Change-Id: Ib68322494d89754f47e0bfa2e504827804d9586c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864091Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706275}

This cl also updates the dialog strings to include "Chrome Remote Desktop"
in the title - for both Accessibility and Screen Recording.

Bug: 1012545
Change-Id: Ia7fb4e13fe103802d4130e67a8ae59cb7d2c50b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863640
Auto-Submit: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706274}

Move error histograms in IndexedDB to use function instead to reduce
code size.

Bug: 1012881, 945578
Change-Id: I4f211651bda3437fd956302c9b00fbd422ae769d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857798Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706273}

https://skia.googlesource.com/skia.git/+log/20c626aa2358..634d15032d37

git log 20c626aa2358..634d15032d37 --date=short --no-merges --format='%ad %ae %s'
2019-10-16 lsalzman@mozilla.com fix SkTextBlob::getIntercepts regression no longer considering glyph vertical offset

Created with:
  gclient setdep -r src/third_party/skia@634d15032d37

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@google.com

Bug: None
Change-Id: Iedbee32247601b3f998586213bb8fdb5c43e6dd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864028Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706272}

We map key types from the TLS code points to Android key types so
choosePrivateKeyAlias can filter the selection. Prior to Android 10, the
API ignored the parameter so it didn't actually matter what was passed
in. Starting Android 10, the filter is applied.

We had mapped ECDSA to "ECDSA", however the actual string is "EC". See:
https://developer.android.com/reference/android/security/KeyChain.html#choosePrivateKeyAlias(android.app.Activity,%20android.security.KeyChainAliasCallback,%20java.lang.String%5B%5D,%20java.security.Principal%5B%5D,%20java.lang.String,%20int,%20java.lang.String)
https://developer.android.com/reference/android/security/keystore/KeyProperties.html#KEY_ALGORITHM_EC
https://docs.oracle.com/javase/7/docs/technotes/guides/security/StandardNames.html#KeyFactory

Tested manually by importing an EC key on an Android 10 device and
testing with a TLS 1.2 server. (Note TLS 1.3 doesn't use the old client
certificate types anymore and we do not currently do anything with the
new values.)

Bug: none
Change-Id: I8fd222093c603962f8455b3fbde76d7a0d511042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863377
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706271}

The condition before invoking |terminate_all_workers_callback_| in
TestSharedWorkerServiceImpl::OnRemoteSharedWorkerConnectionLost() should
match the one in DestroyHost(). Both of these functions can be invoked
when the callback is not set.

Bug: 1008257
Change-Id: I9dd5f7812bbe01dfba8bb3a5fca0481e6a4ee7aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862892
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706270}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/65084e6f..ecd11dd1

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie1f1b70946759c2206a08efe6e65831c5c8a90d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863438Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706269}

Currently the ash::mojom::AssistantState::READY signal is sent out when
LibAssistant is created, not when it finished starting.
This puts us in a limbo state where we're told everything is up and running, but
any query sent out will be rejected.

To fix that, a new signal ash::mojom::AssistantState::NEW_READY has been
introduced that will only be sent out when LibAssistant signals it is ready to
process queries.

This signal should eventually replace the old |READY| signal, but for now it is
added as a new signal to allow us to check it is sent out consistently on all
devices.

Internally this is achieved by introducing a new |AssistantStateObserver| which
is used to inform |Service| about all state changes to the
|AssistantManagerService::State|. These state changes are then forwarded to
|AssistantClient::OnStatusChanged|.

BUG: b/141264108
Change-Id: I38d9635001be5ef13e80090102646559e5c17158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835183
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706268}

https://webrtc.googlesource.com/src.git/+log/af0aa0977370..2f6e525099a0

git log af0aa0977370..2f6e525099a0 --date=short --no-merges --format='%ad %ae %s'
2019-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1c1107d4..bdc89d87 (705985:706176)

Created with:
  gclient setdep -r src/third_party/webrtc@2f6e525099a0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I736f0fa0b0922202a959cac5ff3d1ce03302c61c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864017Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706267}

This reverts commit af31b7d5.

The problem bit us again in crbug.com/1005023, so I implemented a more
general fix. As a result, we should now be safe to turn AFDO back on
here.

Bug: 916130
Change-Id: I0f29059f9eccaf62dfeeccf543a8cabbeeaf86a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860881Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706266}

Previously WebEngine was crashing when user clicks on a drop-down box.
The issue was that WindowParentingClient interface wasn't implemented
for root Aura windows that are used to host web frames. This CL adds
WindowParentingClient implementation. Also updated LayoutManager
implementation to handle drop-down menu windows properly.

Bug: fuchsia:34997, fuchsia:36350
Change-Id: I173febd62825dbe460844742451cc8581e41b3b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861039
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706265}

Some places called Layout() instead of InvalidateLayout(), which is less
efficient and works poorly with layout managers.

Some places did not SchedulePaint() when changing characteristics that would
affect paint, e.g. text color.

Some places called InvalidateLayout() or SchedulePaint() unnecessarily, e.g.
after calling another function that should do these as needed.

Bug: none
Change-Id: Ie2cf7f01c0e1bccaf0a98365ed0e6fb63bfe7f67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857569
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706264}

The test is flaky on several bots. See the issue for details.

Bug: 1014790
Change-Id: Ib438e3fabf825b2ebafc5d59a1de6248a260c5cd
Tbr: bsazonov@chromium.org
Notry: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862879Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706263}

This reverts commit a2c0ced3.

Reason for revert: Breaks webengine in some scenarios

Original change's description:
> [Fuchsia] Reenable protected mode in WebEngine
> 
> Bug: 982922, fuchsia:24570
> Change-Id: If9fb495249488c43f97e4451a14f0193911d600f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804527
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Commit-Queue: Emircan Uysaler <emircan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#697683}

TBR=sergeyu@chromium.org,emircan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 982922, fuchsia:24570, fuchsia:38358
Change-Id: Ifa2cc465d53891484ff23b7f737ee69169b8dd09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864094Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706262}

BUG=b:139700524
TEST=no code change

Change-Id: Ia532872f4709f8dbacae84795b8b475ea76682af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850757Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706261}

JAWS calls IndexInParent on nodes in the accessibility
tree frequently. Try to use the efficient version rather
than recomputing it.

Bug: 1008558

Change-Id: Ieadfe193b0b294eb1bdb2efbcfd118ff5e1fecc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828066Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706260}

https://crrev.com/c/1812241 reads the monitor refresh rate with xrandr
when we're using desktop GL on Linux Nvidia. This applies the same fix
when we're using ANGLE (--use-cmd-decoder=passthrough).

Also fixes X11 errors when the primary display is disconnected.

Bug: 1012262, 535392
Change-Id: I0c54371496aa141643c5f6a2950935e22ba0f534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857091
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706259}

This Cl adds a flag for ANGLE's D3D11on12 backend:
https://chromium-review.googlesource.com/c/angle/angle/+/1814404/3
This backend is being added to evaluate potential challenges in creating
a full D3D12 implementation.


Bug: angleproject:3919
Change-Id: I2e20f50b79399a14beb8d0e64e54f55d98be7582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818430
Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706258}

This test was disabled as flaky a long time ago, so trying to enable it
since lots of code has changed since then.

Bug: 452018
Change-Id: I803cb8d52a7a9ce5fb0dec83ee9deb99f04a8ff5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864019Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706257}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9c927784e714..22f14e2a1c49

git log 9c927784e714..22f14e2a1c49 --date=short --no-merges --format='%ad %ae %s'
2019-10-15 dburger@chromium.org Invoke determine_android_version with iterable.

Created with:
  gclient setdep -r src/third_party/chromite@22f14e2a1c49

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I757234e68a624cb25c22ac948ee43992a3b8533b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862272Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706256}

https://chromium.googlesource.com/angle/angle.git/+log/81ab9c90998f..0b9ebe58e380

git log 81ab9c90998f..0b9ebe58e380 --date=short --no-merges --format='%ad %ae %s'
2019-10-15 jmadill@chromium.org Vulkan: Add "ImageViewHelper".

Created with:
  gclient setdep -r src/third_party/angle@0b9ebe58e380

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@google.com

Bug: None
Change-Id: I27071df4387e0249419176aa5fde3c99fb8a70bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862273Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706255}

This change will harden the setAutocomplete API making programming
errors less likely.

Previously the interactionModel parameter was stringly typed, now it is
typed as a enum so API misuse will be caught by closure's type checker.

This change was motivated by the thread on line 256 of the following CR:
https://crrev.com/c/1737872/3/third_party/blink/renderer/devtools/front_end/ui/ARIAUtils.js

Screenshot (proof the api still works): https://i.imgur.com/0geTYIg.png

Change-Id: I7f4fdd6009f182219db16c2e0ed3d9bfe4c663d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832247
Commit-Queue: John Emau <John.Emau@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706254}

This CL fixes a bug causing the color well selection ring to be scrolled
into view if it receives focus. The color well has overflow:hidden to
contain the selection ring within its bound, and so when the ring is at
the edge of the well, it is partially hidden. However, when the ring
gets focus (currently only possible via tab/shift-tab), the default
focus behavior shifts content and brings the ring wholly into view.

The .focus API has a preventScroll option that can used to prevent this.
However, there is currently no way to prevent the default focus behavior
from scrolling, which is what happens on tab. There has been some
discussion on this Github thread
(https://github.com/whatwg/html/issues/834) about this problem, but as
of now, no solution has been proposed to prevent tab or the default
focus behavior from scrolling. As a result, the fix being applied
herewith turns off the default tab behavior by calling preventDefault
on a tab keydown event and implements a custom tab functionality for the
color picker on top of .focus with preventScroll. (Instead of applying
this only to the color well, it felt more consistent to do it for the
entire color picker.)

There is another related bug in the color picker, where the selection
rings of the color well and hue slider do not receive focus when they
are clicked. This is also being fixed with this change, with a call to
.focus with preventScroll on mouse down. As a result of this additional
change, several tests started to fail due to the addition of a focus
rect around color selection rings. To minimize the rebaselining needed
with this change (as well as future changes), some tests that do not
need to be pixel tests have been rewritten as test harness tests. The
ones that need to remain pixel tests now have new baseslines that show
the focus rect.

Bug: 1013347
Change-Id: Ie985767cb64bc099c107223b75e3b21612a411dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854166
Commit-Queue: Sanket Joshi <sajos@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706253}

Bug: 1001839
Change-Id: Id27380f95b5c06f938826d4ec9a4725577034718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861041Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706252}

This reverts commit 61ae3ddf.

Reason for revert: Causing flaky GPU process crashes on Chrome OS webgl video tests
Bug: 1014756

Original change's description:
> media/gpu/v4l2vd: move stateless-specific parts into backend class
> 
> There are two V4L2 decode APIs: stateless and stateful. In the VDA era
> these were implemented as two completely separate classes
> (V4L2VideoDecodeAccelerator and V4L2SliceVideoDecodeAccelerator), which
> resulted in a lot of duplicated code and bugs due to fixes not being
> replicated on both classes.
> 
> For the VD-based decoder, we want to avoid doing the same error and
> use a single V4L2 decoder, supported by different backends depending on
> which V4L2 API we are using.
> 
> This CL is the first step towards that direction: it splits the
> V4L2SliceVideoDecoder into its general V4L2 part and the one that is
> specific to the stateless API.
> 
> Bug: 1003223
> Test: video_decode_accelerator_tests passing on Kevin.
> 
> Change-Id: I373f3ea739b6799ecad009d053ca7e415b8484bd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840034
> Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: David Staessens <dstaessens@chromium.org>
> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705894}

TBR=akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org,dstaessens@chromium.org

Change-Id: Ieb4fe2152e8d8a2c21a5eccaa5c13bdaf5c3b91d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1003223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864095Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706251}

For Chrome OS we just get it from the active user. For other platforms
we do the same but only as a best effort since we are not testing it,
so after a NOTREACHED(), and replacing the current best-effort return
of an empty string.

Bug: chromium:1012048
Test: browser_tests
Change-Id: I8af942cfb01f9be6c0061b1271a395fe3768f1b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859676Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706250}

R=pkasting@chromium.org

Bug: 1014142
Change-Id: I1056cae1b0702cf3a525b336fd49468bc32001c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859682
Auto-Submit: Stephen Lin <stephenlin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Stephen Lin <stephenlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706249}

This CL adds CommonAppsNavigationThrottle to handle URL for Intent
Picker with the App Service intent handling. Currently this only
includes querying apps with a URL and launching apps with a URL for
ARC apps and PWAs. Persistency and metrics are not implemented yet. This is a
simplified version to test the intent handling for the App Service. Later
this file will be implemented properly and replace the
AppsNavigationThrottle and ChromeOSAppsNavigationThrottle.

BUG=853604

Change-Id: I0b6b5a4cd9547f67ee2c8758692184b53d173e38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859419Reviewed-by: Maajid <maajid@chromium.org>
Reviewed-by: Shao-Chuan Lee <shaochuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706248}