- 24 Jul, 2018 40 commits
-
-
Douglas Creager authored
WPT provides a "nonexistent" subdomain that it guarantees will never resolve to any IP address [1]. Our test harness doesn't rely on /etc/hosts to resolve these test domains, and uses rewrite rules internally instead. Those rewrite rules were blindly resolving all *.test domains to 127.0.0.1; this patch adds an additional rule that handles the nonexistent subdomain correctly. [1] https://web-platform-tests.org/writing-tests/server-features.html#tests-involving-multiple-origins Bug: 866003 Change-Id: I4e331490d56872b8dfc4db25973291ea6e099565 Reviewed-on: https://chromium-review.googlesource.com/1145487 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#577505}
-
Stefan Teodorescu authored
Add Chrome desktop style RelaunchNotification to ChromeOS version of Chrome, including the RelaunchNotificationController written for Chrome desktop. This shows the bubble for the recommended relaunch and the dialog for the required relaunch. Bug: 846425 Change-Id: I4aea7907d2f7a591e4e845597a7ece3d943722ca Reviewed-on: https://chromium-review.googlesource.com/1146654Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Marton Hunyady <hunyadym@chromium.org> Commit-Queue: Stefan Teodorescu <fane@google.com> Cr-Commit-Position: refs/heads/master@{#577504}
-
Sidney San Martín authored
When the mouse is at the top of the screen in fullscreen and the toolbar is visible, the toolbar slides down to make room for the menu bar. The offset was calculated in GetBoundsForTabStrip(), which only affects some of of layout. This change moves it to GetTopInset(). Bug: 865901 Change-Id: I5de02ac951f8347aeadc4af7238ea8f9172edc68 Reviewed-on: https://chromium-review.googlesource.com/1147477Reviewed-by:
-
Elly Fong-Jones authored
The Mac window system doesn't support zero-size windows, so it's important that DialogTestBrowserWindow not impose a 0x0 maximum size on constrained dialogs. This fixes a slew of constrained window tests, like PrintPreviewUIUnitTest.* and PrintPreviewDialogControllerUnitTest.*. TBR=sky@chromium.org Bug: 832676 Change-Id: I0708d20ef7e16468af6e13980994d063e3b7e87a Reviewed-on: https://chromium-review.googlesource.com/1148011Reviewed-by:
-
Amirhossein Simjour authored
VrUiWidgetFactory should be initialized with VrModalDialogManager instead of ModalDialogManager. The issue appeared after this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1136856 Bug: 866511 Change-Id: I0cc8fa0a0bf951415d85a44c5fe48c6fa20999a7 Reviewed-on: https://chromium-review.googlesource.com/1147214 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#577501}
-
Rayan Kanso authored
This is a reland of d3981964 TBR=avi@chromium.org Original change's description: > [Background Fetch] Move all updatable UI options to their own proto. > > Bundle up the icon and the title since they will be accessed/modified > together in the updateUI call. > > It also makes sense to move the icon from the metadata proto since that > will speed up getting the registration info. > > TBR=avi@chromium.org > > Bug: 865063 > Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593 > Reviewed-on: https://chromium-review.googlesource.com/1146650 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577272} Bug: 865063 Change-Id: I77567e8e2e0ea59ede514c77b40326e7ece48a25 Reviewed-on: https://chromium-review.googlesource.com/1148261 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Daniel Bratell authored
There are three identical small ToGLuint functions which clashed in jumbo build experiments. This moves it to gles2_cmd_utils.h and changes the type to not add a dependency on GL in command_buffer/common. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iad7cfc8a2506b765ba7a93c2eb9dc59149e5b8f4 Reviewed-on: https://chromium-review.googlesource.com/1141944Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#577499}
-
Koji Ishii authored
The test: fast/borders/border-image-border-radius.html should apply line-height quriks, but crbug.com/40634 prevents applying it in legacy, but LayoutNG considers it's quirks. This patch changes the test to the standard mode, so that the rendering matches without crbug.com/40634. TBR=eae@chromium.org Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ifb5c2152f344f5c8d3b1cf54379107c631857952 Reviewed-on: https://chromium-review.googlesource.com/1146880Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577498}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f685b421. With Chromium commits locally applied on WPT: 1736c657 "Rename a WPT which has a duplicate basename" 4bd63c29 "webrtc wpt: close RTCPeerConnection in generateAnswer helper" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21657 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source chongz@chromium.org: external/wpt/touch-events hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/resources jsbell@chromium.org, mek@chromium.org: external/wpt/webstorage ksakamoto@chromium.org: external/wpt/resource-timing mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy TBR=foolip No-Export: true Change-Id: I2f0f3998c68ab244d4524a8cc31f8f2b394e2857 Reviewed-on: https://chromium-review.googlesource.com/1148224 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#577497}
-
Friedrich Horschig authored
There is a nullptr exception connected to SendViewItems. This CL guesses a solution to this problem: 1. It's only called if the controller was checked to be null, so it must be in the implementation. 2. The view_ is synchronously constructed at construction time and can outside of tests never be null. 3. It's bound to web_contents_, so this also cannot be null. The only dereference left is the GetFocusedFrame() method which can be null. Therefore, accessing the correct frame moves to the driver-side which is much more appropriate for frame-based actions anyway. Bug: 865447 Change-Id: Ie5ea7aed980cdf53e784e5d918a9d54717ad6ab1 Reviewed-on: https://chromium-review.googlesource.com/1143477Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577496}
-
Mihai Sardarescu authored
Bug: 863420 Change-Id: I01e883bda9207614a99b9e2d6c02813d3d56984c Reviewed-on: https://chromium-review.googlesource.com/1146814Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#577495}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22a88d89..18dc0c00 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8289b1ad233e092f71648c717f56ed2c6aa77495 Reviewed-on: https://chromium-review.googlesource.com/1148225Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577494}
-
Elly Fong-Jones authored
This code is dead since SecondaryUiMd has been on by default for several releases now. Bug: 832676 Change-Id: I5cfcdf8d1147dd3a788f0e8b57cf96a98d86f39e Reviewed-on: https://chromium-review.googlesource.com/1148010Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577493}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c62aa207e9ac..aa5072898003 git log c62aa207e9ac..aa5072898003 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 art-snake@yandex-team.ru Fix encryption dictionary owning. Created with: gclient setdep -r src/third_party/pdfium@aa5072898003 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I97627832f651fc0eb2c27807022f7fe9b788640b Reviewed-on: https://chromium-review.googlesource.com/1147943Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577492}
-
Mihai Sardarescu authored
This CL accepts a null sync service for the creation of UrlKeyedDataCollectionConsentHelper objects. If such an object is backed by the sync service, then a null sync service is treated like the consent not being given for URL-keyed data collection. Bug: 857589 Change-Id: I915963eeaba39539dc0ae9e9b0bc6d46d3b3e842 Reviewed-on: https://chromium-review.googlesource.com/1148323Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#577491}
-
Victor Vasiliev authored
This does not include QuaRTC changes. There were no flag updates. Remove DISALLOW_COPY_AND_ASSIGN from third_party/quic (pass 4) All of the classes in this CL are static-only, thus we just make them non-constructible by deleting the default constructor. Merge internal change: 205428593 https://chromium-review.googlesource.com/c/1146662/ Move HTTP-over-QUIC code to third_party/quic/core/http Merge internal change: 205324876 https://chromium-review.googlesource.com/c/1146661/ Remove empty class QuicSpdyStreamPeer Merge internal change: 205315603 https://chromium-review.googlesource.com/c/1146219/ Remove DISALLOW_COPY_AND_ASSIGN from third_party/quic/core (pass 3) DISALLOW_COPY_AND_ASSIGN is officially deprecated, and its use causes an unnecessary code dependency on //base. Replace it with officially supported C++11 syntax. Merge internal change: 205303765 https://chromium-review.googlesource.com/c/1146217/ Remove DISALLOW_COPY_AND_ASSIGN from third_party/quic/core (pass 2) DISALLOW_COPY_AND_ASSIGN is officially deprecated, and its use causes an unnecessary code dependency on //base. Replace it with officially supported C++11 syntax. Merge internal change: 205018937 https://chromium-review.googlesource.com/c/1146216/ Remove DISALLOW_COPY_AND_ASSIGN from third_party/quic/core (pass 1) DISALLOW_COPY_AND_ASSIGN is officially deprecated, and its use causes an unnecessary code dependency on //base. Replace it with officially supported C++11 syntax. Merge internal change: 204942911 https://chromium-review.googlesource.com/c/1146215/ R=rch@chromium.org Change-Id: Ifc16940de2271b5a951cefef8223ce22c7d6a250 Reviewed-on: https://chromium-review.googlesource.com/1146663 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577490}
-
Jérôme Lebel authored
Need to use gaia::AreEmailsSame() instead of comparing emails directly. Also, DCHECK_EQ() should be used instead of DCHECK(). Bug: 866801 Change-Id: I229e6aef631dca1f6ecf4c0242a11db15687d25a Reviewed-on: https://chromium-review.googlesource.com/1148206Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577489}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b96253cab7d9..62e2a5e8c2cd git log b96253cab7d9..62e2a5e8c2cd --date=short --no-merges --format='%ad %ae %s' 2018-07-24 vapier@chromium.org cbuildbot: fuzzer: stop processing android stages 2018-07-24 vapier@chromium.org lint: fix not-an-iterable warnings 2018-07-24 vapier@chromium.org lint: fix consider-using-enumerate warnings 2018-07-24 vapier@chromium.org lint: fix unsubscriptable-object warnings Created with: gclient setdep -r src/third_party/chromite@62e2a5e8c2cd The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0e48ce8e3827bb61368147182b339e64ac52685e Reviewed-on: https://chromium-review.googlesource.com/1147945Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577488}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/25cc8ad19873..e507b0ce8e87 git log 25cc8ad19873..e507b0ce8e87 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 saza@webrtc.org Turn off comfort noise generation by default in AECM 2018-07-24 mbonadei@webrtc.org Adding missing dependencies on absl. Created with: gclient setdep -r src/third_party/webrtc@e507b0ce8e87 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3721e5c6ea6f749f37d1168aa3fc9727648c5c6c Reviewed-on: https://chromium-review.googlesource.com/1147903Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577487}
-
Rayan Kanso authored
This is a reland of f7206154 Original change's description: > [Background Fetch] Delete the unused FetchedEvent files. > > TBR=jbroman@chromium.org > > Bug: 822765 > Change-Id: I03fa9efc6fa80814f252593a0582ff25b633580b > Reviewed-on: https://chromium-review.googlesource.com/1142154 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577271} Bug: 822765 Change-Id: I1e8e31569874b6be9de954cc15ac01f6b134017d Reviewed-on: https://chromium-review.googlesource.com/1148260 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577486}
-
David Davidovic authored
In consent_sync_bridge_impl.cc and user_event_sync_bridge.cc, we were using CopyToEntityData immediately after parsing the specifics, which was unneeded. Now replaced that with MoveToEntityData and removed the old, now unused function. Change-Id: I4dea0cbf9a8865b611d1f95ab02a5f4fdfe9aee0 Reviewed-on: https://chromium-review.googlesource.com/1140322Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8fb6f6a..be5fe77 BUG=chromium:863682 TEST=bots TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iaaea854a33e6367f192c0c554789994d681a8f2a Reviewed-on: https://chromium-review.googlesource.com/1145222Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#577484}
-
Wei-Yin Chen (陳威尹) authored
|use_aura| and |is_ios| is mutually exclusive, so the condition to add render_text* and related files can be simplified a bit. This is a followup of crrev.com/c/1144305. Bug: None Change-Id: I986d6347d7e87866ce0c18ea6dbbb25c49dee0d4 Reviewed-on: https://chromium-review.googlesource.com/1147092 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#577483}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d7a1188a3b5a..2a64e6b6d554 git log d7a1188a3b5a..2a64e6b6d554 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 dtu@chromium.org [pinpoint] Stub for the patch module. Created with: gclient setdep -r src/third_party/catapult@2a64e6b6d554 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I31fd792f4e967bec069cff01dbaa30efa51cb19c Reviewed-on: https://chromium-review.googlesource.com/1147942Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577482}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a2437c0a..22a88d89 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id026bb796349ecfddf061e53b0c7ebadb393c8d1 Reviewed-on: https://chromium-review.googlesource.com/1147937Reviewed-by:
-
Mugdha Lakhani authored
from the codebase, now that we're using Manifest::ImageResource instead. Bug: 860507 Change-Id: Ie8ac76ebe4e4ed1ab8a6b6a090dbf05b28d17f5c TBR: peter Reviewed-on: https://chromium-review.googlesource.com/1146656 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dcff0bd78e26..25cc8ad19873 git log dcff0bd78e26..25cc8ad19873 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 david@porter.me Fixed issue with BGRA RTCCVPixelBuffer scale and crop Created with: gclient setdep -r src/third_party/webrtc@25cc8ad19873 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic681b4f800d4634e1e9bbe1117764deee5ed3147 Reviewed-on: https://chromium-review.googlesource.com/1147902Reviewed-by:
-
Philip Jägenstedt authored
It will be enabled again after the next import. Bug: 866802 Change-Id: Id2f4198b7699be1bdf185758401fdb74413a1f21 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1148208Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#577478}
-
Jérôme Lebel authored
When signed out: - personalized section should be collapsed - non-personalized should be expanded When signed-in with no consent given: - personalized section should be expanded - non-personalized should be expanded When signed-in with consent given: - personalized section should be collapsed - non-personalized should be collapsed Bug: 849838, 863860 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4fa468253606c431684d0c8b19bcf4548dcf4ad7 Reviewed-on: https://chromium-review.googlesource.com/1133171 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#577477}
-
Victor Costan authored
Chrome's SQLite currently uses permissive (0644) POSIX access controls for newly created databases, and //sql offers a method for opting into restrictive (0600) permissions. This method is only used by the login database. However, all Chrome databases are likely to have private data. For example, the cookies database may contain long-lived OAuth tokens, and can be just as valuable as the login database. The same argument applies for the DOMStorage database. This CL configures SQLite to use restrictive permissions by default, and removes the method for opting into the restrictive permissions. Change-Id: I5f0ce9e7f038081fad515cfc30c45ccccf7ff1b6 Reviewed-on: https://chromium-review.googlesource.com/1146295Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
-
Marc Treib authored
Before this CL, all the methods in sync_service.h seemed to be in a totally arbitrary order. This CL attempts to reorder them to be grouped in a logical way, and also updates some comments that were out of date. No functional changes. Bug: 865936 Change-Id: Ief7c8e8ac6f4eff0e1002dae54df1e96b5e7e00b Reviewed-on: https://chromium-review.googlesource.com/1146646 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Philipp Hancke authored
and add_cleanup BUG=836871 Change-Id: I175e53f3466719403e5d61a68dc7125bf547e36e Reviewed-on: https://chromium-review.googlesource.com/1140789 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#577474}
-
Thomas Tangl authored
Encryption options is placed last in the "Sync and personalization" section to match the mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr664Bt8FBOxWEdg35-B8FaW0 Bug: 864751 Change-Id: I406708e8ea9e02e27a45f62ad9ca1ba67f7d3a36 Reviewed-on: https://chromium-review.googlesource.com/1146757Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#577473}
-
Artem Titov authored
Bug: webrtc:8366 Change-Id: Ieaa4bf30132708570ac76c0957248c1dbb22a611 Reviewed-on: https://chromium-review.googlesource.com/1146922Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Artem Titov <titovartem@chromium.org> Cr-Commit-Position: refs/heads/master@{#577472}
-
Nick Harper authored
CertVerifyProcInternalTest.EVVerificationMultipleOID uses a certificate from trustcenter.websecurity.symantec.com, but the test fails with the upcoming Symantec Legacy PKI distrust. This replaces the test certificate with another that has the 2.23.140.1.1 OID before 2.16.840.1.113733.1.7.23.6 in X509v3 Certificate Policies extension. Bug: 705285, 796230 Change-Id: I0ed5d50d727a712d7c38babdb9ecfdfd30d50cc5 Reviewed-on: https://chromium-review.googlesource.com/1147665 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577471}
-
tzik authored
After this CL, we can use ComPtr as the |this| pointer of base::BindOnce and base::BindRepeating. ComPtr doesn't have `operator*` nor `operator->*` that are needed to run a method pointer. So we need a special handling for it to use it as a receiver on base::Bind. We currently use scoped_refptr to store COM instance on base::Bind, which happens to work, but that looks fragile. This CL is a preparation to convert these scoped_refptr to ComPtr. Change-Id: I1fe31e23ac627050860fe2c81ead6807a17bb939 Reviewed-on: https://chromium-review.googlesource.com/1145153 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577470}
-
Haruka Matsumura authored
This CL changes the system of slots registration in HeapCompaction. As preparing for HeapCompaction with IncrementalMarking, we change a timing of the registration on HashMap that related to slots, from during tracing to during atomic pause. So, we add HashSet that registeres traced slots. Bug: 864425 Change-Id: Ia63c36abbf160dfea115ebd6c6953c499d895770 Reviewed-on: https://chromium-review.googlesource.com/1145144Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Haruka Matsumura <harukamt@google.com> Cr-Commit-Position: refs/heads/master@{#577469}
-
Vasilii Sukhanov authored
The direction is used if instead of the password generation we trigger the standard password drop-down. Bug: 865469 Change-Id: I3da15c0446753e69f84d352c7095c40d571030ce Reviewed-on: https://chromium-review.googlesource.com/1145300Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Colin Blundell authored
While working on GaiaCookieManagerService, I noticed that SigninClient::AddCookieChangeCallback() is unnecessary to call out to the embedder for: the only embedder-specific parameterization of the //components-level SigninCookieChangeSubscription is for the URLRequestContextGetter, which is already available to the component via SigninClient::GetURLRequestContext(). This CL eliminates that client method in favor of having GaiaCookieManagerService construct SigninCookieChangeSubscription directly. I verified that all production clients were supplying the same URLRequestContextGetter that they return in their implementation of SigninClient::GetURLRequestContext(). TBR=jzw@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic8a9d0c6e3e63cf531408eb6ab46db65bcf3e668 Reviewed-on: https://chromium-review.googlesource.com/1145312 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Philipp Hancke authored
BUG=836871 Change-Id: I16e2419717601e3bb89e83df720eee31cc631edc Reviewed-on: https://chromium-review.googlesource.com/1140781 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
-
