- 03 Sep, 2020 40 commits
-
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ibddd7cdd6d100e5c551ede9efbedbe3f10a5585e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296062 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#804270}
-
Alexis Hetu authored
Updating expectations to reflect ANGLE side fixes Bug: angleproject:3930, angleproject:2914, angleproject:2899 Change-Id: I9fcdbd1d3a40c16289abdb71d753e271d5f7cad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385880 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#804269}
-
Jie Jiang authored
Created by: clang_format.py -i chrome/browser/chromeos/arc/bluetooth/* BUG=None TEST=None Change-Id: Idce5b4fc8cc64211b6535d708c0640fab906794d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391036 Auto-Submit: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#804268}
-
Henrik Boström authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/2323359 implemented the spec-compliant behavior of having internal slots for SDP as to not prematurely surface descriptions of pending SLD, SRD or addIceCandidate operations. But that CL forgot the changes to the localDescription due to ICE candidates being generated and "onicecandidate" firing. This caused a regression in M87. This CL adds test coverage for this in WPT and fixes the bug by surfacing all descriptions at OnIceCandidate. // Fippo approved. TBR while hta is OOO TBR=hta@chromium.org Bug: chromium:1124384 Change-Id: Ifb11d6416772b87b9076ff6238e909928c66af6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390747Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#804267}
-
Daniel Classon authored
Renames the kSpeakToType setting, which is a duplicate of the kDictation setting, to accurately reflect the missing setting it refers to: kHighlightKeyboardFocus. Needed to deep link to the highlight keyboard setting. Bug: 1084154 Change-Id: I70bcf4bb6efd95056519d35784acd80086a56e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391734Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#804266}
-
Liquan (Max) Gu authored
This is a reland of 00d4ff28 Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2378538 Revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/2391904 Revert reason: PRImpl#constructor's mCertificateChain's being null causes assert failure (crbug.com/1122148#c7) Reland reason: PRImpl#mCertificateChain can be null, so we remove the assert from it. Bug: 1122148 Change-Id: Ie8dad7804ef3d6ab79daf739addab4650ec8fc9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391920 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804265}
-
danakj authored
R=avi@chromium.org Change-Id: Ia1beb8f5e22c53e38803f44302785d63abe82363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391728Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#804264}
-
Haiyang Pan authored
This reverts commit f806ba6f. Reason for revert: Very likely caused CompositorRenderPassTest.CopyShouldBeIdenticalExceptIdAndQuads failing consistently in android x86 builders since: * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1162 * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2065 Original change's description: > viz: Remove two fields from CompositorRenderPass. > > This patch moves two fields from RenderPassInternal into > AggregatedRenderPass, effectively removing them from CompositorRenderPass > since they are not used there. > > R=weiliangc@chromium.org > > Bug: 1106418 > Change-Id: I46a156420b0dd53fe44afae012011c4e040258d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389421 > Reviewed-by: weiliangc <weiliangc@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: vmpstr <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804083} TBR=kenrb@chromium.org,vmpstr@chromium.org,weiliangc@chromium.org Change-Id: I31520aee6341539a46184ce406a809e84a300ee8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392756Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#804263}
-
Sylvain Defresne authored
Bug: none Change-Id: Ia018a9a25756a6785b61c3ce3532cd1826a08ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391074 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#804262}
-
Mitsuru Oshima authored
Explicitly shutdown SerialTracker and Seat before destroying display, as deleting window depends on them. Bug: 1111390, 1124106 Test: manually tested by existing chrome while lacros is running Change-Id: I54ec70bb6d5e35fd178ccc90ed748210486394fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387481Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#804261}
-
Nick Diego Yamane authored
MouseWarpMode was removed in http://crrev.com/1082423006, so remove its leftovers from drag_window_resizer.cc. R=oshima@chromium.org Bug: None Change-Id: I0e98ff77e847c4a2ee638dfb4944ceeb254fa759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391646 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#804260}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fb45a94639ca..5383c636752f 2020-09-03 aninditaghosh@google.com Merge "QueryResultIterator reads strings from string_cells one at a time than splitting all at the beginning." 2020-09-03 simonmacm@google.com Merge "traced_perf: unwind the first n extra processes we see." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I638358cf30355472e3a349b21d3bd1a6633a8779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804259}
-
Andrei-Laurențiu Olteanu authored
Add converters. Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: I50146d5c470c987a2f1e0ed39533d860713a71e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374148 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGInlineNodeEditor| to produce |NGInlineItem| with |ShapeResult| having same start and end offset for valid text painting. Before this patch, we see wrong painting, e.g. "AxXX" instead of "AxVX" when insert "x" before "X" of "AVX". This is cause by kerning between "A" and "V". Bug: 1121885 Change-Id: I8242356ef6b865f2ad8b2e47de62d3200286e3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391701 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804257}
-
Alexander Alekseev authored
This adds legend to the graphs. CPU tab legend: https://screenshot.googleplex.com/BSEafb7msokFohF.png RAM tab legend: https://screenshot.googleplex.com/7KZWaGYP5NNjkR7.png Folded legend: https://screenshot.googleplex.com/6g9U2v4CEjgKhPq.png Bug: 1121868 Change-Id: I9c093f4d3ef886b6aba659497a56d766eb8cb2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380268 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Juanmi Huertas authored
When changing ImageRendering, there are some cases where it is needed to check if there is something changing in the canvas. Adding a DidDraw as a change of imageRendering can produce a redraw of the canvas. Bug: 1106978 Change-Id: Icdc6b57eaa94e33279f9eb08c2b3cd807d4a1665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391727Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#804255}
-
RJ Ascani authored
The Encrypted Media Extensions spec requires that persistent CDM user data is isolated per-origin. Previously, the Fuchsia CDM user data was shared for each key system. This CL creates data stores for each origin and provides them to the platform CDM service for storage of persistent user data. Bug: 991723 Change-Id: I45ff72410ae2f88311fcfe7f832707b72acdbb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138259 Commit-Queue: RJ Ascani <rjascani@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#804254}
-
Gary Tong authored
Bug: 1123673 Change-Id: I21c18fa266c91223cf62295444edb26885bc8b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391176 Commit-Queue: Gary Tong <gatong@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#804253}
-
Hidehiko Abe authored
In order to migrate it with chromeos/chromeos_buildflags.h. BUG=1114198 TEST=Build locally. Ran tryjob. Change-Id: Idbec0af0b6dbcc95f0758494c1e4800980782855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377169Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
David Van Cleve authored
We occasionally fail Trust Tokens operations due to transient unavailability of the entire Trust Tokens logic, for instance when third party cookies are being blocked unconditionally due a user setting. This logic (in url_loader_factory.cc, providing the `authorizer` callback argument to TrustTokenRequestHelperFactory) means that Trust Tokens operations will sometimes fail "during normal operation," at no fault of the caller's. We'd like to avoid printing console errors in this case. For instance, right now because third party cookies are disabled by default in incognito mode, we print a console error on every Trust Tokens operation executed in incognito mode. This CL extends the Trust Tokens-related console message suppression in FrameConsole to encompass "unactionable" Trust Tokens failures, like ones due to TrustTokenOperationStatus::kUnavailable, which represents an unavoidable unavailability of the Trust Tokens subsystem. Test: Adds an inspector-protocol WPT ensuring no errors are logged Bug: 1111572 Change-Id: I53898a272fb8063cdbddfda0e916e49525973d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385878Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#804251}
-
Luciano Pacheco authored
Add DCHECK for conditions that fails to launch Files app. Add warning log if can't launch Files app when it isn't ready. Bug: 1090211 Change-Id: Iec2a20bb648354e83b7f7fa95df380b1f5182dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390929 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1d46a533aa37..c4bfa82e48ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If3242372f90e69ef6fb81add5e5667fb841bbfed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392619Reviewed-by:
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /services/video_capture This CL was uploaded by git cl split. R=chfremer@chromium.org Bug: 1110266 Change-Id: I40bf9a0a66648430358fb0de198bd648c52a1324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370733Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#804248}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8badb56a..99d869bb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a931bbf0aa2be63c57bd18df8c42edb3b95b93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392576Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804247}
-
Koji Ishii authored
Change-Id: I96587805e3f3bc5e72d86eb2098fa665d7f23cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391945Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804246}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ef0fb4c2707e..c4bfa82e48ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I420e251cfd4df4aae58f2c1dc71d62d805278f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392618Reviewed-by:
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ie0aa4584ac2bae1f156751693beda6a94279c14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390544Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#804244}
-
Xianzhu Wang authored
BTW avoid a possible warning of an uninitialized field (which didn't actually happen). Change-Id: I8a895b8a95d394f4652e662402f108331d71a1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390968 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#804243}
-
Jacobo Aragunde Pérez authored
Includes one generic test for BubbleDialogDelegateView and specific tests for bubbles that behave like alerts and are known to be properly working. The generic test does not work on Windows, this has been reported as crbug.com/1123933 and marked with a TODO. The specific tests expose a known bug about duplicated events that is already reported as crbug.com/1082217. This fact is documented with a TODO in the test code. Bug: 1082217, 1119349, 1123933 Change-Id: I5019b67c965bdfb83589da4db1402e6b9067011a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378306 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804242}
-
Joshua Pawlicki authored
Bug: 1114727 Change-Id: I3740a4732a97502f2e51cac7501e33399ef7d75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346728 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#804241}
-
Antonio Sartori authored
This CL uses the "Subsume" algorithm for Content-Security-Policy Embedded Enforcement https://w3c.github.io/webappsec-cspee implemented n the services/network CSP module from the AncestorThrottle for checking whether a frame should be allowed to embed or not. The same behaviour is currently enforced by blink. The new version is hidden behind a feature flag. Change-Id: I4f72782a209bda967843e290d180167151fca852 Bug: 1094909,1086857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270206 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#804240}
-
Devlin Cronin authored
Add instructions for removing flags to flag_expiry.md. Bug: None Change-Id: Ib42fd8ccd062b1612091235204db000ca2a4fff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389015Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804239}
-
Maksim Ivanov authored
Print developer-friendly DCHECK failure messages in case the program crashes due to misuse of Task APIs - e.g., trying to post a task to the UI thread in a unit test without creating a BrowserTaskEnvironment. This targets these two (mis)usage scenarios: (1) calling content::GetUIThreadTaskRunner()/GetIOThreadTaskRunner() without having a BrowserTaskEnvironment; (2) calling base::PostTask() with |content::BrowserThread::UI|/|::IO| without having a BrowserTaskEnvironment. Before this change, these scenarios were triggering obscure crashes that are hard to decipher for developers, namely: * "[FATAL:browser_task_executor.cc(293)] Check failed: g_browser_task_executor." for scenario #1; * "[FATAL:task_executor.cc(70)] Check failed: executor." for scenario #2. In order to improve this, the following changes were made: * A DCHECK message was added into base::GetRegisteredTaskExecutorForTraits() - the previous message-less DCHECK was preventing the helpful message in base::GetTaskExecutorForTraits()'s DCHECK from being reached. This helps in the scenario #2 from above. * A DCHECK message was added into BrowserTaskExecutor::Get() that is analogous to the DCHECK message from base::GetTaskExecutorForTraits(), and code throughout the file was changed to use this Get() function instead of DCHECK'ing the same without any message. This helps in the scenario #1 from above. * A Death unit test was added that verifies that scenarios #1 and #2 trigger DCHECK failures that contain the "BrowserTaskEnvironment" substring, which would prevent from regressing in this debug logging again. Bug: none Change-Id: I959c4971537d2096321e573d148974f347a58f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368600Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#804238}
-
Juanmi Huertas authored
Clear was not yet private as it was still being used by Canvas 2D Layer Bridge. Removing that usage now, and marking Clear as Private inside Canvas Resource Provider. Adding an explicit DidDraw to the creation of the Resource, as it has been cleared on construction. I am leaving a GetOrCreateResourceProvider in line 101 as it was called, and that would, potentially, recreate the Resource. It would be also a good follow-up to try to see if there is a way to encapsulate the things DidDraw is doing here and in other places where it is being called after the internal Clear of the CRP, to have it done internally as well. Bug: 1090081 Change-Id: I87a5b6d20a1d79606e1d986c484f2677edde2863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382612Reviewed-by:
-
Thomas Lukaszewicz authored
This CL fixes a bug where the Layer implementing the corner mask for the ClientView is not updated when the BubbleFrameView's corner radius is updated. Bug: 1124016 Change-Id: I30e9588080b7c7aebc792b911b3bdbbaa719eba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391640Reviewed-by:
-
Sorin Jianu authored
Since the updater is implemented only for per-user installs, restricting the testing hooks (and thus, the external constants to admin privileges) does not get us anything. And on the negative side, requiring admin privileges for integration tests breaks COM RPC in Windows with UAC on. Due to integrity control, when COM is running at high integrity, COM only looks up its registration under HKLM. The current implementation of updater is using per-user COM. Therefore, developing integration tests requires hacking of the tests, which is undesirable. For a related change, this CL also enables integration tests in component builds for Windows. Typically, Windows devs build the project as a component-build with debugging symbols (level 2), such that full debugging is possible. With this change, a Windows dev is able to develop, build, run, and debug integration tests without needing elevation at all, or another build configuration. Bug: 1124585 Change-Id: Id3e1195dfef2183faf0b3857a439a03411566c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392082Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804235}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I9a68ca6af9c3fc8c1012bf42d91c92d702a922a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391085 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#804234}
-
Frédéric Wang authored
Partial support for the accent/accentunder attributes on the munder, mover and munderover elements has been added in the UA stylesheet [1]. This CL modifies the munderover layout algorithm to take these boolean attributes into account when determining gaps and shifts parameters as specified in [2] and [3]. Additionally, for overscript we also rely on the OpenType MATH.MathConstants.AccentBaseHeight parameter as specified in [3]. This makes the remaining underover-parameters-3.html test pass. Note that underover-parameters-4.html no longer corresponds to what is in the MathML Core specification [4] and we will ignore it in our implementation. Finally, this CL extends underover-parameters-3.html to also test dynamic changes of accent/accentunder attributes, using various syntaxes for true/false. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2184131 [2] https://mathml-refresh.github.io/mathml-core/#base-with-underscript [3] https://mathml-refresh.github.io/mathml-core/#base-with-overscript [4] https://github.com/web-platform-tests/wpt/commit/aab53f17c0f688da550311ddc919c1702fb8681b Bug: 6606, 1124285, 1124289 Change-Id: Ie589a2f2a00e6f49b15376bd83762d34c914fd65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391083Reviewed-by:
Rob Buis <rbuis@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#804233}
-
Nicolas Ouellet-Payeur authored
This reverts commit e97a414a. Reason for revert: crbug.com/1124751 Original change's description: > media/gpu/vaapi: Introduce ScopedVABuffer and use for encoding and Vpp > > VaapiWrapper owns VABufferIDs of the VA buffers that are used > outside of VaapiWrapper. This CL moves the ownership out of > VaapiWrapper. The VA Buffers are owned by ScopedVABuffer in order > to prevent the buffer leakage. > Ths ScopedVABuffer will be used for other VABufferIDs later. > > Bug: b:166646505, b:162962069 > Test: video_encode_accelerator_tests on atlas > Test: media_unittests --gtest_filter=VaapiVideoEncodeAcceleratorTest > Test: vaapi_unittest --gtest_filter=VaapiUtilsTest > Change-Id: I7b0dda7491d29ebba70bc42051a8657144209dda > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379423 > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804103} TBR=mcasas@chromium.org,jchinlee@chromium.org,hiroh@chromium.org,andrescj@chromium.org,wtlee@chromium.org Change-Id: I943ecf23284c208860233bcf5f3e774e9761363a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:166646505 Bug: b:162962069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392402Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#804232}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/web_applications This CL was uploaded by git cl split. R=ortuno@chromium.org Bug: 1110266 Change-Id: Idfa976a6741f19d840933bbd7eb3150e4cf50136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371283Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#804231}
-
