- 15 Apr, 2020 40 commits
-
-
Kent Tamura authored
This CL introduces LayoutNGRubyAsBlock, which is LayoutNGBlockFlowMixin<LayoutRubyAsBlock>. <ruby> with display:block uses it if LayoutNGRuby flag is enabled. This CL has no behavior changes. Bug: 1069817 Change-Id: Ia8c80ed4727a0788f1a8c2a1a502ceabd5ebab96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147408Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#759144}
-
Ramin Halavati authored
Profile API are updated for better support of multiple off-the-record profiles (issue 1033903) and Independent OTR profiles will be deprecated. This CL updates HatsHatsSurveyStatusChecker to use the newer profile APIs and removes the dependency on Independent OTRs profiles. Bug: 1033903 Change-Id: Ief2ff3e1462c469d6adab2de3f2f40531b245835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144036 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#759143}
-
Johann authored
Use HeapMojoRemote wrapper so that Oilpan will GC the object. BUG=chromium:1049056 Change-Id: I79e80eecadf9f15c43ef2a1f952440b8b677b6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145744 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759142}
-
Gyuyoung Kim authored
This CL migrates filter-region-transformed-composited-child [-expected].html tests from css3/filters to external/wpt/css/filter-effects with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to filter-region-transformed-composited-child-001[-ref].html to be align with existing test naming style. Bug: 1063749 Change-Id: Ie6b779978770416df22cf702b377c4d04b207033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143021Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#759141}
-
Wei Lee authored
Originally, for reprocess request, we will put the Jpeg orientation information when constructing the second request. However, the frame data is actually filled when processing the first request. If the orientation changes between these two requests, we might put the wrong orientation into the second request which is inconsistant to the actual image data. Therefore, this CL stores the orientation information when constructing the first request and use that info for the second request. Bug: b/153828264 Test: Manually test on Kukui and it works as expectation Change-Id: Ic19a395b21ed934efca46b160ae18fd223ded6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143179 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#759140}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/81d176721689..8073a50204ee git log 81d176721689..8073a50204ee --date=short --first-parent --format='%ad %ae %s' 2020-04-15 ehmaldonado@google.com gclient: Set with_branch_heads if asked to sync to refs/branch-heads/* 2020-04-15 ehmaldonado@chromium.org Revert "metrics: Use vpython3 instead of sys.executable" Created with: gclient setdep -r src/third_party/depot_tools@8073a50204ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068263,chromium:1070545 Tbr: agable@chromium.org Change-Id: I9d94595c75c7f1dcf3f7c90b52bbd6aa009857d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759139}
-
Wanming Lin authored
This CL removes duplicated tests in wpt and moves uncovered checkpoints from those duplicated tests to existing tests. Tests in device-orientation-on-secure-origin.https.html are covered in several existing tests. devicemotionevent-init.https.html duplicates with motion/optional-event-properties.https.html deviceorientationevent-init.https.html duplicates with orientation/optional-event-properties.https.html motion/add-child-listener.https.html duplicates with device-orientation-events-of-detached-documents.https.html orientation/window-property.https.html, motion/window-property.https.html duplicate with idlharness.https.window.js t001-manual.https.html, t002-manual.https.html, t003-manual.https.html duplicate with orientation/add-listener-from-callback.https.html t021-manual.https.html, t022-manual.https.html, t023-manual.https.html duplicate with motion/add-listener-from-callback.https.html ondeviceorientationabsolute.https.html duplicates with orientation/deviceorientationabsoluteevent.https.html Bug: 816462 Change-Id: Ic1f604e144a6a853c989f1596873d079247f21f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147359Reviewed-by:
-
Alexandre Courbot authored
V4L2Buffer::GetVideoFrame() is an internal method that is never exposed outside of V4L2Device. Change a regular error handling (which would be the way to do if this was exposed) into a NOTREACHED() so we catch potential bugs in our code. BUG=None TEST=VDAtest --use_vd passes on Kukui. Change-Id: Ide5cf00447df154d39d1400d156633ea67b45e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143426 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#759137}
-
Yue Zhang authored
* Instead of holding on to references of RecyclerViews to check tab switcher state within two Activities, use Espresso style checks. Benefits of doing so are: 1) Espresso style requires us to use moveActivityToFront() to bring current activity to the front, which makes tests more readable. 2) It aligns better with the approach that we are using across tab_ui. * Use helper functions from TabUiTestHelper. Bug: 1017141 Change-Id: I939fc48f258a0c0b8089fd91a1492f0479370cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145076Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759136}
-
Eric Willigers authored
LaunchReleaseNotesImpl() now uses web_app functionality instead of relying on the Extensions implementation of Bookmark Apps. Bug: 1070469 Change-Id: Ib42a0ca72c5e4ef0f0cfd6f0c0095b9a84b0a063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149727Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#759135}
-
Alexandre Courbot authored
Add a simple method that allows to query a single control of a V4L2Device and use it in the V4L2VDA. This will also come handy for the V4L2VD. BUG=b:149663704 TEST=VDAtest --use_vd passes on Kukui. Change-Id: I9e306fcf4115936dde07e8595631b86ceeb6e917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143425 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4a4e82967f41..bce98d0a1b9f git log 4a4e82967f41..bce98d0a1b9f --date=short --first-parent --format='%ad %ae %s' 2020-04-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@bce98d0a1b9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie9f718354b547ef220e03e0ab5626fee108b697e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147726Reviewed-by:
-
John Z Wu authored
- Replace SigninErrorController with the errors wrapped by SyncService - Call opt ins for transport only data - Rely on SyncService state change for delegate callbacks - Introduce some new userInfo keys in the NSError object - Redo unit test to use more fakes Change-Id: Ibb954e142c254627380658dc9af1e624b96edf98 Bug: 1056416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103555 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#759132}
-
Alexandre Courbot authored
jkardatzke@ is to become one of the main owners of the Chrome OS/V4L2/VAAPI parts. Add him to the OWNERS file. BUG=None TEST=None Change-Id: Ic2b13e3e9aa67165e44ba875275c10022019c903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148799 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#759131}
-
Jeroen Dhollander authored
This is a reland of f5bc3fb9 It also includes the rolldep of src-internal, so it also contains the following private CLs that are required: * crrev.com/i/2879257 * crrev.com/i/2837749 * crrev.com/i/2883185 Original change's description: > Reland "Uprev LibAssistant to 1.46s" > > This is a reland of e3f29527 > > Original change's description: > > Uprev LibAssistant to 1.46s > > > > The current LibAssistant branch (1.42c) is no longer maintained, > > and also does not contain the latest features. > > > > * This will only be landed after M83 branches > > * This depends on the internal changes to land first > > > > Note: > > Bug: b/152777569 > > Change-Id: Ic34b6ca3ba1d793c719ebb58ab9766e943fc5ec6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134617 > > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > > Reviewed-by: Tao Wu <wutao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#758408} > > Bug: b/152777569 > Change-Id: I2aa720f229708d8ccfac7656a5d5d41606a13b37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147808 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Cr-Commit-Position: refs/heads/master@{#758603} Bug: b/152777569 Change-Id: I3b044b99b85ae73184085d6abc4b54aecfe64a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148067Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#759130}
-
Donna Wu authored
Bug: 520391 Change-Id: I2dc1160947ea6b97ee5dc7e5d5cf5ca57e57b1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145263 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
-
Alexandre Courbot authored
The ApplyResolutionChange() method is already called in the right sequence, so we can call our own callback directly instead of posting it as a task. BUG=b:149663704 TEST=VDAtest --use_vd passing on Kukui. Change-Id: I78407ecfa42c79753263ae09c5542caa525af6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143424 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759128}
-
chrome://appsDaniel Murphy authored
R=calamity@chromium.org, loyso@chromium Fixed: 1070185 Change-Id: I84aafb1203586e272bb0d68d8f0aed49f0d7f827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147805 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#759127}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1067031 Change-Id: Iedab6684bf2cc2a18e9ddd04154cb121d69d5d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147404Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759126}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ibb49659029e01fbfeb3fd79d6ea938ec21fdd18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147725Reviewed-by:
-
Xiaocheng Hu authored
Currently, there are two different invalidation code paths for font-face related changes: 1. Via FontSelector::FontFaceInvalidated(). This is called when: - The loading status of a font changes - A FontFace is changed via the JavaScript API This code path also allows partial style invalidation when the feature CSSReducedFontLoadingInvalidations is enabled; Otherwise, it marks the full document's style as dirty. 2. Via StyleEngine::InvalidateForRuleSetChanges(). This is called when StyleEngine identifies changes in the active @font-face rules. It marks the full document's style as dirty. This patch makes (2) to also use FontSelector::FontFaceInvalidated() to update style and layout, instead of directly marking full document style dirty. As a result: - When the feature is enabled, @font-face rule changes don't need full document style recalc - We no longer need to compare FontSelector versions in style diff. This is required by partial layout recalc for font loading - There is no essential behavioral change when the feature is disabled, since in that case both code paths mark style dirty on the full doc Note: there's also a renaming to certain variables & functions to make code more readable, since what they actually rebuild is FontFaceCache instead of FontCache. Bug: 441925 Change-Id: I5207e99fdb7e610bcdedc4c7b3615b0c13b69c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147687Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/05dc1d6cad93..b2bcf0eb3a4d git log 05dc1d6cad93..b2bcf0eb3a4d --date=short --first-parent --format='%ad %ae %s' 2020-04-15 rwkeane@google.com Discovery: Multi Network Interface part 2 Created with: gclient setdep -r src/third_party/openscreen/src@b2bcf0eb3a4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0e0b1579dfb116e9bba757387789c4aede94b374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150086Reviewed-by:
-
Anne Lim authored
Temporarily cache the result of unmask calls on a page. The card can be filled again later without attempting to auth. This is cleared upon page navigation. Bug: 152444825 Change-Id: I5d6706a488a2c50694d481e1ea07e051d68ef4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134610 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759122}
-
Justin Cohen authored
This reverts commit 79d88adc. Reason for revert: Fix test. Original change's description: > [ios] Disables failing tests in RestoreTestCase. > > These tests are attempting to load an invalid URL that happen to no > longer be invalid. > > TBR=justincohen@chromium.org > BUG=1070790 > > Change-Id: I03df3f99989b70013e4a047c3636f7e0b5d45fc4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148029 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759036} TBR=rohitrao@chromium.org,justincohen@chromium.org Change-Id: I31bc8c06a54f2d106e5b040ced6730c8bf4fc121 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150010Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759121}
-
John Z Wu authored
Change-Id: I1d59001345830e59a0e57834490f9f5afbaa0247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150126 Auto-Submit: John Wu <jzw@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ib75716cf8070b3e2b0a91b818fa8317696076c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150186Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759119}
-
Jeevan Shikaram authored
Fixes a bug that did not show the correct web apps in App Management when BMO is turned on. Fixed: 1064877 Change-Id: I38dcd7485c59cd6b9a821b15b14f04c08e7590bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147127Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#759118}
-
Shakti Sahu authored
This CL refactors query tiles into a generalized component 1 - Moved to components/browser_ui/widget 2 - Subclassed generic Tile to QueryTile for query tile usage 3 - Moved XML layouts, drawables, dimensions etc to components as well. 4 - Future clients will have to add their layout resources and specific java classes in the same directory. Bug: 1068687 Change-Id: I48646b8d2f2160cdfbec74cfaa1ebc74ed7dbaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140921 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#759117}
-
Rohit Rao authored
RestoreIOSLiveTab is not compiled with ARC and therefore is not properly retaining the CRWSessionStorage* which it is passed. Temporarily work around this bug by keeping a strong pointer to the CRWSessionStorage* in ClosingWebStateObserver, until RestoreIOSLiveTab can be fixed properly. BUG=1070852 Change-Id: Ic3d8a4d0cc3c29bfae4f657de06b98aa869b3bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150035Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759116}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e0950f3cd2c6..81d176721689 git log e0950f3cd2c6..81d176721689 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 apolito@google.com upgrade git to 2.26.1 2020-04-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-04-14 iannucci@chromium.org Fix recipe autoroller account. 2020-04-14 ehmaldonado@google.com metrics: Use vpython3 instead of sys.executable Created with: gclient setdep -r src/third_party/depot_tools@81d176721689 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068263,chromium:1070694 Tbr: agable@chromium.org Change-Id: I9257ae3b42eeedf414af29a5b4cced28f2e16d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149823Reviewed-by:
-
David Black authored
On creation, AssistantSearchProvider will sync its results with the cache of Assistant conversation starters. It will also observe changes to the conversation starters cache to keep itself in sync. Bug: b:153165835 Change-Id: I678bb6c8b8d80148c18c4970107872089d02dd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140210 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
nancy authored
If the app is unpaused before the user responses to the pause app dialog, remove the app from pending_pause_requests_, and not pause the app, when the user click the pause app dialog. Because the app has been unpaused, and the user can still use the app. BUG=1068799 Change-Id: I4beef6959bc01746388dcfc0a3d282859e16cd6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147481Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759113}
-
Martin Šrámek authored
The steady state button uses the aria label "Run safety check now". Per feedback from the accessibility review, when we swap that button with a reload button, we should also update the aria label. We will use the label "Check again". This string already exists in settings_strings.grdp, with a reasonably matching strings description, so we will reuse it in order to be able to merge this change into M83. We will introduce a dedicated string resource in a follow-up CL (that will not be merged into M83): https://chromium-review.googlesource.com/c/chromium/src/+/2149418 Bug: 1070841 Change-Id: I9b9ee80a53ce0efc591d78fe384ce29748f183d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149647Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#759112}
-
John Z Wu authored
- Use more mocks - Remove old autoreleasepool work around Bug: 1070657 Change-Id: Ic234ddb2e9be28048a39c365ec8c2e09eaf38d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147882 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: If006fe91be7c37d81fea2088c42a8bdb920938a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150029 Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#759110}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/39fd800d2c43..05dc1d6cad93 git log 39fd800d2c43..05dc1d6cad93 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 rwkeane@google.com mDNS: Multi-Packet Known Answer Suppression Created with: gclient setdep -r src/third_party/openscreen/src@05dc1d6cad93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I48dd1b14f82e9130ee65aef86249b1aa19c44112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150085Reviewed-by:
-
Klaus Weidner authored
By default, this is a no-op, but test API implementations can override it to do console logging or similar. This is intended to help investigate flaky tests on Windows that are currently just being reported as "timed out" with no indication what's going wrong. Includes a fix for ar_dom_overlay_hit_test.https.html, the logs had shown that the test wasn't waiting for the test body to execute, and an unexpectedly failing assertion wasn't being reached. Bug: 1054750 Change-Id: I878c6ea56ebb8e0752027ea13de7106d7f9e7bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132784 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#759108}
-
edchin authored
This reverts commit c977b051. Reason for revert: EG swipe is not working properly on iOS 12. Disabled swipe test for iOS 12. Original change's description: > Revert "[ios] Add eg2 tests for managed bookmarks" > > This reverts commit db19268d. > > Reason for revert: test failure, see crbug.com/1070676 > > Original change's description: > > [ios] Add eg2 tests for managed bookmarks > > > > This CL adds eg2 tests for changes in crrev.com/c/2140953. > > > > The test fixture in this CL must enable certain command-line flags > > to be able to run the managed bookmarks enterprise policy. > > > > The eg2 tests for managed bookmarks include testing: > > - disabling long-press for managed items (URLs and folders) > > - disabling swipe-to-delete for managed items (URLs and folders) > > - disabling new folder context menu button when inside a managed folder > > - disabling edit context menu button when inside a managed folder > > > > Bug: 1065187 > > Change-Id: Ide92b87f03585d186b133f192d1e39a4fbbaa1cd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145260 > > Reviewed-by: Sergio Collazos <sczs@chromium.org> > > Commit-Queue: edchin <edchin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#758848} > > TBR=edchin@chromium.org,sczs@chromium.org > > Change-Id: Ie6b374a26d85cd99d52417ee52aabee8ff2d2683 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1065187, 1070676 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149287 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758903} TBR=xhwang@chromium.org,sczs@chromium.org Change-Id: Idbdbab707e239b9abdae0c19a10979af9abfef06 Bug: 1065187, 1070676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149507Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759107}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/b86cd3f5fb91..5abb89b35e3c $ git log b86cd3f5f..5abb89b35 --date=short --no-merges --format='%ad %ae %s' 2020-04-13 ianswett gfe-relnote: Rename QuicHttp3ErrorCode::NO_ERROR to HTTP3_NO_ERROR to avoid colliding with the Windows NO_ERROR error code. No functional change, not flag protected. 2020-04-13 ianswett gfe-relnote: Change a string to a char[16] to avoid using data() in string, which is sometimes const. Fixes a Chrome merge failure of cr/305944808. Protected by existing flags gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-13 bnc gfe-relnote: Convert IETF RESET_STREAM error codes to and from QuicRstStreamErrorCode. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-10 dschinazi Add QuicheDataReader::ReadStringPiece8 2020-04-10 dschinazi Improve logging of QuicCryptoFrame 2020-04-10 dschinazi Apply GREASE to QUIC transport parameters 2020-04-10 fayang Change a WARNING log to DLOG in QuicStreamIdManager. 2020-04-10 renjietang Initialize values in tests to avoid MSAN failure. 2020-04-10 renjietang Move incoming SETTINGS handling from QuicReceiveControlStream to QuicSpdySession. 2020-04-10 ianswett Internal QUICHE change 2020-04-10 bnc Return INTERNAL_ERROR if QuicErrorCodeToTransportErrorCode() is called with invalid QuicErrorCode. This should never happen, because QuicErrorCodeToTransportErrorCode is only called for serializing locally initiated CONNECTION_CLOSE frames, with locally specified QuicErrorCodes. 2020-04-10 bnc gfe-relnote: Use PushId instead of QuicStreamId argument type where appropriate. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-10 bnc gfe-relnote: Change QuicRstStream::ietf_error_code to 64 bits and move it out of the union with error_code. Behavior change in IETF QUIC only, protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-09 bnc Do not use union in QuicErrorCodeToIetfMapping. Also do not end public member names with underscore. 2020-04-09 bnc Shorten QuicHttp3ErrorCode and QuicHttpQpackErrorCode member names; make QuicHttpQpackErrorCode enum class. Enum class members are always scoped, therefore they do not have to be long or unique. 2020-04-09 bnc gfe-relnote: Do not increment QuicSimpleServerSession::highest_promised_stream_id_ if push cannot be created. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-09 nharper Use all encryption levels in quic_crypto_stream.cc 2020-04-09 renjietang store received TransportParamters in TlsClientHandshaker so that it could later be stored into the session cache. 2020-04-09 dschinazi Introduce quic::AllSupportedVersionsWithTls() 2020-04-09 dschinazi Add operator!= to QUIC TransportParameters 2020-04-09 bnc Move QuicIetfTransportErrorCodes, QuicErrorCodeToIetfMapping, and QuicErrorCodeToTransportErrorCode from quic_types to quic_error_codes, next to closely related QuicHttp3ErrorCode. 2020-04-09 renjietang Implement comparator for TransportParameters. 2020-04-08 renjietang Modify QuicResumptionState and SessionCache to support multiple TLS sessions. 2020-04-08 dschinazi Remove QuicDispatcher workaround for Android Conformance Test 2020-04-08 renjietang Allow copy constructor of TransportParameters. 2020-04-08 renjietang Remove QuicStreamIdManager::IsIncomingStream() as it's hard coded. Also QuicSession doesn't need the indirectness. 2020-04-08 bnc gfe-relnote: Use indexed name if possible when sending Literal Header Field without Indexing instruction. Protected by gfe2_reloadable_flag_spdy_hpack_use_indexed_name. 2020-04-08 bnc gfe-relnote: Consolidate constants with the same value. No functional change. Not protected. 2020-04-08 wub gfe-relnote: (n/a) Change 2 QUIC_BUG to QUIC_LOG_EVERY_N_SEC(ERROR) to reduce alert spam. Logging only, not protected. 2020-04-08 quiche-dev gfe-relnote: Reject chlo packets with unacceptable uaid/sni in quic dispatcher. Protected by --gfe2_restart_flag_reject_unacceptable_packet_early_in_dispatcher. 2020-04-07 renjietang Clean up QuicStreamIdManager comments and remove unnecessary methods. 2020-04-07 nharper gfe-relnote: test-only change: De-parameterize QuicCryptoServerStreamTest 2020-04-07 dschinazi Reorder QUIC TLS versions before QUIC_CRYPTO 2020-04-07 fayang gfe-relnote: Neuter handshake data when 1-RTT packet gets decrypted in quic_loas_server_stream. Affecting QBONE, not protected. 2020-04-07 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_bbr2_avoid_unnecessary_probe_rtt. 2020-04-07 bnc gfe-relnote: Do not include PUSH_PROMISE header block length when calling QuicSpdyStream::OnStreamHeaderList(). Not protected. 2020-04-07 dschinazi Disable TLS in YperfChannelTest 2020-04-07 wub gfe-relnote: For better experimentation, add QUIC connection option ELDT to enable loss detection tuning. No behavior change, not protected. 2020-04-07 renjietang Use Quic protocol flags to control QuicStreamIdManager's max_streams_window. 2020-04-06 renjietang Remove max_streams_window_ in QuicStreamIdManager to make the code more readable. 2020-04-06 fayang gfe-relnote: Calling OnConfigNegotiated() after OverrideQuicConfigDefaults in tls_server_handshaker. No functional change expected. Protected by existing gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-06 dschinazi Add operator<< overrides for QUIC version vectors 2020-04-06 ianswett gfe-relnote: Deprecate gfe2_reloadable_flag_quic_bundle_retransmittable_with_pto_ack. 2020-04-06 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_arm_pto_with_earliest_sent_time. 2020-04-06 ianswett gfe-relnote: Support the BBQ2 connection option in QUIC BBRv2 to lower the CWND gain to 2 in STARTUP. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src You forgot to pass -r, make sure to insert a R=foo@example.com line to the commit description before emailing. Run: git cl upload --send-mail R=bnc@chromium.org Change-Id: I2822bd93938fcc537a4fb74a9df13b22bd3a6783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146297 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#759106}
-
Yuzu Saijo authored
This is a reland of 9caea10d This CL contains the part of the original change which only adds the blocklisting mechanism. The flaky test is to be fixed and added in the next CL. Bug:1070511, 1068949 Original change's description: > [bfcache] Blocklist Printing > > This CL disables BackForwardCache when window.print API is used. > > Change-Id: I52a1b350c70246344487f00b19682579cbceec58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121638 > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757348} Change-Id: I3fee79ea7332b6c61ba538017bd83d14b0b49719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145542Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
