- 05 Aug, 2020 40 commits
-
-
Brian Sheedy authored
Targets the new driver and Windows versions for the GPU Windows 10 Quadro P400 machines in preparation for an upcoming upgrade. Bug: 1085489 Change-Id: I4dffa9fe085fa96dc3ad3e73bb981314195f98e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340000 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#795161}
-
Siyu An authored
Design doc go/chrome-sync-merchant-offers. Start with implementing only the protobuf changes since they are in kind of a finalized state and this CL can unblock impl on GMSCore. Bug: 1112095 Change-Id: I27705f467424d614c80b4dd03ae5207e112e4c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333870 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#795160}
-
Devlin authored
This reverts commit 4856b612. Reason for revert: New test is failing on windows asan. https://ci.chromium.org/p/chromium/builders/ci/win-asan/13719 [ RUN ] All/DumpAccessibilityEventsTest.AccessibilityEventsAriaHiddenDescendantsAlreadyIgnored/win DevTools listening on ws://127.0.0.1:56078/devtools/browser/cb8ef55e-fd6c-40c9-9bb9-69a6e2f10a39 [3056:12476:0805/095807.582:ERROR:browser_test_utils.cc(712)] No committed entry. [3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged [3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kLayoutComplete [3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kLoadComplete [3056:12476:0805/095810.693:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged [3056:12476:0805/095810.694:ERROR:dump_accessibility_events_browsertest.cc(103)] === IsRecordingComplete#1 run_until size=0 [3056:12476:0805/095810.703:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged [3056:12476:0805/095810.856:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged [3056:12476:0805/095810.857:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kEndOfTest [3056:12476:0805/095810.866:INFO:dump_accessibility_test_helper.cc(93)] Testing: C:/b/s/w/ir/content/test/data/accessibility/event/aria-hidden-descendants-already-ignored.html [3056:12476:0805/095810.867:INFO:dump_accessibility_test_helper.cc(95)] Expected output: C:/b/s/w/ir/content/test/data/accessibility/event/aria-hidden-descendants-already-ignored-expected-win.txt [3056:12476:0805/095810.867:ERROR:dump_accessibility_test_helper.cc(127)] Diff: * Line Expected - ---- -------- 1 EVENT_OBJECT_HIDE on <div#heading-root.a> role=ROLE_SYSTEM_GROUPING name="Heading" INVISIBLE level=2 2 EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL * 3 IA2_EVENT_TEXT_INSERTED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL new_text={'<obj>' start=0 end=1} * 4 IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1} Actual ------ EVENT_OBJECT_HIDE on <div#heading-root.a> role=ROLE_SYSTEM_GROUPING name="Heading" INVISIBLE level=2 EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL IA2_EVENT_TEXT_INSERTED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL new_text={'<obj>' start=0 end=1} IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1} IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1} <-- End-of-file --> Original change's description: > Fire WIN HIDE event only on ignored ancestor > > Google drive expand/collapse state is not being announced due to > excessive HIDE/SHOW/REORDER events flooding NVDA, and NVDA end up > discarding most events. > > For example, if aria-hidden="true" is set on an ancestor node, which > would cause that node many of its descendants to be set to IGNORED > state which triggering too many EVENT_OBJECT_HIDE and causes NVDA > to drop the events. In reality, we only want EVENT_OBJECT_HIDE to be > generated on the ancestor node where aria-hidden="true" is set, so > not to flood and confuse NVDA with excessive events. > > This change fixes the above issue by firing EVENT_OBJECT_HIDE on the > root should the entire subtree changes to IGNORED state. > > Suppressing excessive SHOW/REORDER events will be addressed in follow up > patches. > > AX-RelNotes: NVDA can now announce Google drive "My Drive" expand/ > collapse state. > > Bug: 1019420 > Change-Id: I4fdabd6740630a149c1b22cdb3180d2f75807b10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309450 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#795017} TBR=dmazzoni@chromium.org,aleventhal@chromium.org,Adam.Ettenberger@microsoft.com,vicfei@microsoft.com Change-Id: I4354e1effb7b3fe4a01caef00f696513ecaacbbc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339828Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795159}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1e0d126c..10ee7644 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie2ff859c44254929e07512ccd23568fbf659e4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339794Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795158}
-
Thomas Tellier authored
Bug: 1015746 Change-Id: I5862995d37ae067664304f57562460c46d51c811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339518Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#795157}
-
Noah Rose Ledesma authored
The media session controller will now notify the media session of audio device switching. Upon receiving this message, the media session will update the MediaSessionInfo to include the device id and notify its observers. Because it is possible for a media session's players to be using different audio devices, a device is only added to the info object if all of the sessions players are using the same device. Bug: 1096251 Change-Id: I280387991b333eff60141e38e119eff7444aebb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324406 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#795156}
-
Tomasz Wiszkowski authored
Introduces new metric recording outcome of every Omnibox focus event. Logged result will allow us to monitor for increase in abandoned interactions as we introduce new suggestion types. Bug: 1105156 Change-Id: I0b12e8cfa748e6a33f1d44e96ade77bf0b39cdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329878 Commit-Queue: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Reviewed-by:Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#795155}
-
liberato@chromium.org authored
AndroidBatteryMetrics required an application state change before switching from UNKNOWN to the current state, which prevents it from recording metrics on browser startup immediately. This CL changes the behavior to check the application state on startup, so that recording can begin immediately. Change-Id: Iaec5a175ea3f367b30d1fd95414dcc5e67573315 Bug: 1113311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333090 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#795154}
-
Ken Rockot authored
Bug: 1059389 Change-Id: Ifcd3c119d779503d4a2f8a9bd8046b6ce7272951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339205Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#795153}
-
Koji Ishii authored
r793989 crrev.com/c/2332083 caused a test in `virtual/ layout_ng_block_frag` to hit DCHECK failure in |NGInlineCursor|, and probably caused two flakes in crbug.com/1112237 and crbug.com/1112289. r795011 crrev.com/c/2313736 supports block fragmentation in |NGInlineCursor|. This patch removes these DCHECK failiure expectations. Bug: 829028, 1112237, 1112289 Change-Id: I637ad65e2143d7506a570c8edf91edb36e26ad47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339697 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#795152}
-
Etienne Bergeron authored
This CL is fixing a crash related to cursor movement (line) when a single-line RenderText has newline. The unittest added is crashing without the fix. The problem is the following: 1) In single-line, newline codepoints are rewritten 2) The whole text will be in the same run (same Line). 3) The cursor movement function are looking at the original text to detect a newline. SEE: RenderText::GetAdjacentSelectionModel(...) is calling |-> LineSelectionModel(GetLineContainingCaret(current), direction); But it has an incorrect line number, since: RenderTextHarfBuzz::GetLineContainingCaret(...) |-> LineIndexForNewline The function is looking at the original text! R=msw@chromium.org Bug: 1108254 Change-Id: I656cd8a4b0a5d5d77e074249425c5821860d3e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339385Reviewed-by:Michael Wasserman <msw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795151}
-
Nate Fischer authored
This adds a search bar to filter flags. To match the apparent behavior of chrome://flags, this accepts any flag which contains the query as a case insensitive substring of either the flag name or description. If the user has any (non-empty) query, this will also filter out the warning message, since this is just getting in the user's way. This imports the material search icon (magnifier glass). Bug: 1052345 Test: Manual - verify the search bar works as expected Test: run_webview_instrumentation_test_apk -f DeveloperUiTest.* Change-Id: I80db4b7325d9c931f622f9f37d969350865115b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330310 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#795150}
-
Andy Lu authored
Implementing a pref so that printing a web page can be disabled. The print option will not show up in the "share" action sheet if the policy is disabled.Also will disable any other entry point such as Javascript window.print(). Also added the unit tests associated with the new pref. Bug: 1066482 Change-Id: I3167f941bc2f192600d359a75a8bd844ffc2fc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337715Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Andy Lu <andyhylu@google.com> Cr-Commit-Position: refs/heads/master@{#795149}
-
Dominic Mazzoni authored
Original patch: http://crrev.com/c/2319411 Revert: http://crrev.com/c/2326560 See diff between first and last patchsets. The revert was due to the new DCHECK added in render_accessibility_impl.cc. I carefully debugged all of the failures and there was only one real failure (slider thumbs) which are now fixed with a few lines of code to explicitly invalidate them. The other failures were all false positives - in every case, the bounds of a LayoutObject had changed but the paint invalidation simply hadn't come yet - but it eventually came and all bounding boxes became correct. So I'm just removing the DCHECK. The performance win is great, and we're not seeing any cases where bounds aren't invalidated where they should be. We can revisit if we see failures in the wild. Original description: Previously, any time there was a layout, the accessibility serialization code would scan every AXObject to see if any needed to update their bounding box. Instead, replace this with a mechanism that uses PaintInvalidator to mark AXObjects that might have dirty bounding boxes. Existing tests already provide some coverage; if you comment out the code in paint_invalidator.cc, a handful of browser tests fail. To provide even more coverage, a debug-only check walks the entire tree and ensures that no nodes have incorrect bounding boxes. If you try commenting out the code in paint_invalidator.cc now, hundreds of browser tests fail. This provides some good confidence that it's working correctly. Finally, add a new blink perf test demonstrating a simple scenario where this results in a dramatic speedup, just by focusing links in a document with a few thousand nodes. Bug: 1109081 Change-Id: Ia6bdbbac243c816a613d7b44807c91534b33221e AX-Relnotes: makes accessibility less sluggish on very large web pages Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333573Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#795148}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08a9885983f1..3b1b0980710f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com,rdcronin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1085419,chromium:1105096,chromium:1112335,chromium:1113252 Tbr: rogerta@google.com,rdcronin@google.com Change-Id: Ie646c5535cbda49368215d574d8b692598a32c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338817Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795147}
-
Aaron Leventhal authored
Active descendant information should be exposed on the focused object. In the case of the Omnibox, this is the textfield, not the listbox. This is the same source as active descendant changed events. The active descendant information is not currently used by any AT to enable the omnibox, but it could be, so it should be corrected. Bug: None Change-Id: I1adda17e3065d884b20ab2307f5c89b3c7c0c7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339379 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2de6d657dde3..695e1de8318d 2020-08-05 johnkslang@users.noreply.github.com Merge pull request #2365 from KhronosGroup/update-gtests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I4d14295b6deda9e26a5af572635524e71b5555a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795145}
-
David Tseng authored
Bug: 1112348 AX-Relnotes: n/a Change-Id: I05deaeaf61f1390feb700c322799d9afd05a75e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322736 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#795144}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/011b0075cd53..a4a8199cf1a3 2020-08-05 t-olfly@microsoft.com Source order viewer toggle persistence 2020-08-05 jobay@google.com Eliminate initial timeout in waitForFunction If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112692 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8210522fb914799218b17f3f348a9b95fec877ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339537Reviewed-by:
-
Jihwan Marc Kim authored
A 'once' listener should be unregistered when it is invoked, and stopImmediatePropagation() should not invoke other event listeners. We had a bug that stopImmediatePropagation() unregistered uninvoked 'once' listeners. Bug: 993109 Change-Id: Iaabb03141ee7cf2de88dc6c8726f5a474efd133b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336011 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#795142}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/486f1812ef65..bd6505349012 2020-08-05 saagarsanghavi@google.com ResultDB reporting for bot-triggered builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Iadaeb46832185a028295ce96aa8541d492fc29aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339726Reviewed-by:
-
Jimmy Gong authored
- When the print job app is enabled, print notifications will show a simplified progress notification and hide all buttons. Bug: 1103369 Change-Id: I17424d33fed72a1df6cf1ba3ec5dd129ebe5774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324411Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#795140}
-
Jimmy Gong authored
- Fixes a bug where the PRINTER_UNREACHABLE error was not captured by the print job history service. - This only occurred if the user were to attempt to print repeatedly to an offline printer. In those cases, the error was only captured in the OnPrintJobUpdated event. Bug: 1103429 Change-Id: I910fa3a173300e62ac151e58ff679c0e389497ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315797Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
This CL is adding unittests for testing fractional text position. The tests are fonts and platform-independant. The layout will be the same on every system. R=msw@chromium.org Bug: 1111044 Change-Id: I3db022838866516501fbd0405a059a6a4b5aa3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331332 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e4e2a847dab3..c547fda2a9c6 2020-08-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 74cc8ea2b8df to be7c55a2a8ce (2 revisions) 2020-08-05 syoussefi@chromium.org Add back glslang include check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I4efc5974a6b93014147619acf507fd3a680acac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339639Reviewed-by:
-
Orin Jaworski authored
This CL puts the UX revised button labels and tooltip texts into the omnibox_strings.grdp data set for translation. Bug: 893183 Change-Id: Ib0015c44e939667b0ad1b7283d9dd676acd98d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339601Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#795136}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/076a4e58205d..7ce4924a35ea 2020-08-05 tommek@google.com Fixing linear texture data validation on bytesPerRow If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8a6c516522f3714585d463b5197032c0bbf5d53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339439Reviewed-by:
-
Tim Van Patten authored
The Abseil build target "absl_hardening_tests" includes "//base/test:run_all_unittests" as a 'dep', which breaks when ANGLE attempts to build abseil: ERROR at //third_party/abseil-cpp/BUILD.gn:199:7: Unable to load "/home/timvp/code/chromium/src/third_party/angle/base/test/BUILD.gn". "//base/test:run_all_unittests", ANGLE doesn't have a test/BUILD.gn, so Abseil needs to only look for that dependency when building with Chromium. Bug: angleproject:4873 Change-Id: Ia27e10b6e732ed510abd0866b99b04967bc7ca3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317709 Commit-Queue: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#795134}
-
Anders Hartvoll Ruud authored
For certain use-cases in the Inspector it's more useful to display the cascaded value rather than the computed values. This CL provides an API which returns those values. Bug: 1108356 Change-Id: I301a1b596a52e939381510a8f1440f416137aa64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324423 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#795133}
-
Lan Wei authored
After compared with interval of reporting the throughput metrics every 1 second and 5 seconds, we found out that 1 second is closer to the real data, so we decide to change to the interval to 1 second. Bug: 1040634 Change-Id: I94527a45ffe390fc6d44a2430f52dcb2346d6cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332978Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#795132}
-
Abigail Klein authored
communicate with the braille background page. Screenshot: https://screenshot.googleplex.com/cN7RSTWBv08 ChromeVox. AX-Relnotes: added virtual panning keys to the braille caption panel in Change-Id: Ice94af92fd84be29f14d828d3e2561c093635c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331913Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#795131}
-
Carlos IL authored
Bug: 1105210 Change-Id: Ic119d0d4fc22ebfdd7200a5f40c2327acbb7cf70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337538Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#795130}
-
David Tseng authored
Two changes: - always return false for ComboBoxNode.isGroup. Eventually, we can maybe consider a combo box a group if it isn't collapsed, but for the time being, we should avoid this path (see the bug for a crash/exception) - do not cache the value of is group in NodeWrapper; it's possible the descendants of the current node changes R=anastasi@google.com, dmazzoni@chromium.org Fixed: 1108633 Change-Id: I201e49c9f85f2b3fcf864dc2ca241f5bce99f84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339212Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795129}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f68444a445f7..9a43f48ed4cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idf1da66ac92c3c8fd36e29f62966b17f1b8a0a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339213Reviewed-by:
-
Alex Turner authored
Remove use of AtomicStrings in the HashMaps. Instead, we use the hash of each string as that is all the information we need to keep around. This should also simplify any future operations on a different thread. Bug: 1110204 Change-Id: I32a31589e9546c907dc78d1d00d77ba3e0d48fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335894 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#795127}
-
Eric Seckler authored
This is a reland of 027aa92e Relanding but disabling test on CrOS devices (some of our CrOS devices seem to have asymmetric CPUs that aren't covered by the test). Original change's description: > base: Add API to restrict thread affinity to little cores on Android > > Adds functions that facilitate setting the CPU affinity of a given > thread or process to all little cores on the system. > > We intend to use this API to run a power experiment. > > Bug: 1111789 > Change-Id: I6c3d32c2338e9f00464e8b6a8c96af93658a3ae2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335176 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794998} TBR: dcheng@chromium.org Bug: 1111789 Change-Id: I59315ec0e9a1727986278a04fa5bde409143dfb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339416Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#795126}
-
Ken Rockot authored
Storage service will no longer maintain support for unsandboxed out-of-process operation. This change eliminates the separate sandboxed service test suites and renames the others to drop the "unsandboxed" qualifier. Bug: 1052045 Change-Id: Ide0da8e819d52c989f84233f76ed9823423d65e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339716 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#795125}
-
Xianzhu Wang authored
crrev.com/794218 caused memory regression because of more frequent allocation of LayoutBoxRareData for the previous layout overflow rect which probably has different rareness characteristics from the other rare fields. Move the previous layout and visual overflow rects from LayoutBoxRareData into BoxOverflowModel to reduce chance of allocation of LayoutBoxRareData. This also enables us to simplify the previous overflow rect saving logic. Bug: 1112535 Change-Id: I1bc416b4065f6b47e6da0bcc05f2ec039bc04f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335647 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795124}
-
David Bertoni authored
Add tests for chrome.tabs.reload and chrome.tabs.update. This CL also cleans up the expected/actual order for chrome.test.assertEq in another test. Bug: 1093066 Change-Id: I614e82180e1ca08953515cbb1899ab00832f2fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322743Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#795123}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/d6a5a2271e6e..8f1c25394047 2020-08-05 dpranke@google.com DEPS: remove use_relative_hooks. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1107325 Tbr: jophba@chromium.org Change-Id: Ic1008d083cd61e18042f553d44434bfffa824a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339723Reviewed-by:
-
