GitLab

replace std::find() with base::containsValue()
at components/payments

Bug: 561800
Change-Id: Id11c844383e792b608eaa2e0bec6a389821e927c
Reviewed-on: https://chromium-review.googlesource.com/1102283Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#567860}

We want to shut off most of the chromium.webkit builders
and merge their tests into the main builders, but currently
the tryserver.blink builders mirror them, and the tryserver.blink
builders need to stick around so we can generate baselines.

This CL adds a bunch of dummy builder entries on chromium.fyi so
that we can switch the tryservers to mirror them, instead.

Then we'll be free to delete the chromium.webkit builders.

This CL also adds some placeholder entries to mb_config.pyl so
that we can rename the tryserver.blink bots to match the new
naming scheme.

R=hinoka@chromium.org
BUG=853040
NOTRY=true

Change-Id: I2e10feb13473a149a74a69915fcac0d80ec6cd28
Reviewed-on: https://chromium-review.googlesource.com/1101999
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567859}

This CL replaces the usages of 'blacklist' and 'whitelist' in the Declarative
Net Request code. It introduces the following changes to the public API:
  - RuleActionType blacklist -> RuleActionType block
  - RuleActionType whitelist -> RuleActionType allow
  - MAX_NUMBER_OF_WHITELISTED_PAGES -> MAX_NUMBER_OF_ALLOWED_PAGES
  - addWhitelistedPages -> addAllowedPages
  - removeWhitelistedPages -> removeAllowedPages
  - getWhitelistedPages -> getAllowedPages

As a result of this change, existing extensions using the Declarative Net
Request API will need to be updated. Usages of these terms in enums and
preference keys are kept as-is.

BUG=850774, 842296

Change-Id: Id4aaac5ec3123fd56a1591e22025a455d7cb6941
Reviewed-on: https://chromium-review.googlesource.com/1094141
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567858}

For migrated LUCI builders.

Bug: 840631
TBR: dpapad, sky
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I8bd70004c4d90f96cac332ff2548b6d87a7f4d05
Reviewed-on: https://chromium-review.googlesource.com/1102907
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567857}

TBR=robliao@chromium.org
BUG=853360
NOTRY=true

Change-Id: Id50cc9e6fc255f2bdafad60468540209075db893
Reviewed-on: https://chromium-review.googlesource.com/1103615Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567856}

This patch records UMA metrics for any change to the internal display's
zoom factor. It does not record temporary zoom factor changes by
debouncing signals that are within a small interval and only allowing
the last signal to pass through.

Bug: 849894
Change-Id: I2dc7d31e9910855ca4a59834a56d8322641a9f5b
Component: Display Manager, UMA, Zoom
Reviewed-on: https://chromium-review.googlesource.com/1093270Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567855}

This was missed when switching from audio master AV sync to video master
AV sync.

When setting playback rate, we only set the rate of the master, and have
the AV sync detect that and adjust the follower.

TODO is to proactively tell AvSync that we changed the rate, so it
doesn't have to discover that on its own.

Bug: b/110230181, b/78193238
Test: On device
Change-Id: I734030a68e5d670ec2c35b966f931e687630458a
Reviewed-on: https://chromium-review.googlesource.com/1101997
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567854}

* Fix to broken host tool "fvm verify" tested (outcome: works).
* SDK method rename; "zx_get_startup_handle" to "zx_take_startup_handle".

Bug: 852876,707030
Change-Id: Ib635c807ae92dedc76c65c34ab9d3829e8a7e5c0
Reviewed-on: https://chromium-review.googlesource.com/1102834Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567853}

I noticed this while reviewing some other CL.

Bug: none
Change-Id: Iab610a1e10079bc8e448eb392b2ce1229fe24fab
Reviewed-on: https://chromium-review.googlesource.com/1101574
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567852}

* Only run one configuration of EXPECT_QUIC_BUG tests
* Shrink timeouts in EndToEndTest.PreSharedKey timeout tests

Speed up net_unitttests by 15%

Bug: 806109
Change-Id: If98cbfaf300b044f01f8a1d91ec96584e43aaef5
Reviewed-on: https://chromium-review.googlesource.com/1103393Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567851}

Only CastCommandLineHelper will initialize the CommandLine
singleton, and the CommandLine.isInitialized() == true should be
a required post-condition of calling
initCommandLineWithSavedArgs().

Bug: Internal b/110021629
Test: cast_base_junit_tests
Test: cast_shell_junit_tests
Test: set command line args and install Cast apk on Android TV
Merge-With: eureka-internal/180061
Change-Id: Ieb65dba995df360d39f2793945b603156544c3aa
Reviewed-on: https://chromium-review.googlesource.com/1103446
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567850}

Heuristics for country doesn't need to check for the
value to accept the previously detected fields.
Same case for company.
The wrong output test corrected.

Bug: 853220
Change-Id: I2a271de3bc7046f0407a855fe3a9f442bed533e9
Reviewed-on: https://chromium-review.googlesource.com/1102561
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567849}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/8fd2b32dce02..7d1c88ce94

2018-06-08 kerrnel@chromium.org cryptohome: Add MountGuestEx dbus function to header.
2018-06-12 kerrnel@chromium.org cryptohome: Remove usused DoAutomaticFreeDiskSpaceControl
2018-06-12 lasoren@chromium.org Constant for bootstrapping Mojo IPC connection.
2018-06-08 amoylan@chromium.org Add ML service constant for Mojo pipe token
2018-06-07 kerrnel@chromium.org cryptohome: Add RemoveEx method and remove unused Remove.
2018-06-05 kerrnel@chromium.org cryptohome: Add MigrateKeyRequest protobuf.
2018-06-04 phweiss@google.com shill: Add new Manager property AlwaysOnVpnPackage

The TBR is an inherited +1 from CL:1099136 on cryptohome_util.cc.

Tbr: hashimoto@chromium.org
Bug: b:74589757
Bug: 842718, 799739, 211405
Change-Id: I07182858e3a96b700f335366620b9fd601c827fe
Reviewed-on: https://chromium-review.googlesource.com/1102979Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567848}

* Libfuzz builders use a lot of bots, let scheduler handle it.
* remove ios-webview

Bug: 840631
Change-Id: I4d7491a76863f82986c641c76118933838e755dd
Reviewed-on: https://chromium-review.googlesource.com/1103548Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567847}

Swiping up on a short/wide pdf no longer hides the toolbar.

Also disable synchronization for testSmallWidePDFScroll on iOS12,
but it's likely something larger is going on.

Bug: 852393
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iab556064447cfe54cb498678d192a45f36b55a1a
Reviewed-on: https://chromium-review.googlesource.com/1100337
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567846}

This CL makes the edit-as-html editor remain open on "blur"
when there is no relatedTarget. This allows switching windows
without closing the editor.

Screenshot: https://imgur.com/a/FT4GxFM

Bug: 805462
Change-Id: I46f0660f7e25a34bc75be79e179f7666f5a50525
Reviewed-on: https://chromium-review.googlesource.com/1101828Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567845}

In order to allow more than one touch filter to delay the reporting of
touches, make the existing filter keep track of its own filter state.

BUG=b:69232663
TEST=manual testing with filters enabled

Change-Id: Idfc68fea22574becd920cdd599dd2e90e19bd04d
Reviewed-on: https://chromium-review.googlesource.com/1093584Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567844}

Bug: 847639
Change-Id: I8dd0c17453e3dc19b4101468eed73d55264448fb
Reviewed-on: https://chromium-review.googlesource.com/1098472
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567843}

This CL adds ApiCompatibilityUtils.requireNonNull method that behaves
identically to Objects.requireNonNull added in API level 19 (see
https://developer.android.com/reference/java/util/Objects). This method
does what the name says - it ensures that passed object is not null.

Bug: None
Change-Id: Ia9a1b32f34569208f2eea67fc998fe1d3fca613d
Reviewed-on: https://chromium-review.googlesource.com/1097404
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567842}

R=dmazzoni@chromium.org

Change-Id: Iaaf42a68afee1a624cdc30d3eccc92b53fc7c136
Reviewed-on: https://chromium-review.googlesource.com/1098195
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567841}

No change to production logic.

This fixes a bad test and reenables it. In the test, the server and test
were deadlocked: the server was waiting for the test to finish, while
the test couldn't finish because the server wouldn't serve the second
page.

Instead, let the server complete the request shortly after we invoke
stopLoading(). This unblocks the server, but still guarantees the load
will still be provisional at the time we invoke stopLoading().

  --num_retries=0 --break-on-failure --repeat=1000 \
  -f ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden

Bug: 683384
Test: run_webview_instrumentation_test_apk \
Change-Id: I21be548fb1fd57724351fd372cc78d00062489b2
Reviewed-on: https://chromium-review.googlesource.com/1100547Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567840}

A couple of cleanups I stumbled upon while reading the code:
- struct DecodeRequest can be made internal.
- unique_ptr<> doesn't need to be made const& (strange pattern).
- A few consts and initializing structs with = {} (ISO memset),
 using implicit initialization [1].
- Removed unnecessary |weak_this_|.

All in all, less lines of code :-)

TBR=dcastagna@chromium.org

[1] http://en.cppreference.com/w/c/language/struct_initialization

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If1a4e781abfa7ae96b85a6d621f5c96d4effb162
Reviewed-on: https://chromium-review.googlesource.com/1100001Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567839}

With https://crrev.com/c/1050931, variations is enabled 100% in m68. We want to
keep some small percentage disabled in order to compare metrics, but can't use
variations to do so. So hard-code the random group assignment instead, and add a
UMA histogram, Android.WebView.VariationsEnableState, with the result.

The logic about whether variations is enabled is now pretty complex, but we'll
remove most of it after 100% rollout. The current variables are:

- mEnabledByCmd
    Controlled by the --enable-webview-variations switch.
- mEnabledByExperiment
    Controlled by AGSA's experiment.
- sVariationsAlwaysEnabled
    Hard-coded to true in m68, intended for easy revert in case we decided to
    completely disable variations in m68.
- sEnableState
    The newly-added tri-state: default enabled, control-group enabled, and
    experiment-group enabled.

Before this change, variations would be enabled if any 1 of the first 3
variables were true. The new sEnableState can disable variations, overriding
sVariationsAlwaysEnabled.

This means that "sVariationsAlwaysEnabled" is no longer an accurate name, since
it can be overridden, but I'm keeping it as-is to allow easy reverts.

Bug: 851045
Change-Id: I5b96d5636d1a1d2b0d662a121cd8b285cdb37a48
Reviewed-on: https://chromium-review.googlesource.com/1094139
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567838}

Tests had failed on asan/lsan and debug.

Fix dispatchEvent to run on event queue by calling within setTimeout.

Bug: 852788
Change-Id: I01d0013be945014bcd54f923989a02f68f6687b8
Reviewed-on: https://chromium-review.googlesource.com/1101604
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567837}

Bug: 849055
Change-Id: If18969f45020b6dfb559c73603724854661e8508
Reviewed-on: https://chromium-review.googlesource.com/1102559
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567836}

Using wpt-import in Chromium 2cfc7aa7.
With Chromium commits locally applied on WPT:
03ef65db "Update existing WebUSB WPT to be multi-global"
1db32e09 "OffscreenCanvas Text rendering tests"
89102421 "Reland "Multi-global WebUSB WPT for window and worker""


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19692

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
alexander.shalamov@intel.com, kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com:
  external/wpt/web-nfc
alexander.shalamov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org:
  external/wpt/generic-sensor
bajones@chromium.org:
  external/wpt/gamepad
bjonesbe@adobe.com:
  external/wpt/css/css-shapes
bokan@chromium.org:
  external/wpt/visual-viewport
bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org:
  external/wpt/css/css-cascade
  external/wpt/css/css-conditional
  external/wpt/css/css-namespaces
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox
chcunningham@chromium.org, wolenetz@chromium.org:
  external/wpt/media-source
chongz@chromium.org:
  external/wpt/pointerlock
  external/wpt/touch-events
chongz@chromium.org, yosin@chromium.org:
  external/wpt/input-events
cvazac@akamai.com, igrigorik@chromium.org:
  external/wpt/server-timing
dcheng@chromium.org, scottmg@chromium.org:
  external/wpt/domparsing
  external/wpt/domxpath
dgrogan@chromium.org:
  external/wpt/css/css-tables
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams
drott@chromium.org:
  external/wpt/css/css-text-decor
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
dtapuska@chromium.org:
  external/wpt/uievents
eae@chromium.org, szager@chromium.org:
  external/wpt/intersection-observer
ecobos@igalia.com:
  external/wpt/css/css-display
ericwilligers@chromium.org:
  external/wpt/css/motion
eroman@chromium.org, rsleevi@chromium.org:
  external/wpt/WebCryptoAPI
fmeawad@chromium.org, panicker@chromium.org:
  external/wpt/device-memory
foolip@chromium.org:
  external/wpt/compat
  external/wpt/fullscreen
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
garykac@chromium.org:
  external/wpt/clipboard-apis
  external/wpt/keyboard-map
garykac@chromium.org, joedow@chromium.org:
  external/wpt/keyboard-lock
guidou@chromium.org:
  external/wpt/mediacapture-streams
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
hta@chromium.org:
  external/wpt/webrtc
igrigorik@chromium.org, panicker@chromium.org:
  external/wpt/performance-timeline
igrigorik@chromium.org, yoav@yoav.ws:
  external/wpt/preload
jfernandez@igalia.com:
  external/wpt/css/css-align
jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org:
  external/wpt/payment-handler
jochen@chromium.org, estark@chromium.org:
  external/wpt/referrer-policy
jrummell@chromium.org:
  external/wpt/encrypted-media
jsbell@chromium.org:
  external/wpt/IndexedDB
  external/wpt/encoding
  external/wpt/resources
  external/wpt/service-workers/cache-storage
  external/wpt/storage
jsbell@chromium.org, mek@chromium.org:
  external/wpt/FileAPI
  external/wpt/webstorage
kojii@chromium.org:
  external/wpt/css/css-rhythm
  external/wpt/css/css-scoping
  external/wpt/css/css-text/i18n
  external/wpt/css/css-writing-modes
kojii@chromium.org, ksakamoto@chromium.org:
  external/wpt/css/css-font-loading
kojii@chromium.org, mstensho@chromium.org:
  external/wpt/css/CSS2
kozyatinskiy@chromium.org:
  external/wpt/console
kpaulhamus@chromium.org:
  external/wpt/webauthn
ksakamoto@chromium.org:
  external/wpt/resource-timing
mcasas@chromium.org:
  external/wpt/geolocation-API
  external/wpt/mediacapture-record
meade@chromium.org:
  external/wpt/web-animations
mek@chromium.org:
  external/wpt/webmessaging
mkwst@chromium.org:
  external/wpt/cookies
  external/wpt/mixed-content
  external/wpt/secure-contexts
  external/wpt/trusted-types
  external/wpt/upgrade-insecure-requests
  external/wpt/x-frame-options
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy
mkwst@chromium.org, jochen@chromium.org:
  external/wpt/subresource-integrity
mlamouri@chromium.org:
  external/wpt/mediasession
  external/wpt/remote-playback
  external/wpt/screen-orientation
msisov@igalia.com:
  external/wpt/webvtt
msramek@chromium.org, mkwst@chromium.org:
  external/wpt/clear-site-data
mstensho@chromium.org:
  external/wpt/css/css-break
  external/wpt/css/css-multicol
mtrofin@chromium.org:
  external/wpt/wasm
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents
ortuno@chromium.org:
  external/wpt/bluetooth
panicker@chromium.org:
  external/wpt/longtask-timing
  external/wpt/page-visibility
  external/wpt/user-timing
panicker@chromium.org, tdresser@chromium.org:
  external/wpt/paint-timing
pwnall@chromium.org, jsbell@chromium.org:
  external/wpt/cookie-store
rego@igalia.com:
  external/wpt/css/css-grid
  external/wpt/css/css-ui
  external/wpt/css/selectors
rijubrata.bhaumik@intel.com, mcasas@chromium.org:
  external/wpt/html-media-capture
rmcilroy@chromium.org:
  external/wpt/requestidlecallback
rob.buis@samsung.com:
  external/wpt/quirks
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-method-basic-card
  external/wpt/payment-method-id
  external/wpt/payment-request
skobes@chromium.org:
  external/wpt/css/css-scroll-anchoring
smcgruer@chromium.org:
  external/wpt/css/css-position
tdresser@chromium.org:
  external/wpt/hr-time
  external/wpt/navigation-timing
timvolodine@chromium.org:
  external/wpt/battery-status
timvolodine@chromium.org, reillyg@chromium.org:
  external/wpt/orientation-event
worker-dev@chromium.org:
  external/wpt/workers
  external/wpt/worklets
xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com:
  external/wpt/css/geometry
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=lukebjerring

No-Export: true
Change-Id: I1f8e43d19bce55cefdb489172df46d8ff4cbd888
Reviewed-on: https://chromium-review.googlesource.com/1103219
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567835}

Since AppListClientImpl and AppListControllerImpl depend on each other
tightly, we can merge them. All Chrome components talk to Ash via the
AppListControllerDelegate interface, and AppListClientImpl implements
it. That's similar to the Ash AppListControllerImpl implementing
AppListViewDelegate.

This commit also merges app_list_controller_browsertest.cc with
app_list_browsertest.cc and renames those tests into AppListClient*.

Bug: 733662
Change-Id: I570d46b540d8bf23198f34e8ea8810dc3f026ab1
Reviewed-on: https://chromium-review.googlesource.com/1100554Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#567834}

Also eliminates references to progress-dots which were removed
with the old UI.

Bug: 647411
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie7bc4ec3c5b506c637dbffa103e74ac8f133742d
Reviewed-on: https://chromium-review.googlesource.com/1080227
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567833}

During unit tests, or if the default search provider is disabled by
policy, there may not be any default search provider.

Previously, when we went to fetch the favicon for the search provider,
we did not account for the defaults search provider being potentially
null, and this CL  fixes that.

Bug: 852630
Change-Id: I8637c684b1df286ac06506138b86b3237190ebb6
Reviewed-on: https://chromium-review.googlesource.com/1102882
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567832}

A simple typo prevented this from working.
My manual testing didn't notice because the default value
matches my desktop.

Bug: 823547
Change-Id: I9a497380c17a85437b8486e0160f6df7a1429922
Reviewed-on: https://chromium-review.googlesource.com/1103231
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567831}

Currently we check whether ticking mutator is needed and if so we
collect mutator input state. There are duplicated logic in the two
operations above. This patch is to skip the first check and collect
input state directly. Then mutate if the input state is not empty.

Bug: 791279
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib4c7b92ca0b545b42d75b91bc3fd7f9296034d74
Reviewed-on: https://chromium-review.googlesource.com/1103013
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567830}

This CL supports alt+shift+i to open the feedback dialog in views login
screen.

Bug: 852242
Change-Id: I9a285c6929fd2302d22f90fbefbb32bcd814359d
Reviewed-on: https://chromium-review.googlesource.com/1102035Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567829}

Privacy requested this on the design recently. The idea is that with a
large enough variance, a first party cannot embed a third party to
determine the exact number of bytes in a response.

Bug: 853243
Change-Id: I9a7f851eabc6f99d8aae35dc6398a09263043d0c
Reviewed-on: https://chromium-review.googlesource.com/1102908Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567828}

Bug: 533481
Change-Id: I0ff00a6aeb20853d26f83b893e0eab1c1fa46b48
Reviewed-on: https://chromium-review.googlesource.com/1100295Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567827}

Make ApiHelperFor* classes final and remove @TargetApi annotations in
WebViewContentsClientAdapter.

Bug: 791099
Change-Id: Idc0c0aa04e31ceae06646d237e51600d9844f327
Reviewed-on: https://chromium-review.googlesource.com/1103298
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567826}

BUG=853311

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I52c732677d85ad0d102a9868eff3107e75dad3e0
Reviewed-on: https://chromium-review.googlesource.com/1103017Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567825}

|next_state_active_policy| should be checked instead of
|active_policy|.

Bug: 843671
Change-Id: I071494804252330e8e03f1fcdbbcc2667b39fb50
Reviewed-on: https://chromium-review.googlesource.com/1102983Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567824}

Looking at UMA for the P2P file sharing feature, the file move fails
more often than it should.  Add some UMA to find out why.

Bug: 758690

Change-Id: Ifbf549ef2bb17d40c4190451d8089d3c42019f74
Reviewed-on: https://chromium-review.googlesource.com/1101402
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567823}

- self.navigationController.navigationBarHidden = YES; wasn't being set or propagated to these VC's
anymore. This causes both the native navBar and MDCAppBar to be added to the view hierarchy.

On top of making tests fail, there was a large top inset on legacy Editors added by the native
navBar.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3b5196516c7b9c242cfef4ef89a01299c2ae0087
Reviewed-on: https://chromium-review.googlesource.com/1103295
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567822}

Do not try migrate back to default network if it's disconnected.
Remove Connection Migration V1 tests and add equivalent test coverage
in V2 to test session is migrated when a new network is connected after
write error. The new V2 tests are also regression tests which verifies
session doesn't attempt to migrate back if default network is
disconnected.

Bug: 818259, 843299
Change-Id: I54c793b8110eb134d4eeaa3ec7d6d129fdd6aeef
Reviewed-on: https://chromium-review.googlesource.com/1102109Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567821}