- 22 Jun, 2019 11 commits
-
-
Matt Menke authored
And plan to remove it in Chrome 78. It was added about 2.5 years ago as a temporary measure to give Enterprises time to fix servers that were (likely accidentally) returning HTTP/0.9 responses. Usage appears to be low, allowing for relatively safe removal of the policy and the code backing it. Bug: 976751 Change-Id: I3d5c133cca77c1747bf52c905a5509e520f8626d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666912Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#671478}
-
Yuly Novikov authored
With the exception of "GPU FYI XR Win Builder" Perf bot. Bug: 973992, 977735, 976471 Change-Id: I976a15c6d422981e402a1e8aa55bb710324fd875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672177Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#671477}
-
Dan Beam authored
BUG=965811 Change-Id: I70024269a3239b1920d0cd73f79ab9242fde6ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671467 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#671476}
-
Mohamed Heikal authored
Using relative paths was causing build failures. To create this change: * find out/Debug -name *_jni.h -delete * find . -name BUILD.gn -exec sed -i '/jni_package =/d' {} \; * ninja $ALL_JNI_HEADERS minus third_party, chromecast, cronet, libassistant * refactor_jni_includes.py --out-dir out/Debug * fix DEPs files manually * split out net/, remoting/, printing/ changes into this cl See https://groups.google.com/a/chromium.org/forum/?#!topic/java/MEovGrAwbqI for discussion on naming scheme. Bug: 964169 Change-Id: I81f7ae06c3ccd0c9b7ac83df0159295804635374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671727Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#671475}
-
Geoff Lang authored
Use the presence of the GL_CHROMIUM_compressed_texture_etc extension as an indicator that there is native support for GL_OES_compressed_ETC1_RGB8_texture in ANGLE. BUG=882580 Change-Id: Ibb0032052d971a19f00ebb2e5815da9185aa5148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666870Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#671474}
-
Mohamed Heikal authored
Using relative paths was causing build failures. To create this change: * find out/Debug -name *_jni.h -delete * find . -name BUILD.gn -exec sed -i '/jni_package =/d' {} \; * ninja $ALL_JNI_HEADERS minus third_party, chromecast, cronet, libassistant * refactor_jni_includes.py --out-dir out/Debug * fix DEPs files manually * split out components/ changes into this cl See https://groups.google.com/a/chromium.org/forum/?#!topic/java/MEovGrAwbqI for discussion on naming scheme. Bug: 964169 Change-Id: I4f6fa72e33092dc5f9a2ad78a4d410c881e244e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669082Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#671473}
-
Eric Roman authored
The NetLog is now an internal detail of the Network Service. In particular this CL: * Removes ChromeNetLog class * Removes ContentBrowserClient::GetNetLog() * Removes BrowserProcess::net_log() * Removes support for writing to a NetLog when Network Service is disabled. And exception is made for Android WebView, which preserves support for NetLog when Network Service is not enabled. Bug: 934009,767450 Change-Id: I95e2a6aae85ec9c7b90bce08c57e23cb688e5d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663846Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#671472}
-
Matt Mueller authored
This is used to limit a CRL to a subset of the certs issued by a single issuer. (Does not support any other issuingDistributionPoints features.) Bug: 749276 Change-Id: Ifb5122bf7fdea17d8a884fe76896a65c570d2d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671367 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#671471}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fd047540b0cd..24b441ff93e8 git log fd047540b0cd..24b441ff93e8 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 rnasri@google.com Implement Visually Complete at 2s Metric Created with: gclient setdep -r src/third_party/catapult@24b441ff93e8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:973838 TBR=sadrul@google.com Change-Id: I7f2da07e1b747768ab658ebab107cfb15cd1ac04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671907Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671470}
-
Varun Khaneja authored
Here's how it works: 1. Client calls V4LDbM::CheckUrlForHighConfidenceAllowlist() 2. If the hash prefixes aren't ready or Safe Browsing is disabled, it returns NO_MATCH i.e. can't determine if the URL is safe. 3. If no match is found in the local database, it returns NO_MATCH to indicate the URL isn't on the allowlist. 4. If the full hash of the URL matches a full hash in the local database, MATCH is returned to indicate no further lookup is required. 5. If a hash prefix match is found, it initiates a full hash lookup and returns ASYNC to indicate that the client will be notified later. If the returned value is ASYNC, a full hash request is sent to the backend to check if the URL's full hash matches a full hash of a URL on the high confidence allowlist. Once the response is received, the client's |OnCheckUrlForHighConfidenceAllowlist| method is called with the final result, whenever it is available (or a timeout happens). This entire feature is behind a different Finch flag: SafeBrowsingRealTimeUrlLookupEnabled R=drubery Bug: 963165, 966646 Change-Id: Ifdc24d3f0b2e68013da5080febbe2aaf94edded4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661288 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#671469}
-
Ben Pastene authored
Fails on swarming due to missing size, eg: https://chrome-swarming.appspot.com/task?id=45909000afe02a10 R=erikchen, dpranke Bug: 961548 Change-Id: I2ce40de235243f21e4b52b02c2925efade230fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669979Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#671468}
-
- 21 Jun, 2019 29 commits
-
-
Sofiya Semenova authored
Only prefetch the prefetch_url if the tab is in the foreground. Start a prefetch when a backgrounded tab is switched to the foreground. Only prefetch any URL once. Bug: 976071 Change-Id: If0a34ef5203794d34993c90dbe8db370b1780b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667753 Commit-Queue: Sofiya Semenova <sofiyase@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#671467}
-
Kurt Horimoto authored
Observers who had started UI because of overlay presentation previously would have had to store state to track whether the UI has been started so that it could be stopped when the corresponding DidHideOverlay() signal was received. This CL updates DidHideOverlay() to include the request corresponding with the overlay that was stopped so observers could detect whether UI needs to be updated based off of the request instead of storing this state. Implementing this callback required updating OverlayRequestQueueImpl to return unique pointers of popped requests so that the request lifetime can be extended beyond the observer callback. Bug: 941745 Change-Id: I256fa21766148ea4b8856c86e3d3e99517b48be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659232 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#671466}
-
Scott Little authored
This CL marks "loading" attribute support as experimental, so that tests run with this attribute supported. Note that this only turns on lazy loading of images and iframes marked with "loading=lazy", and does not turn on any automatic lazy loading of images/iframes that aren't marked "loading=lazy". Bug: 937986 Change-Id: Iccf1c4614f648f0596198e9c76eafac818daac23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636639 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#671465}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6caa1897fd2c..9d1193b591c5 git log 6caa1897fd2c..9d1193b591c5 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 thestig@chromium.org Clean up image_diff_png.cpp. 2019-06-21 thestig@chromium.org Change PNG functions to return std::vector. 2019-06-21 tsepez@chromium.org Ensure CPDF_ColorSpace classes are only created via MakeRetain<>. 2019-06-21 thestig@chromium.org Check encoding results in DiffImages(). 2019-06-21 chinsenj@google.com Move PNG encoding logic to helper in pdfium_test_write_helper.cc 2019-06-21 tsepez@chromium.org Make SharedCopyOnWrite() invoke class-specific Clone() method. Created with: gclient setdep -r src/third_party/pdfium@9d1193b591c5 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Ie9762abb8a8978523d98502d4d34c396979e0724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672168Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671464}
-
Dirk Pranke authored
It turns out isolates built on Mac builds that enable_dsyms didn't include the symbols in the .dSYM/ directories for frameworks, apps, and plugins. This CL fixes that. R=bpastene@chromium.org, rsesek@chromium.org BUG=961548 Change-Id: I60f27e7e51235cac6d4fa3c5b7c6de11c0b97819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671667Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#671463}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/067687f467dd..647f200016ab git log 067687f467dd..647f200016ab --date=short --no-merges --format='%ad %ae %s' 2019-06-21 geofflang@chromium.org Limit max texture size and max MSAA samples on Android. 2019-06-21 geofflang@chromium.org Always scalarize mat and vec constructor arguments. 2019-06-21 tobine@google.com Print perf results to stdout on Android 2019-06-21 syoussefi@chromium.org Vulkan: Handle 0-sized viewports Created with: gclient setdep -r src/third_party/angle@647f200016ab The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:882580,chromium:882580,chromium:977330 TBR=jonahr@google.com Change-Id: I33951ca3853d2818eabc7154456bcad3d69dd1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671909Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671462}
-
Findit authored
This reverts commit 07f70727. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 671446 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzA3ZjcwNzI3ODc5Yjg5MGJjZGI4MTgzMDM2ZTg5NWRlMzc1Y2E2OTUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-archive-rel/1542 Sample Failed Step: compile Original change's description: > [build] Cleanup for specifying [min|target|max]SdkVersion in GN > > crrev/c/1650265 enforced setting [min|target|max]SdkVersion in GN. > However, this is to strict for some dependencies, e.g. WebRTC. > Therefore, relax rules so that you can specify the SDK versions in both > GN and the AndroidManifest.xml. And the build system will assert that > these values match. > > + Update some SDK versions that had been changed inadvertently in > crrev/c/1650265. > > TBR=tedchoc@chromium.org,torne@chromium.org > > Bug: 891996 > Bug: 977417 > Bug: 977328 > Change-Id: I89b944c1f73a35ba8fcdafdf4bdf62508759811e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660361 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671446} Change-Id: I06e05d04cf5e8cbc4c663bd6a5ebfda1ba0b2b3c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672178 Cr-Commit-Position: refs/heads/master@{#671461}
-
Koji Ishii authored
This patch fixes |ComputeMinMaxSize| not to clear |NeedsLayout| when all of following conditions are met: 1. Needs |MinMaxSize| 2. Is an orthogonal flow root. 3. Is legacy layout. 4. Change is applied that dirties the layout. In this case, |NGBlockNode::ComputeMinMaxSize()| calls |Layout()|, which goes to |RunLegacyLayout()|, which calls |LayoutObject::LayoutIfNeeded()|. However, its constraint space is intermediate that it does not update |CachedLayoutResult|. Then when laying it out, because |NeedsLayout()| is cleared, existing out-of-date |CachedLayoutResult| is used. This patch fixes: 1. Not to pre-layout orthogonal roots if it has |CachedLayoutResult|. 2. Set |NeedsLayout()| if |RunLegacyLayout()| clears it, but |CachedLayoutResult| was not updated. Bug: 976859 Change-Id: Ic2d979a3c4f9479040bfd0e54cf4283b60ed52b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670146Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#671460}
-
Jared Saul authored
This CL removes the following histograms, which essentially reverts https://codereview.chromium.org/2864363004/ and https://codereview.chromium.org/2866993002/ from 2017: Autofill.DaysSincePreviousUseAtSubmission.Profile Autofill.HasModifiedProfile.CreditCardFormSubmission Bug: 975959, 975904 Change-Id: I7fac9ca5851767e6f595a8943ca0d5bea3480030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669994 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#671459}
-
Jordy Greenblatt authored
The color contrast between minimize+close button and the background in the Wallpaper modal[1] is low enough to cause accessibility issues for vision impaired users at a ratio of 3.61 (compare to the minimal acceptable ratio of 4.5 to meet W3C guidelines). The contrast provided by the new color for both of the buttons, i.e. Google Grey 700 aka #5F6368 aka rgb(95, 99, 104), provides an acceptable ratio of 6.05. ------ Result of this change: http://screen/d6eeOZx9ted Note: newly colored buttons in red rectangles. Bug: 910362 Change-Id: I1193b43675b81d0492dd16d4115ade48c0512f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671728Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#671458}
-
Olga Gerchikov authored
This changes fixes Issue 976633: Null-dereference READ in blink::ScrollTimeline::GetDocument. I can't recreate the crash scenario, but I suspect that it's a racing condition when ScrollTimeline is created with uninitialized document.scrollingElement. The fix is to initialize ScrollTimeline.document with the document passed in the constructor instead of consulting the scroll source. Bug: 976633 Change-Id: I76a7b660e543e3a0ea9512554bb194813a203a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670074Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#671457}
-
Fabrice de Gans-Riberi authored
A change in Fuchsia will soon require the "fuchsia.device.NameProvider" service for gethostname and uname to work properly and report the proper name. This updates all the sandbox_policy files in Chromium to include this service. Bug: 977378 Change-Id: I226a62ff0912cd6f5244b52599b47d4ea9033658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669661Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#671456}
-
Eric Roman authored
This configuration is no longer supported with the switch to Network Service. Being able to configure the media cache size separately from the main disk cache would have become flaky in M72, and stopped working consistently in M74. (Since Network service experiments started on stable channel in M72, and was fully rolled out to desktop platforms by M74) The Enterprise.Policies UMA histogram indicates the policy was infrequently used. The DiskCacheSize policy can be used instead to control the size of the unified cache. Bug: 974387, 934009 Change-Id: Iae086bbe80166bc76db7ca2e1d3eb35d640c7c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661077 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#671455}
-
Becca Hughes authored
Remove EmbedSurface from the public PictureInPictureWindowController API because it should not be used outside //content. BUG=953957 Change-Id: Id960a662885da94a5d20ac9c90efd7805547f6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665654Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#671454}
-
Kristi Park authored
AnimatedLogoDownloadTime is was removed in https://crrev.com/c/1457116 and is no longer used. Extend NumberOfTiles by another 10 milestones and transfer ownership to the new NTP owner. Bug: 975476 Change-Id: Ia0ade3b6c88c16bc11b5a7d91ba3cd13806c9141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666713Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#671453}
-
Liquan(Max) Gu authored
This is a reland of b1a33e63 The last build failure was because we used TimeDelta instead of base::TimeDelta. Original change's description: > [FCP++] Text: Replace node_id with LayoutObject* - part 1 > > FCP++ is currently using node_id to track a layout object. But > we should use LayoutObject* instead to track the nodes. The replacement > will be more efficient and avoid the generation of node id. > > After we use layout object* in text record, we start to get a risk of > UAF. UAF happens when we stop recording, block the LayoutObject > removal hook by is_recording_, and use LayoutObject* in > PopulateTraceValue. The fix to it is to clear up everything > > We also noticed a risk of using |this| in two callback functions, but > it proved to be not a real risk in crbug.com/976357 > > |cached_largest_paint_candidate_| was raw pointer. It's better to be > a WeakPtr so no risk of becoming a dead pointer. > > Note that this CL is mainly to replace node_id with LayoutObject* in > TextPaintTimingDetector's sets & maps. A subsequent patch will be made > to replace node with LayoutObject in the control logic of > TextPaintTimingDetector. And do the same thing for > ImagePaintTimingDetector. > > Bug:967837 > > Change-Id: Iba0496cfca3f5056724c3267ec10226913d4e70e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649467 > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671360} Bug: 967837 Change-Id: I69ccf15a8c433a86449fd2f8d2e3900d97b66ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671147Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#671452}
-
Mia Bergeron authored
The lock screen media controls should only be displayed if there is an active media session. This is done by making LockScreenMediaControlsView a MediaControllerObserver. Bug: 965567 Change-Id: I2106bc265e233e6c96fbb86b22469b91d9ba6a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665551Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mia Bergeron <miaber@google.com> Cr-Commit-Position: refs/heads/master@{#671451}
-
Jinsuk Kim authored
https://crrev.com/c/1547547 inadvertently increased the triggering condition for pull-to-refresh by 33%, hence causing the action to occur when not expected by users. This CL reverts the related change. Bug: 974823 Change-Id: I76374a6c6af187de719d40c03075f7883bc866da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669910Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#671450}
-
Xianzhu Wang authored
- Rebaseline tests that failed because of * anti-alias pixels along border radius edges * different gradient values that are not visible * LayoutNG changes (after LayoutNG is enabled for web_tests) - Unskip some tests and mark them with real failures so that we can see their failure status on the bot. Bug: 524134 Change-Id: I567c153417f5ff03e34eba610084cdb5310d98b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671024Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#671449}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/58dbd381..0bed9125 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iee65fef3978f35525db6c902639e589aa3499798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671352Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671448}
-
Lucas Furukawa Gadani authored
Bug: 908139 Tbr: boliu@chromium.org, seantopping@chromium.org, blundell@chromium.org, johannes@chromium.org, scottmg@chromium.org, lazyboy@chromium.org Change-Id: I539846e658857ab55fa07bbb18697aeeb9d45cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567902Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#671447}
-
Tibor Goldschwendt authored
crrev/c/1650265 enforced setting [min|target|max]SdkVersion in GN. However, this is to strict for some dependencies, e.g. WebRTC. Therefore, relax rules so that you can specify the SDK versions in both GN and the AndroidManifest.xml. And the build system will assert that these values match. + Update some SDK versions that had been changed inadvertently in crrev/c/1650265. TBR=tedchoc@chromium.org,torne@chromium.org Bug: 891996 Bug: 977417 Bug: 977328 Change-Id: I89b944c1f73a35ba8fcdafdf4bdf62508759811e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660361Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#671446}
-
Caleb Raitto authored
Too many tests are failing due to leaks -- we can re-enable after fixing the leaks or disabling the leaking test cases. Bug: 974478 Change-Id: I1578e8924c3e6fa9c1153acb74a2e84cd1310856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666738Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#671445}
-
David Benjamin authored
It's QuicCryptoClientConfig, not QuicClientCryptoConfig. Bug: none Change-Id: I0661fb57b10ab4d6452fbfc06f022bb28fd76443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669096 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#671444}
-
Mohamed Heikal authored
Using relative paths was causing build failures. To create this change: * find out/Debug -name *_jni.h -delete * find . -name BUILD.gn -exec sed -i '/jni_package =/d' {} \; * ninja $ALL_JNI_HEADERS minus third_party, chromecast, cronet, libassistant * refactor_jni_includes.py --out-dir out/Debug * fix DEPs files manually * split out android_webview changes into this cl See https://groups.google.com/a/chromium.org/forum/?#!topic/java/MEovGrAwbqI for discussion on naming scheme. Bug: 964169 Change-Id: I791fa4461a84366f8628c27bd635c27ea7993812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670116 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#671443}
-
Khushal authored
R=fserb@chromium.org Bug: 976136 Change-Id: If2bd977fca8c7fecff485c7735abc5c487f8666a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670290 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#671442}
-
Fabrice de Gans-Riberi authored
The feature name was renamed in Fuchsia. There is no permanent replacement for accessing "/hub" as of yet. Bug: 977730 Change-Id: Ice51e0d5a5464e596129f5b9aad075040d2a9510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671860 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#671441}
-
Khushal authored
Ensure that we never use shared images for low latency canvas until it can support single buffering. R=fserb@chromium.org Bug: 976774 Change-Id: I093b3627f05233ea4f7212eb3093c805498bf2ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669918 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#671440}
-
Xianzhu Wang authored
This reduces sizeof(LayoutObject) from 120 bytes to 104 bytes in release without DCHECK builds on 64-bit systems. - Move bitfields_ above pointers to fill the gap between DisplayItemClient and LayoutObject; - Move FragmentData::next_fragment_ into rare_data_ because we have already treated multi-fragment as rare (e.g. for pagination_offset, etc.). Change-Id: Ia0c695e3c3760a661035aa50213f1d9588c53661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669888 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#671439}
-