GitLab

As we develop the motion spec in pieces, the UI may regress until the
choreography is fully implemented. To prevent this, I added a constant
that we can use to gate changes that should not be enabled until
additional motion specs are also implemented.

This change is gated by that flag, so this change will not be visible
by default.

See bug for spec/demo.

Bug: b:111890130
Change-Id: I88ab63e4ba83e8210eacdd3dd8b3c45b305d0373
Reviewed-on: https://chromium-review.googlesource.com/1152208Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#579876}

https://android.googlesource.com/platform/external/perfetto.git/+log/ebafd75a0c5d..6af2bfe03baf


git log ebafd75a0c5d..6af2bfe03baf --date=short --no-merges --format='%ad %ae %s'
2018-08-01 treehugger-gerrit@google.com Merge "Allow to send multiple fds over UnixSocket."


Created with:
  gclient setdep -r src/third_party/perfetto@6af2bfe03baf

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I316f3d9861190e8417f8691201a197a344571f51
Reviewed-on: https://chromium-review.googlesource.com/1158785
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579875}

Bug: 806868
Change-Id: I2877c4cfa3241dc6a783311b69f46c27c3b347c5
Reviewed-on: https://chromium-review.googlesource.com/1158855
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579874}

GetOriginsTask is ref counted, and its first reference is implicitly
retained by base::Bind() in GetOriginsTask::Run().
Though this case is safe, an upcoming base::Bind change rejects this
pattern of the first reference retention.

After this CL, the caller of GetOriginsTask::Run() keeps the first
reference to the GetOriginsTask instance to avoid the check failure.

Bug: 866456
Change-Id: Ia011ccc3b815a626200403b22c63b8133c83fbb0
Reviewed-on: https://chromium-review.googlesource.com/1158664
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579873}

1. /pkg, /svc and /config/ssl are now cloned to Context processes.
   https://crrev.com/1149262 removed FDIO_SPAWN_CLONE_NAMESPACE.
   As result the context process was failing to open /pkg/icudtl.dat.
2. Added FDIO_SPAWN_CLONE_JOB flag - job needs to be cloned so the
   context process can start its own children.
3. Updated SandboxPolicyFuchsia not to clone /tmp - it doesn't appear
   to be necessary for any sandboxed processes.
4. Removed FDIO_SPAWN_CLONE_STDIO for Context and sandboxed processes.
   Instead stderr is added fds_to_map.

Bug: 852145, 869216, 868556
Change-Id: I89c429231cd0e295247c80f12e587e1c7335456b
Reviewed-on: https://chromium-review.googlesource.com/1155967
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579872}

Attribution section should be removed after clicking restore default
background. Adding clearAttribution function when the
restoreDefaultInteraction is called.

Screenshot:
https://screenshot.googleplex.com/AQT8eBddJ7A.png

Bug: 869693
Change-Id: I18526c72c74fbff84320faf5f8a756c545138fcf
Reviewed-on: https://chromium-review.googlesource.com/1157650Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579871}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0d97057a..b538ae75

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I65b789ae482ea58277b26e78d4cfb82aa563ab12
Reviewed-on: https://chromium-review.googlesource.com/1158397Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579870}

* Make it a little easier to understand
* Remove some panel-related code (a lot more of that in a separate CL)

No change in behavior.

Bug: 805612
Bug: 788033
Change-Id: I70225cc90cba940a8e2cb148be4aa887ebaa01ce
Reviewed-on: https://chromium-review.googlesource.com/1150776
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579869}

This change:
- writes to settings each time ChromeVox changes a tts property
- updates from prefs on startup
- observes pref changes and announces when rate, pitch, and volume changes
- adds a new key binding (Search+o, s) which opens the tts settings
- adds a new menu item in the ChromeVox menus opening tts settings

There should be no functional change for ChromeVox commands (e.g. keyboard shortcut to change pitch).

Changes to global tts settings should be reflected in ChromeVox immediately once changed.

Change-Id: Ic701c6f7b4422194ac8a957fbaf4fe0fd60e00af
Reviewed-on: https://chromium-review.googlesource.com/1157173
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579868}

Allows each target to then append and customize the license file based
on their third-party sub-licenses.

Bug: 869935
Change-Id: I732c132abaf386f7ce763fb7452384717c1264ed
Reviewed-on: https://chromium-review.googlesource.com/1158964
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579867}

This CL supports showing toasts on lock screen.

If the device is locked and the toast can be in the lock screen,
ToastOverlay appears in kShellWindowId_LockSystemModalContainer
instead of kShellWindowId_SystemModalContainer.

kShellWindowId_LockSystemModalContainer can be used only during
the lock screen is visible, so we switched the container when the
lock status is changed.

Bug: b/79951342
Test: ash_unittests --gtest_filter="ToastManagerTest.*" passes

Change-Id: I40d62e21b437686fcfc4b119a0c9954207f3533d
Reviewed-on: https://chromium-review.googlesource.com/1154783
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579866}

Change-Id: I9a2287102428a6c386fde09d9d237c6a9419e824
Reviewed-on: https://chromium-review.googlesource.com/1156589Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579865}

This CL fixes the Size we SetAll() in the viz::TextureDrawQuad
from an empty one to the appropriate CanvasResource Size -- this
is needed to indicate to e.g. Ozone the |resource_size_in_pixels|
of the overlay candidate, but it's also more correct in general.

Also removes an unused variable and adds {} in a few needed places.

Bug: 869161
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ice28fb8c9d7f9a4eee29a22f8634b08c9dfb2e36
Reviewed-on: https://chromium-review.googlesource.com/1157232
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579864}

This CL implements the Read and Write functionality for the new
data store. It has not yet replaced the existing notification
database.

Bug: 856603
Change-Id: Ie218078f1a17ef0948279fef4632c24cdc437ff0
Reviewed-on: https://chromium-review.googlesource.com/1140163
Commit-Queue: Sharon Yang <yangsharon@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579863}

Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
exector is good for preventing concurrency errors since it guarantees
serial execution, but bad for performance since the entire app shares
this single queue.

It looks like this callsite can use the THREAD_POOL_EXECUTOR instead,
since this use doesn't appear to rely on the concurrency guarantees that
SERIAL_EXECUTOR provides.

Bug: 869907
Change-Id: I7dce5b4f28520a3d2a81491756f5aec5f6806fa9
Reviewed-on: https://chromium-review.googlesource.com/1158962Reviewed-by: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579862}

Adds a Views::GetAnchorBoundsInScreen() method. This defaults to
GetBoundsInScreen() but can be overridden for views whose visual
bounds differ from their actual bounds. This is the case for toolbar
buttons on Touch (that provide larger hit targets than their visual
size).

This method is then used for the menus spawned by AppMenuButton and
ToolbarButton as well as BubbleDialogDelegate which allows these
specific menus and BubbleDialogDelegates in general to be better
aligned visually to their anchors.

Bug: chromium:800372, chromium:869928
Change-Id: I9c516d8a7ecb6c922e347d4db61ce1db72c71be7
Reviewed-on: https://chromium-review.googlesource.com/1152525
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579861}

Change-Id: Ia3190dd63539ef85e33d13642ad9005910bffa70
Reviewed-on: https://chromium-review.googlesource.com/1157528Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579860}

Previously, Assistant response text/cards/suggestions were streamed in
and rendered immediately. We actually want to cache them until all
renderable elements for an interaction are received, and then show them
all at once.

This is a prerequisite for motion specs which require animating the
response in as a whole and resizing the container smoothly.

To accomplish this, this CL adds:
- AssistantResponse object to hold the renderable elements.
- A cached AssistantResponse in AssistantInteractionController that is
  not added to the model until it is finalized.
- Notification of TTS started event to AssistantInteractionController.
  This is used as an early indication that we have received all
  renderable elements for an interaction.

Bug: b:111932420
Change-Id: I0cc84079183fc30b8c949491e5e2bc4d0b4365b1
Reviewed-on: https://chromium-review.googlesource.com/1153626Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#579859}

This reverts commit e93874be.

Reason for revert: http://crbug.com/863954#c3

Original change's description:
> [AF] Do not discard form data after dynamic form submission
> 
> Prior to this change form data were being discarded after a dynamic form
> submission. This was because the dynamically changed form was being added
> to the cache with its user entered/autofilled values. At the time of
> submission, form data were being discarded as they were thought to be the
> initial values of the fields at page load. This CL changes
> AutofillHandler::OnFormsSeen (which is called on dynamic form changes) to
> attempt to find a previously cached version of the form first. Prior to
> addition to the cache, form values are overridden by the cached values.
> This prevents those values from getting confused with the initial form
> values at the time of submission.
> 
> Bug: 863954
> 
> Change-Id: Iba4771ee87b9777e66a6b10b6b369379dc123a46
> Reviewed-on: https://chromium-review.googlesource.com/1137021
> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577033}

TBR=sebsg@chromium.org,mahmadi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 863954
Change-Id: I71d0970d10fe1d4857e98ba558b9253b13ad053d
Reviewed-on: https://chromium-review.googlesource.com/1151911Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579858}

This reverts commit 734d2825.

Reason for revert: The CL this CL was fixing was already revertedand looks like this is causing other regressions.

Original change's description:
> Fix animation jankiness after selecting the current NTP in Android tab switcher
>
> If you open an NTP on Android, open the tab switcher, and then focus the NTP,
> there is often some jankiness at the end of the animation where the page very
> quickly appears to jump back-and-forth by a few pixels.
>
> It turns out that this happens when we switch from TabListSceneLayer (what we
> use to display the tab switcher) to StaticTabSceneLayer (what we use to show
> the tab during normal browsing): for the NTP, we never use the live layer in
> the tab switcher, so we have to use the static layer. When we switch to
> StaticTabSceneLayer, it (sometimes?) still uses the static layer very briefly,
> but displays it at not quite the right size, which causes the jumpiness before
> we switch back to the live layer.
>
> The fix is to make ContentLayer clip the static layer to the value of
> ComputedSize() in the case where should_clip == false.
>
> Bug: 748648
> Change-Id: I2999ee1be91681d692e381a9aff230567ace20fc
> Reviewed-on: https://chromium-review.googlesource.com/1114349
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Commit-Queue: Ryan Landay <rlanday@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570974}

TBR=dtrainor@chromium.org,rlanday@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 748648,  867868, 865395
Change-Id: I9f092f7906a3b2d96480e3a797292d96dda22074
Reviewed-on: https://chromium-review.googlesource.com/1151568Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579857}

https://webrtc.googlesource.com/src.git/+log/7a1c7f782a14..78026754a734


git log 7a1c7f782a14..78026754a734 --date=short --no-merges --format='%ad %ae %s'
2018-08-01 peah@webrtc.org AEC3: Utilize shadow filter output to respond to audio path changes
2018-08-01 oprypin@webrtc.org Explicitly add -mfpu=neon to all targets that use NEON


Created with:
  gclient setdep -r src/third_party/webrtc@78026754a734

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:869821
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I50a4664af22308ac41d58db2390bf766493e546b
Reviewed-on: https://chromium-review.googlesource.com/1158786Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579856}

New subscriptions are currently considered as having been server-
invalidated, which is incorrect. This change should significantly drive
the number down to expected values.

Change-Id: I56a5de9e6f9388ee60674c9f3de3af5727291392
Reviewed-on: https://chromium-review.googlesource.com/1158829
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579855}

This change removes 6+ MB of binaries from the build tools bundle:
3.7M	lib/linux/libclang_rt.asan-i686-android.so
2.5M	lib/linux/libclang_rt.ubsan_standalone-i686-android.so
80K	lib/linux/libclang_rt.profile-i686-android.a

It also can break some workflows, but as discussed in person, there is a good
chance that no one is using those libraries on i686 arch.


Bug: 866225
Change-Id: Ifbc85e542359681f60f19f52e5bd7a8a7e1655f3
Reviewed-on: https://chromium-review.googlesource.com/1158708Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579854}

Also:
* Remove an out-of-date comment.
* Add binutils to install-build-deps.sh for readelf and grep.  We already use
  binutils in many places, and it's likely already installed everywhere, but
  it's good to list out direct dependencies.

BUG=850682
R=thakis

Change-Id: I80830ad42fe37f1b93f393f5a6ca5af68ef92998
Reviewed-on: https://chromium-review.googlesource.com/1157436Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579853}

- Some of these tests were consistently failing but went unnoticed
because they only run on Android O+ and there are no cq-blocking
O bots yet.

- Tested by running all tests with *Channels* in the name on an
Android O device.

Change-Id: I29d92984eb9f9d74062ec36dc391412be8b0fa51
Reviewed-on: https://chromium-review.googlesource.com/1158834Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579852}

Previously, each tab had its own SuggestedTextTouchBarController. Now,
because of http://crrev/c/1151613, there is only one
SuggestedTextTouchBarController per window. Because the controller does
not maintain the state of each tab, as a user switches tabs, the
controller needs to update its state to match the tab. When the
controller's WebContents change, new suggestions should be generated
for the selected text in the current tab.

The methods -webContentsTextSelectionChanged:range: and
-webContentsFinishedLoading were combined into a singular method,
-updateTextSelection:range:, because they had very similar
functionality.

The parameters for -requestSuggestionsForText:inRange: were removed
because they were always |text_| and |selectionRange_|.

A new method was created, -webContentsChanged, to get a tab's current
text and selected range and then call -updateTextSelection:range: with
the proper parameters.

When the controller gets a new pointer to a WebContents, the pointer
may be null. To avoid calling WebContents::IsFocusedElementEditable()
on a null pointer, a method -isTextfieldFocused was created to check
that |webContents_| is not a null pointer and that an editable element
is focused.

A new SuggestedTextTouchBarControllerBrowserTest was written,
SetWebContentsTest, to test that the SuggestedTextTouchBarController
properly updates its current text selection based on the new
WebContents.

Bug: 717553
Change-Id: I356a548bbdf33b51484fd7c55a1aa5ea37be4bae
Reviewed-on: https://chromium-review.googlesource.com/1153728Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Cr-Commit-Position: refs/heads/master@{#579851}

https://chromium.googlesource.com/angle/angle.git/+log/ad63728be30d..038e725af257


git log ad63728be30d..038e725af257 --date=short --no-merges --format='%ad %ae %s'
2018-08-01 jmadill@chromium.org D3D11: Use angle::Result error pattern. 2/3


Created with:
  gclient setdep -r src/third_party/angle@038e725af257

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Ic94f4f359c637874db543cd7efa9bbcf95baa3e7
Reviewed-on: https://chromium-review.googlesource.com/1158784Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579850}

https://pdfium.googlesource.com/pdfium.git/+log/3a40bed9d6e5..56094c50c0da


git log 3a40bed9d6e5..56094c50c0da --date=short --no-merges --format='%ad %ae %s'
2018-08-01 tsepez@chromium.org Rename PageSetContainerLayoutItem to TraverseStrategy_PageSet.


Created with:
  gclient setdep -r src/third_party/pdfium@56094c50c0da

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib9431028d74bce02b171e0b884d677e78510c5fa
Reviewed-on: https://chromium-review.googlesource.com/1158727Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579849}

This is follow up to fix after crrev.com/c/1142687

Test: Manually + unit test
Bug: 868231
Change-Id: I176da80dbde497e8bf47730045bfa770c23dec36
Reviewed-on: https://chromium-review.googlesource.com/1157703
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579848}

This change moves MergeDictionary() from base::DictionaryValue to the
parent class base::Value and relaxes its interface to accept base::Value
pointers as well. Appropriate CHECKs are added.

Bug: 646133
Change-Id: Ib6dab60ea2ff4f56b320e4a54f0782905aa3c4ae
Reviewed-on: https://chromium-review.googlesource.com/1158233Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579847}

The metric UnifiedConsent.Migration.SyncEverythingWasOn is
added to record whether sync users were syncing everything
before they migrated to unified consent.

Bug: 858870
Change-Id: I6b83e258ba8c8ac4ec9fdc980d396a920ba7574a
Reviewed-on: https://chromium-review.googlesource.com/1157009
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579846}

This preserves the "theme both normal and incognito windows" behavior of
COLOR_BACKGROUND_TAB_TEXT, which was the only color available until I added
incognito and inactive variants last week.  It makes some themes look more like
their authors intended (e.g. Black Red Shards).  OTOH, it makes some themes
unreadable because the copied text color doesn't work in the current treatment
of incognito tabs.  I'm not sure which route is better, but this route seems to
at least err on the side of author intent, so...

Bug: 869395
Test: Install "Black Red Shards" theme, open an incognito window with multiple tabs, check that text is red on all tabs.
Change-Id: Idef3b07edd2b49b1acc440edaf8c31838350dd98
Reviewed-on: https://chromium-review.googlesource.com/1157867Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579845}

Don't call pending_connect_requests_.pop_front() when it's empty.

Bug: internal 111887604
Test: cast_bluetooth_unittests
      Try concurrent Connect requests, second request returned
      successfully.

Change-Id: If52e57a4fa7ef2d4401ef3150dc1255ea27812e0
Reviewed-on: https://chromium-review.googlesource.com/1157784Reviewed-by: Bailey Forrest <bcf@chromium.org>
Commit-Queue: Tiansong Cui <tiansong@google.com>
Cr-Commit-Position: refs/heads/master@{#579844}

https://chromium.googlesource.com/catapult.git/+log/226b95461af2..59a61beec4fe


git log 226b95461af2..59a61beec4fe --date=short --no-merges --format='%ad %ae %s'
2018-08-01 wangge@google.com Use Legacy Command Line Path in Compatibility Mode.
2018-08-01 wangge@google.com Skip Downloading the APK If it exists


Created with:
  gclient setdep -r src/third_party/catapult@59a61beec4fe

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866881,chromium:863390
TBR=sullivan@chromium.org

Change-Id: Iecf499e6080a0b86e168089b4f41f0c99c4be5b3
Reviewed-on: https://chromium-review.googlesource.com/1158725Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579843}

This only holds the hint data for now. Another CL to follow will use it.
Moves the recently added activation list into the hint cache as well.

Bug: 867651
Change-Id: I188cab0b8539439d859186eecc8185a66ba34efb
Reviewed-on: https://chromium-review.googlesource.com/1150739
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579842}

This patch adds a toggle to the Settings to enable/disable
notifications.

Bug: b/111505289
Test: VoiceInteractionControllerClientTest.PrefChangeSendsNotification
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I7b1ba03cc326abb098f9f902f0c51d68f4938133
Reviewed-on: https://chromium-review.googlesource.com/1142503
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579841}

This CL implements the writable part of KeyframeEffect's target member.
This brings us into line with the spec, except that Chromium still don't
support CSSPseudoElement and so we only allow setting Elements.

Bug: 813902
Test: external/wpt/web-animations/interfaces/KeyframeEffect/target.html
Test: external/wpt/web-animations/interfaces/KeyframeEffect/idlharness.window.js

Change-Id: I91faf22473e7776a8cad6165ff60c5d9ee47a9a6
Reviewed-on: https://chromium-review.googlesource.com/1157002
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579840}

So we can zip all the scripts from chrome src tree and run on a target machine
without checking out the chrome src tree using the following command:

python tools/mb/mb.py zip out/Release telemetry_gpu_integration_test_scripts_only out/my_scripts.zip

BUG=867155
TEST=perf
R=kbr@chromium.org,nednguyen@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi


Change-Id: Ia3706abad6aadb4904fc7584837a511b72be71e8
Reviewed-on: https://chromium-review.googlesource.com/1157251Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579839}

This change implements reading and writing of Remote Gatt Descriptors
for WinRT. Furthermore, it enables corresponding tests.

Bug: 821766
Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe
Reviewed-on: https://chromium-review.googlesource.com/1156703
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579838}

Currently this test verifies that after setting the scroll position
there are no paint invalidations, however paint invalidations could
occur as part of the lifecycle after script runs. By waiting for the
next frame we allow the lifecycle to become clean and commit the frame.

This is also a speculative fix for what may have caused the old
flakiness on the linked bug.

Bug: 520166
Change-Id: I2cfe8fe47a89c39c81f83b23388f945549b8bc8e
Reviewed-on: https://chromium-review.googlesource.com/1158718Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579837}