GitLab

Such breaks used to go unnoticed and cause misery and assorted unpleasantries.
Upgraded test expectations. Added a unit test.

As long as we haven't both got an in-flow child that broke AND exceeded
available fragmentainer space, we need to continue and lay out its siblings. A
block of zero height at a fragmentainer boundary actually belongs in the former
fragmentainer, not the latter. A consequence of this change is that even
non-zero height blocks that start at a fragmentainer boundary gets a
zero-height fragment in the former fragmentainer, before it continues in the
next fragmentainer. We may want to avoid this, but I'm not sure what's more
correct yet (or if it matters at all).

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I50e862d8c0dc787a47b799e2e639e5ca7ba57158
Reviewed-on: https://chromium-review.googlesource.com/663141
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501588}

YouTube has deprecated Flash embeds so it will provide a better
experience for our users to have them inlined with possible breakage
instead of having to use Flash and navigate to YouTube.

Bug: 763322
Change-Id: I3243e3048f499ec51e3220ebd18201a94e3eca46
Reviewed-on: https://chromium-review.googlesource.com/657277Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501587}

Support for font-display shipped to stable in Chrome 60.

The runtime flag is no longer needed.

BUG=669455

Change-Id: I8d7e5eb46797dc78f9f4330dcba28ab68212f2e5
Reviewed-on: https://chromium-review.googlesource.com/659719Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501586}

Mechanical changes to use BindOnce and OnceCallback
explicitly at everywhere in media/midi.

Bug: 672793
Change-Id: Ibef3543d3b91f6617f5116a845b03e0ccb823629
Reviewed-on: https://chromium-review.googlesource.com/657357
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501585}

The following changes were done:
 1- Auditor adds a list of OSes that actively use each annotation to
    annotations.xml, so that removing annotation from one OS and keeping
    it in another would not result in marking it deprecated.
 2- A script is added to tools/traffic_anntotation/scripts, to call all
    scripts that update a give file when annotations.xml is modified, or
    to run unittests that ensure these files are up to date.
 3- 'test-only' switch added to Auditor. When this switch is present,
    auditor only checks if annotations.xml is up to date and issues an
    error it if is not. When switch is not specified, annotations.xml
    may get updated and if so, the above mentioned script is called to
    update downstream files.
 4- Auditor will prevent use of deprecated unique ids.
 5- Unittest checks that annotations.xml is loadable and its content are
    valid.
 6- Unittest calls the script mentioned in (2) to test if downstream
    files are correctly updated.

Bug: 656607
Bug: 690323
Change-Id: I00acbddbe14eeee23317bb9990069e00558a5bb4
Reviewed-on: https://chromium-review.googlesource.com/645088
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501206}
Reviewed-on: https://chromium-review.googlesource.com/663724
Cr-Commit-Position: refs/heads/master@{#501584}

Instead of exposing individual task runners (timer/loading/unthrottled)
to content/, expose a method which returns an appropriate task runner
for the given type.

R=haraken@chromium.org,kinuko@chromium.org
CC=hajimehoshi@chromium.org

Change-Id: I16b6b04dd4ce2715dd2d7580c4cdc2fa45236de6
Reviewed-on: https://chromium-review.googlesource.com/657418
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501583}

This CL replaces native struct
content::ServiceWorkerRegistrationObjectInfo with mojom struct
blink.mojom.ServiceWorkerRegistrationObjectInfo.

BUG=758151

Change-Id: I8e79e1d7ed46ca12c247d83448be0531e3818e50
Reviewed-on: https://chromium-review.googlesource.com/662369Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#501582}

It's modified in core/frame and /platform.

Bug: 751425
Change-Id: Ibe09bbd6debbcfcbef5624f98ec486770d97698c
Reviewed-on: https://chromium-review.googlesource.com/611742Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501581}

ContainerTypeOperations is a class template representing type traits for
various generic container operations, such as storage initialization or
bulk copy. This can be used, for instance, to use memcpy for efficient
copying for specific types. This will be used in HashTable v2 (see bug).

The set of operations are mostly inspired by Vector's traits. This traits
is intended to become the unified traits that can be applied to any WTF
containers (currently, Vector and HashTable have separate sets of traits).

This patch only provides a basic implementation that should work for any
types. Specializations for other types will be added later.

Bug: 715430
Change-Id: Ie1fb852942e4f6210eef26cad7606833c5d1949f
Reviewed-on: https://chromium-review.googlesource.com/641290Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501580}

This is a subtask to enable use-zoom-for-DSF in Android. This CL correctly
applies the DSF to Android scrollbars when using the 'use-zoom-for-DSF' flag.

Bug: 737777
Change-Id: I207cdaf26b1501e99f80019acfe56240d704ce5a
Reviewed-on: https://chromium-review.googlesource.com/620328
Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501579}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/17f4706e..6442dfd5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I11eff13dc65184a17c5af28a2a6b0d44ccd0a0c8
Reviewed-on: https://chromium-review.googlesource.com/663244Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501578}

This CL adds an implementation for setting and reading last modified
date of a file/folder in a zip file. As a result, last modified date of a
file will not be default value anymore.

BUG=607078

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idfcb3249360aa7c6d8ca8004a39ce38813bf4932
Reviewed-on: https://chromium-review.googlesource.com/664499
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501577}

Bug: 745385
Change-Id: Ic2f7c192a9899e21816de675fa19ac33fa5eb5e5
Reviewed-on: https://chromium-review.googlesource.com/642639Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com>
Cr-Commit-Position: refs/heads/master@{#501576}

There were two issues:
* The contentWindow access was throwing an exception because Chrome's
error pages are considered cross-origin.
* The test uses a setTimeout of 10 sec since Mozilla had flaky failures at 5
sec. This issue is still unresolved, see github.com/w3c/ServiceWorker/issues/1194
However, somehow the test seems to pass on local Release despite taking over
6 seconds, so I'm leaving it out of SlowTests for now.

Bug: 758892
Change-Id: I4ff501bcc679db6e7d6ddd7d70adfd33e79bd718
Reviewed-on: https://chromium-review.googlesource.com/664460
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501575}

To simplify the Clear Browsing Data ui on desktop, we introduce a basic
section with the most frequently used options and an advanced section
showing the existing options as well as an additional "Site settings"
checkbox.

The footers are removed and their information is integrated into the
checkbox descriptions in the basic tab.

This change requires a few additions to cr_dialog to inject a tab bar
and restrict the dialog to a fixed height.
SettingsCheckbox requires an additional attribute to add html with links
to the summary.

https://screenshot.googleplex.com/TvDGxE77XUC.png
https://screenshot.googleplex.com/CvF0kx7UwSY.png

Bug: 725401
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic2a84d468d9e4fd74c225d8a3668d8d1663f8da6
Reviewed-on: https://chromium-review.googlesource.com/580987
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501574}

In successful revalidation,
- The SRI check result before the revalidation can be reused
- Resource::Data() can be already null and thus we shouldn't check
  SRI again.

This CL
- Skips SRI checks if |integrity_disposition_| is already set
  (i.e. set before revalidation) to avoid crashing, and
- Clears |integrity_disposition_| on failed revalidation to ensure
  correctness.

Bug: 752830
Change-Id: I482cad4e6e0daa0c078f8fc5fe9f6c30526105dc
Reviewed-on: https://chromium-review.googlesource.com/656297Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501573}

Now that the legacy parsing code has been removed from the base API
the CSSPropertyID argument is not required.

This patch deletes the argument from the following base class methods
as well as all overrides.
- CSSPropertyAPI::ParseSingleValue
- CSSPropertyAPI::ParseShorthand

Bug: 668012
Change-Id: Iad91612b5917d7349cf4f6f3a1beb1286c7256fc
Reviewed-on: https://chromium-review.googlesource.com/662927Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501572}

Bug: None
Change-Id: I5729ca7f84b19d09aa1bae586e5c921ad997bb43
Reviewed-on: https://chromium-review.googlesource.com/640380
Commit-Queue: Kári Tristan Helgason <kthelgason@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501571}

This CL's intention is to adjust to the change of WebIDL's specification.

Before this CL, MaplikeRest's types cannot be annotated.

After this CL, however, MaplikeRest's types can be annotated types.

In order to check if ASTs are dumped correctly and if the code generator works correctly,
I also added pattern match based tests and code generator's tests.

Bug: 714866
Change-Id: I0cf998e609f635f1a9068ae8904e536bf9e6caa4
Reviewed-on: https://chromium-review.googlesource.com/664497Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Lisa Suzuki <lisabelle@google.com>
Cr-Commit-Position: refs/heads/master@{#501570}

* Improve rounding; use std::round() or gfx::ToRoundedInt() more.  In most cases
  this was a no-op from our existing behavior, but a few places were rounding
  negative numbers incorrectly (toward positive infinity rather than away from
  zero).  This eliminates the need for local helpers or MathUtil::Round().
* Prefer C++ to C library functions (e.g. powf() -> std::pow())
* Eliminate unneeded #includes/#defines.
* git cl format
* Shorten code

Bug: none
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I19f42f51db3cdbca8ff634af9391da151b985d50
Reviewed-on: https://chromium-review.googlesource.com/658043
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501569}

TBR=eae@chromium.org

Bug: 636993, 758816
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I22b14e3a042607d46cc8f3173fa7fbdfaefae5dc
Reviewed-on: https://chromium-review.googlesource.com/663004Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501568}

This reverts commit cc477ff2.

Reason for revert: Looks like this broke Chromium OS asan tests https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23602/steps/ash_unittests

Original change's description:
> splitview: Cleanup window selector unittests.
> 
> Move splitview window selector unittests to their own test class.
> 
> Bug: None
> Test: ash_unittests
> Change-Id: I8153c916a05ef9ab6011105ca670dfc0e73ee257
> Reviewed-on: https://chromium-review.googlesource.com/661327
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501487}

TBR=oshima@chromium.org,xdai@chromium.org,sammiequon@chromium.org

Change-Id: I998514803173091629c5ccc679ac42bf82e121a7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/663699Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501567}

When camera device fails to open, the camera HAL can terminate the Mojo
channel before Chrome does, resulting a Mojo connection error and
setting the VCD internal state to kError.

BUG=b:65525047
R=wuchengli

Change-Id: If785cb426b4ce048146a795fa1d28ea183c6267a
Reviewed-on: https://chromium-review.googlesource.com/659697Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501566}

When the menu Widget closed on drop of bookmark, the attempt to
reset |data_source_| in DragDropClientMac::Drop() caused crash
because the DragDropClientMac is deleted along with the Widget
in the |drop_helper_.OnDrop()|. So, clear |data_source_| before
calling |drop_helper_.OnDrop()|.

Beside the crash issue, there was another issue that custom types
of ui::OSExchangeData items are not copyed into NSPasteboardItem
used in the dragging session. This is because the types set for
NSPasteboardItem does not contain the custom types such as bookmark.
So, instead of using SupportedPasteboardTypes() for NSPasteboardItem,
use OSExchangeDataProviderMac::GetAvailableTypes() to include any
custom types contained in the ui::OSExchangeData items.

Bug: 673192
Change-Id: Ib98cca2058c4898a17db7bfced97264fbc653e14
Reviewed-on: https://chromium-review.googlesource.com/648886
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501565}

Sometimes, drag&drop shadows will show thumbnails, and if those haven't
been loaded yet, it will show filenames. However, the thumbnails are
might have been preloaded by other parts of the filesapp, so use these
if possible.
Still keep the old logic as a fall-back.

Bug: 755792
Tested: manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6a716984bd8854655e4bada2851ef69ab0f7a8b4
Reviewed-on: https://chromium-review.googlesource.com/654499
Commit-Queue: Marianne Thieffry <mariannet@google.com>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501564}

The original patch caused buildbot failures because it didn't rebaseline
the newly added wpt innerText getter tests. This is fixed in this one.

Original change's description:
> Stop TextIterator from emit double newlines after H4~6 elements
>
> TextIterator currently may add two consecutive newlines after an
> H4, H5 or H6 element, while the spec of innerText doesn't have
> this case at all.
>
> This patch removes the extra newline to make TextIterator more
> spec-complicant.
>
> Note: TextIterator should eventually remove double newline emission
> also for H1~3. This patch removes it only for H4~6 to keep the
> amount of rebaselined tests small.
>
> Bug: 752672,758816
> Change-Id: I32583c194a829f52411555125e77590e36ccf838
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
> Reviewed-on: https://chromium-review.googlesource.com/661937
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501297}

TBR=yosin@chromium.org,kojii@chromium.org,xiaochengh@chromium.org,simonp@opera.com

Bug: 752672,758816
Change-Id: I9f6414635d257a309eca0f7f28882c7ebdc90e94
Reviewed-on: https://chromium-review.googlesource.com/664122
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501563}

This change enables pixel canvas recording by default on Chrome OS
platform. It also adds a flag in chrome://flags to toggle the feature.

Bug: 764097
Change-Id: Iae7657fc4ec1bb9a1162267476d1f2fc167f99d9
COMPONENT: Chrome OS, Compositor, UI
Reviewed-on: https://chromium-review.googlesource.com/661778
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501562}

https://skia.googlesource.com/skia.git/+log/79a3aafc34c1..adf17dc52ff4

$ git log 79a3aafc3..adf17dc52 --date=short --no-merges --format='%ad %ae %s'
2017-09-12 benjaminwagner Add new task to run the float-cast-overflow sanitizer.
2017-09-12 benjaminwagner Update omitted Bazel tests.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: Icd0ee233ba899f52d79400561d9e67925fa7bffa
Reviewed-on: https://chromium-review.googlesource.com/664307Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501561}

This reverts commit bc49021b.

Reason for revert: Caused SEGV in browser_tests and webkit_layout_tests.

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/44465
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/5207
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/32519


Original change's description:
> Invalidate partial rectangle during paint invalidation
> 
> Record partial invalidation rectangle in LayoutObject::
> InvalidatePaintRectangle(). During paint invalidation, get the rect and
> invalidate it.
> 
> This CL is for SPv1, and prepares for SPv2 partial raster invalidation.
> 
> Bug: 732612
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I65b96e47fa105258e6f677e2923c361585ecfbda
> Reviewed-on: https://chromium-review.googlesource.com/663977
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501548}

TBR=wangxianzhu@chromium.org,chrishtr@chromium.org

Change-Id: I53140c2754ca3cf9cc29cf15f2284dc4fa39a14e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 732612
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/664321Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501560}

This patch updates the modal permission prompt ui to not show a trailing
full stop. Since we share the strings with infobar code, for now we just
remove the full stop in code.

Bug: 760360
Change-Id: I6ec4821d7e2f81df76656048bde1bb712dab32dd
Reviewed-on: https://chromium-review.googlesource.com/658169
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501559}

This reverts commit cc477ff2.

Reason for revert: ASan detected heap-use-after-free in SplitViewWindowSelectorTest.WindowGridSizeWhileDraggingWithSplitView.

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23602

Original change's description:
> splitview: Cleanup window selector unittests.
> 
> Move splitview window selector unittests to their own test class.
> 
> Bug: None
> Test: ash_unittests
> Change-Id: I8153c916a05ef9ab6011105ca670dfc0e73ee257
> Reviewed-on: https://chromium-review.googlesource.com/661327
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501487}

TBR=oshima@chromium.org,xdai@chromium.org,sammiequon@chromium.org

Change-Id: Ie609324d8a10bc3f35951d583df5c7782a03aae9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/663107Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501558}

As a follow-up to https://chromium-review.googlesource.com/658016,
this adds a layout test that makes sure module scripts are preloaded.

Bug: 740886
Change-Id: Iffa21862444d940750d03bf7cb744812cd87f4a1
Reviewed-on: https://chromium-review.googlesource.com/664498
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501557}

Only compile, 83/83 fail at the moment.

Bug: 764423
Change-Id: Ia49a9b5e119c84de651484938357ede133c56dda
Reviewed-on: https://chromium-review.googlesource.com/663603Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501556}

This is using the deprecated Speed Index. Apparently something changed that
broke us. We aren't really using this benchmark and can probably delete it
outright but let's wait until the new PWA benchmark is landed.

Bug: 763153
Change-Id: I0fe734a145e9cf20b741f128e67456aff29e956c
Reviewed-on: https://chromium-review.googlesource.com/663799Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501555}

There are no corresponding tests.

Bug: 603396
Change-Id: Iaa3b2f1219b8482e7a5bb56ab4cd7fe7604dcb78
Reviewed-on: https://chromium-review.googlesource.com/664462
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501554}

This is preparation to move some code from
chrome/browser/chromeos/arc to components/arc,
so that those moved code can refer prefs.

BUG=739097
TEST=Ran trybot.

Change-Id: I0f52e80a88c7d34b7833d86e4db97cd94eb253ba
Reviewed-on: https://chromium-review.googlesource.com/642640Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501553}

namespace is always "Event". We don't need to treat it as a variable.
This CL helps move_blink_source.py to replace "Event*Factory.h" in
EventFactory.cpp.tmpl with "event_*_factory.h".

Bug: 578345
Change-Id: Ib46b4c39549cd5e564d836fa705c4f574762d38f
Reviewed-on: https://chromium-review.googlesource.com/663800Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501552}

Bug: 745385
Change-Id: Id0dff9b0610770a8bd781ae4274cbae96f3a67cc
Reviewed-on: https://chromium-review.googlesource.com/640450Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com>
Cr-Commit-Position: refs/heads/master@{#501551}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9e197dff..17f4706e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I2e1cc4eee3dd93333203c50442965b510aabf271
Reviewed-on: https://chromium-review.googlesource.com/664260Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501550}

CHECKs proved this to be the cause of the crash in the bug. While
there are some suggested fixes in the bug that are preferable, this
patch patch simply avoids reentering PerformScrollAnchoringAdjustments
which will prevent the crash.

Bug: 745686
Change-Id: Ic2a156cb344b6b32e5aa4d5c3164421a033c757e
Reviewed-on: https://chromium-review.googlesource.com/657600Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501549}