GitLab

BUG=622468,605761

Review-Url: https://codereview.chromium.org/2096363003
Cr-Commit-Position: refs/heads/master@{#403317}

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments and variable names

BUG=579259

Review-Url: https://codereview.chromium.org/2110983002
Cr-Commit-Position: refs/heads/master@{#403316}

Whenever user tries to extend an existing text selection by dragging the mouse
(left button hold) with shift key pressed, Blink enters drag-n-drop mode.

This behavior does not match common editing behavior out there, including other
engines' (WebKit, Gecko/Firefox, Opera/Presto and IE).

Patch changes Blink so that whenever one extends a selection with mouse
and shift key pressed off of a #text node, it does not enter drag-n-drop mode.

Additionally, patch also adds some further tests to ensure that when
selection is extended off of either a link or an image, drag-n-drop does
get triggered, no matter if shift key is pressed.

Associated WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=155314.

BUG=142023

Review-Url: https://codereview.chromium.org/2048733002
Cr-Commit-Position: refs/heads/master@{#403315}

The toolbar action for Media Router has a context menu option to "Remove from
Chrome...", which doesn't show a confirmation dialog like other extension icons
with the same option do (and ellipsis usually suggests a confirmation). Also,
since the removal merely removes the icon and none of the MR functionalities,
the use case is different from the removal of other extensions on the toolbar.
This CL replaces the text with "Remove icon".

BUG=624104

Review-Url: https://codereview.chromium.org/2112623002
Cr-Commit-Position: refs/heads/master@{#403314}

ash::Shell still calls ShellDelegate::CreateMediaDelegate.

BUG=619636
TEST=Compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2113023002
Cr-Commit-Position: refs/heads/master@{#403313}

Foreign fetch used to completely ignore the skipServiceWorker flag. Just skipping
foreign fetch whenever skipServiceWorker is true would not be correct as the flag
is both set in situations where a request needs to bypass service workers, but
also when the renderer doesn't believe the client making the request is controlled
by a service worker. In that second case foreign fetch would still need to process
the request.

To fix this, this changes skipServiceWorker to an enum with three states, in
order to distinguish between skipping all service workers (for CORS preflight,
dev-tools skip service worker, force-refresh, etc) and skipping just the
controlling service worker.

This also makes sure that (for now) any request that requires a CORS preflight
will not get intercepted by foreign fetch.

BUG=540509,604084

Review-Url: https://codereview.chromium.org/2105503002
Cr-Commit-Position: refs/heads/master@{#403312}

Since the window can be dismissed and then reappear, the user needs more
context.

BUG=b/29439306
TEST=simulated a failure, saw the new strings

Review-Url: https://codereview.chromium.org/2111283002
Cr-Commit-Position: refs/heads/master@{#403311}

For HW encoders, we discovered deadline_utilization is not an
appropriate benchmark metric; and we plan to test a few alternatives.
Before landing those code changes, this change renames the variables and
cleans up comments to reflect the new more-abstract meaning.

R=xjz@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2103043005
Cr-Commit-Position: refs/heads/master@{#403310}

BUG=

Review-Url: https://codereview.chromium.org/2104413002
Cr-Commit-Position: refs/heads/master@{#403309}

Since we now route Gesture events directly to the guest renderer, there
is no longer any event to focus the BrowserPlugin in the embedder
renderer, meaning that even though touch/gesture events work properly,
the guest may not receive keyboard input.

This CL provides a temporary fix by sending a synthetic GestureTapDown
to the embedder on TouchStarti, in parallel with sending the TouchStart
directly to the guest. The synthetic event focuses the BrowserPlugin.

This CL also fixes two tests that were still sending Gestures to the
embedder.

When BrowserPlugin is removed, this code will disappear along with
RenderWidgetHostViewGuest.

BUG=619906
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2101663002
Cr-Commit-Position: refs/heads/master@{#403308}

This enables us to keep track of how often WebAPKs are launched from a
notification vs from the home screen.

BUG=623216

Review-Url: https://codereview.chromium.org/2094113002
Cr-Commit-Position: refs/heads/master@{#403307}

chrome_browser_ui_ash_non_chromeos was
already removed from .gypi files by an earlier patch.

BUG=

Review-Url: https://codereview.chromium.org/2087373004
Cr-Commit-Position: refs/heads/master@{#403306}

BUG=610285

Review-Url: https://codereview.chromium.org/2095643002
Cr-Commit-Position: refs/heads/master@{#403305}

Record the "bundle_data" target corresponding to a BundleFileRule object
so that the dependencies can be correctly computed when generating the
ninja steps for the "create_bundle" target.

Change the "stamp" step of "bundle_data" target in the generated ninja
to depends on the target dependencies and source files.

Change the "copy_bundle_data" steps of "create_bundle" target in the
generated ninja to depends on the "bundle_data" target that defined
the corresponding source files.

Change the "compile_xcassets" step of "create_bundle" target in the
generated ninja to depends on all the "bundle_data" targets that defined
the corresponding source files.

Change the rule used to determine whether a "bundle_data" source file
is part of an assets catalog (some file where incorrectly omitted causing
them to be incorrectly copied to the final bundle).

All those changes will allow the "copy_bundle_data" and "compile_xcassets"
steps to only depends on the targets that generate them (if any) and will
reduce the number of file copied into the final bundle during incremental
builds.

Fix unit tests with new expectations.

BUG=623501

Review-Url: https://codereview.chromium.org/2105613003
Cr-Commit-Position: refs/heads/master@{#403304}

https://chromium.googlesource.com/chromium/src/+/d0ff92817

BUG=624269
TBR=glebl@chromium.org

Review URL: https://codereview.chromium.org/2119623004 .

Cr-Commit-Position: refs/heads/master@{#403303}

Stop using UMA preference to gate sending HitReport to SB backend, use extended reporting preference instead.

BUG=598889

Review-Url: https://codereview.chromium.org/2104423002
Cr-Commit-Position: refs/heads/master@{#403302}

* Convert NetworkStateListDetailedView to wm common types and add debug name.
* Fix include guards.
* Move files to //ash/common/system/chromeos.
* Fix DEPS.

BUG=619636
TEST=ash_unittests, manual by opening the network (i) info panel and dumping
the window tree with Ctrl-Alt-Shift-W
TBR=derat@chromium.org

Review-Url: https://codereview.chromium.org/2109293002
Cr-Commit-Position: refs/heads/master@{#403301}

This patch updates the code to prevent auto deducing to a raw pointer.

R=jochen, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2107953002
Cr-Commit-Position: refs/heads/master@{#403300}

because is deprecated. Also using |using|.

While I was doing that, I saw that some methods
related to Get_X_By_Y_() had inconsistent names,
signatures and/or locations in the header/implementation
files, hence:

- GetDeviceEntryForMediaStreamDevice() renamed to
  GetDeviceEntryByTypeAndId() and reducing the
  parameters to the used information.

- GetDeviceEntryForController() renamed to
  GetDeviceEntryByController()

- FindDeviceInfoById() renamed to GetDeviceInfoById()

- GetVideoCaptureDeviceFromSessionId() renamed to
  GetVideoCaptureDeviceBySessionId()

- Added GetDeviceEntryBySerialId().

And bundled together in the .h file. Also I shoved
around some methods in the .h file to match the .cc
but I'm planning on another subsequent CL just
aligning both.

BUG=554289
TEST=no new code introduced (this is a refactoring)
so all unittests, content_browsertests and browser_tests
related to video capture (there a loads of them)
passing should be enough verification.

Review-Url: https://codereview.chromium.org/2108293002
Cr-Commit-Position: refs/heads/master@{#403299}

This patch updates the code to prevent auto deducing to a raw pointer.

R=benwells@chromium.org, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2108623005
Cr-Commit-Position: refs/heads/master@{#403298}

This also removes the ability to set options that we are
not pursuing right now.

BUG=622893

Review-Url: https://codereview.chromium.org/2117583002
Cr-Commit-Position: refs/heads/master@{#403297}

The color profile will originate in content::RenderWidgetHostViewMac
on Mac and aura::WindowTreeHost on Aura, and will need to be consumed
in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface. Both of
these originating structures have a ui::Compositor.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2102203003
Cr-Commit-Position: refs/heads/master@{#403296}

For devices with different names, the chooser just shows their names;
for devices with the same name, the chooser shows their name with
its unique device identifier.

So the chooser will look like:
device_different_name
device_same_name (device_1)
device_same_name (device_2)
device_same_name (device_3)

BUG=544121

Review-Url: https://codereview.chromium.org/2098983002
Cr-Commit-Position: refs/heads/master@{#403295}

BUG=597794,606074
NOTRY=true
TEST=eanbled webgl2 conformance tests
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2113573002
Cr-Commit-Position: refs/heads/master@{#403294}

This adds full closure compilation for the certificate manager page
directory.

BUG=425627
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2101243004
Cr-Commit-Position: refs/heads/master@{#403293}

Moves the following things out of the mojo::internal namespace
and moves their headers to mojo/public/cpp/bindings:

  - InterfaceId
  - Message flags (constants in Message rather than in internal)
  - MessageHeaderValidator
  - PipeControlMessageHandler
  - PipeControlMessageHandlerDelegate
  - PipeControlMessageProxy
  - SyncHandleWatcher

This completes the set of existing helpers necessary to implement
custom bindings endpoints with custom routing logic.

BUG=612500
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2114523002
Cr-Commit-Position: refs/heads/master@{#403292}

This CL both increases maximum backtrace depth (24 -> 48) and reduces
AllocationRegister memory usage (265 -> 42 MiB on 32-bit platforms) at
the expense of performance (~30% hit). See the bug for more details.

BUG=617772

Review-Url: https://codereview.chromium.org/2089253002
Cr-Commit-Position: refs/heads/master@{#403291}

BUG=352807
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2113453005
Cr-Commit-Position: refs/heads/master@{#403290}

R=dpranke@chromium.org, sergeyu@chromium.org
BUG=622415

Review-Url: https://codereview.chromium.org/2111213002
Cr-Commit-Position: refs/heads/master@{#403289}

Currently on iOS SSL interstitials are presented in donwstream's Tab.
This CL allows presenting them from WebClient::AllowCertificateError to be
consistent with other platforms (where interstitials are presented from
ContentBrowserClient::AllowCertificateError).

Implementation of IOSSSLErrorHandler::HandleSSLError is even simpler than
Tab code because the latter used to present Safe Browsing interstitials
which can not be supported by WKWebView.

BUG=602298

Review-Url: https://codereview.chromium.org/2108783005
Cr-Commit-Position: refs/heads/master@{#403288}

BUG=624668
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2110363002
Cr-Commit-Position: refs/heads/master@{#403287}

This CL begins moving MSE init segment received algorithm implementation
to blink level, so that it could be shared across different
implementations (e.g. between Chrome and Opera). The old init segment
algorithm is in MediaSourceState::OnNewConfigs, and for now it needs to
be kept, since it does other important things that must be done on the
Chromium media pipeline level atm (e.g. creating track buffers and
demuxer streams).

BUG=620881

Review-Url: https://codereview.chromium.org/1678523003
Cr-Commit-Position: refs/heads/master@{#403286}

MipmapUtil had error handling where it would return "-1" values to
indicate errors. None of the call sites should trigger this behavior,
so the error checks were converted to DCHECKs.

R=vmpstr
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2105903003
Cr-Commit-Position: refs/heads/master@{#403285}

CFNetworkExecuteProxyAutoConfigurationURL run loop sources are not
thread safe. Therefore, the following source events should be
synchronized:
1. Adding the source to the run loop.
2. Handling the result of proxy resolution.
3. Removing the source from the run loop.

This change does not prevent the parallel resolution of proxies for
multiple URLs but only prevents concurrent execution of the above
mentioned event, which are supposed to be lightweight operations.

BUG=166387

Review-Url: https://codereview.chromium.org/2094373002
Cr-Commit-Position: refs/heads/master@{#403284}

This jar is a dependency for Robolectric 3.0

BUG=522043

Review-Url: https://codereview.chromium.org/2049543002
Cr-Commit-Position: refs/heads/master@{#403283}

Autofill table:
  * Added billing_address_id column to masked_credit_card table.
  * Bumped version to 67.

Sync:
  * Do not overwrite user's preferred billing address for their server
    card when downloading masked credit cards from the server.

Personal data manager:
  * Added an UpdateServerCreditCardBillingAddress() method to support
    changes from settings.

Android autofill settings:
  * Let users change the billing address of their server credit card.
  * Local and server credit card settings have a common parent and
    re-use common UI elements.

BUG=602663

Review-Url: https://codereview.chromium.org/2109643003
Cr-Commit-Position: refs/heads/master@{#403282}

This CL adds closure compilation to the settings menu directory.

BUG=425627
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2111023002
Cr-Commit-Position: refs/heads/master@{#403281}

BUG=619770

Review-Url: https://codereview.chromium.org/2115653002
Cr-Commit-Position: refs/heads/master@{#403280}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a9f8ed16a47c..44fb68ed1d6d

$ git log a9f8ed16a..44fb68ed1 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2109613006
Cr-Commit-Position: refs/heads/master@{#403279}

its value is the string forced.

BUG=624187,b/29833682

Review-Url: https://codereview.chromium.org/2107033002
Cr-Commit-Position: refs/heads/master@{#403278}