GitLab

This CL adds startScrollOffset and endScrollOffset to the
ScrollTimelineOptions and the equivalent accessors to the ScrollTimeline
object. It includes the full parsing of the input DOMStrings into the
relevant CSS types.

Thie CL does not actually add use of the values in the currentTime
algorithm - that is left for a follow-up.

https://wicg.github.io/scroll-animations/#dom-scrolltimeline-startscrolloffset

Bug: 885196

Change-Id: I85bd6698abe2acaa2d57d69cec17d99a186e22e7
Reviewed-on: https://chromium-review.googlesource.com/1231156Reviewed-by: Anders Ruud <andruud@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592423}

This was not tested since it is only compiled in Chrome OS builds.

Bug: none
Test: compile
Change-Id: I5c8954faa1b782efe744e312f4d578fe43567ed3
Reviewed-on: https://chromium-review.googlesource.com/1232521Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592422}

Change-Id: Ibd1d85291b0620295aa26aa0369c5befa17564aa
Reviewed-on: https://chromium-review.googlesource.com/1233594Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592421}

DRM is crashing in CreateBufferWithGbmFlags(), apparently because there
are no DRM devices. Move the crash earlier and add a log when the primary
device opens, after which GetDrmDevice() should never be able to return
nullptr.

Bug: 877661
Test: compile
Change-Id: I0cf117513e5d853d31635e9e6d2c7fc2f59a4feb
Reviewed-on: https://chromium-review.googlesource.com/1232394
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592420}

This wires up SharedImageInterface all the way to cc, and uses it for OOP and GPU raster.
This also adds memory accounting in SharedImageFactory/SharedImageStub.

Bug: 870116
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I37eba221bc2aeb4d03b7d4d93bde772482dc681b
Reviewed-on: https://chromium-review.googlesource.com/1178977
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592419}

- Use DOMNodeId where appropriate
- Use wtf_size_t when dealing with WTF containers
- Apply truncation/SafeCast where appropriate

BUG=879657

Change-Id: I4c81a2f3e10000fc04e0a56f29080c4447862c85
Reviewed-on: https://chromium-review.googlesource.com/1227187Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592418}

VizProcessContextProvider is missing memory reporting logic found in
ContextProviderCommandBuffer. Make VizProcessContextFactory a
MemoryDumpProvider so display compositor gpu memory is reported again.

This is expected to have an impact on the gpu and skia memory tracing
categories. This isn't a regression itself, it's just fixing memory
reporting that was broken when VizDisplayCompositor experiment was
enabled by fieldtrial test config.

Bug: 876508
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia885fccd122dbfc8909f62e0a970c10ab3499632
Reviewed-on: https://chromium-review.googlesource.com/1209985Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592417}

Offline ToS are loaded if attempt to load online content fails.
Play Store ToS are region dependent. The proper version is decided
based on language from chosen locale and device region from the VPD.

Dedicated resources are used for most of the regions targeted by v1
Demo Mode:
  * Belgium: nl-BE, fr-BE
  * Finland: fi-FI
  * Sweden: sv-SE
  * Norway: nb-NO
  * Denmark: da-DK
  * France: fr-FR
  * Ireland: en-IE
  * Netherlands: nl-NL
  * Canada: en-CA, fr-CA
  * US: en-US
  * UK - en-GB
  * Luxembourg: eu (no dedicated terms available for de-LU nor fr-LU)

The other regions use default resources:
  * EMEA: emea
  * EU: eu
  * APAC: apac
  * AMERICAS: en-US
  * Germany: de
  * South Korea: kr
  * Anything else defaults to en-US

Information about VPD regions:
https://storage.googleapis.com/chromeos-factory-docs/sdk/regions.html#available-regions

If Demo Mode expands the list of targeted regions dedicated resources
should be added for the new regions.

Bug: 857275
Test: Run wizard controller and demo setup browser tests.
      Run about_ui_unittest.
      Manually perform offline demo mode setup.

Change-Id: I556f08720f6214f1b33be09af9ac232c103b2f14
Reviewed-on: https://chromium-review.googlesource.com/1211737Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592416}

Doc with background info: https://docs.google.com/document/d/1yg7wiWwYbd5hybJfHJC1aCZlOH7E8AR1f93IA71eU3I/edit#

Bug: 750639
Change-Id: Ifccd618c0e44f297f54b0c0bc3792f565eb47be9
Reviewed-on: https://chromium-review.googlesource.com/1226518
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592415}

In GeneratedCodeCache::ReadDataComplete also handle cases when
the entry was just created but no data is written into. We
always expect response_time as the header in the cache entry. If
the number of bytes read is smaller than the response_header then
it should be treated as a Error. Also, we can have entries with
only response time and no data associated with it.

Bug: chromium:884217
Change-Id: I5cc3f0923aa87ce208fe766ab6e9fb2633c24159
Reviewed-on: https://chromium-review.googlesource.com/1228123
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592414}

https://chromium.googlesource.com/angle/angle.git/+log/5c72f28d1a3f..2c8f0845431d


git log 5c72f28d1a3f..2c8f0845431d --date=short --no-merges --format='%ad %ae %s'
2018-09-19 oetuaho@nvidia.com Add ANGLE_multiview_multisample


Created with:
  gclient setdep -r src/third_party/angle@2c8f0845431d

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I2c34eaa7dbb1c136592dbde51f55cd787868693d
Reviewed-on: https://chromium-review.googlesource.com/1233636Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592413}

This reverts commit 5fc998cf.

Reason for revert: Added tests are failing. See crbug.com/886616

Original change's description:
> Added threaded virtual test suites for fast/events/touch|wheel
> 
> This cl adds threaded tests suites for fast/events/touch|wheel/* layout tests.
> Other than the following tests the rest of the tests are passing without any
> issues:
> 
> Touchpad fling related tests: these tests are skipped since touchpad swipe
> is recently added to gpu benchmarking. I already have a bug for converting
> these tests to use gpu benchmarking. see crbug.com/857490
> -virtual/threaded/fast/events/touch/gesture/pad-gesture-cancel.html
> -virtual/threaded/fast/events/touch/gesture/pad-gesture-fling.html
> -virtual/threaded/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html
> -virtual/threaded/fast/events/wheel/mainthread-touchpad-fling-latching.html
> -virtual/threaded/fast/events/wheel/wheel-fling-cancel.html
> 
> The following test is flaky, but checking flakiness dashboard showed that its
> other variations are flaky as well. see crbug.com/884312
> -virtual/threaded/fast/events/touch/multi-touch-user-gesture.html
> 
> The following two tests are failing, but again so are their other variations.
> I updated all the expectations to point to the same bug and added expectations
> for the threaded versions. see crbug.com/876305
> -virtual/threaded/fast/events/touch/compositor-touch-hit-rects-list-translate.html
> -virtual/threaded/fast/events/touch/compositor-touch-hit-rects.html
> 
> Only the threaded version of the following tests are failing since they are using
> event sender. I filed a bug to convert it to use gpu benchmarking: crbug.com/884332
> -virtual/threaded/fast/events/touch/gesture/gesture-tap-active-state-hidden-iframe.html
> -virtual/threaded/fast/events/touch/gesture/gesture-tap-frame-removed.html
> -virtual/threaded/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html
> -virtual/threaded/fast/events/touch/gesture/gesture-tap-active-state.html
> -virtual/threaded/fast/events/touch/gesture/focus-selectionchange-on-tap.html
> 
> One additional test is failing when running with
> --additional-driver-flag=--enable-blink-gen-property-trees, for which I have filed a bug:
> crbug.com/884846
> 
> Bug: 874995, 884332, 884312, 876305
> Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ifbc4ca54b48307320fe3a703b93cff1620dd1878
> Reviewed-on: https://chromium-review.googlesource.com/1227331
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592215}

TBR=bokan@chromium.org,pdr@chromium.org,sahel@chromium.org

Change-Id: Ida4607d90ff08b8e218491d85165015b05177937
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 874995, 884332, 884312, 876305
Bug: 886616
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1234193Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592412}

BrowserSideNavigation (aka PlzNavigate) launched. There is no more need
to prefix those tests with the "BrowserSide" prefix.

Bug: 789577
Change-Id: I5987644fdee4020eae1d7e420be1d24f6c656919
Reviewed-on: https://chromium-review.googlesource.com/1233493
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592411}

1. Remove |response->head.mime_type| assignment before
   ParseContentType call.
2. Rename Content-Type test parameter to response_content_type.
3. Initialize |had_charset| to false to address MSAN bug;
   this will be removed from this CL as soon as
   https://crrev.com/c/1232591 lands and I rebase.

Bug: 886629
Change-Id: I32fbe9d5c1fa6a0ba735bfd335923f0e1a723b04
Reviewed-on: https://chromium-review.googlesource.com/1233814Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592410}

This reverts commit 5665173d.

Reason for revert: this is ranked as #1 renderer process related crash on the latest chrome dev 71.0.3554.0 on Windows. 97 crashes from 90 clients so far.

Original change's description:
> Use of dump without crashing to debug smooth scroll animation bug.
> 
> Bug: 797708
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Icce9d0c3eeed94297936aebc81681f5db2ec0682
> Reviewed-on: https://chromium-review.googlesource.com/1226825
> Reviewed-by: David Bokan <bokan@chromium.org>
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#591377}

TBR=bokan@chromium.org,sahel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 797708, 884592
Change-Id: I1e2787982eb1920e28e9a38281de0c76334162f2
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1233954Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592409}

This does not fix any known issues (and in fact doesn't change any
behavior), but it seems wasteful to set the background blur to the
exact same value multiple times.

Bug: 881134
Change-Id: I3762c486385d9136f1aea3e50d1e304d69aef141
Reviewed-on: https://chromium-review.googlesource.com/1233122Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592408}

Bug: 844242
Change-Id: I980a50866506181759ad78424e9c35bfc3cd9edc
Reviewed-on: https://chromium-review.googlesource.com/1201627Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#592407}

In QUIC, consider session has pending crypto data if crypto stream has buffered data waiting to be sent. Protected by FLAGS_quic_reloadable_flag_quic_fix_has_pending_crypto_data.

Also rename HasPendingCryptoData to HasUnackedCryptoData.

Merge internal change: 213505364

R=rch@chromium.org

Change-Id: I7225bf701a96dd4f07b1b0388d632d286fcfd4b2
Reviewed-on: https://chromium-review.googlesource.com/1232036
Commit-Queue: Fan Yang <fayang@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592406}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce2e95b6cc38..be50d76e46ea


Created with:
  gclient setdep -r src-internal@be50d76e46ea

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6e48aac8d9d3dd595ca7779927ea8660b464f7c1
Reviewed-on: https://chromium-review.googlesource.com/1233634Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592405}

This prevents a crash in chrome://sync-internals in some situations, e.g.
when we're waiting for a custom passphrase to be entered.

This is analogous to https://crrev.com/c/1160229 and
https://crrev.com/c/1228198.

Bug: 878887
Change-Id: I3e1261fb7f0d98d73f98a82622ee4bb7511c9d6f
Reviewed-on: https://chromium-review.googlesource.com/1233697Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592404}

Fixed one test that I expected to pass, but didn't because it was
pointing to the wrong ref. Fixed that, and now it passes. Updated
some expectation files. More stuff from various tests (but not
whole tests) is passing than before.

Bug: 781135
Change-Id: Ieb1312b8bf13c7a45afe644ad2a58f3f955044b6
Reviewed-on: https://chromium-review.googlesource.com/1228073Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592403}

If the Response body object is a readable stream then check whether
the object is disturbed or locked.
If the condition is true then throw TypeError.

refernce: https://fetch.spec.whatwg.org/#concept-bodyinit-extract

Bug: 878281
Change-Id: I0593d048e7bd146863efdc9f1d355bc70857cdc0
Reviewed-on: https://chromium-review.googlesource.com/1226718Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#592402}

Currently, UIDevToolsTest tests the whole system together
in a single test file. This file uses WindowElement in most
tests, which makes it difficult to port for the forthcoming
Mac implementation, which does not have WindowElement due
to not being an Aura platform.

This  is the first of a series of changes that will
break most of UIDevToolsTest up into more granular tests,
which will make it easier to isolate WindowElement use
to Aura.

This change takes the functionality that was previously
being tested in the style tests in UIDevToolsTest, and
breaks it into:
- css_agent_unittest.cc, which tests interaction between
elements and CSSAgent
- Separate files for individual element subclasses, to
ensure the mapping between the elements and their underlying
objects.

Additionally, it fixes a few bugs smoked out by the new
tests in CSSAgent and WidgetElement.

Bug: 769352
Change-Id: Ie24f2166a2dbe7fef31db2800c8bf88a1f470057
Reviewed-on: https://chromium-review.googlesource.com/1231033
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592401}

This reverts commit 0f374eff.

Reason for revert: http://crbug.com/886918

Original change's description:
> Reland "Enable Perfetto by default for all telemetry tests"
> 
> This is a reland of 32c8ebbe
> 
> Relanding after https://chromium-review.googlesource.com/c/chromium/src/+/1225306
> 
> Original change's description:
> > Enable Perfetto by default for all telemetry tests
> >
> > This will use Perfetto instead of TraceLog for all
> > trace-based Telemetry tests running on Mac/Windows/Android.
> >
> > R=nednguyen@google.com
> >
> > Bug: 839084
> > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> > Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
> > Reviewed-on: https://chromium-review.googlesource.com/1176119
> > Commit-Queue: oysteine <oysteine@chromium.org>
> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Cr-Commit-Position: refs/heads/master@{#585368}
> 
> TBR=nednguyen@google.com
> 
> Change-Id: I31b69483281f9fb34c5083888b8f45f00ca95e6e
> Reviewed-on: https://chromium-review.googlesource.com/1208955
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: Annie Sullivan <sullivan@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592127}

TBR=sullivan@chromium.org,oysteine@chromium.org,nednguyen@google.com

Change-Id: I7e3984b90f8f53d1dface9459ea07d7383e7c6d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1233717Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592400}

This CL streamlines IdentityManager's interaction with
ProfileOAuth2TokenService when getting accounts with refresh tokens
to have IdentityManager act as a straight passthrough rather than
using its internal state that is updated via Po2TS::DiagnosticsClient.
The motivation is to enable conversion of the codebase to
IdentityManager as smoothly and painlessly as possible, as explained in
detail in crbug.com/883722.

IdentityManager's internal state is currently still used for obtaining
the AccountInfo to send in the
OnRefreshToken{Updated, Removed}ForAccount callbacks. Changing that will
require first modifying OnRefreshTokenRemovedForAccount() to pass only
the account ID, as at the time that PO2TS::OnRefreshTokenRevoked() is
fired, AccountTrackerService does not necessarily know about the account
anymore.

Bug: 883722
Change-Id: Ia13c7f9162449fa0ea60de5fb9e67b5373a82dea
Reviewed-on: https://chromium-review.googlesource.com/1225758Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592399}

This change fixes a number of bugs in FidoBleTransaction and adds
corresponding tests. In particular, it fixes a race condition, where
the completion callback was run before the last write was acknowlegded.
In addition, it improves the robustness with regard to malformed input.

Bug: 880053
Change-Id: I81f6d5c02d01b9d7ea1a184a7236cd74d52f356d
Reviewed-on: https://chromium-review.googlesource.com/1224383
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592398}

This reverts commit d54e0de4.

Reason for revert: Tests added in this CL are failing. See https://crbug.com/886533

Original change's description:
> [Autofill] Browser Tests for Sign-in After Local Save.
> 
> Adding browser tests for the sign-in after local save flow. This includes user-action sign-in metrics, the sign-in promo, and the manage cards prompt.
> 
> Bug: 855186
> Change-Id: I8c1d15f79e6915230860d7f0f2529a10c01559b7
> Reviewed-on: https://chromium-review.googlesource.com/1196918
> Commit-Queue: Manas Verma <manasverma@google.com>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Jared Saul <jsaul@google.com>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592227}

TBR=mathp@chromium.org,estade@chromium.org,msarda@chromium.org,jsaul@google.com,manasverma@google.com

Change-Id: I6fe0b1508df0980aded5fa38fb5d43b3664db83f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855186
Reviewed-on: https://chromium-review.googlesource.com/1233938Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592397}

Bug: 878534
Change-Id: I08caf24449e619087dbf5ab27d122ef9115ba0ad
Reviewed-on: https://chromium-review.googlesource.com/1230513Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Cr-Commit-Position: refs/heads/master@{#592396}

Bug: 516866
Change-Id: I15a23355de0d4dca083f671dece10bf2059d1800
Reviewed-on: https://chromium-review.googlesource.com/1230063
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592395}

Also add a caveat about a restriction of std::aligned_alloc on its size
parameter (size must be an integral multiple of alignment).

Change-Id: I83389f78650bf51e819d4f992789f0361a4b29db
Reviewed-on: https://chromium-review.googlesource.com/1232633Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592394}

A different fix is under discussion at
https://chromium-review.googlesource.com/c/chromium/src/+/1233814
but since there's some disagreement on the approach, let's land
this while the review over there is ongoing, to heal the bot.

Bug: 886629
Change-Id: I80c64f6bf969b5b1edf108d2a46155f2f4252595
Reviewed-on: https://chromium-review.googlesource.com/1232591Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592393}

These prefs are generated at compile-time. Currently, the perf benchmarks
will hard-fail if the JSON is invalid. This CL adds tests for that case.

Bug: 884035
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I58610eb69a4b2610dce72e6de2f8cba2104a29d6
Reviewed-on: https://chromium-review.googlesource.com/1231840Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592392}

This reverts 7d96627b.

Reason: adb problems possibly fixed.

Bug: 885071, 758566
Change-Id: Id1abd6f5ab2022ecb50232b8f02e5cab8940ec84
Reviewed-on: https://chromium-review.googlesource.com/1233695
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592391}

I suspect that we are encountering back to back begin frame requests
that cause use to write out two begin frame responses which cause
us to crash. Ensure that the begin_frame_response_valid_ is false
when we generate a BeginFrame.

BUG=885124

Change-Id: I21332bccaea142f8daf18a15805142f03f59c339
Reviewed-on: https://chromium-review.googlesource.com/1231733Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592390}

Bug: 758566
Change-Id: I9ec28cc5bb1be7baac6ac232bd9db1a10870b3cc
Reviewed-on: https://chromium-review.googlesource.com/1233595Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592389}

Change-Id: I78b9172711cad010a754ad4d524758df39af5e61
Reviewed-on: https://chromium-review.googlesource.com/1233337
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#592388}

The scheduler assumes that all database tasks succeeded and continues
accordingly. This change propagates the errors, and if there are any,
the scheduler will abandon the fetch.

Change-Id: I813ab23107369799ada4cc39a5eee9944433ed44
Reviewed-on: https://chromium-review.googlesource.com/1228015
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592387}

RequestQueueStore and RequestQueueStoreSQL were combined.

I went ahead and added a test fixture for request queue tasks. This ensures
we actually delete the database in TearDown.

Bug: 883938
Change-Id: Ia56698061685440402d82b5a6836c827f30b546a
Reviewed-on: https://chromium-review.googlesource.com/1227134Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592386}

This reverts commit 673081e3.

Reason for revert: Test complete. One day in the field is sufficient.

Original change's description:
> Field crash if histogram bucket creation isn't as expected.
> 
> There are reports from the field that the "maximum" of a histogram
> does not match what was configured.  The working theory is that it is
> due to rounding errors in the creation of exponential buckets.
> Verify this assumption.  If it's behaving wrong, it should crash
> during the creation.
> 
> Bug: 836238
> Change-Id: I4cf5e4bc3986e288c728ae37e2ff8cf841b7598d
> Reviewed-on: https://chromium-review.googlesource.com/1228840
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Brian White <bcwhite@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592128}

TBR=asvitkine@chromium.org,bcwhite@chromium.org

Change-Id: I0c7ecfc65d31aa2d161f1b689a178432a9364e27
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 836238
Reviewed-on: https://chromium-review.googlesource.com/1233893Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592385}

To shrink LayoutBlock back to its previous size, store the
constraint space as a pointer again. This seems to actually have a
slightly positive effect on performance according to pinpoint (?!)

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I9de7205eefbce457a9b7a82a6d5529adb13d58c4
Reviewed-on: https://chromium-review.googlesource.com/1232584Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592384}