- 23 May, 2020 8 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f8283ef4bdf..c3e2c610cae3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ramyan@google.com Change-Id: Ia541dd37256615f675e847a1730d5ce64895300a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213780Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771376}
-
Gayane Petrosyan authored
Bug: 1085873 Change-Id: I2ec9e4e673757c31ea354bb542430512199771a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213882Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#771375}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d998d150. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" fc4093a6 "Move mouse-pointer-preventdefault.html to wpt" 3304d0fe "Revert "Move mouse-pointer-preventdefault.html to wpt"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iba2508d67027feaaa30a2a8b712585b48b9f78f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213903Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771374}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ibeccedca5c13ca28c7a7e1ce972d65c2aad67986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213844Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771373}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590177508-82204ce5fd465758380fa192db925e711e803d9a.profdata to chrome-win32-master-1590191676-5c3f21023d82190a9464b9c5e89cd434c565ee7a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id2c6be3878062bc85b82459cc5e50e46d1157152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213776 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771372}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/562c067f0813..4f8283ef4bdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ramyan@google.com Change-Id: I6edaaeadb69c13b3c164ccecf545ab7eda5e9b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213771Reviewed-by:
-
Jinsuk Kim authored
Added a missing deps in the target native_java_unittests_java which uses the newly added chrome/browsr/contextmenu:java. This reverts commit bb30c5c1. Bug: 952703 Change-Id: Ib29b8c62311f0bd70616a959022a605f6daebfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210036Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#771370}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590177508-6c1b546bac84a3411fd7b6d2012a9c3c8fbfc260.profdata to chrome-mac-master-1590191676-a4db509c06232b1ce84802804d74b9954154103c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia552ea239fdbd6453f0d7d374f7a59f5b0bb77b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213772Reviewed-by:
-
- 22 May, 2020 32 commits
-
-
Kenneth Russell authored
It's randomly crashing the GPU process, causing it and the test following it to fail. Skip this in both the WebGL 1.0 and 2.0 expectations though it's not run on the waterfall for WebGL 2.0 yet. Bug: 1085677 Change-Id: I91ee47fb9ebc345d33c2e8e885f3b40b4a7c2f27 Tbr: jmadill@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213766Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771368}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/870a83f93edf..562c067f0813 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ramyan@google.com Change-Id: Ia38af002398eafbada9688abe3e4440902df929d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213761Reviewed-by:
-
Alexander Surkov authored
Extend property filter format to name(args)=value to specify arguments for a method call. AX-Relnotes: n/a Bug: 1076955 Change-Id: I0c862b257808368e93c41e61a9b5525d35bb80d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190175 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#771366}
-
Yury Semikhatsky authored
This reverts commit 1537d629. Reason for revert: potentially breaks gmail reloading when disabling offline mode with DevTools open. Bug: 1085150 Original change's description: > [DevTools] Properly notify devtools agent host when service worker is destroyed > > ServiceWorkerDevToolsAgentHost now stores thread-safe reference to > ServiceWorkerContextWrapper instead of ServiceWorkerContextCore that > could be deleted asynchronously on the service worker core thread. > > WorkerDestroyed notification is now sent to the observers of > ServiceWorkerDevToolsManager iff the worker version is both stopped > and doomed. Each worker can be terminated (and restarted) multiple times > and will result in a sequence of targetCrashed/targetReloadedAfterCrash > events in the protocol but the instance of its > ServiceWorkerDevToolsAgentHost will survive restarts and all connected > sessions will be preserved. > > It fixes the events generated in the protocol for service workers from > targetCreated, (detachedFromTarget, attachedToTarget, targetReloadedAfterCrash)* to > targetCreated, (targetCrashed/targetReloadedAfterCrash)*, targetDestroyed > and avoids inadvertent session terminations when workers are stopped and > also spurious targetReloadedAfterCrash events. > > Bug: none > Change-Id: I1125604d08b7842f7f8d74751091193b9af2cb59 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099590 > Commit-Queue: Yury Semikhatsky <yurys@chromium.org> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750975} TBR=dgozman@chromium.org,horo@chromium.org,caseq@chromium.org,yurys@chromium.org,einbinder@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: Ibba7ce840b8c8b73c32086d141005306591e21cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213448Reviewed-by:
Yury Semikhatsky <yurys@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#771365}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c9ebf905761c..d3d7b95bac19 2020-05-22 tobine@google.com Vulkan:Migrate timer sync functions to one-off cmd buffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I71e9cadf99c470b6f64131ed368df229a515b774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213454Reviewed-by:
-
danakj authored
Tests that want to run the document lifecycle are changed to use updateAllLifecyclePhasesAndCompositeThen(). The test that wants to do printing in the renderer and grab the pixels is changed to capturePrintingPixelsThen(). This path explicitly prints the current frame, rather than going into the end-of-test-find-a-frame (non-OOPIF-compatible) path. This makes it possible to use the API from any frame. Remove all the main-frame-attached post/invoke v8 callback helpers in TestRunnerForSpecificView, as they are no longer used. R=nasko@chromium.org Bug: 866140, 1069111, 952399 Change-Id: I8271f093bbc0ad9c68b2c05acc24d2062d090f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204408 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#771363}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590161669-17629765fa6319602482bd35878adc03bc8e5e00.profdata to chrome-win32-master-1590177508-82204ce5fd465758380fa192db925e711e803d9a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib67ff81d9e3bd02590af8711fa3dc4281ae832ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213763Reviewed-by:
-
Kurt Catti-Schmidt authored
Support for UIA_CulturePropertyId via GetPropertyValue was added in https://chromium-review.googlesource.com/c/chromium/src/+/1096255/, however it was not implemented according to spec. The MSDN spec for UIA_CulturePropertyId specifies that this property returns an integer with a language code, not a BSTR with the language attribute string as implemented previously. This change returns the proper culture ID as spec'd, via the existing 'GetCultureAttributeAsVariant' method added for TextPattern. Unit tests are added for a variety of scenarios. AX-Relnotes: Fixes an issue when looking up a node's language in UIA. Bug: 1085205 Change-Id: I60c9b83b65ecf7f56fd5cb7929d495ac7620a08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212979 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771361}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590161669-593ac6a44fd629dc3035fae6d797ac804dd4b719.profdata to chrome-win64-master-1590177508-ab8e07852b85f9a8b9b3fea70f472cb98013b6e2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae799d3d3dbf53b341e542f4690aa36c361b08db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213762Reviewed-by:
-
Sahel Sharify authored
This cl exposes payment features to java using a payment specific feature list rather than ChromeFeatureList.With this change payment features will be accessible from components/payments. Bug: 1085784 Change-Id: Ib7c1114b61519fd838842f0e53c2f9a7fb816b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213334Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771359}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590161669-1437af88aff1c6cc90f5b4a73d3631f0e7fd0e76.profdata to chrome-mac-master-1590177508-6c1b546bac84a3411fd7b6d2012a9c3c8fbfc260.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I4ae8b476f875f92a6b89826fe54211fffdef191e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213458Reviewed-by:
-
Sam Fortiner authored
Based on early results in dev/canary, this feature is looking promising and we would like to continue this experiment in Beta. To unblock that we are enabling this experiment for the perf bots now to get more data on the impact. Bug: 1058987 Change-Id: I5e771beb6d4085c25df353c68c37db05d220af65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211019Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771357}
-
Pavel Yatsuk authored
This CL adds a dialog that is displayed when interaction with permission dialog is blocked because of overlay window covering permission dialog buttons. BUG=1014477 Change-Id: I1ab7a6342f77f28e3179a4f5129d8fcf292f3019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198365 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#771356}
-
Gang Wu authored
Bug: 1085538 Change-Id: Iade4c1e85bb865d3dda9e6ab74107546df234de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213324 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
These were some of the augmentations that came out of a review session with the UX designer: - Make sure the Play button disappears while seeking. - Enlarge the Play/Pause button. - Fill in the holes of the Play/Pause buttons and change the transparency colors. - Shrink the background gradient and make it non-linear (make it tail off quickly towards the end). - Set Pause image asset as the default icon (to avoid flashing from Play to Pause when playback starts). - Adjust the margins a bit, especially to increase bottom padding to lift controls at bottom up a bit and set the proper space between them. - Increase the font for Time Remaining. - Make the SeekBar track a little thicker. TBR: bsazonov@chromium.org Screenshots: https://crbug.com/895776#c47 Bug: 895776, 656015 Change-Id: Id288dc836df4d7b835fd1e148f1d5e0335aca764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183936Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#771354}
-
David Tseng authored
R=dmazzoni@chromium.org Fixed: 1068665 AX-Relnotes: Fixes Chrome find in page feedback in ChromeVox. Change-Id: I00a434feb43da30ced04f01c63980ad568bf0233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213238 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/71f352e32811..c9ebf905761c 2020-05-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from a6d833327f7e to b2cfe61366da (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Idbeafdb4d63a76f183d30ec5b1cd348f0cfb4c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213637Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7524d2e6a243..870a83f93edf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC avi@google.com,vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: avi@google.com,vasilii@google.com Change-Id: Id9a9085fe78dbfd7d47c89ce9adb9286d6b39111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213631Reviewed-by:
-
Manuel Rego Casasnovas authored
The use counter was counting all the cases in which we have a percentage row track in a grid container with indefinite height. However some of these cases render the same independently if we resolve the percentages against the intrinsic grid container height (like it happens right now for grid layout row gutters and tracks) or not (like it happens for flexbox row gutters). This patch modifies the use counter so we count only the cases that will change the output depending on how we resolve the percentages. So the cases in which we have a single row with 100% percent are not counted anymore. This is similar to what we do for kGridRowGapPercentIndefinite, where we only count cases when there are more than 1 row. This will give us a better understanding of the web compat risk if we decide to change this behavior in the future. Change-Id: I07ff2c914b39b2e27084afad39c949a95072ce19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212128Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#771350}
-
Alexander Surkov authored
Bug: 1085421 Change-Id: I3910d3d7d54637dfc054f70dc81ffa2f051c07ae AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212461 Commit-Queue: Alexander Surkkov <asurkov@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/afd8a6c6ae87..88a3b462962d 2020-05-22 herb@google.com turn off 2M glyph test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I6a023b4ffe52ff3770651892db30b31e2bea9762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213640Reviewed-by:
-
Hirokazu Honda authored
There are some media features that needs to be overridden in a test. For instance, we want to enable kVaapiVP9Encoder, which is disabled by default now, and also kFFmpegDecodeOpaque to use VpxVideoDecoder to decode vp8 bitstream for a verification. There is no way to enable and disable features in our video tests. After this CL, media::test::VideoTestEnvironment takes feature sets to be either enabled or disabled in a test. Bug: 1045825 Test: video_encode_accelerator_tests --codec=vp8 on eve Change-Id: Ib66d96c124783ca47c3e943d396e6666ebac03ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206872 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#771347}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590119331-fbabb52511f6c610b90717a191978d71b893771f.profdata to chrome-win64-master-1590161669-593ac6a44fd629dc3035fae6d797ac804dd4b719.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5f6399797073ae1dd7442387bea42b8b9a92ed28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213586Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590147234-0a723ff3779a785a5a73326d87db7cb98fa45feb.profdata to chrome-win32-master-1590161669-17629765fa6319602482bd35878adc03bc8e5e00.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I30d3fc0fd95919ee2faa6418c59b6c9c468f15c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213587Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590147234-3f090f605cbcaf87b1210a2c3aca08f21e49a4ee.profdata to chrome-mac-master-1590161669-1437af88aff1c6cc90f5b4a73d3631f0e7fd0e76.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ida925a9a97cd536d965b3320679dd3743789e2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213701Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd9e807ee9a7..9046a4247505 2020-05-22 primiano@google.com Merge "infra: add perfetto.dev site" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7f923402a1021a3fcf66b2a9d323c21d19d1615c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213633Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ec31488ace66..afd8a6c6ae87 2020-05-22 bsalomon@google.com Change intermediate image sizes in GrSurfaceContext::rescale If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I6efa6eff6c7f404e7487c8a1648376c6163ca1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213632Reviewed-by:
-
Aleks Totic authored
Caption.html - Legacy fails the caption block %ge sizing test. Legacy computed caption block %ge from grid size. I've discussed with tab, and will try to make block %ge caption size be auto instead. - Browsers mostly agree on column-width.html test, 1 difference. It exausively tests how td and col sizes are combined to generate column width. Bug: 958381 Change-Id: I61d0e5a0e67d7fbb122ee5818917ee14d9801da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161571 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771341}
-
Mario Sanchez Prada authored
This reverts commit bcb3ba73. Reason for revert: This migration was wrong because it did overlook that there might be multiple responses being sent from the renderer to the browser process during one serialization process, in which case the renderer will crash due to not havin a valid mojo callback to invoke after the first response is sent. See crbug.com/1085721. The solution is to rework this to have a separate mojo method that will be called from the renderer for each response that needs to be sent back to the browser process, but let's revert this for now and work on that on a follow-up CL. Original change's description: > Migrate FrameMsg_GetSerializedHtmlWithLocalLinks to mojom::Frame > > This CL moves this message out of frame_messages.h and adds a new > method in content::mojom::Frame to allow the browser request from > the renderer the serialization of a RenderFrame's contents, regardless > of whether such contents include same-site or cross-site resources. > > Since this functionality also requires an asynchronous response from > the renderer once the serialization is complete, this CL does also > migrate FrameHostMsg_SerializedHtmlWithLocalLinksResponse, for which > some extra bit have been added to WebFrameSerializer[Client], so that > we can appropriately reply to the browser process when the serialized > data is available. > > In a future CL, this functionality will probably get moved down into > Blink itself, but at the moment there's way too much functionality > in use in Blink's public API, so this CL does not tackle that part > yet, and focused on the migration from legacy IPC to mojo only. > > Bug: 1044088 > Change-Id: I4ce5b3cfe795e5019bb30a278577ec2be3ee2854 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207234 > Commit-Queue: Mario Sanchez Prada <mario@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770794} TBR=kinuko@chromium.org,acolwell@chromium.org,haraken@chromium.org,mario@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1044088, 1085721 Change-Id: Ic84a3244aef24fcde881f2316aa75679665e7734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212132Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#771340}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 0e41d647ceaeb2195d5d9ab5ff25c19292a36bf5`. TBR=rnk Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Change-Id: I48b5bc02e2a21329c51de24366b6ca2c4e9c1f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211510Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#771339}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5dfa8d5f. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" fc4093a6 "Move mouse-pointer-preventdefault.html to wpt" 3304d0fe "Revert "Move mouse-pointer-preventdefault.html to wpt"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I144d8964de0288f4b32c019c0ab29783408acfb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213497Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, aborting payment on desktop would succeed only before the payment app has been invoked. The invoked payment app was not consulted whether it could be aborted. This patch delegates abort handling on desktop to the payment app. This patch also removes the identity callback from the desktop implementation of PaymentRequest, because aborting requires ServiceWorkerPaymentApp to know the service worker registration ID, which is also used for payment handler host logging, and ServiceWorkerPaymentApp now has a reference to the payment handler host. After this patch, the invoked payment handler receives the abort event and determines whether abort should be performed. (Android already does that.) Bug: 1083242 Change-Id: I267ad820ef06b17fb88bd8b948c22b0e07145fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208105 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#771337}
-
