- 20 Aug, 2019 40 commits
-
-
Kent Tamura authored
'transitionrun' event is delayed if a page has text selection, and the transition detection logic in style.mjs didn't work in this case. After this CL, we remove '$part-transitioning' part in attributeChangedCallback. This works well because Blink doesn't compute style for <std-switch> before calling attributeChangedCallback for 'on' attribute. Change-Id: I8f25eca61fd52441d06bf86173c19d1c764bb859 Bug: 992454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758002Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#688427}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fa2a0bda6e24..b081bc4a3139 git log fa2a0bda6e24..b081bc4a3139 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 13cc0fce4340..6aca71d7d705 (5 commits) 2019-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3b734c26..8cd21345 (407 commits) Created with: gclient setdep -r src/third_party/skia@b081bc4a3139 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:None,chromium:None Change-Id: Ia53f957b03b22ea079530038675dbf1be91d2610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761500Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688426}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8cd21345. With Chromium commits locally applied on WPT: 2871d281 "Remove invalid test cases using unitless zero length in math functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I9fdd50f30778a988ba61dc5c63419d27e1948d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760422Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688425}
-
Vlad Tsyrklevich authored
Due to performance regressions I've reduced the percentage of processes GWP-ASan is enabled for. As a result, I've been able to proportionally increase the amount of memory we use per process. As a result, the previous maximum metadata of 255 no longer sufficies. Increase MetadataIdx to be a 16-bit type and increase the maximum metadata to something more reasonable. Change-Id: If031dec3732ccf3ba69bdafdca2b03cb274bd9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761477 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#688424}
-
David Munro authored
* Emit a metric whenever a user tries to use a virtual keyboard or unsupported IME in a Linux app, recording the event and reason. * Emit another metric whenever we show a message to the user (currently we only show a message the first time per session). Bug: chromium:962848 Test: Unit tests Test: Run manually, check histograms in chrome://histograms Change-Id: I25f702f06af0cf599847043543f2a8f8b78bfe0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752569 Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#688423}
-
Miyoung Shin authored
This CL converts ServiceWorkerContainerHostAssociated{Ptr,PtrInfo,Request}, ServiceWorkerContainerHost{Ptr,PtrInfo,Request} and ServiceWorkerContainerAssociated{Ptr,PtrInfo,Request} in content to to new Mojo types, and uses pending_receiver<ServiceWorkerContainerHost> in service_worker_container.mojom and pending_associated_remote<ServiceWorkerContainerHost> and pending_associated_receiver<ServiceWorkerContainer> client_receiver in service_worker_provider.mojom. Bug: 955171, 978694 Change-Id: I24cbe7f6c63245e08abd3a9c1613b40e95710b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760631 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Ken Rockot <rockot@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#688422}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8534c983593d..92d81e78499b Created with: gclient setdep -r src-internal@92d81e78499b The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ibe5224eb02a6ae9858f30f864da79fbeae8622e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761431Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688421}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d8cdcea0eeb1..0beb43809ae9 git log d8cdcea0eeb1..0beb43809ae9 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 enga@chromium.org Validate RenderBundle texture formats Created with: gclient setdep -r src/third_party/dawn@0beb43809ae9 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I1f8900754f690f7e38d399a3f046f63174e602f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761432Reviewed-by:
-
Takashi Toyoshima authored
OnUploadProgress() can be called even during a redirect is not resolved. So the existing DCHECK is wrong. Bug: 994007 Change-Id: I523b6e68dc5f7e90f0a4f8a3314450a8a34bb214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760630Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#688419}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52a6a40535b0..fa2a0bda6e24 git log 52a6a40535b0..fa2a0bda6e24 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader dadeb009a297..fd72dd0a439f (5 commits) Created with: gclient setdep -r src/third_party/skia@fa2a0bda6e24 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:None Change-Id: I2479cd373d4c1c4f371308370dcbd7cb0bca3589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761433Reviewed-by:
-
Tomas Popela authored
It's because GCC has problems when mixing the alignas() together with __attribute__() (that is used to export the symbols). The best solution is to use ALIGNAS() macro from //base/compiler_specific.h together with alignof() to have the equal functionality that compiles on GCC as well as on clang. This is a regression after https://crrev.com/659933. Bug: 994581 Change-Id: Ia376866ff9ac57d52d2e907fa325ae5a51893d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758064Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#688417}
-
Peter K. Lee authored
Use staticTexts[] instead of otherElements[]. The rest are comment and cleaning up test rig. Bug: 994990 Change-Id: Ia8cc9ec5f1bd8661c2a1bfdd796b036f7d434571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761488Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#688416}
-
Mohsen Izadi authored
With the introduction of cc::MirrorLayer, a render pass can be embedded multiple times in a compositor frame. If such a render pass contains a SurfaceDrawQuad, that draw quad would appear multiple times in the frame, potentially affecting the damage rect in multiple locations. To calculate the damage rect for each appearance of a surface, transforms applied to all ancestor render passes should be taken into account. So, we need to use backtracking on the render pass tree (more accurately, it is a directed acyclic graph rather than a tree) to be able to calculate all the different ways transforms can be applied to surfaces. This CL also fixes some tests that were setting up render passes incorrectly (e.g. render passes referencing themselves). This CL was originally landed as r678692 (later reverted) which was accumulating transforms to root target while traversing the render pass tree rather than transforms to parent targets. This is now fixed and the test is updated to catch that. I have verified that reported issues caused by the original CL (985978, 986249, and partly 986206) are not reproducible with this CL. This CL also removes the workaround landed as r682962. BUG=987725,985978,986249,986206 Change-Id: I9d44cde5a738256162489b49964e34aa7bfb9b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743468Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
Originally, VideoFrameConverter returns converted frames directly. However, MailboxVideoFrameConverter generates mailbox at GPU thread. We have to use WaitableEvent to block the working thread. In this CL, VideoFrameConverter changes to use callback to return converted frames. With this change, we don't block the working thread anymore. BUG=chromium:952730 TEST=play crosvideo.appspot.com on kevin and eve Change-Id: I073dbeca41724242a1d8e20fbdc42f8aee66bf64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716250 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#688414}
-
Alan Cutter authored
This file was missed in the refactor done in https://chromium-review.googlesource.com/c/chromium/src/+/1736620 Bug: 926083 Change-Id: I8f5ec6f4b5a435d8cf06065df3119772a31a52d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760838 Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I4b8660da9719bce3d6c4c5ddb322bd17ccd2766a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761140Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688412}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c2af6b117e96..0be80f8179c5 git log c2af6b117e96..0be80f8179c5 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 shaochuan@chromium.org Temporarily disable TastVMTest on betty-pi-arc-release Created with: gclient setdep -r src/third_party/chromite@0be80f8179c5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I91e6735781565b433ca8bf3f1401d8a4027482bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759902Reviewed-by:
-
Jeremie Boulic authored
Bug: 778674 Change-Id: I548cc05d2ac3ad1c6fc42ebbd86142d031f09883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757714Reviewed-by:
François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#688410}
-
Koji Ishii authored
These were marked to fail on Mac10.13 only. It looks like these fail on Mac10.10 and Mac10.12 hence marking. fast/text/forced-break-before-close-tag.html fast/dom/collection-item-should-be-overridden-by-own-property.html NOTRY=true TBR=noel@chromium.org Bug: 992920 Change-Id: If012118c25ad955636b2f6ba530848a0bc4246fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760586Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#688409}
-
Yuki Shiino authored
This reverts commit 9e30a264. Reason for revert: Suspicious to be causing test failures at https://ci.chromium.org/p/chromium/builders/ci/win-asan/7042 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904649337418417152/+/steps/sbox_integration_tests_on_Windows-10-15063/0/logs/Deterministic_failure:_ProcessMitigationsTest.CheckWin10MsSignedWithIntercept_Success__status_FAILURE_/0 Original change's description: > Win Sandbox: Optimize the NtCreateSection intercept. > > In the case where an approved DLL is being loaded, there is no > point trying to create the section in the target process, because > it will just fail. In this case, just call straight into the > broker for the section to be created there. > > This also fixes issue 993450 as it causes the second call to > NtCreateSection during the LoadLibrary of the chrome DLL to > always be sent via the intercept to the broker. > > BUG=995338,993450 > > Change-Id: Ife7c8c6e1b8c43495e2b69baedbb1096b58a94a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759896 > Reviewed-by: James Forshaw <forshaw@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688344} TBR=forshaw@chromium.org,wfh@chromium.org Change-Id: Id7920d0212395b24f67997ba9b4ed36fab330a8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995338, 993450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760836Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#688408}
-
Miyoung Shin authored
This CL converts EmbeddedWorkerInstanceHostAssociatedPtr, EmbeddedWorkerInstanceHostAssociatedPtrInfo, ThreadSafeEmbeddedWorkerInstanceHostAssociatedPtr, EmbeddedWorkerInstanceClientPtr and EmbeddedWorkerInstanceClientRequest in content to new Mojo types. Bug: 955171, 978694 Change-Id: I72dccb7cfcbf78707eb1ad17dca610ad347cf214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757604 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit e5f1b06d. Reason for revert: suspect causing chrome_cleaner_unittests failure on windows-bots because of: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/39695 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/94372 ... UwSPresent/ProtoChromePromptIPCTest.Communication/true_true_PromptAcceptanceACCEPTED_WITHOUT_LOGS_DisconnectedAfterCloseMessageLength UwSPresent/ProtoChromePromptIPCTest.Communication/true_true_PromptAcceptanceDENIED_DisconnectedAfterCloseMessageLength UwSPresent/ProtoChromePromptIPCTest.Communication/true_true_PromptAcceptanceACCEPTED_WITH_LOGS_NotDisconnected UwSPresent/ProtoChromePromptIPCTest.Communication/true_false_PromptAcceptanceACCEPTED_WITH_LOGS_NotDisconnected E.g. win7 tests' log https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904641206741120976/+/steps/chrome_cleaner_unittests/0/logs/Deterministic_failure:_NoUwSPresent__x2f_ProtoChromePromptIPCTest.Communication__x2f_false_false_PromptAcceptanceDENIED_NotDisconnected__status_FAILURE_/0 [ RUN ] NoUwSPresent/ProtoChromePromptIPCTest.Communication/false_false_PromptAcceptanceDENIED_NotDisconnected [636:3088:0819/200428.002:5454013:ERROR:proto_chrome_prompt_ipc.h(74)] Writing a message to the pipe failed.: The pipe has been ended. (0x6D) ../../chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc_unittest.cc(648): error: Expected equality of these values: error_occurred_ Which is: true should_have_errors Which is: false ../../chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc_unittest.cc(670): error: Expected equality of these values: expected_exit_code Which is: 0 rv Which is: -1 Original change's description: > Implement ProtoChromePromptIPC. > > Bug: 969139 > Change-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747 > Commit-Queue: Oliver Li <olivierli@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Joe Mason <joenotcharles@google.com> > Cr-Commit-Position: refs/heads/master@{#688357} TBR=joenotcharles@google.com,wfh@chromium.org,olivierli@chromium.org Change-Id: If19d65f100db413bd68ca5f9bfa60aa426474e00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 969139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760644Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#688406}
-
Yutaka Hirano authored
Bug: 994000 Change-Id: Id92f66c7e0ac4fb3eeabfbb5b209080d450561bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760643Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#688405}
-
Darwin Huang authored
Avoid potential unnecessary copies by using emplace consistently. No intended functional changes. Bug: 995605 Change-Id: I187c51bdba19f112bff7eab77ea1e943bd7c64ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761691 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688404}
-
Christopher Lam authored
This CL pulls the System Web App migration logic into PendingAppInstallTask in preparation for External App migration. This also changes migration_source to a list of apps that the Web App System will uninstall using the App Service and then migrate OS data from. This CL also adds the Settings SWA as a migration target for OS Settings. Bug: 976578 Change-Id: I1d938690d7550101138563a3b266bc491fefd2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736129 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#688403}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b779cee96613..8534c983593d Created with: gclient setdep -r src-internal@8534c983593d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I0b2605956ca60aadaa8fa43ae17b83b658177ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760116Reviewed-by:
-
Xiaocheng Hu authored
Spec (*) explicitly disallows unitless zero length in math functions: > Note: Because <number-token>s are always interpreted as <number>s or > <integer>s, "unitless 0" <length>s aren’t supported in math functions. > That is, 'width: calc(0 + 5px);' is invalid, because it’s trying to > add a <number> to a <length>, even though both 'width: 0;' and > 'width: 5px;' are valid. There are some existing WPT test cases violating this, which are removed in this patch. (*) https://drafts.csswg.org/css-values-4/#calc-type-checking Bug: 994359 Change-Id: Iba66c4e425ec24133c7f70bbbeca7a60d59e1883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758734Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688401}
-
Maggie Chen authored
A non-sandboxed, 15-seconds-delayed gpu process is currently running in the browser to collect dx12/vulkan info. This switch is added for gpu integration test where dx12 and vulkan paths will be tested. With this switch, the gpu information will be collected immediately. Bug:977034 Change-Id: I3609a9f4e2827862530fdc4e0d14591bd99b4013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761103Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688400}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e41cafe2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7c474b1aee7184859ddc5c5050707b3cc276f300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760421Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fdf38802a684..a0b52b570853 git log fdf38802a684..a0b52b570853 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 steveanton@webrtc.org Remove zhihuang@webrtc.org from OWNERS 2019-08-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision afb0a631..21d23ea5 (688061:688221) 2019-08-19 qingsi@webrtc.org Reland "Set the usage pattern bits for adding remote ICE candidates from SDP." 2019-08-19 srte@webrtc.org Removes empty p2p/base/transport.h Created with: gclient setdep -r src/third_party/webrtc@a0b52b570853 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Icabce3b243e10de860e43e0c027f3a5f47a850d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761202Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/caaa058f628b..c2af6b117e96 git log caaa058f628b..c2af6b117e96 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 gwendal@chromium.org chromeos_config: mark some loonix derivative experimental Created with: gclient setdep -r src/third_party/chromite@c2af6b117e96 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6632a5fb753033a925f1dd3e193569dc67f3c437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761614Reviewed-by:
-
tby authored
To display zero-state local files, we need to get the right icon for the filetype. This adds a helper function to do that, which closely mirrors the extension->icon mapping in file_manager/common/js/file_type.js. Bug: 959679 Change-Id: Ib0b9b77a62843e1e84a6f0494dc234e0660fe9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755564Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#688396}
-
Chinglin Yu authored
This fixes a shutdown race in destroying the JankMonitor instance that fails some tests intermittently. In JankMoitor::Destroy(), shutdown of MetricSource and the monitor thread happens concurrently, which may result in a race that the monitor timer is stopped in destroying the monitor thread and then restarted by a task running on UI or IO thread. Then the timer bound to the monitor thread is destroyed on the UI thread and fail the tests using JankMonitor. Fix the race by making the shutdown sequential: the monitor thread is destroyed after MetricSource is destroyed. Bug: 904785 Test: content unittest: JankMonitorShutdownTest.ShutdownRace Change-Id: Ic4073fa22670ca4532cba99f6e71fab5a93ea40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753369Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688395}
-
Daniele Castagna authored
gl_copy_texture_CHROMIUM_unittest currently tests copies of 8x8 textures. When glCopySubTexture is used, the full texture is copied. This patch adds a test, GLCopyTextureCHROMIUMES3Test.BigTexture, that tests a copy of a 1080x1080 textures, additionally, when glCopySubTexture is used, there will be two copysubtexture copying two different subrects that cover the whole texture. This tests is for crrev.com/c/1730549. Bug: 991668 Test: The new test fails without crrev.com/c/1730549 Change-Id: I2dfecf35aff974a64deafef5d457960d81fa0a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735587 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688394}
-
Hiroki Nakagawa authored
This class will be used for dedicated workers, too. Bug: 945673 Change-Id: I88ea5c8c8f61f3a4ccb61f89c7a960a34634b5a1 Tbr: hayato@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758027 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#688393}
-
Wei-Yin Chen (陳威尹) authored
Bug: 930970, 930965, 930972 Change-Id: I3b48baa250665d00eebe37bfff7b3b2e97b2f3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757396Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688392}
-
Ken Rockot authored
Updates the Preferences Service to support multiple independent clients (with independent observable pref concerns) to connect over the same PrefStoreConnector pipe. This is accomplished by adding an optional Token parameter to the Connect() message which browser code can provide to uniqueify an individual Connect call. The API change is temporary and can be removed once Prefs Service itself is pulled off of the Service Manager. Bug: 995404 Change-Id: Ib33378bcffb16a3742c67804d6778ba5633adc1d Tbr: hansberry@chromium.org Tbr: wutao@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761403 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#688391}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df7093214c55..a44d67c6e809 git log df7093214c55..a44d67c6e809 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 ehmaldonado@chromium.org depot_tools: Add python3 to win bootstrap. Created with: gclient setdep -r src/third_party/depot_tools@a44d67c6e809 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: I2ea33714297e73d173ea1b184af3ab44f18a3359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761661Reviewed-by:
-
Chinglin Yu authored
In ProfileProviderFeatureParamsTest, ScopedFeatureList is destroyed after exiting the test function, while ProfileProvider::Init() sets up each registered collectors on its own dedicated seqneuce. The collector might access FieldTrialList while ScopedFeatureList is destroyed, causing UAF. Fix by adding TestBrowserThreadBundle::RunUntilIdle() to finish the setup of collectors before destroying ScopedFeatureList. --gtest_repeat=1000 --gtest_break_on_failure Completes without crash. Bug: 994475 Test: gdb --args unit_tests --gtest_filter="ProfileProvider*.*" \ Change-Id: Id9b66d9cd0fae956a5bc59779c92ad0846f35196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757962Reviewed-by:Gabriel Marin <gmx@chromium.org> Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688389}
-
John Z Wu authored
Change-Id: Ie7190f73dc90de5bc99d5e9df5080df77035f109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761608Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#688388}
-
