- 15 Dec, 2017 40 commits
-
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/760ef9c24a40..069dd4fa6b05 $ git log 760ef9c24..069dd4fa6 --date=short --no-merges --format='%ad %ae %s' 2017-12-14 iannucci [bot_update] Put depot_tools at the end of $PATH on LUCI. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Icd7fa7972c0e65b4907f473aa8207522840aeb3e Reviewed-on: https://chromium-review.googlesource.com/827937Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524339}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/a088365e2fac..7f846f273cea $ git log a088365e2..7f846f273 --date=short --no-merges --format='%ad %ae %s' 2017-12-14 reed remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I01a2785ce52948803987e6c3bfbd16b33383da7b Reviewed-on: https://chromium-review.googlesource.com/828405Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524338}
-
Albert J. Wong authored
This reverts commit 8c29b757. Reason for revert: <INSERT REASONING HERE> Original change's description: > Enable frame pointers on arm32. > > LLVM fixed the bug where framepointers were not located next to the return > address in thumb mode. https://bugs.llvm.org/show_bug.cgi?id=18505 > > With that fix, enabling framepointers on arm32 bring it in line with other > build configurations and allows for better stack traces. > > Bug: 786450 > Change-Id: I01a1c9f82fac22b2bbc15c6f52deed8aca7263ea > Reviewed-on: https://chromium-review.googlesource.com/826255 > Reviewed-by: Brett Wilson <brettw@chromium.org> > Commit-Queue: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524127} TBR=ajwong@chromium.org,brettw@chromium.org Change-Id: Ie327529394021473cfffd0ee80baecce4bd83e2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 786450 Reviewed-on: https://chromium-review.googlesource.com/828607Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#524337}
-
Emil A Eklund authored
Change signature of the NGTextFragmentPainter::Paint method to match the signature of other Paint methods, specifically by dropping document arg. Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9c752b2c7f56c333c76b1815f69c3691e490fdc7 Reviewed-on: https://chromium-review.googlesource.com/827632 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#524336}
-
Bryan McQuade authored
Page load metrics browser tests sometimes want to assert that no page load metrics are logged for a given page load. They do this by checking to see that no PageLoad.* histograms were logged, but excluding PageLoad.Internal.* histograms, which are considered internal and thus allowed to be logged during non tracked page loads. Recently, the PageLoadMetricsBrowserTest.NonHttpOrHttpsUrl test started flaking on Windows, due to PageLoad.Experimental.Renderer.* metrics being logged during this page load. These are really internal metrics, so should use the PageLoad.Internal.* naming convention, which also allows them to be ignored by this test. Bug: 794408 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I593adf3b8c995e50b74431cc89e782cf4456abff Reviewed-on: https://chromium-review.googlesource.com/826386Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#524335}
-
Andrey Kosyakov authored
This fixes a problem where we were using a loader id on the blink side that is different from DevTools navigation token on the browser side. Change-Id: Ieb82d2a7fea7f0e233eeeaf2158d46803cbb7e80 Reviewed-on: https://chromium-review.googlesource.com/828074 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524334}
-
Emil A Eklund authored
Expose whether a fragment has an associated layer on NGPhysicalFragment, with the implementation defering to the LayoutObject. Aditionally expose the type of block on NGPhysicalBoxFragment. Both are needed for painting directly from the LayoutNG fragment tree as it affects the paint order. Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9f2d123acec104b1c61b9bd1297c49541713ac18 Reviewed-on: https://chromium-review.googlesource.com/827635 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Eric Willigers authored
x, y, width, height are presentation attributes. Spec: https://svgwg.org/svg2-draft/single-page.html#embedded-ForeignObjectElement When specified using stylesheet rules and as attributes, the stylesheet rules have higher specificity. https: //svgwg.org/svg2-draft/single-page.html#styling-PresentationAttributes Change-Id: I62101c1e41e6dcca19de74231104dd809e68a306 Reviewed-on: https://chromium-review.googlesource.com/828241Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#524332}
-
Sasha Bermeister authored
Moved QuotaStatusCode from storage/common to WebKit/common. This is pre-work to onion soup the QuotaDispatcherHost mojo API and remove WebStorageQuotaType and WebStorageQuotaError. This patch: * Moves QuotaStatusCode to WebKit/common and updates users to use blink:: instead of storage:: for the types * Moves QuotaStatusToString to a function in an anonymous namespace in the only file it's used (sync_file_system_api.cc) * Removes kQuotaStatusLast, since it's not used anywhere * Makes QuotaStatusCode an enum class in preparation for converting it to a mojo enum (where it will be an enum class) * Updates the DEPS files for android_webview/browser to depend on WebKit/common/quota, since aw_quota_manager_bridge.cc uses QuotaStatusCode * Removes the dependency of QuotaStatusCode on WebStorageQuotaError - reversed the dependency * Added a TODO to remove WebStorageQuotaError and replace it with blink::QuotaStatusCode General strategy: * Renamed storage:: to blink:: for each value of the enum * Removed includes from files where the include was the only change (also removed includes of quota_types where it was being used to transitively include quota_status_code) * IWYUs where includes were previously missing; except in unit tests (where the include is transitive), and when interfaces are implemented (and the type is included from the virtual method decl) * Generally removed `using` declarations, except in files with 4/5+ uses, where they were added if not already there * Added visibility of WebKit/common to storage/ Bug: 781643 Change-Id: I7f31493dfee4934d5ed6e400e2c0723191549057 Reviewed-on: https://chromium-review.googlesource.com/821802Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#524331}
-
Andrey Lushnikov authored
This patch rebaselines test expectations for automapping-sourcemap and automapping-sourcemap-nameclash tests. BUG=659456 TBR=dgozman Change-Id: Icd635ad1e5da1369b168a91c752374675ca8d4f5 Reviewed-on: https://chromium-review.googlesource.com/828263Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#524330}
-
Kunihiko Sakamoto authored
This adds variants of PageLoad.Clients.MultiTabLoading.* metrics that are recorded only when there are >=2 (or >=5) inflight loading tabs. Bug: 792759 Change-Id: Ic1c8711d6424752dd80685b7740ec12fcc1c885e Reviewed-on: https://chromium-review.googlesource.com/826706Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Pavel Feldman authored
Bug: 790909 Change-Id: I80f47d2619ef1109ca9c60bf484f270db9d012e1 Reviewed-on: https://chromium-review.googlesource.com/826710 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#524328}
-
Andrey Lushnikov authored
The test was mocking time only partially: the window.performance.now() should be mocked as well. BUG=610464 TBR=dgozman Change-Id: If9c81662235e43ee2ffafef2ed772158f3a74968 Reviewed-on: https://chromium-review.googlesource.com/828443Reviewed-by:
-
Fady Samuel authored
In order to track bugs in the wild, this crash key reports the details of the invariants violation. Bug: 672962, 791154 TBR: danakj@chromium.org for trivial change to selection_bound.{h|cc} Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I344f91b92cf06f9eddebdc573df35a8de5b6920e Reviewed-on: https://chromium-review.googlesource.com/826166 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#524326}
-
Dave Schuyler authored
This CL adds a View in store link row that links to the extension home page as well as a link row for the Chrome Web Store page for the extension. Bug: 794286 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I06a8c078f0659adc3c69e6139133ec9cf6a81d9a Reviewed-on: https://chromium-review.googlesource.com/826473 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#524325}
-
Stuart Langley authored
In ui/base/Clipboard kMimeTypeText = "text/plain" In platform/clipboard/ClipboardMimeTypes kMimeTypeText = "text" When I onion souped the code I did not realize that these two constants with the same name had different values. The fix is to use platform/clipboard/ClipboardMimeTypes kMimeTypeTextPlain so we have the same value on both sides. A future cleanup might be to amalgamate these constants. Bug: 794517 Change-Id: I9631430bc6c232afc38f12dcfad6b78f683add0b Reviewed-on: https://chromium-review.googlesource.com/828320Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#524324}
-
Xianzhu Wang authored
I often copy flagged tests. This can be achieved by clicking "Flagged" then one of the copy buttons, but this is sometimes incovenient because - "Flagged" query is interuptive because it resets the current filters making it difficult to return to where I was working on before clicking it; - I often forgot to click the "Flagged" button before copying resulting all tests were rebaselined after pasting the list of tests into the command line. Now add a "flagged only" checkbox to indicate whether to copy all or just flagged tests. Change-Id: I6a30e5070c724718bb59766f0535153849320d76 Reviewed-on: https://chromium-review.googlesource.com/820682 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#524323}
-
Gyuyoung Kim authored
Member<> now supports const types. This CL removes an unnecessary const_cast in ScopedFocusNavigation and makes a Member<> const in SelectionModifier so we can do the same there. Bug: None. Change-Id: Ica178eed562e19f9042872d162b6b7f37ed51fe3 Reviewed-on: https://chromium-review.googlesource.com/826843Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#524322}
-
Kentaro Hara authored
Bug: 784252 Change-Id: Iaf2c709ddd12134382a621205d3b34b08474f86e Reviewed-on: https://chromium-review.googlesource.com/823863 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
-
Scott Violet authored
AFAICT these aren't necessary. BUG=none TEST=none Change-Id: Iacda5ff8e2fceebf921ad26d5f074fedb58cd607 Reviewed-on: https://chromium-review.googlesource.com/827538Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#524320}
-
Yuzu Saijo authored
This CL adds PrepareForLeakDetection in CSSDefaultStyleSheets which sets the members back to the constructor state in order to stabilize the number of resources for leak detection. Bug: 763280 Change-Id: Ia91831594c6607cf316967d2d4b841d274ca8a10 Reviewed-on: https://chromium-review.googlesource.com/826344 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#524319}
-
Vlad Tsyrklevich authored
Control Flow Integrity [1] indirect call (cfi-icall) checking can not verify that dynamically resolved function pointers call their intended function. To account for this, we place the function pointers in the various g_driver_* structs in ProtectedMemory, a wrapper for keeping variables in read-only memory except for when they are initialized. Once they are set they can not be tampered with since the memory is set back to read-only. The generated bindings in gl_bindings_autogen_*.cc are not aware of the fact that their implementation is held in protected memory, so instead of using base::UnsanitizedCfiCall() we mark the individual function stubs with __attribute__((no_sanitize("cfi-icall"))) to disable icall checks on the generated bindings since their function pointer calls are routed through protected memory. [1] https://www.chromium.org/developers/testing/control-flow-integrity Bug: 771365 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6bbf1b9a4122e1d00f6d2a365ae3730b4bb95a73 Reviewed-on: https://chromium-review.googlesource.com/770252 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524318}
-
chrome-release-bot authored
TBR=mmoss@chromium.org Change-Id: Idc3a60c9d0fd0acb533b35359b6139622054705b Reviewed-on: https://chromium-review.googlesource.com/828122Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524317}
-
Dominick Ng authored
This CL passes a local AppBannerControllerPtr variable into the callback sent through Mojo. This keeps the Mojo connection alive and removes the need to store an AppBannerControllerPtr member. BUG=None Change-Id: Id67ba09ee438f9b455a43d4c2b89b6f8f75b27a8 Reviewed-on: https://chromium-review.googlesource.com/828240Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#524316}
-
Chandan Padhi authored
Instead, |matched_output_device_id| will be used to fetch output audio parameters for the associated output device or to decide if remote audio tracks should be rendered to the associated output device. Bug: 793255 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic2954a6f6e99597c70b26abfb15a6c69d65b848a Reviewed-on: https://chromium-review.googlesource.com/822311Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Chandan Padhi (OOO Fri) <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#524315}
-
Mike Reed authored
Default action is for skia to invoke codecs, so gfx/blink need not provide them. Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I554452134b7e11d3ecb0f1a765cc57e8413d3116 Reviewed-on: https://chromium-review.googlesource.com/826502Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Peter Boström authored
Adds somewhat-compliant Harmony style to the translate bubble. This UI is in the process of being reworked, so minor issues may be allowed to fall through the cracks in the interrim. Bug: chromium:730521 Change-Id: Ic8274ad285e41ce7750c41caaeb67010fd9e153c Reviewed-on: https://chromium-review.googlesource.com/815292 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Cr-Commit-Position: refs/heads/master@{#524313}
-
Ke He authored
Tests shouldn't call the OverrideLocationForTesting() since the Geolocation core will be moved to //service/device. In this CL a common ScopedGeolocationOverrider implementation is moved to //device/geolocation/public/cpp, so it can be reused by multiple clients. The ui_test_utils::OverrideGeolocation() is not removed in this CL because it is still needed by UrlWithApiKey in GeolocationBrowserTest. We'll rewrite it as a Service-Unittest when moving geolocation-core into //service/device folder, and remove the ui_test_utils::OverrideGeolocation() then. BUG=788298 Change-Id: I43c029bb5e82058673e738138cdadf139a076ff2 Reviewed-on: https://chromium-review.googlesource.com/778488 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524312}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7773f988. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7715 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: worker-dev@chromium.org: external/wpt/service-workers TBR=leon.han@intel.com No-Export: true Change-Id: I5da69e16fc82bbdd607253872c995ee21d3adfca Reviewed-on: https://chromium-review.googlesource.com/828380 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524311}
-
Paul Jensen authored
It's useful to know the API version of a Cronet packaged release. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ib7fdd1a7ca16c4cbe363f8ef7dd2297fa8672299 Reviewed-on: https://chromium-review.googlesource.com/828386Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524310}
-
Matt Falkenhagen authored
This is needed for service worker since the flow is: 1) Blink sends //content the WebHTTPBody containing blobs. 2) //content makes a ResourceRequestBody where blobs are converted to data pipes. 3) //content sends the ResourceRequestBody back to Blink for service worker FetchEvent dispatch. It is converted to a WebHTTPBody with data pipes. Bug: 778878 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id260d34dcfd5457e0b4abf72d8e185728eed15a6 Reviewed-on: https://chromium-review.googlesource.com/771092 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Charles Harrison authored
This patch relands the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/821090 This is a small refactor that should have some performance wins. Now that PlzNavigate has launched, we should be dispatching our preconnects after the initial navigation request has gone out, not before. This is because frequently (especially on Android), dispatching preconnects tends to hog the IO thread, delaying the initial request. Note that this predictor is probably going away, but this CPU work is in the critical path of some other work I am planning on tackling. Bug: 792524 Change-Id: I03b058af249088f779dfb574c8552b32150bea2c Reviewed-on: https://chromium-review.googlesource.com/826783Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#524308}
-
Vladimir Levin authored
This patch enables img.decoding attribute. I2S: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/MbXp16hQclY R=chrishtr@chromium.org Change-Id: I4b4387d1582b72787687bdc68dd96ff0f3b6c134 Reviewed-on: https://chromium-review.googlesource.com/828273Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524307}
-
bsheedy authored
Adds a browser test equivalent of the framework that's been used in instrumentation tests for VR testing and ports over a simple WebVR presentation test as a proof of concept. Additional tests will be ported over in follow-up CLs. Bug: 780668 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id944f524e65056c15308a377e5c1260ce73e44ae Reviewed-on: https://chromium-review.googlesource.com/809804Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#524306}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: I6310554d4cdbc93cd6420398ecfe9e668059dd99 Reviewed-on: https://chromium-review.googlesource.com/826605Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#524305}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/f6e6be2da12a..a088365e2fac $ git log f6e6be2da..a088365e2 --date=short --no-merges --format='%ad %ae %s' 2017-12-14 halcanary SkBitmap::pixmap Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Ie875327cd0af9421ec128c7a25a1a11730b5c786 Reviewed-on: https://chromium-review.googlesource.com/828440Reviewed-by:
-
Devlin Cronin authored
Simplify the InstallVerifier::IsFromStore() logic to omit the migration logic. This previously said that extensions that were in any auto-updatable location with an empty update URL were considered as being from the store, but this is incorrect for policy-installed extensions. Instead, rely purely on the Extension::from_webstore() bit or the update url pointing to the webstore. Add unittests to verify the new behavior. Forked from proberge's patch at: https://chromium-review.googlesource.com/c/chromium/src/+/748775 Bug: 794219 TBR=dtrainor@chromium.org (c/b/downloads) TBR=zea@chromium.org (c/b/sync) Change-Id: Ie4357238078b4c3bf2fd180c6c0099fe1f5bd90e Reviewed-on: https://chromium-review.googlesource.com/826503 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#524303}
-
Leo Zhang authored
Views with padding listPreferredItemPaddingStart will crash on Android 4.1.*. Tested on Android 4.1.2 and 4.2.2. Bug: 792809 Change-Id: I007885ac549391c097e187d591107d6fea4c7cb4 Reviewed-on: https://chromium-review.googlesource.com/823650Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#524302}
-
Sammie Quon authored
Seperate the back button and app list button into separate elements. Draws the background in ShelfView::OnPaint. This fixes issues with ink drop and accessibility focusing not working correctly. Made changes to ShelfView focus search to accommodate this. Add back_button_unittest. Removed app_list_button/back button ink drop unittest which tested if different parts of the old app list button's ink drop acted different if different parts were pressed. Not needed as the two separate buttons' ink drops should work normally. Removed app_list_button rtl unittest as the buttons should be flipped normally by the views rtl handling. Test: ash_unittests *Shelf* *ApplistButton* *BackButton* Bug: 791638, 758402 Change-Id: I07bdd0b490ffb2619a13cebacf388e2e08190114 Reviewed-on: https://chromium-review.googlesource.com/761856Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#524301}
-
Iris Uy authored
This adds a switch so that an AuthServerWhitelist can be set in headless mode which enables Negotiate authentication for the whitelisted URLs. The switch is added to the HttpAuthPreferences for the HttpAuthHandlerFactory, which is set in the URLRequestContext. Bug: 741872 Change-Id: Iaeaefbf58ff21351b9830309faf4f017c14e7b17 Reviewed-on: https://chromium-review.googlesource.com/828321Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: Iris Uy <irisu@chromium.org> Cr-Commit-Position: refs/heads/master@{#524300}
-
