- 22 Nov, 2017 40 commits
-
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/acf2f3adbac0..465835d61f39 $ git log acf2f3adb..465835d61 --date=short --no-merges --format='%ad %ae %s' 2017-09-26 oetuaho Support arrays of arrays in the API Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I304fa4200d96a97657ea0c1c52ca391a97c9da92 Reviewed-on: https://chromium-review.googlesource.com/785510Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518631}
-
Tsuyoshi Horo authored
This CL removes v8-cache-strategies-for-cache-storage flag. When --v8-cache-options=none is NOT set, V8 code cache for JS file in CacheStorage is created when the JS file is executed in a page for the first time. Bug: 787687 Change-Id: Idc982b456742253c7f3f3b13dff5c301348564f2 Reviewed-on: https://chromium-review.googlesource.com/784530Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#518630}
-
tzik authored
This allows base::MakeRefCounted() on Blink, and converts FakeWebTaskRunner construction to use base::MakeRefCounted(), so that FakeWebTaskRunner can switch to the zero-started ref count. That is needed to switch it to a subclass of base::SingleThreadTaskRunner. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id8701c9cce10eea8a4d1254eee31c9e6ffc8ff5b Reviewed-on: https://chromium-review.googlesource.com/778500Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#518629}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/dd41194ca4d5..34afa0b1f71c $ git log dd41194ca..34afa0b1f --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If8e6709449d10219eeea10837e1e21e4e52bed71 Reviewed-on: https://chromium-review.googlesource.com/785610Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#518628}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/db97ff6e..3bc0f66e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ibfd26862dc1f60eaf86b4b9119d6c3f6b09d53af Reviewed-on: https://chromium-review.googlesource.com/785470Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#518627}
-
Philip Jägenstedt authored
LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/ and LayoutTests/external/wpt/navigation-timing/ have the same origin but have diverged slightly over time. https://chromium-review.googlesource.com/c/chromium/src/+/782419 shows what the interesting differences between the two copies were. metadata_cache in most of the tests were removed when the tests were initially added to web-platform-tests: https://github.com/w3c/web-platform-tests/pull/181 idlharness.html: It's OK to no longer test an instance of Window, that's being done in the hr-time test: https://github.com/w3c/web-platform-tests/pull/8388 test_timing_xserver_redirect.html: The bits around pageOrigin were removed in https://github.com/w3c/web-platform-tests/commit/234a672d023e8f57f3c78ca129788ca650242cc0. That assert was still failing in our own tests, but removing it is OK, using location.hostname is wrong as it doesn't include the port: https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-hostname Change-Id: Ic5c4151a3e309fee1894c72cd14d159bd314be20 Reviewed-on: https://chromium-review.googlesource.com/781684 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#518626}
-
Hajime Hoshi authored
This CL is just refactoring to avoid default arguments. We plan to replace base::nullopt with specific task types. Bug: 780785 Change-Id: I1369ac944fa49f6aed11a841d17011d1c3a1faf9 Reviewed-on: https://chromium-review.googlesource.com/781330Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518625}
-
Takashi Toyoshima authored
Since CORS related headers in services/network/public/cpp will be used also in Blink, these headers should not include cors.mojom.h, but do cors.mojom-shared.h insteads. We may revisit this when we need to depend on cors.mojom things that are not defined in the mojom-shared.h. But for now, we just disallow to depend on cors.mojom.h here. Also deps to //services/network/public/interfaces would be better to be public now. Bug: 787002 Change-Id: Icd475c7a5c304207a61421fb78a51a1ed4b3b912 Reviewed-on: https://chromium-review.googlesource.com/784743Reviewed-by:
-
Aleksandr Popov authored
Billing address field is no more disabled after adding a new billing address. There is also a small fix for CreateNewBillingAddress unit test: the phone number field is changed to match the expected format. R=anthonyvd@chromium.org Bug: 785666 TEST=Make clean installation of the browser (no credit cards and/or billing addresses should exist), then open: Press "Buy", then add a credit card; then add a billing address. The billing address combo box should become enabled, and one may select a billing address it it. https: //googlechrome.github.io/samples/paymentrequest/credit-cards/ Change-Id: I60f281b38feb849357ee0679167bb42f68db221e Reviewed-on: https://chromium-review.googlesource.com/774260Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#518623}
-
Hajime Hoshi authored
Bug: 780785 Change-Id: I19718d9ba39a3c883f2b7fab6470ae0b240caaeb Reviewed-on: https://chromium-review.googlesource.com/781541Reviewed-by:
-
Greg Thompson authored
r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG=639072,764415 This CL was uploaded by git cl split. R=finnur@chromium.org Change-Id: Ia165545395e8b1a2826508e759e11ce6777b7f1e Reviewed-on: https://chromium-review.googlesource.com/784939Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#518621}
-
Henrik Boström authored
So that this CL can land: https://webrtc-review.googlesource.com/c/src/+/17523 When SetRemoteDescription is overloaded, static_cast is necessary for base::Bind to be able to tell which signature to call. Bug: webrtc:8473 Change-Id: I93f7e5bdffd314978b3852a003a1e4a8912ff39d Reviewed-on: https://chromium-review.googlesource.com/749845Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#518620}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/37e489c985ca..dd41194ca4d5 $ git log 37e489c98..dd41194ca --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic8ffd3785e89781eb9c02af05badf8bdff106fe0 Reviewed-on: https://chromium-review.googlesource.com/785311Reviewed-by:
-
Yuta Kitamura authored
The callback argument of SignalQuery() is called only once, thus OnceCallback is more appropriate. This is a clean-up step before we replace repeating WTF::Function with base::RepeatingCallback. Bug: 771087 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7331cd594947bd051263febcdf27c6014a8623e1 Reviewed-on: https://chromium-review.googlesource.com/781603Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
Mihai Sardarescu authored
This CL display the regular sign-in error dialogues when a user signs in to Chrome via DICE: * Error dialog informing the user that the email pattern is not allowed as a primary account in Chrome; * Error dialog informing the user that the same account is a primary account in a different profile; This CL prefers duplicating some logic from the InlineLoginHandlerImpl for DICE instead of reusing it because when DICE is enabled the account is added present in the token service before sync is started. This CL also redirects the current tab to the NTP once the user successfully signed in to Chrome. Bug: 782634 Change-Id: Ic2eb0d528ff393fc49e15f46671b646fe9e28f36 Reviewed-on: https://chromium-review.googlesource.com/779430Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#518617}
-
Henrik Boström authored
The previous use of std::map made the track order "random" based on track pointer values. This fixes subtle bugs, one of which was detected in https://chromium-review.googlesource.com/c/chromium/src/+/753598/, where the stream.getTracks() track order became very flaky. It is likely this bug is already causing flakiness, but I was unable to repro outside of that CL. When this CL and the referenced CL lands we'll be able to remove the test from TestExpectations as a flaky test. But due to another flake, this CL is not enough to remove it from TestExpectations. The test in question: external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html Bug: 787461 Change-Id: I0d5450bf0534a2148818aa843404d6dd43ac5e0b Reviewed-on: https://chromium-review.googlesource.com/782321Reviewed-by:
-
Jan Krcal authored
This CL removes the feature flag and the command line switch for fetching icons for MostLikely tiles. This feature is fully launched. Bug: 695810 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iab0ff18f17c88aa1f32d4b1f750fccef143dd261 Reviewed-on: https://chromium-review.googlesource.com/781780Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#518615}
-
Bernhard Bauer authored
https://crrev.com/468591 avoided showing a supervised user interstitial over an existing one, but that only applies to committed navigations (where spurious callbacks can happen, and where canceling the existing interstitial might close the tab), and actually causes weird issues for non-committed navigations. Additional cleanup: Move from RepeatingCallback to OnceCallback for asynchronous checks, to make sure we run them once and only once. Bug: 760986,760540,b/69306583 Change-Id: I1da6447c47855d5dbc94c09151408f1d049399c6 Reviewed-on: https://chromium-review.googlesource.com/781768 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#518614}
-
Hajime Hoshi authored
Calling SingleThreadTaskRunner's PostTask instead of WebTaskRunner loses task type information (kJavaScript in this case), and the UMA for task types is confused. This CL fixes this to remove the indirection. Bug: 780785 Change-Id: I19cf843e336e9daf95bd0c697bf5a0cdf7e1ab87 Reviewed-on: https://chromium-review.googlesource.com/785114Reviewed-by:
-
Olga Sharonova authored
This reverts commit ee41ffee. Reason for revert: Bug: 787793 Original change's description: > cc: Run threaded LayerTreeTests with sync scheduling. > > Add an additional mode that runs multi-threaded LayerTreeTests with > sync/webview scheduling. > > R=danakj@chromium.org > > Bug: 787257 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: Ie2c12b772de6e992d1caa238159ea9bc2592ee2e > Reviewed-on: https://chromium-review.googlesource.com/783637 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518510} TBR=danakj@chromium.org,enne@chromium.org,khushalsagar@chromium.org Change-Id: Ibb83ff13c50a9c131ec9a8aefd8aa9bcd2df670e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787257 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/785390Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#518612}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0001378a..db97ff6e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1f012e178ef63d0383ff4b92be4139394818c3d5 Reviewed-on: https://chromium-review.googlesource.com/784990Reviewed-by:
-
Ivan Sandrk authored
Continuation of work on "locked fullscreen feature". In locked fullscreen mode we want to completely disable the context menu as a security measure. Details in a comment on the design doc: go/locked-fullscreen-mode/edit?disco=AAAABQ62qO8 Bug: chromium:755696 Change-Id: Ie92231506bf2293bc853e3a4a3be648004ac65a6 Reviewed-on: https://chromium-review.googlesource.com/779151 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#518610}
-
Mythri Alle authored
Remove: v8.browsing_desktop v8.browsing_mobile and rename: v8.runtimestats.browsing_desktop to v8.browsing_desktop v8.runtimestats.browsing_mobile to v8.browsing_mobile Bug: chromium:690921 Change-Id: I563e6a59b67d322dea0a41c501e70d12b15e8f01 Reviewed-on: https://chromium-review.googlesource.com/782279Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#518609}
-
Yannic Bonenberger authored
Bug: 755477 Change-Id: Ib2055bea28420629e59bd95c5fa0cd0bbf34cf7e Reviewed-on: https://chromium-review.googlesource.com/688616Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Greg Thompson authored
r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG=248683,764415 This CL was uploaded by git cl split. R=treib@chromium.org Change-Id: Ib5788e422101becf2c7c834c9d83df1c0a4e4551 Reviewed-on: https://chromium-review.googlesource.com/785012 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Marc Treib authored
With this change, a tile will also be highlighted when right-clicking its "x" in the top right. This was the previous behavior, but was broken by making the "x" keyboard-focusable in https://crrev.com/c/725659. While we're here, also remove the "-webkit" prefix from the CSS "filter" property, since Chrome doesn't need it anymore. Bug: 785215 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5b2451b2a33bbf021f2328fbec3733bc20d0f3ab Reviewed-on: https://chromium-review.googlesource.com/779122Reviewed-by:
-
Rune Lillesveen authored
Split the PASS text of the reference into multiple inlines like the test does. The reference did not match in Blink because of a text shaping bug: https://crbug.com/6122 Bug: 657748, 6122 Change-Id: If9894d45415a8f9ada80c2912abbd552a181b423 Reviewed-on: https://chromium-review.googlesource.com/784933Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#518605}
-
Roman Sorokin authored
Also makes fake_cryptohome_client loads install_attributes from the stub file. It's needed to use install_attributes in fake_authpolicy_client (which uses fake_cryptohome_client). After that would be landed we should point to different repo on the Chrome OS side for that file. TBR=mnissler@chromium.org Bug: 784858 Test: manual Change-Id: I1febe7c278a65ea6c8714875816c1f03e1d6b335 Reviewed-on: https://chromium-review.googlesource.com/768718 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#518604}
-
Dominik Röttsches authored
Tbr: asvitkine Bug: 785517 Change-Id: I406718042e7ee595a5597a80ebc8e8250f139a7e Reviewed-on: https://chromium-review.googlesource.com/784932Reviewed-by:
-
Hajime Hoshi authored
Bug: 780378 Change-Id: I69b5822d50b8cd1cbd281ab6486a40f7e459a091 Reviewed-on: https://chromium-review.googlesource.com/784656Reviewed-by:
-
Hiroki Nakagawa authored
This just cleans up referrer tests and doesn't change behavior. Bug: 773921 Change-Id: I790cb392d009792b469a1907c0f2e47da87a07b5 Reviewed-on: https://chromium-review.googlesource.com/784742Reviewed-by:
-
Alexandr Ilin authored
This CL contains three different changes that are independent but work together to improve page load timing benchmarks results. 1. Preconnect to the main page for all hint origins including HintOrigin::NAVIGATION. 2. Check for possible HSTS redirects before preconnecting. 3. Open minimum 2 sockets for the main page. This change requires a fair amount of plumbing to pass a number of sockets from LoadingPredictor to PreconnectManager. Bug: 699080, 784206 Change-Id: I5301a86989d1e2ecaa5197ebcec526e4d3bf4eae Reviewed-on: https://chromium-review.googlesource.com/778899Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518600}
-
Prashant Malani authored
For the purposes of this class, the semantics of circular_deque and std::deque are the same. Switching to std::deque will make this class easier to re-use outside of Chrome, by reducing its dependency on src/base/containers. BUG=chromium:701005 TEST=MIDI works on Chrome. Change-Id: Iae83c69ef85682fbde75e6078cd5eb262b9f4082 Reviewed-on: https://chromium-review.googlesource.com/784010 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#518599}
-
jdoerrie authored
This change removes the deprecated base::Value::IsType() in //components in favor of using is_{none,bool,...}() directly. Bug: 646113 Change-Id: Id03d55287eefbb262aa19da2a9eea01474901d06 Reviewed-on: https://chromium-review.googlesource.com/781663Reviewed-by:Colin Blundell <blundell@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#518598}
-
Vadym Doroshenko authored
1.getElementByNameWithParent is a generic function that's not used password_controller.js anymore, so common is the better place for it (it would also allow to test it). 2.isPassword argument is not needed anymore, so function is simpified. 3.Added a test for it. Bug: 782224 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ida9a6719f1533d36c4dd468100860046a0db809f Reviewed-on: https://chromium-review.googlesource.com/758402 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518597}
-
Darren Shen authored
Currently, StylePropertyMapReadonly.get/getAll/has are virtual functions so that they can be overridden by specific types of style maps (e.g. the computed style map). However, because the whole function is virtual, overriding it requires implementing the function from scratch. This means that there's a lot of logic being duplicated across different style maps (e.g. validation, converting CSSValues to style values). This patch makes get/getAll/has non-virtual. To override behaviour, subclasses just need to override two functions: const CSSValue* GetProperty(CSSPropertyID); const CSSValue* GetCustomProperty(AtomicString); This makes it very easy to define new style maps and significantly reduces amount of duplicate boilerplate code. Future patches will do the same thing for other methods on StylePropertyMap. Bug: 785132 Change-Id: Iae6e43684ff54a317bca0db6a0bf32629c298bc1 Reviewed-on: https://chromium-review.googlesource.com/770606Reviewed-by:nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#518596}
-
Alexandre Courbot authored
libva 2.0 is a major version upgrade, meaning that the library dlopen'ed by Chromium is renamed from libva.so.1 to libva.so.2. Due to the way ChromeOS is built, we may end up with a browser build against the old libva even after the sysroot is upgraded to the new version. For this reason we will keep both versions of the library on the system until all buildbots have caught up to the 2.0 upgrade. This patch makes Chromium capable of loading any of these two versions, by whitelisting the newly-introduced libraries on the rootfs, and loading the correct library depending on the version it has been compiled against. The old libva 1 paths will be removed once the buildbots have all caught up. BUG=chromium:785117 TEST=Made sure that the chrome binary and video_decode_accelerator_unittest were both finding and loading the right library. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3b24ffdd2ac9dcadacab2f3e10dbe62644e9ce01 Reviewed-on: https://chromium-review.googlesource.com/781324Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#518595}
-
Tatiana Gornak authored
This CL implements skeleton view for the autofill on-field popup. Every type of the autofill popup is displayed as a text row after this CL. The implementation is guarded with a feature. Screenshots of some popups are attached to the bug. This CL doesn't implement animation related to the popup, e.g. the row isn't hilighted when the mouse hovers over the row. The separator element isn't displayed. BUG=768881 Change-Id: Ib235a1b811ce0026428fdc03d1eba7f7be27fd0a Reviewed-on: https://chromium-review.googlesource.com/685237 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Hayato Ito authored
This fix is similar to https://chromium-review.googlesource.com/c/chromium/src/+/778648. virtual/incremental-shadow-dom/shadow-dom/nodetree-radio-node-list.html should be fixed with this CL, however, it still crashes due to crbug.com/787717. Once we can rewrite built-in elements so that they don't use Shadow DOM v0 feature, the crash would be gone. Bug: 776656 Change-Id: I0acde37be7688c9875cbbed633f3a527f91b66ed Reviewed-on: https://chromium-review.googlesource.com/784740Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#518593}
-
Christian Dullweber authored
Site engagement entries are currently included in the cookie counter. This creates an entry for every single site visited, which is especially confusing when cookies are turned off. Site engagement doesn't act like a cookie (it can't be read or written by a site), so this CL removes it from the counter. Bug: 782606 Change-Id: Ia0953b8a34b3899d19fe19af1da3c8ec21600f23 Reviewed-on: https://chromium-review.googlesource.com/774283 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#518592}
-
