- 20 May, 2020 40 commits
-
-
Ben Kelly authored
Bug: 960012 Change-Id: I4cb28adc3172adbd6ad9583e2a84393fad2bc750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209375Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#770814}
-
David Schinazi authored
This CL adds new events to record transport parameters, and implements the right QuicConnectionDebugVisitor calls to access the transport parameters. I've confirmed that they show up in netlog locally. R=nharper@chromium.org Change-Id: I297c57c594eea349b46e40654063e8c9140e39f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210783 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#770813}
-
François Degros authored
There is no need to mock hasSwitch since it doesn't seem to be used anymore, at least not in the code being tested. BUG=912236 TEST=browser_tests --gtest_filter="FileManagerJsTest.FileTasks" Change-Id: I78cba36159bc00074e18d635dc21ef64e7622d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206871Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#770812}
-
David Van Cleve authored
This change makes Trust Tokens configurable in two origin trial modes: - "Standard": issuance requires the "TrustTokens" origin trial (runtime_enabled_feature.json5) be active; redemption and signing don't - "Third party": all three operations require the trial be active This fairly complex configuration is motivated by the fact that we don't know whether we'll be running a standard origin trial or a third party origin trial [1], as the code for the latter has landed but not launched, so we need to be able to decide dynamically. This is implemented by gating all three Trust Tokens operations behind the same RuntimeEnabledFeature [2] and having a runtime check for the presence of the origin trial during issuance: - in "standard" mode, the RuntimeEnabledFeature is always on (so long as the corresponding base::Feature is; see below), so all three operations are always available, but issuance will fail in contexts without configured origin trial tokens; - in "third party" mode, the RuntimeEnabledFeature is left off even if the base::Feature is enabled: the Origin Trials framework will enable it, activating all operations, if there is an origin trial token. In both modes, we unconditionally require that the kTrustTokens base::Feature be enabled in order to execute any of the operations: if it's disabled, the Blink RuntimeEnabledFeature will start disabled and, additionally, the origin trial will not be permitted to activate (because of the new logic in OriginTrialContext). I wrote up a slightly longer description of the constraints and the implementation rationale: https://bit.ly/configuring-trust-tokens [1]: https://docs.google.com/document/u/1/d/1xALH9W7rWmX0FpjudhDeS2TNTEOXuPn4Tlc9VmuPdHA/edit [2]: The entry point for each operation is identical (e.g. you use the trustToken argument to RequestInit whether it's an issuance, redemption, or signing operation), so it's not possible to vary the "enabled or not" decision at an IDL level depending on the operation. Fixed: 1081739 Change-Id: I1e63f2c12a1e2a158011fa5e95676b48f36e38dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199910 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#770811}
-
yilkal authored
This cl adds an EDU coexistence information screen. A screenshot of the screen is here: https://drive.google.com/file/d/16DErhvB0RNawBqhfUqMuh9nIz0AgHLYV/view?usp=sharing Bug: 1082336 Change-Id: Ie02c67142f82c7aa90ba741acd6d7312c34594fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208087Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#770810}
-
Lei Zhang authored
This templatized class is only ever used for base::string16. Since that is the only string type it will be used with in the foreseeable future, remove the overhead of the template. Change-Id: I7a62e83ab612c1d7e7b2461a50bc7be7be0768f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207737Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#770809}
-
Minoru Chikamune authored
ClusterFuzz found null-dereference READ in scoped_refptr<mojo::SimpleWatcher::Context>::operator bool. This bug already existed before HeapMojo wrappers were introduced. We are not sure the root cause, but HeapMojo wrappers could sanitize the issue. Bug: 1049056, 1079286 Change-Id: I9f0fae6921024525891841bc942ac3a521a0a015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208780Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#770808}
-
Mohamed Amir Yosef authored
The underlying dropdown menu model already supports showing icons and secondary labels. This CL add such support to the combobox model. When an item is selected the main label is shown inside in the combobox together with the icon. Secondary labels are displayed only inside the dropdown menu. Bug: 1044038 Change-Id: Ibe3cc37464bfd8e416aeadec62827b8ca103d13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207386 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#770807}
-
Mikel Astiz authored
Change-Id: Ic33b2b06c13d57196a87e1e065502445da6a25a7 Bug: 1053232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210421Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
This CL moves some interfaces for context menu under chrome/browser/contextmenu and defines a new modularized target. This allows TabDelegateFactory class to chrome/browser/tab, and put |TabImpl.updateAttachment| back to Tab interface. Bug: 952703 Change-Id: Ie5534ce07c8e84593e6033141501e3f3a0ba4704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201796Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#770805}
-
Sophey Dong authored
Still haven't added the part to get the content types yet, so it is not hooked up yet. Instead, another method is added to provide all the options. Bug: 1079467 Change-Id: Ia6326db8d7aa01dab2690485f6891418b3f4d11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197524 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#770804}
-
Kenneth Russell authored
Unify the suppressions between WebGL 1.0 and 2.0 for: conformance/more/functions/readPixelsBadArgs.html conformance/more/functions/texImage2DHTML.html conformance/more/functions/texSubImage2DHTML.html conformance/textures/misc/origin-clean-conformance-offscreencanvas.html conformance/textures/misc/origin-clean-conformance.html Bug: 1082525, 1083100 Change-Id: Ic6cd0abb27ee434a4a5263264283a568d1d0ee23 Tbr: shrekshao@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209687Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#770803}
-
Kenneth Russell authored
Recent NDKs don't ship a gcc binary any more, so the detection of the NDK fails, even if specified via --ndk-dir. Bug: 1084750 Change-Id: I323cfdc04ecbeb53fde864d41f55bf3270ea33b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207577Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#770802}
-
kylechar authored
This is a reland of 40eb3bd7. Don't change use-vulkan tag to be vulkan since that's already used by ANGLE. Original change's description: > Fix GPU integration test tags > > Both [no-]skia-renderer and [no-]use-vulkan tags in GPU integration > tests were based on the command line. Code assumed that if there was > nothing on the command line then the feature was disabled which was > incorrect. > > Change the tags to be based on if the feature is enabled or not. Also > change use-vulkan to just be vulkan for brevity. > > Bug: 1069551, 1084569 > Change-Id: I33fdbfb4d8078127f066f4a86a267477e4e9e020 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209348 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770579} Bug: 1069551, 1084569 Change-Id: Ia9a816e18b0de283185ccda7c14e6e412fdf1eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210627Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#770801}
-
zhaoyangli authored
The assigned machine is in mac 10.14 so os can't be os.MAC_10_15. This is to fix the infra failures caused by this wrong config. bug: 1085198 Change-Id: Ia8a64508045f3fb7ee8b021d61f97faf7755ecba No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211043 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#770800}
-
Rune Lillesveen authored
Invalidation was done for :-webkit-full-screen, but not the standardized :fullscreen pseudo class. Issue created for making :-webkit-full-screen an alias: 1085151 Bug: 1082663 Change-Id: I17ce7da26158fe6ea37c02241938861658960f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209217Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#770799}
-
Mohamed Amir Yosef authored
Secondary labels are displayed below the labels of each menu item. This and the CLs in the same chain are introduced to support the use case in this mock: https://screenshot.googleplex.com/si2PPQSzV1w Bug: 1044038 Change-Id: I17535582c700ee83d95e077a15066542de13d925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208976 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Sammie Quon authored
They are converted later to unique ptr anyhow, so create them as unique ptrs. Also as I did conversion did some updates: 1) Remove duplicate code. 2) Remove dead code. Test: pass existing tests Bug: none Change-Id: I79f6bcb0a0898c7959d15db9c40dc0365657259c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208264Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#770797}
-
John Smith authored
This change moves the bulk of the Mac scrollbar drawing code into NativeThemeMac. This is done in order to bring this more into alignment with other platforms and to make it easier to transition things over to color pipeline. It contains changes to do this for both the views UI and web platform ui. CocoaScrollbarPainter is removed now that all of its previous responsibilities are in NativeThemeMac. Bug: 1056950 Change-Id: Iedc224b582a7bcbdf920ed4b58855b284bfd0f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195561Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Joan Barnett <johnsm@microsoft.com> Cr-Commit-Position: refs/heads/master@{#770796}
-
Tom Anderson authored
This CL adds a mechanism for making extension requests. A followup will add some usages of this feature. The usage should look like this: // The extension is nullptr if it's not present. if (connection->randr) connection->randr->GetScreenInfo({window}); BUG=1066670 R=msisov,sky Change-Id: I02f5b4bb6d6cee77442fa0edb19c54f36e66276b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209622 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Mario Sanchez Prada authored
This CL moves this message out of frame_messages.h and adds a new method in content::mojom::Frame to allow the browser request from the renderer the serialization of a RenderFrame's contents, regardless of whether such contents include same-site or cross-site resources. Since this functionality also requires an asynchronous response from the renderer once the serialization is complete, this CL does also migrate FrameHostMsg_SerializedHtmlWithLocalLinksResponse, for which some extra bit have been added to WebFrameSerializer[Client], so that we can appropriately reply to the browser process when the serialized data is available. In a future CL, this functionality will probably get moved down into Blink itself, but at the moment there's way too much functionality in use in Blink's public API, so this CL does not tackle that part yet, and focused on the migration from legacy IPC to mojo only. Bug: 1044088 Change-Id: I4ce5b3cfe795e5019bb30a278577ec2be3ee2854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207234 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#770794}
-
Artem Bolgar authored
We are getting a crash in org.chromium.ui.base.WindowAndroid.setPreferredRefreshRate because getWindow() returns null and there is no nullcheck there. getWindow() CAN return null when there is no activity (and this is exactly our case, Oculus Browser is not using Activity). There are getWindow() nullchecks in other methods of WindowAndroid, but not in setPreferredRefreshRate which looks as oversight. Bug: 1085160 Change-Id: I6cbeac08787f9664abd4fdb2e619e100a09fa943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210673Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770793}
-
Tarun Bansal authored
Turns out the array object could be null in some cases. This CL adds a check for null array object and returns earlier in case it's null. Bug: 1084755 Change-Id: I9cb7f5f5e2b4fb724dca76bad3e0c558dc6b1d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209514 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Swapnil authored
The browsertests of URL blacklist policy are moved from policy_browsertests to a separate file. Bug: 1084512 Change-Id: I20258570e63d0ddc6b07435f2a75b25195e3af70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207207 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770791}
-
Moe Ahmadi authored
Tests cover the functionality added in: -crrev.com/c/2194472 -crrev.com/c/2199361 Also fixes bugs and issues that came up while writing the tests: -Restores previous selection, if any, and if no match is selected by default. -Remove and Toggle buttons can be triggered by pressing 'Enter' and 'Space'. -Removes isTrusted check for mouse and keyboard events. This is not necessary and not commonly done in WebUI and makes testing complicated. Bug: 10846603 Change-Id: Id0274fa9a420a6e097a8f63538571498fd3e1d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194275 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770790}
-
David Tseng authored
Mostly speculative; pass with testing/xvfb.py out/d/browser_tests --gtest_filter=ChromeVox*.NavigationSyncsSelect !! & !! & !! & !! & TBR=dtseng@chromium.org Fixed: 976105 Change-Id: Ieb646dd0ab22d4b45f2355c89542a59c51af5888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209684Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#770789}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a0139c0aa3d4..008b71ab1384 2020-05-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I4bef4acf028f3235f72ad477d67f5542831f42db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770788}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1589990279-037dea0eb6fc46c134bcb3d90d9f61194c559337.profdata to chrome-mac-master-1590004011-c7e121da0d5a86abd485d92fadbd2d4beb7d781b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9fe48bd86c151a1f58a500ade7ac5c7221573e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210905Reviewed-by:
-
Brian Sheedy authored
Enables the standard "gpu_telemetry_tests" set of tests on the GPU CrOS builders and suppresses found failures. Bug: 1080424, 1084796, 1084794, 1080375 Change-Id: Ie7a8fe63bb478395e3524aeccc9584456d13daaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209398Reviewed-by:
-
Dave Tapuska authored
The viz::RenderPassDrawQuad's render_pass_id is a RenderPassId which is a uint64_t as is the mojom value. The struct trait although narrowed it to an int32_t. BUG=1082889 Change-Id: Ic2c851d40c46a7c5156209210285fb2961b1b20a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210791Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#770785}
-
Robbie McElrath authored
This CL fixes the following Site Settings issues in WebLayer: * Fix launching system settings from certain links * Apply themes to the UI, copied from Chrome's * Hide unsupported settings categories * Finish implementing pref-based settings * Properly handle multiple settings instances by closing one Bug: 1049683 Change-Id: I9c8afa1b5a8faa9d2429d6c34b171225cc5f5af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209598Reviewed-by:
-
James Cook authored
This was added for mustash, but isn't used anymore. Bug: none Change-Id: Ib822df1f0760aa38b038305f5e3f8271b76f976c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209681 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
inglorion authored
When first introduced in crrev.com/c/2067858, we limited parallelism for ThinLTO code generation on Goma, with the intent to ramp it up as load permitted. We believe it is safe to increase to 200. In some test builds I performed, this reduced chrome binary link time by about 15%. Bug: 1027456 Change-Id: I4b86570a1b726d9b1faf6b9fa1d3249687b3f32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194842Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#770782}
-
Lukasz Anforowicz authored
Google C++ Style Guide [1] is neutral on this subject, but asks to be consistent with surrounding code: Note that the C headers such as stddef.h are essentially interchangeable with their C++ counterparts (cstddef). Either style is acceptable, but prefer consistency with existing code. Most of Chromium uses <stddef.h> and this was confirmed in a 2019 discussion on cxx@chromium.org [2], so let's switch checked_ptr.h to use <stddef.h> instead of <cstddef>. [1] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes [2] https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/cxx/Bc1XyEL9pp4/Ie4C-_AjCAAJ Bug: 1073933 Change-Id: I8a844e32fd5f1ced327932e8cfd27bc6555a4cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209603Reviewed-by:danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#770781}
-
Asanka Herath authored
Until C++17 a static constexpr member variable needs a definition. Without this, kEntryNameHash members and similar metrics name hashes can't be odr-used (ill-defined). So now generated UKM builders .cc files will go from (only modified snippet shown for a sample event): const char Identifiability::kEntryName[] = "Identifiability"; to: const char Identifiability::kEntryName[] = "Identifiability"; const uint64_t kEntryNameHash; And similarly for metrics hashes. While we are here, this CL cleans up the include header so that it doesn't include a double //. I.e. This: #include "services/metrics/public/cpp//ukm_builders.h" Becomes this: #include "services/metrics/public/cpp/ukm_builders.h" Bug: 973801 Change-Id: Icfd234ef953f2cefee5376803be266a2321df020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203767Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#770780}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Bug: 1084509 Change-Id: I48fcfdf1fd570e328289f801386fc10dab284808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211045Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770779}
-
David Schinazi authored
This feature never worked as advertised. IPv4-mapped addresses are a host-only concept. They never appear on the wire. For example, if I open a TCP socket to IPv6 address ::ffff:1.2.3.4 and port 443, my device will send out an IPv4 packet with destination address 1.2.3.4. It will not send an IPv6 packet. IPv4-mapped IPv6 addresses exist to allow applications to only use IPv6 but still work on IPv4 networks. More details here: https://tools.ietf.org/html/rfc4038#section-4.2 R=zhongyi@chromium.org Change-Id: I4e9f349c1753aaab19dbaf040fa5d40a6a1740d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204826 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770778}
-
Alexander Timin authored
When test tracing is enabled, by default browser tests generate a file name based on the test name. However, when a test a parametrised, it has slashes in its full name (e.g. All/Foo.Bar/0). Replace slashes with underscores to ensure that we don't fail to actually write a trace file to the file. R=sky@chromium.org Change-Id: I8073e0dbd925b9c35e97dd7f6726b6b5b9210d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207376 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b19e9782ebef..ab2265ec86ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sebsg@google.com,kmilka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1068160,chromium:1077221,chromium:1083995 Tbr: sebsg@google.com,kmilka@google.com Change-Id: I76366a3169787c5c88fa8c17cfc680192fb9192e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210667Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770776}
-
Jesse Schettler authored
Remove CreateStatefulPartitionResult() since it is unneeded. Also, explicitly set relevant policies to ensure they are tested. Bug: None Change-Id: Ic81c99c34e357fb9978081b2337deb9fd96da323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209595 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#770775}
-
