GitLab

All html_viewer entry points now have Mojo C thunks.

R=piman@chromium.org
BUG=453591

Review URL: https://codereview.chromium.org/1035813002

Cr-Commit-Position: refs/heads/master@{#322275}

This patch modifies the wallet datatype to always have a datatype controller,
and give that datatype controller the responsibility of enabling and disabling
the datatype as necessary. If the sync experiment pref is disabled, the datatype
will not start up, and if it's already started will turn itself off. Similarly, if the
experiment is enabled, the datatype is capable of starting itself up.

BUG=470362

Review URL: https://codereview.chromium.org/1024553010

Cr-Commit-Position: refs/heads/master@{#322274}

R=nednguyen@google.com
BUG=453131, 455292

Review URL: https://codereview.chromium.org/1029423002

Cr-Commit-Position: refs/heads/master@{#322273}

Ensure that the DXVA decoder for VP8 and VP9 picks up the path for the HMFT correctly on non WOW64 environments

The DXVA decoder incorrectly assumes that the ProgramW6432 environment variable exists on vanilla 32 bit Windows
OS'es which is not the case. This causes the HMFT load to fail.

Fix is to only use the DIR_PROGRAM_FILES6432 directory type for a WOW64 environment which is 32 bit chrome on a 64
bit OS. In the normal case we use the vanilla DIR_PROGRAM_FILES type.

BUG=470193

Review URL: https://codereview.chromium.org/1031263002

Cr-Commit-Position: refs/heads/master@{#322272}

BUG=470393

Review URL: https://codereview.chromium.org/1018353003

Cr-Commit-Position: refs/heads/master@{#322271}

BUG=309849

Review URL: https://codereview.chromium.org/1038743002

Cr-Commit-Position: refs/heads/master@{#322270}

Currently any overlay ContentViewCore added to the Tab is
automatically added to the Tab CC layer.

This CL introduces a new parameter to allow romaing overlays.

BUG=453121

Review URL: https://codereview.chromium.org/1026983002

Cr-Commit-Position: refs/heads/master@{#322269}

The viewport is made up of two scrolling layers now, the inner
and outer viewport scroll layers. These layers do not follow the
usual scroll bubbling logic since they're supposed to appear as
one viewport to the user (i.e. we should rail). Forcing it to
be scrolled via LayerTreeHostImpl::ScrollBy caused that method to
become increasingly complex.

This patch creates a Viewport class that allows LTHI::ScrollBy to
call Viewport::ScrollBy and scroll the viewport as a unit. I've
tried to simplify the logic in both these methods as much as I
could without changing behavior.

BUG=443724

Review URL: https://codereview.chromium.org/986443003

Cr-Commit-Position: refs/heads/master@{#322268}

BUG=470647

Review URL: https://codereview.chromium.org/1006583003

Cr-Commit-Position: refs/heads/master@{#322267}

The refactor in https://codereview.chromium.org/23983047 removed a
trace event that monitored y scroll offset. This CL restores that event.

BUG=468304

Review URL: https://codereview.chromium.org/1013753014

Cr-Commit-Position: refs/heads/master@{#322266}

This is a stub for now; eventually it will report invalid certificate
chains on SSL interstitials to a server endpoint. Right now it logs the
report but doesn't actually send it anywhere. The checkbox is
tied in with Safe Browsing Extended Reporting.

BUG=461588

Review URL: https://codereview.chromium.org/935663004

Cr-Commit-Position: refs/heads/master@{#322265}

Also change some logging to VLOG. To see logs, use --vmodule="*/autofill/*=2" --enable-logging=stderr

BUG=470232

Review URL: https://codereview.chromium.org/1016033009

Cr-Commit-Position: refs/heads/master@{#322264}

In this change:
- Add AttachmentStoreForSync class. It has functions that will be called by AttachmentServiceImpl to manage sync’s references to attachments.
- Change AttachmentServiceImpl to call those functions. The rule is that for all attachments that we start uploading call AddSyncReference, for all attachments that we no longer upload (for whatever reason) call DropSyncReference.

Couple of notes:
- There is no storage implementation for those functions, it will come in the next change.
- There is growing confusion between AttachmentIdSet and AttachmentIdList. I’ll resolve this next week in a separate change.

BUG=457735
R=maniscalco@chromium.org
TEST=No user facing behavior. Change covered by sync_unit_tests.

Review URL: https://codereview.chromium.org/1002263005

Cr-Commit-Position: refs/heads/master@{#322263}

Add error message text label between CVC input row and Verify/Cancel
buttons. Error messages passed to
CardUnmaskPromptViewBridge::GotVerificationResult() are displayed.

Dialog will re-layout to fit entire message if a multiline message is
set. Previous to this CL the layout was done exactly once per dialog,
upon dialog creation. This CL refactors the layout code out into
-performLayout and calls it whenever the error message text changes.

Screenshot attached to bug: https://code.google.com/p/chromium/issues/detail?id=448572#c14

BUG=448572

Review URL: https://codereview.chromium.org/1024553004

Cr-Commit-Position: refs/heads/master@{#322262}

BUG=470630
TEST=none
R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/1031203002

Cr-Commit-Position: refs/heads/master@{#322261}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/114912d..9c59ebc

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1030273002

Cr-Commit-Position: refs/heads/master@{#322260}

BUG=339912

Review URL: https://codereview.chromium.org/1036913002

Cr-Commit-Position: refs/heads/master@{#322259}

The histogram was used for the 64bit transition. Is it no longer useful.

BUG=

Review URL: https://codereview.chromium.org/1030253003

Cr-Commit-Position: refs/heads/master@{#322258}

To narrow down LowBox/AppContainer launch issue reporting UMA on specific create process error code.

BUG=468922
R=jschuh@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/1020863012

Cr-Commit-Position: refs/heads/master@{#322257}

The previous fix to detecting page transition types was wrong, but close
enough to correct that it seemed right when I tested it.  I realized it was
wrong when reviewing some other history-processing code today.

(The only places where it was wrong were places that had the same bits set
or more as PAGE_TRANSITION_TYPED: i.e., PAGE_TRANSITION_AUTO_SUBFRAME,
PAGE_TRANSITION_GENERATED, PAGE_TRANSITION_FORM_SUBMIT, and
PAGE_TRANSITION_KEYWORD.  None of these other page transition types
typically make it into HQP in-memory index, which is I why I didn't notice
the effect of my incorrect fix.)

BUG=369989

Review URL: https://codereview.chromium.org/1030913002

Cr-Commit-Position: refs/heads/master@{#322256}

This simplifies the python closure compiler infrastructure.

R=rothwell@google.com

Review URL: https://codereview.chromium.org/476453002

Cr-Commit-Position: refs/heads/master@{#322255}

For testing background usage of Chrome on android devices.

BUG=

Review URL: https://codereview.chromium.org/1004833003

Cr-Commit-Position: refs/heads/master@{#322254}

Experiments should be set up/defined on the Finch server, not in Chromium
code. Remove the definition.

BUG=441377

Review URL: https://codereview.chromium.org/1024493003

Cr-Commit-Position: refs/heads/master@{#322253}

Also add a new, prettier checkmark asset. (It doesn't appear this is actually used anywhere else, so no other UIs should be affected.)

BUG=none

Review URL: https://codereview.chromium.org/1005603003

Cr-Commit-Position: refs/heads/master@{#322252}

INTERNAL => try again
anything else => permanent failure

BUG=463291

Review URL: https://codereview.chromium.org/1028313006

Cr-Commit-Position: refs/heads/master@{#322251}

BUG=466848

Review URL: https://codereview.chromium.org/1016473003

Cr-Commit-Position: refs/heads/master@{#322250}

BUG=

Review URL: https://codereview.chromium.org/1032553008

Cr-Commit-Position: refs/heads/master@{#322249}

This does not move all of the previously static methods into the interface yet, just those used by WebEncryptedMediaClientImpl. The rest can be migrated as necessary.

This CL also includes a fixes for 457384 and 374751 (containers and codecs must match media type), because it was convenient along with the new interface for checking codec support.

BUG=468912,457384,374751

Review URL: https://codereview.chromium.org/1023863002

Cr-Commit-Position: refs/heads/master@{#322248}

Previously, webpagereplay stores all the stdout & stder of the wpr subprocess to
a fix log file path location. It then parses the log lines to get replay server
port  assignment. When there are multiple telemetry processes running in parallel,
this cause a concurrency problem.

This patch addresses the issue by create a temp location for the log file path.
This is to make sure that different telemetry processes will write & read to different
log files.

BUG=469296

Review URL: https://codereview.chromium.org/1025553008

Cr-Commit-Position: refs/heads/master@{#322247}

To facilitate landing actual QuicServer support in Chromium using
Chromium's MessageLoop and friends.

Merge internal change: 89526581

Review URL: https://codereview.chromium.org/1006193003

Cr-Commit-Position: refs/heads/master@{#322246}

This is a retry CL after making these tests ChromeOS-only tests and disabling them in the official build.
Original CL: https://codereview.chromium.org/1026513005/

In order to avoid future regressions on ChromeOS.

BUG=469235
TEST=interactive_ui_tests --gtest_filter=AcceleratorInteractiveUITest.*

Review URL: https://codereview.chromium.org/1005093004

Cr-Commit-Position: refs/heads/master@{#322245}

This class write the
Net.SocketIdleTimeBeforeNextUse_ReusedSocket
Net.SocketIdleTimeBeforeNextUse_UnusedSocket
Net.SocketInitErrorCodes
Net.SocketRequestTime
Net.SocketType
histograms.

This histograms are all unowned, and have a large cumulative load on user bandwidth and internal google servers.
Are these histograms used at all? It appears they have not been used for some time (based on lack of ownership)

BUG=469288

Review URL: https://codereview.chromium.org/1027693004

Cr-Commit-Position: refs/heads/master@{#322244}

If you are not signed into sync or have unchecked "Autofill" then the option should be hidden.

BUG=468987

Review URL: https://codereview.chromium.org/1020303007

Cr-Commit-Position: refs/heads/master@{#322243}

BUG=NONE
TEST=NONE
NOTRY=true

Review URL: https://codereview.chromium.org/1006373006

Cr-Commit-Position: refs/heads/master@{#322242}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aa09e3e..862b1f1

TBR=jchaffraix@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/1034763003

Cr-Commit-Position: refs/heads/master@{#322241}

BUG=466848

Review URL: https://codereview.chromium.org/1004933003

Cr-Commit-Position: refs/heads/master@{#322240}

Review URL: https://codereview.chromium.org/1032913002

Cr-Commit-Position: refs/heads/master@{#322239}

BUG=466848

Review URL: https://codereview.chromium.org/1032553009

Cr-Commit-Position: refs/heads/master@{#322238}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c5443d75..b09c6a7d

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1005693012

Cr-Commit-Position: refs/heads/master@{#322237}

Clean up ClearObsoleteWallpaperPrefs() function. It was used to migrate wallpaper data from a very old version of Chrome (probably M32). It should be safe to remove this function now.

BUG=171694

Review URL: https://codereview.chromium.org/1003363008

Cr-Commit-Position: refs/heads/master@{#322236}