- 26 Oct, 2020 1 commit
-
-
chrome://media-appTrent Apted authored
More accurately, this just hides the codepath that would redirect files sniffed as "image/tiff" back to the old gallery app if the file had an extension matching a known RAW image format. (chrome://media-app was already a handler for "image/*", so logic was needed to exclude RAW). However, it also adds explicit extension-match file handlers to the web app manifest to handle cases where sniffing is not done. Initially tried sharing the logic that drives `IsRawFile()` in the files app's file_tasks but that's not really compatible with the web app manifest, and `IsRawFile` can just be deleted soon. Encapsulate IsRawFile() to make that removal easier: nothing outside file_tasks.cc uses it since r777758. The logic is put behind a base::Feature, but not a chrome://flag: usage of this is low and the change is low-risk. And flipping chrome://flags#media-app also works to use the old gallery for these file types. Bug: 1030935, b/154062029 Change-Id: I4779f76fa81800ffef316748cb94e12534b38775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494404Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#820645}
-
- 25 Oct, 2020 39 commits
-
-
Jinsuk Kim authored
This reverts commit e1fcf7ac. Reason for revert: identified as culprit for crbug.com/1141360 Original change's description: > Toolbar: Remove dependencies on NewTabPage > > With this CL, toolbar/ classes are free of dependencies on > chrome/browser/ntp. A new interface NewTabPageDelegate plus its > implementation in ToolbarManager replaces the references to > NewTabPage. Dependencies on static URL util methods in NewTabPage, > NativePageFactory were addressed by moving the methods to > modularized targets - components/embedder_support/android:util_java > and chrome/browser/ui/native_page, respectively. > > Bug: 1127732 > Change-Id: I8619db6454b1aa274328a3a243b977cbd87aac02 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467578 > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819204} TBR=fgorski@chromium.org,tedchoc@chromium.org,mdjones@chromium.org,jinsukkim@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1127732, 1141360, 1141362 Change-Id: Ib77ad0c85d2b7313954729110f3510f096fd4d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495501Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#820644}
-
mlcui authored
Most shortcuts in the shortcut viewer use one of four strings, representing a single key with 0-3 modifiers. This is currently hard-coded with the shortcuts. This CL refactors that to automatically determine the correct string based on the number of modifiers, eliminating the need to specify the shortcut string for most shortcuts. This refactor is intended to make way for having a runtime-determined number of modifiers for a given shortcut, as #new-shortcut-mapping changes shortcuts involving Shift - for those shortcuts, we need to display the shifted key instead of Shift + unshifted key. Bug: 1139080 Change-Id: I8bb2c71a31fb1eb546aee88d6690990afd6c2f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494205 Commit-Queue: Michael Cui <mlcui@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#820643}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Idf6f275f69fafa8099690427e0d794b6f1357ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820642}
-
Darren Shen authored
Add Mojo and protobuf messages for Chrome to send an event the IME service when the composition is canceled. Bug: 1019541 Change-Id: I7077586d8df4e094300651aa81ac6be73ed7b0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483946 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#820641}
-
Melissa Zhang authored
This CL overrides AccessibleWindowRole to |kDialog| because BubbleDialogDelegateView sets it to |kAlertDialog|. |AlertDialog| triggers screenreaders to repeat the whole of the |sharesheet_bubble_view| which is undesirable behaviour that is resolved with |kDialog|. Bug: 1140272 Change-Id: Ie42811cc95a39af5f12268314117a6dc9ea189a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494190 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#820640}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 890f5cbb. With Chromium commits locally applied on WPT: 44931e57 "[webauthn] Move large blob tests to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I545d74c5bed07d17fe63a65458d2dbc5c0464903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497143Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820639}
-
Nicholas Hollingum authored
We add a BorealisAppLauncher class with associated tests, and hook this class into the BorealisApps service. This needed minor refactorings of the BorealisContext. Bug: b/162562622 Change-Id: I3b6bc49b6d494fef4f8a03810048ceb3fd9122b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485998 Auto-Submit: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#820638}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea39f9199c12..16b096af4c82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I27787c2959539c582c7923bee4991f091a73e129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497530Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820637}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7a0263547cda..9e3eec5464d6 2020-10-25 jmadill@chromium.org Revert "Vulkan: Make DescriptorPoolHelper a Resource" 2020-10-25 jmadill@chromium.org Skip flaky tests on Win7/NVIDIA/GLES. 2020-10-25 jmadill@chromium.org Adjust TestSuite test timeout values. 2020-10-25 jmadill@chromium.org Re-land "Link C++ histogram support into angle_perftests." 2020-10-25 lehoangq@gmail.com Metal: Fix 2D array texture's robust resource init 2020-10-25 lehoangq@gmail.com Metal: Implement sampler object & shadow compare mode 2020-10-25 m.maiya@samsung.com Check for precision match of uniforms only if there is static use 2020-10-24 jmadill@chromium.org Expand Mac XFB suppression. 2020-10-24 jmadill@chromium.org Suppress failing Windows 7 test. 2020-10-24 jmadill@chromium.org Disable timing out Vulkan GLES 1 test. 2020-10-24 lehoangq@gmail.com Metal: Partially implement EXT_debug_marker 2020-10-24 lehoangq@gmail.com Metal: Implement glRenderbufferStorageMultisample(ANGLE) 2020-10-24 lehoangq@gmail.com Metal: Support integer textures. 2020-10-24 syoussefi@chromium.org Vulkan: Dirty pipeline and desc set after mid-RP clear with draw 2020-10-24 syoussefi@chromium.org Vulkan: Assert that attributes in shader info map are active 2020-10-24 timvp@google.com Fixes to roll ANGLE into AOSP 2020-10-24 jmadill@chromium.org Tests: Remove standalone duplication. 2020-10-23 timvp@google.com Revert "Link C++ histogram support into angle_perftests." 2020-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e203e4bc to 4787c9ad (240 revisions) 2020-10-23 jonahr@google.com Suppress VUID-vkCmdDraw-None-02698 validation 2020-10-23 jmadill@chromium.org Test Runner: Only run watchdog in child processes. 2020-10-23 jmadill@chromium.org Vulkan: Refactor how finishToSerial() retires commands. 2020-10-23 syoussefi@chromium.org Vulkan: Drop RelaxedPrecision from aliased attributes 2020-10-23 cnorthrop@google.com Vulkan: Reduce scope of clear workaround 2020-10-23 jmadill@chromium.org Make capture replay tests exectuable. 2020-10-23 jmadill@chromium.org Vulkan: sRGB cleanups. 2020-10-23 jmadill@chromium.org Trace Tests: Print trace download progress. 2020-10-23 timvp@google.com Vulkan: Make DescriptorPoolHelper a Resource If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1141040 Tbr: jonahr@google.com Test: Test: AOSP PresubmitTest: Test: GLES1ConformanceTest.AmbLight/ES1_VulkanTest: Test: MultithreadingTest::MultiContextDrawSmallDescriptorPools()Test: Test: angle_perftest --gtest_filter="*free_fire*" Change-Id: I3be39a3e94e32f78a18d3e330624cf9b15d08d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497505Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ic64536f90ae1407de1df47faf4c706853449e6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497142Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820635}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d4f7a4502b07..ea39f9199c12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I2145200659ad3571f628234926299229c366409e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497512Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603623202-14ac2c6cb0d89a9ecbecb2436c9610301e837409.profdata to chrome-linux-master-1603646058-2e9f14b5d7fb706e5b9950a1952473f3aa55ccc4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ief363801248b8199af6bafeefce27bfe31b29c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497514Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb535d73. With Chromium commits locally applied on WPT: 44931e57 "[webauthn] Move large blob tests to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I293bd8b1a16c3d8c20f24bb051df5c8be02fea0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497141Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15125e3533d7..d4f7a4502b07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ifd35a7bbf865b26b2594d69af39b5cecf5372b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497501Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4280.20-1603100572-benchmark-88.0.4300.0-r1 to 88-4280.20-1603100572-benchmark-88.0.4303.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie702e7b35f9e97a18f112c9379cdffc74654bf3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497509Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4280.20-1603104419-benchmark-88.0.4300.0-r1 to 88-4280.20-1603104419-benchmark-88.0.4303.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I358987b0dd290f5b10c223bca6e1af11160c2a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497225Reviewed-by:
-
Xianzhu Wang authored
Change-Id: I55e77f96e7be7c554cd00e6e07c9720763e83f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496288Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820628}
-
Peter McNeeley authored
Recent changes by magchen have given us the ability to correctly identify quad damage on a per quad level. Here we evaluate this data and marshal it into the OverlayCandidate. In the case of underlays the damages provided by 'SurfaceDamageRectList' are not enough. To determine actual visible damage, the opaque but non-damaged quads also need to be taken into account. The function SetOccludedDamageEstimate subtracts the occluding damage area from these opaque quads giving a very good approximation of the total visible damage area for this OverlayCandidate. Finally this damage information will be used in a later phase of overlay selection to make heuristic determinations on which candidates to promote. Change-Id: I64188066f96e4f0667791d8c0144ae3687979b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485513Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#820627}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1603570785-5714ab571043b20e62d7021352e7cf86f5390b23.profdata to chrome-win32-master-1603613972-73699eb7c90ca72304abe78e4e06ee3df85b698a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic521d8a41f8eb420feff5d9d828c89deb1bc80c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496751Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 88-4280.20-1603104419-benchmark-88.0.4296.6-r1 to 88-4280.20-1603104419-benchmark-88.0.4300.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4b330886199a6597f2f5ab2f54da387317c10ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497309Reviewed-by:
-
David Bienvenu authored
Also fixes some lint warnings; no functional changes. Bug: 1010217 Change-Id: Ib414a3a5979e94fbd6262fce48dfdb89da2f7960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493834 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#820624}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ac611446f4e..15125e3533d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I5c49ade83cee8a31c486b508277cb6d42f13ff89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497302Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I87af38849595c650fcd3d892b4cc9c6aa74c0558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497307Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic51571beed894d7b475d7f9d0c8a2adf9caa3fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497320Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010250700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/8FLJniKLOIvgXmnehF5KQa4m-kep06p-rTGFZXejsuoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I9838d268c99500b20e7237a33c441e1c9e0e9834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497099Reviewed-by:
-
James Cook authored
Crosapi changes are unusual in that they are less security sensitive than most IPC changes (since ash and lacros run at the same level of privilege) but more sensitive to version skew issues. Given these unique constraints we're going to let a few non-security-team owners review small, less-security-sensitive changes. Larger changes will be escalated to the security team. See go/lacros-mojo-security-review Bug: none Change-Id: I3d39cd910ba527020d9d234b8b2bc0ab8f397027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495509 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#820619}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1603570785-c5f650ffcd8ebc6a1ff7150f2b7e9994dbc992e1.profdata to chrome-win64-master-1603613972-3db8d0e06abb7812d76b308af9c886af81f88ed1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f0305377bf1718d18c3421c6f13a3702c0fb6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497200Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603605132-ab0d20de15b3555bfa0dd3f16926df8f867dc44c.profdata to chrome-linux-master-1603623202-14ac2c6cb0d89a9ecbecb2436c9610301e837409.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3ec03dfcc50518c65f401b2608590005db94be50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497205Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aac4971071eb..0ae6879b52fc 2020-10-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If5410376dff16aad718d0b7d377c0d911374953e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497201Reviewed-by:
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. This is the minimum change for chromium-side attestation flow to support ECC key type. As for implementation details, it is chosen to let the AttestationFlow object to hold a constant key type instead of being flexible when calling GetCertificate. The reasons are 1., we don't have the needs to specify key type with a single attestation flow instance, and it requires the key type passing through almost the entire attestation flow. It implied more code change, but also implies impact to readability because we already use "key type" terminology to refers to the type of EMK/EUK in this class; more presence of overloaded "key type" is not easy for readers. BUG=b:158955123 TEST=unit_tests. Change-Id: Iab3cdd0b943219765ec7b99626cba53c382ce6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474933 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#820615}
-
Leo Lai authored
Now we are using AttestationClient for enrollment preparation. BUG=b:158955123 TEST=build ok. Change-Id: I4ca086d952e3c5762733769f8f0faf9ebfa97b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466006 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca73582a554c..9ac611446f4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ic059cddc634337a25f35feb85bad6d72bf35817f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496753Reviewed-by:
-
Markus Handell authored
Local testing shows VTVideoEncodeAccelerator is quite capable of operating under NV12 frame input. This patch makes sure we don't fallback to OpenH264 when running with --video-capture-use-gpu-memory-buffer. Bug: 1127791 Change-Id: Id4ee78aba90012b351428deaeee3e17b3da38d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495021 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#820612}
-
Markus Handell authored
This capturer didn't previously support GMB capturing. This patch changes this by supplying a new GpuMemoryBufferTrackerMac supporting IOSurface generation. With capture & display in HD at 60 fps, we routinely run out of buffers. This patch increases the max number of outstanding buffers for macOS. Because the FileVideoCaptureDevice writes to GMBs using mode gfx::BufferUsage::SCANOUT_VEA_READ_CAMERA_AND_CPU_READ_WRITE which previously implied kIOSurfaceLockReadOnly locking mode, a new buffer usage constant gfx::BufferUsage::SCANOUT_VEA_CPU_READ is introduced which is used for buffers shipped from video capture. This fixes the related TODO in gpu_memory_buffer_impl_io_surface.cc by mapping SCANOUT_VEA_CPU_READ to kIOSurfaceLockReadOnly. Bug: 1134165, 1130101 Change-Id: I4d2d1624214659bd232a6fe064dc1de9362c5958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487341 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#820611}
-
Moja Hsu authored
This CL adds exposureMode(continuous/manual) and exposureTime MediaTrackCapabilities. Bug: b:148527288 Test: Test controls on built-in camera of krane and huddly go camera Change-Id: I34efc4f7027f696591336939ac8aafcec7695844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275505Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820610}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ib09050a5b17e17ada63d41f8957d463f3fe7ad0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496523Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4272c8cdcc11b0d5623e232f0068d1ac61591d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497002Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/052e17b2db85..aac4971071eb 2020-10-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I642af5b63316b3ba4b55956e543c718a2cbdde94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495553Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603583489-aa627a5dd933144f589179af31a0aa634346b6c2.profdata to chrome-linux-master-1603605132-ab0d20de15b3555bfa0dd3f16926df8f867dc44c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic974f4380077cfd3371c79e228a719f70960ca27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497007Reviewed-by:
-
