- 03 Dec, 2018 40 commits
-
-
Ivan Sandrk authored
Locked fullscreen is supposed to be a secure mode where the user cannot do anything outside of the current browser window, but ARC apps can currently draw on top of it. To fix this, we disable ARC when entering the mode, and we re-enable it upon exiting the mode. Bug: 888611 Change-Id: I84cda87a260a42108f1ef6c4767c174bc8b1fb61 Reviewed-on: https://chromium-review.googlesource.com/c/1356813Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#613254}
-
Chris Palmer authored
A foolish consistency is the hobgoblin of little minds. #welp Bug: None Change-Id: Ia174e3fa99252a7931429c22d769872bc2f0c3bd Reviewed-on: https://chromium-review.googlesource.com/c/1357625 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#613253}
-
Dana Fried authored
Also removes code associated with "show close button on hover" in non-touch situations because showing of close button on inactive tabs is now purely a function of tab size and the code had no effect. Previously, tabs were relying on invalidation of the tabstrip to repaint when active status changed. This resulted in cases where when the number of tabs at minimum size exceded the size of the browser window, pinned tabs would not repaint when a new tab was added, resulting in them appearing to still be active (until something else invalidated the tabstrip, like a mouse event or resize). Now we're using InvalidateLayout() and SchedulePaint() correctly to make sure things which could change the render or layout state of a tab result in the tab being laid out and/or repainted. Bug: 896849 Change-Id: If2fcdafe80a0d22dc1d7c5c2c4a703729b8ed55b Reviewed-on: https://chromium-review.googlesource.com/c/1357329 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#613252}
-
Eric Foo authored
This is a reland of 7d53bc24 Original change's description: > Remove incorrect named builders ("_" underscores) > > Bug: 868202 > Change-Id: I807807511df39b7a4eac3b699fcd2274d4d24138 > Reviewed-on: https://chromium-review.googlesource.com/c/1343081 > Reviewed-by: Ryan Tseng <hinoka@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Eric Foo <efoo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609559} Bug: 868202 Change-Id: I26a75c2226e910637c677b28598865ad31fb67e2 Reviewed-on: https://chromium-review.googlesource.com/c/1357720Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#613251}
-
Philip Rogers authored
In https://crrev.com/612683 the blink-gen-property-trees flag was changed from --enable-blink-gen-property-trees to --enable-blink-features=BlinkGenPropertyTrees. This patch updates the bot configuration to use the new flag. Bug: 910859 Change-Id: I75bd3b947cf6fe5e8ec43a34a60e9cb7d61152c5 Reviewed-on: https://chromium-review.googlesource.com/c/1359131Reviewed-by:
-
Ovidio Henriquez authored
The small-caps-aat.html was failing on the WebKit Mac10.13 (retina) builder. Tbr: drott@chromium.org Bug: 910263 Change-Id: Idbe95ab8055f53b777c03c7e6a5d283abf691074 Reviewed-on: https://chromium-review.googlesource.com/c/1359063Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#613249}
-
Martin Kreichgauer authored
The Windows WebAuthNGetAssertion API call allows setting the allow list parameter via two separate fields/types: `WEBAUTHN_CREDENTIALS CredentialList` and `PWEBAUTHN_CREDENTIAL_LIST pAllowCredentialList`. The latter is newer and allows setting transport restrictions on each credential descriptor. However, using it appears to prevent GetAssertion from falling back to the CTAP1 device protocol in cases where (a) the authenticator does not speak CTAP2, or (b) it speaks CTAP1 and CTAP2 but the credential was created via CTAP1. This change works around the issue by using the older field instead. WebAuthNMakeCredential does not seem to suffer from the same issue and reliably sticks to U2F if the authenticator is CTAP1-only or dwAuthenticatorAttachment is WEBAUTHN_AUTHENTICATOR_ATTACHMENT_CROSS_PLATFORM_U2F_V2. Hence, nothing changes for it. Bug: 898718 Change-Id: I5e06cd48a3dd424b4763753d8e4d41d8c6680c68 Reviewed-on: https://chromium-review.googlesource.com/c/1357621 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#613248}
-
Becca Hughes authored
This adds MEIPreload version v1.0.4.0 to Chromium so that it is boostrapped with new installs. BUG=910647 Change-Id: I5b8128a7043b30610c3a62ea6c3f71adc96dbf89 Reviewed-on: https://chromium-review.googlesource.com/c/1357299Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#613247}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a44efb76a8a4..0cfefd1a1e98 git log a44efb76a8a4..0cfefd1a1e98 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 tsepez@chromium.org Replace wide literals with narrow ones in WideTextBuf operations. Created with: gclient setdep -r src/third_party/pdfium@0cfefd1a1e98 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id61ea4ba07b8b4ecc9e7455a9b00017f1af0d2e5 Reviewed-on: https://chromium-review.googlesource.com/c/1358806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613246}
-
Kevin McNee authored
Unlike touchscreen pinch events, touchpad pinch events don't occur within a gesture scroll sequence. If a touchpad pinch update couldn't be directly coalesced with a previous pinch update, we now just enqueue the pinch update rather than producing a scroll update. We also now allow for pinch updates to be coalesced if their anchors are approximately equal to accommodate OOPIF coordinate conversion imprecision. Bug: 897791 Change-Id: I3331fc5761b5ca11d4b05386e5ab4468ac2291d7 Reviewed-on: https://chromium-review.googlesource.com/c/1349851Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#613245}
-
Jacob Dufault authored
Reason for revert: the failing test was flaky without this change and has since been disabled (crbug.com/911154) Original change's description: > Revert "cros: Remove WizardInProcessBrowserTest" > > This reverts commit 92925c66. > > Reason for revert: WizardControllerDeviceState*Test timing out on linux-chromeos-dbg > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9248 > > rowserTestBase received signal: Terminated. Backtrace: > #0 0x7feb2e8b3fed base::debug::StackTrace::StackTrace() > #1 0x7feb2e5addfa base::debug::StackTrace::StackTrace() > #2 0x563fac6dc0f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7feafb349cb0 <unknown> > #4 0x7feafb4116d3 epoll_wait > #5 0x7feb2e96353f epoll_dispatch > #6 0x7feb2e956cc5 event_base_loop > #7 0x7feb2e9073c9 base::MessagePumpLibevent::Run() > #8 0x7feb2e63fbe6 base::MessageLoopImpl::Run() > #9 0x7feb2e6eb322 base::RunLoop::Run() > #10 0x563fa6018304 chromeos::WizardControllerDeviceStateTest::WaitForAutoEnrollmentState() > #11 0x563fa5ffeb8f chromeos::WizardControllerDeviceStateExplicitRequirementTest_ControlFlowForcedReEnrollment_Test::RunTestOnMainThread() > > Original change's description: > > cros: Remove WizardInProcessBrowserTest > > > > The base class convoluted the inheritance structure and it is simpler to > > directly derive from InProcessBrowserTest. > > > > Bug: 899777 > > Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 > > Reviewed-on: https://chromium-review.googlesource.com/c/1345244 > > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612394} > > TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org > > Change-Id: I06cfea778c8246795a8bb8fdc9878812a1ab5d52 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 899777 > Reviewed-on: https://chromium-review.googlesource.com/c/1356168 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612523} TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org,ortuno@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 899777 Change-Id: Id6a54d588736969830db39963f5cc4560d1068b9 Reviewed-on: https://chromium-review.googlesource.com/c/1359135Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#613244}
-
khachatryan authored
We are adding ChromeDriver support for Chrome v72 and dropping support for Chrome v69 Change-Id: I3424e451bf596eeab5052cbe6f1c79557d11649b Reviewed-on: https://chromium-review.googlesource.com/c/1359061Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#613243}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/45723ac93149..0a1293c2e432 git log 45723ac93149..0a1293c2e432 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 kjlubick@google.com [canvaskit] Add drawImage support 2018-12-03 michaelludwig@google.com Reland "Share GP implementation between GrFillRectOp and GrTextureOp" 2018-12-03 michaelludwig@google.com Reland "Send max coverage limit for subpixel rects" 2018-12-03 reed@google.com change Run to store bool_aa instead of flags_only_aa 2018-12-03 herb@google.com Make fallback descriptors explicit 2018-12-03 egdaniel@google.com Pass in actual sampled texture and sample params to gpu uniform builders. 2018-12-03 mtklein@google.com clean up TODO Created with: gclient setdep -r src/third_party/skia@0a1293c2e432 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I8e5a2dd701200e72caa27b7b89100345795f6ad4 Reviewed-on: https://chromium-review.googlesource.com/c/1358805Reviewed-by:
-
Sergey Ulanov authored
content_unittests are failing on Fuchsia. TBR=thakis@chromium.org Bug: 910029 Change-Id: Ie567ad03904e3ec27143c3a1bec1a86562c74c18 Reviewed-on: https://chromium-review.googlesource.com/c/1359057Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#613241}
-
Lukasz Anforowicz authored
The test has been fixed in r613184 and therefore doesn't need separate expectations for site-per-process and not-site-per-process. Therefore this CL removes this test from virtual/not-site-per-process suite. Bug: 619662 Change-Id: Idf80b42401df5aa0c78c5b76654a9915e111bfe2 Reviewed-on: https://chromium-review.googlesource.com/c/1359090 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#613240}
-
Erik Luo authored
Keyboard navigation in Console presents new interactions that our stick-to-bottom (STB) logic should care about. Prompt - Before, STB only cared about TextChanged events, but now cares about focusin, since users can Tab from messages to prompt Objects - Expanding an object results in noticeable scroll-anchoring jumps, STB should turn off due to expanding. Expanding a small object that can fit in viewport should guarantee it is visible. Bug: 865674 Change-Id: I47872110d4bf2261b4940b565f8c926333b66836 Reviewed-on: https://chromium-review.googlesource.com/c/1330350 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#613239}
-
Roger Tawa authored
Bug: 907469 Change-Id: I11eef2154474685461408d7932a4406001ee0174 Reviewed-on: https://chromium-review.googlesource.com/c/1359066 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/faf8c0448d40..9eaff40b437e git log faf8c0448d40..9eaff40b437e --date=short --no-merges --format='%ad %ae %s' 2018-12-03 primiano@google.com Merge "Fix chromium roll" 2018-12-03 lalitm@google.com Merge "Support unknown column types for default span join dimensions" 2018-12-03 hjd@google.com perfetto_cmd: Add cmdline flags 2018-12-03 fmayer@google.com Merge "profiling: Wait for perfetto cmd to terminate in script." 2018-12-01 eseckler@google.com Merge "perfetto: Keep track of allowed target buffers for producers." Created with: gclient setdep -r src/third_party/perfetto@9eaff40b437e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:117592083 TBR=perfetto-bugs@google.com Change-Id: I4bb61a2f63bd8d2c54df0ad506326622971fcd92 Reviewed-on: https://chromium-review.googlesource.com/c/1358804Reviewed-by:
-
David Benjamin authored
The original implementation had some thread-safety and lifetime issues. This CL splits LoginHandlerDelegate into a UI and IO half to fix these, and make it cleaner overall. Longer-term, CreateLoginDelegate is one of the many places where we should be able to move the ContentBrowserClient-level interface to the UI thread (south of //content, the current code is similarly a threading mess). https://crbug.com/908926 tracks this. Bug: 901809 Change-Id: I097523042ca62dae46b2ed7c0bf3fc27bf7bab1d Reviewed-on: https://chromium-review.googlesource.com/c/1357645Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#613236}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/20317f4d..41975c6b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I93789748dbba1feb818ce6c2df79bfa0994b5aad Reviewed-on: https://chromium-review.googlesource.com/c/1359048Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613235}
-
Eric Karl authored
Observers can be added while calling OnBeginFrame on existing observers. In these cases, we reentrantly take ScopedOnBeginFrame. There was a DCHECK preventing this, but given that this is supported (we create a the ObserverList with iteration policy EXISTING_ONLY to account for this), we should handle this case. This allows for reentrant scopes in certain cases, making them a no-op. Change-Id: Id5efacf89250fb8d93fe0f6bcb2ce626c1831b2b Reviewed-on: https://chromium-review.googlesource.com/c/1354136Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#613234}
-
Dan Beam authored
There was a handy dandy testing version of NativeTheme in view_unittest.cc that I'd like to reuse in upcoming unit tests for WebUI Dark Mode support (https://crrev.com/c/1354685). BUG=883049 R=sky@chromium.org Change-Id: Ie39f6c42f5069450ec9933b1b83d4cb615ab713d Reviewed-on: https://chromium-review.googlesource.com/c/1357607 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#613233}
-
Jesse Selover authored
ignore_certificate_errors in HttpNetworkSession, which is set by the --ignore-certificate-errors command-line flag, is currently implemented by continuing to use the SSLClientSocket after Connect() fails with a certificate error. Since we currently don't verify until after the handshake, it's safe to ignore the errors and we still allow Read() and Write(). At higher levels, we map the certificate errors back to OK. This is confusing and will longer work when certificate verification happens inside the handshake. A certificate error will mean the handshake hasn't completed. Instead, route the boolean into SSLClientSocketImpl and map the error to OK there. This allows us to remove the error-mapping logic at each of the higher levels. Bug: 347402 Change-Id: I7318e7e9d9e0a3cb0287555b3fd24c9347cc9821 Reviewed-on: https://chromium-review.googlesource.com/c/1343054 Commit-Queue: Jesse Selover <jselover@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#613232}
-
Erik Luo authored
To reveal and select a node, we would call 'onpopulate' on all of its ancestors without a TreeElement, which ensured that the node's own TreeElement would be constructed. When a parent has 500+ children, extra nodes are lazily built after clicking a "Show more" button. To allow revealing hidden nodes, this CL expands the limit if a parent is already populated. Bug: 890632 Change-Id: Ia7b916c21baf5b35dbce8a26eca1681c9bb0b243 Reviewed-on: https://chromium-review.googlesource.com/c/1320569 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
James Darpinian authored
conformance2/textures/misc/copy-texture-image-same-texture.html is failing on AMD even after http://crrev.com/c/1356330. Suppressing the failure. TBR: kbr@chromium.org Bug: 809233, 911216 Change-Id: I56138fe20025eb4836f9b588755fcdc71ba88055 Reviewed-on: https://chromium-review.googlesource.com/c/1359129Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#613230}
-
Robert Flack authored
This reverts commit 3f40244c. Reason for revert: Caused a data race running components_unittests with ScopedFeatureList. Sample failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/30398 WARNING: ThreadSanitizer: data race (pid=9805) Write of size 8 at 0x55b63bfba2b0 by main thread: #0 base::FeatureList::ClearInstanceForTesting() base/feature_list.cc:284:27 (components_unittests+0x85bec63) #1 base::test::ScopedFeatureList::~ScopedFeatureList() base/test/scoped_feature_list.cc:98:3 (components_unittests+0x9a65d52) #2 content::UnitTestTestSuite::~UnitTestTestSuite() content/public/test/unittest_test_suite.cc:61:1 (components_unittests+0xb03cf21) #3 operator() buildtools/third_party/libc++/trunk/include/memory:2325:5 (components_unittests+0x8256779) #4 reset buildtools/third_party/libc++/trunk/include/memory:2638 (components_unittests+0x8256779) #5 ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2592 (components_unittests+0x8256779) #6 ~__tuple_leaf buildtools/third_party/libc++/trunk/include/tuple:171 (components_unittests+0x8256779) #7 ~tuple buildtools/third_party/libc++/trunk/include/tuple:470 (components_unittests+0x8256779) #8 ~BindState base/bind_internal.h:871 (components_unittests+0x8256779) #9 base::internal::BindState<int (content::UnitTestTestSuite::*)(), std::__1::unique_ptr<content::UnitTestTestSuite, std::__1::default_delete<content::UnitTestTestSuite> > >::Destroy(base::internal::BindStateBase const*) base/bind_internal.h:874 (components_unittests+0x8256779) #10 Destruct base/callback_internal.cc:29:3 (components_unittests+0x85b80c7) #11 Release base/memory/ref_counted.h:403 (components_unittests+0x85b80c7) #12 Release base/memory/scoped_refptr.h:284 (components_unittests+0x85b80c7) #13 ~scoped_refptr base/memory/scoped_refptr.h:208 (components_unittests+0x85b80c7) #14 base::internal::CallbackBase::~CallbackBase() base/callback_internal.cc:84 (components_unittests+0x85b80c7) #15 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:3 (components_unittests+0x9a71272) #16 main components/test/run_all_unittests.cc:8:10 (components_unittests+0x4e49ad5) Previous read of size 8 at 0x55b63bfba2b0 by thread T12 (mutexes: write M19294): #0 base::FeatureList::IsEnabled(base::Feature const&) base/feature_list.cc:200:8 (components_unittests+0x85be82d) #1 CanCleanupLockRequired base/task/task_scheduler/scheduler_worker_pool_impl.cc:672:12 (components_unittests+0x866a5e8) #2 base::internal::SchedulerWorkerPoolImpl::SchedulerWorkerDelegateImpl::GetWork(base::internal::SchedulerWorker*) base/task/task_scheduler/scheduler_worker_pool_impl.cc:538 (components_unittests+0x866a5e8) #3 base::internal::SchedulerWorker::RunWorker() base/task/task_scheduler/scheduler_worker.cc:324:51 (components_unittests+0x866f81d) #4 base::internal::SchedulerWorker::RunPooledWorker() base/task/task_scheduler/scheduler_worker.cc:229:3 (components_unittests+0x866f481) #5 base::internal::SchedulerWorker::ThreadMain() base/task/task_scheduler/scheduler_worker.cc:208:7 (components_unittests+0x866f2f1) #6 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:81:13 (components_unittests+0x86daf04) Location is global 'base::(anonymous namespace)::g_feature_list_instance' of size 8 at 0x55b63bfba2b0 (components_unittests+0x00000ebe52b0) Original change's description: > [TaskScheduler]: Create no detach below initial capacity feature > > Under this experiment, scheduler workers are only detached if the pool is > above its initial capacity (threads that are created to replace blocked threads). > > 2 options were considered: > Option A: Detach only when over initial capacity. > > Option B: Detach only when over current capacity (includes currently blocked threads in capacity). > This might better handle the following case: At any given time, there is at least 1 blocked thread. > On top of that, some periodic work uses all worker every 30s or so. The current capacity will > encompass for the blocked thread and avoid detaching it periodically. > > Option A was picked because it is more conservative. Initial capacity is smaller or > equal to current capacity, so detaching is closer to current behavior. We want to avoid having > too many threads that aren't used. > > Bug: 847501 > Change-Id: I0b116db54095767768b158d92f5f146249720b45 > Reviewed-on: https://chromium-review.googlesource.com/c/1348863 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612698} TBR=fdoray@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 847501 Change-Id: I951f5c5701e2d296b2c4edef37648105c4911cf9 Reviewed-on: https://chromium-review.googlesource.com/c/1359127Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613229}
-
Alexander Hendrich authored
This CL does four things: * Support 'sensitiveValue': True for regular policies defined in policy_templates.json * Improve de-duplication logic for SchemaNode generation by also re-using more complex schemas. (Reduces number of |SchemaNode|s from 180 to 131) * Fix a crash if 'sensitiveValue': True was applied to a schema with type 'list' or 'object' (see |CopyAndMaybeConvert()| in policy_conversion.cc) and added tests for this. * Add documentation about 'sensitiveValue' to policy_templates.json. * Make use of namedtuples in generate_policy_source.py Bug: 905357 Change-Id: If3889ada705d9576165c2467f6dd8d9376e54886 Reviewed-on: https://chromium-review.googlesource.com/c/1337346Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#613228}
-
Peter Wen authored
We do a number of tasks in javac.py after the javac command completes: - Move annotation processor generated files to out/Default/gen. - Scan all java files (including aforesaid generated ones) to construct .apk.jar.info files. - Pack all .class (and other files?) into a .jar file for future build steps. This CL splits out these tasks and does them in parallel, in particular also processing java files in parallel. Estimated incremental build savings: ~1.2s Bug: 906803 Change-Id: Ic7a4d4e4cee998ea15f90a1c435de34e60780a3a Reviewed-on: https://chromium-review.googlesource.com/c/1352806 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#613227}
-
Kouhei Ueno authored
Bug: None Change-Id: I16c48291147a71dd119983811e45e3a268ef963e Reviewed-on: https://chromium-review.googlesource.com/c/1343411Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#613226}
-
James Darpinian authored
Fixes WebGL conformance test: conformance2/textures/misc/tex-subimage3d-canvas-bug.html The test expects to be able to create a canvas larger than 32767 in height. Skia seems to support this, and there have been user requests for it. Bug: 859400, 339725, skia:2122 Change-Id: Ibba89e98178bd73817c7b4cbdf569e89ee5764b1 Reviewed-on: https://chromium-review.googlesource.com/c/1356555Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
Jazz Xu authored
This CL achieve the animation by adding sequential labeled CSS class to overflow menu list item so that we can add delays to each visible items to let the items appear one after another. Bug: 814507 Change-Id: I46ee3b6e6a8cbadaad33d2417454267ff4d62a66 Reviewed-on: https://chromium-review.googlesource.com/c/1357462 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#613224}
-
Erik Luo authored
Behind an experiment, a new context menu option in the Sources gutter allows adding a logpoint. Future CLs will tackle editing a breakpoint type and UI changes. Logpoints `console.log` a message instead of pausing. Bug: 700519 Change-Id: Ib33c1a84de4fbc06b6fde6e2e3dd7628e3896d64 Reviewed-on: https://chromium-review.googlesource.com/c/1330079 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
Nico Weber authored
create_string_rc.py globs a bunch of xtb files off disk behind gn's and ninja's back, so that they didn't know that create_string_rc.py needs to rerun when the xtb files are updated. Make the script write a depfile so that ninja knows to re-run the script if an xtb file is udpated. (This is incomplete: if an xtb file is added or removed and nothing else changes, the step still won't re-run. The Right Fix is to list all the xtb files in the gn file and pass them to the script, then make the script assert that the glob matches the passed-in line. That way, if an xtb is added or removed, the command-line tracking will make sure that the command re-runs. But xtb files being added or removed is super rare, so let's punt on this for now.) Bug: 910465 Change-Id: I7050dee3c62d997b750d8b150504a04d086518b8 Reviewed-on: https://chromium-review.googlesource.com/c/1359087Reviewed-by:
Robert Shield <robertshield@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613222}
-
Stephen McGruer authored
Various functions in WorkletAnimation had gotten far too big to be anonymous namespace methods. Pull them out into proper utility functions - which means they can also now be tested! Bug: 910777 Change-Id: I50a65f0e613ff71e7fddc042ee80448f0c3fbcba Reviewed-on: https://chromium-review.googlesource.com/c/1355984Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#613221}
-
Collin Baker authored
DialogModel is a currently unnecessary pure abstract class. Removing it simplifies the dialog hierarchy. Change-Id: Iac8c096b2879d594a723c57abcb1a05bba216e4b Reviewed-on: https://chromium-review.googlesource.com/c/1345212Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#613220}
-
edchin authored
This CL moves the method -setActive: to the coordinator layer since it deals with many child coordinators. Change-Id: I8e61ece1380169ffc10e9e00bccaa68dbde7d4d4 Reviewed-on: https://chromium-review.googlesource.com/c/1355924Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613219}
-
Tim Haloun authored
Added to webrtc rtpencoder struct is a field for specifying the dscp value on a per-encoder basis, allowing audio and video to have different priorities. The API is defined in https://w3c.github.io/webrtc-dscp-exp/ , and the particular codepoints are defined in https://tools.ietf.org/html/draft-ietf-tsvwg-rtcweb-qos-18#section-5 Note, actually enabling DSCP at all is still guarded by the googDscp PeerConnection constraint, for now. WPT tests: https://chromium-review.googlesource.com/c/chromium/src/+/1357515 I2I: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bVNynDp9PHo chromestatus: https://www.chromestatus.com/feature/5583278023114752 Bug: webrtc:5008 Change-Id: I05bdcf62787d30211310a4686bb5fc18fda674da Reviewed-on: https://chromium-review.googlesource.com/c/1298231Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Tim Haloun <thaloun@chromium.org> Cr-Commit-Position: refs/heads/master@{#613218}
-
Mike Dougherty authored
Bug: 905939 Change-Id: Iae8ed5b83aa8bb384ed2c8e65f345547f188a986 Reviewed-on: https://chromium-review.googlesource.com/c/1357382Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#613217}
-
Sam Maier authored
Bug: 908988 Change-Id: I3f00b9e786d617fd288e90f2632bb86d18452502 Reviewed-on: https://chromium-review.googlesource.com/c/1358913Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b9f9a3bc9f36..d80259d35e66 git log b9f9a3bc9f36..d80259d35e66 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 33432579+alan-baker@users.noreply.github.com Strict validation of where type ids are acceptable (#2142) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d80259d35e66 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1632d3f88c2ebd24572357241e054df5dfd3ab96 Reviewed-on: https://chromium-review.googlesource.com/c/1358759Reviewed-by:
-
