- 17 Mar, 2017 40 commits
-
-
dbeam authored
Revert of [MD settings] hide extra horizontal scrollbar (patchset #1 id:20001 of https://codereview.chromium.org/2753943003/ ) Reason for revert: The bug this is fixing https://bugs.chromium.org/p/chromium/issues/detail?id=645346 Is not as bad as the bug it introduced https://bugs.chromium.org/p/chromium/issues/detail?id=702496 Original issue's description: > [MD settings] hide extra horizontal scrollbar > > This CL prevents an unwanted horizontal scrollbar from flashing at the > bottom of the page when transitioning from a sub-page back to the basic > page. > > BUG=645346 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2753943003 > Cr-Commit-Position: refs/heads/master@{#457570} > Committed: https://chromium.googlesource.com/chromium/src/+/bfa14e6ef0b8adc0f56d899f3776fe4b960b8978 TBR=dpapad@chromium.org,dschuyler@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645346 Review-Url: https://codereview.chromium.org/2756253002 Cr-Commit-Position: refs/heads/master@{#457817}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/a392dbaa998e..e0a34e7dcddf $ git log a392dbaa9..e0a34e7dc --date=short --no-merges --format='%ad %ae %s' 2017-03-17 bungeman Only set dw antialias mode to grayscale for A8. 2017-03-17 bsalomon Make dstreadshuffle not crash in with --preAbandonGpuContext and look better in 565 2017-03-16 herb Fix overflow bug in slow span. 2017-03-17 brianosman Add highp to specular lighting intermediate to fix iOS bots 2017-03-17 reed Revert[2] "More SkVertices implementation work"" Created with: roll-dep src/third_party/skia BUG=700836 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=borenet@chromium.org Change-Id: If977d3dd51fa89e8273373f248aa2b3ee82eceb4 Reviewed-on: https://chromium-review.googlesource.com/456491Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#457816}
-
mbjorge authored
In an effort to get a useful/clean signal from the cast unittest system, the current failing tests are being disabled to get the system back to a green state. The disabled tests will be vigilantly monitored by mbjorge@ and jonathanve@ to ensure they are fixed and not forgotten. Tracking hostlist: 461351 BUG=internal b/36238217 Review-Url: https://codereview.chromium.org/2748303002 Cr-Commit-Position: refs/heads/master@{#457815}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/689eddc13b0f..7da88470e422 $ git log 689eddc13..7da88470e --date=short --no-merges --format='%ad %ae %s' 2017-03-17 perezju [devil] Provide device.GetApplicationPids() Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2753063004 Cr-Commit-Position: refs/heads/master@{#457814}
-
nednguyen authored
This also enables system_health_smoke_test on android.chromium bot (Android N5X Swarm Builder). BUG=700426 Review-Url: https://codereview.chromium.org/2752033002 Cr-Commit-Position: refs/heads/master@{#457813}
-
jdufault authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/59fb3e8e603b..0d03f0f74706 $ git log 59fb3e8e6..0d03f0f74 --date=short --no-merges --format='%ad %ae %s' 2017-03-13 jdufault Increase rootfs size for amd64 asan builds to 4gb. 2017-03-08 dgarrett chromeos_config: Create android_import_branch configuration. 2017-03-14 ihf remote_access: check if rsync is on device. 2017-03-13 norvez chromeos_config: add boards betty and newbie 2017-03-02 davidriley som_alerts_dispatcher: allow specifying specific build 2017-02-09 shuqianz cbuildbot: Pass build_id to HWtest stage used as datastore_parent_key 2017-03-10 davidriley classify_special_task: Parse JSON files. 2017-02-28 davidriley chromite: Scripts to lookup suite ids of builds from Milo. 2017-03-14 chrome-bot Update config settings by config-updater. 2017-03-07 hidehiko cbuildbot: Add --goma_dir and --goma_client_json options. 2017-03-13 nxia Revert "Reset Code-Review label in Pre-CQ-Launcher" 2017-03-12 yueherngl fizz: add builder configuration 2017-03-12 chrome-bot Update config settings by config-updater. 2017-03-12 chrome-bot Update config settings by config-updater. 2017-03-10 yueherngl kahlee: add builder configuration 2017-03-10 manojgupta Revert "generic_stages: temporarily ignore all target prebuilts." 2017-03-03 andreyu Remove lakitu_next-paladin from experimental paladins list 2017-03-09 manojgupta generic_stages: temporarily ignore all target prebuilts. 2017-03-10 jrbarnette Remove daisy_skate from HWTest on the CQ. 2017-03-09 hidehiko cbuildbot: Clean up add_option code. 2017-03-02 ayatane [sysmon] Add future statements 2017-02-28 dgarrett classifier: Add ability to parse lab repair status.log files. 2017-03-08 rahulchaudhry cros_setup_toolchains: respect CONFIG_TARGET_SUFFIXES for standalone toolchains 2017-03-08 vapier cros_workon: allow more commands to be used w/out a sysroot 2017-03-06 ihf auto_updater: reduce devserver cpu load using scp. 2017-03-08 vapier chrome-sdk: add a debug log when loading the LKGM version 2017-02-16 davidriley som_alerts_dispatcher: use BuildInfo instead of separate APIs 2017-02-13 xixuan cidb: Add a new suite_scheduling property to the buildTable. 2017-03-08 yunlian remove profile=llvm and USE=clang for llvm builders. 2017-03-01 davidriley cidb: Make GetBuildHistory be able to retrieve only completed builds. 2017-02-16 davidriley milo: Add method to invoke BuildInfo.Get pRPC. 2017-03-07 yunlian Remove some temporary LLVM boards in the PFQ. 2017-03-07 wonderfly chromeos_config: temporarily disable run_gce_tests for lakitu-paladin 2017-03-02 akeshet delete chromiumos-build-stats code and callers 2017-01-03 matteo.franchin Always consume log_level arg in ProgressBarOperation.Run 2017-03-02 hidehiko cros_sdk: Proxies goma_dir and goma_client_json to enter_chroot. 2017-03-01 nxia Register TriageRelevantChanges instance in build_status.SlaveStatus. 2017-03-03 dgarrett bootstrap: bootstrap -> cbuildbot_launch. 2017-03-06 chrome-bot Update config settings by config-updater. 2017-03-02 nxia _GetAllSlaveCIDBStatusInfo: return cidb statuses for all slaves. 2017-03-03 cmtice [waterfall] Remove x86 toolchain waterfall builders 2017-02-27 dgarrett bootstrap: Clean Chrome checkout on branch checkouts. 2017-03-03 chrome-bot Update config settings by config-updater. 2017-03-01 afakhry [chromeos_config]: Increase the master PFQ timeout to 6 hours. 2017-03-03 xixuan Revert "Revert "chromeos_config: temporarily mark lakitu-paladin experimental"" 2017-03-02 ayatane [sysmon] Export variable instead of using env 2017-03-02 ayatane [sysmon] Mark variables readonly for safety 2017-03-02 ayatane [sysmon] Move network metrics to its own module 2017-03-02 ayatane [sysmon] Add network interface stats to sysmon 2017-03-02 ayatane [sysmon] Move literal list out of function 2017-03-02 ayatane [sysmon] Move net_io_counters collection to separate function 2017-03-02 ayatane [sysmon] Extract _is_virtual_netif function 2017-03-02 ayatane [sysmon] Rename sysmon get_* functions 2017-03-02 davidriley classifier: classify TKO parse failures 2017-03-02 wonderfly Revert "chromeos_config: temporarily mark lakitu-paladin experimental" 2017-02-28 yunlian Add 'USE=-clang' to lumpy-chrome-pfq 2017-02-13 nxia TriageRelevantChanges: add _ProcessMightSubmitChanges 2017-01-27 nxia Add TriageRelevantChanges and implement _ProcessCompletedBuilds 2017-02-09 stimim gerrit: add command line support for hashtags 2017-02-17 akeshet completion_stages: add CQ wall-clock metric 2017-02-27 alanjones Disable artifacts and paygen steps for loonix builds. 2017-02-17 dgarrett bootstrap: Filter commandline arguments. 2017-02-17 dgarrett bootstrap: Wipe selected buildroot contents as needed. 2017-01-17 dgarrett osutil.EmptyDir: New empty to delete the contents of a directory. 2017-02-22 nxia _GetSlaveMappingAndCLActions: remove CQ-Master assert. 2017-02-19 vapier cros_test_lib: add support for --catch/--buffer 2017-02-24 nxia generic_builders: report stage status and stage failures. 2017-02-28 chrome-bot Update config settings by config-updater. 2017-02-28 akeshet chromeos_config: temporarily mark lakitu-paladin experimental 2017-02-28 akeshet chromeos_config: temporarily mark kip-paladin experimental 2017-02-10 xixuan chromite: Add retry for some particular provision commands. 2017-02-17 rahulchaudhry cros_setup_toolchains: disable Go cross compiler for x86. 2017-02-22 dgarrett gob_util: Add 2 minute timeout to GOB requests. 2017-02-07 pmalani Extract subdirs to watch for uprevs from test names 2017-02-21 akeshet sync_stages: fix typo LGKM -> LKGM 2017-02-16 nxia GetRelevantChangesForSlaves: provide an include_master option 2017-02-22 dgarrett report_stage: Remove CIDB based performance stats. 2017-02-22 stevenjb cros_chrome_sdk: Elim --fastbuild and --component 2017-02-08 nya Upload Android debug symbols in Android PFQ. 2017-02-23 akeshet pre-cq: update default pre-cq; add caroline-pre-cq, demote rambi 2017-02-06 pmalani Allow for multiple dirs in SUBDIRS_TO_REV 2017-02-16 hashimoto upload_symbols: Increase UPLOAD_MIN_TIMEOUT 2017-02-17 ayatane Clean up virtualenv cruft 2017-02-13 nxia Do not mark CQ-master Completion stage as fail when no CL is picked up. 2017-02-17 akeshet clactions: record a distribution metric for the number of CQ pickups per CL 2017-02-15 dgarrett bootstrap: Rework bootstrap to do full ChromeOS checkouts. 2017-02-24 akeshet chromeos_config: mark whirlwind-paladin experimental 2017-02-21 nxia PatchSeries: fix possible KeyError in CreateDisjointTransactions. 2017-02-23 cmtice [chromeos_config] Disable flaky tests for toolchain builders. 2017-02-21 dgarrett chromite-pre-cq: Tweak. 2017-02-23 akeshet validation_pool: reduce the throttling backoff lookback threshold 2017-02-23 jrbarnette Change the kevin paladin to run only bvt-inline and not bvt-cq 2017-02-22 ayatane Fix accidental removal 2017-02-15 yunlian Create temporary LLVM boards in the PFQ. 2017-02-08 davidriley som_alerts_dispatcher: Allow alerting of non-master builds. 2017-02-06 davidriley som_alerts_dispatcher: Add log-based classification of failures. 2017-02-07 davidriley classifier: Fix test root cause triggering logic. 2017-02-06 davidriley classifier: Add library to classify build stage failures. 2017-02-09 davidriley som_alerts_dispatcher: Make alert keys more unique 2017-02-08 davidriley cidb: Add GetBuildsFailures method. 2017-02-10 dgarrett chromite-pre-cq: Create a chromite-pre-cq builder. 2017-02-10 semenzato chromite: change some devserver failure messages 2017-02-15 marcheu unittests: Use frecon instead of ply-image 2017-02-15 nxia builder_status_lib: Add BuilderStatusManager to operate BuilderStatus. 2017-02-15 nxia Move BuilderStatus to lib/builder_status_lib 2017-02-15 sjg partial_mock: Clarify the comment to ListRegex 2017-02-16 xixuan auto_updater: emergency fix for name inconsiscency caused by git rebase. 2017-02-10 dgarrett generic_builders: Create PreCqBuilder base class. 2017-02-01 pprabhu chromeos_config: Cull remaining storm builders. Created with: roll-dep src/third_party/chromite BUG= Review-Url: https://codereview.chromium.org/2754183002 Cr-Commit-Position: refs/heads/master@{#457812}
-
mastiz authored
image_fetcher is used by components that fetch images outside the content area, hence cookies are undesirable. A quick look at existing clients suggests none are relying on cookies, hence we disable them by default and introduce no API for now to toggle them. BUG=644102,702200 Review-Url: https://codereview.chromium.org/2756633003 Cr-Commit-Position: refs/heads/master@{#457811}
-
dgn authored
BUG=701253 Review-Url: https://codereview.chromium.org/2758753003 Cr-Commit-Position: refs/heads/master@{#457810}
-
wangxianzhu authored
Add a flag needsPaintOffsetAndVisualRectUpdate() to indicate that the object needs paint offset and visual rect update during PrePaintTreeWalk. The original paint invalidation flag setters setMayNeedPaintInvalidation, setShouldDoFullPaintInvalidaiton and setters calling the two will set the new flag besides the original flags. Add 'WithoutGeometryChange' variants of the two setters to allow PrePaintTreeWalk to skip paint offset and visual rect update (to be implemented in later CLs). BUG=697081,685179 Review-Url: https://codereview.chromium.org/2751383003 Cr-Commit-Position: refs/heads/master@{#457809}
-
rouslan authored
BUG=702464 Review-Url: https://codereview.chromium.org/2753773008 Cr-Commit-Position: refs/heads/master@{#457808}
-
olka authored
MediaDevicesManager and AudioInputDeviceManager will be addressed in separate follow-up CLs, to keep it simpler. BUG=672468 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2697033006 Cr-Commit-Position: refs/heads/master@{#457807}
-
eugenebut authored
Also renamed was_within_same_page IPC message to was_within_same_document and NavigationState::WasWithinSameDocument to WasWithinSamePage BUG=695189 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2741313002 Cr-Commit-Position: refs/heads/master@{#457806}
-
lpromero authored
Prior to this CL, CSChromium (clean skeleton) was sharing Chromium's. This means we can now install both alongisde. BUG=none R=sdefresne@chromium.org,marq@chromium.org Review-Url: https://codereview.chromium.org/2754203003 Cr-Commit-Position: refs/heads/master@{#457805}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/adee4859cdb4..78616574cedc $ git log adee4859c..78616574c --date=short --no-merges --format='%ad %ae %s' 2017-03-16 thestig Coalesce redundant path points. Created with: roll-dep src/third_party/pdfium BUG=679353 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2750173009 Cr-Commit-Position: refs/heads/master@{#457804}
-
sky authored
If OZONE_PLATFORM_GBM is false, as happens with ozone_auto_platforms=false, then gn check gives an error. BUG=none TEST=none R=dcastagna@chromium.org,reveman@chromium.org TBR=dcastagna@chromium.org,reveman@chromium.org Review-Url: https://codereview.chromium.org/2754333002 Cr-Commit-Position: refs/heads/master@{#457803}
-
rkaplow authored
BUG=678682 Review-Url: https://codereview.chromium.org/2756773002 Cr-Commit-Position: refs/heads/master@{#457802}
-
msarda authored
This feature has been shipped for more than a year now. This CL removes this experimental switch and the parts of the code that are now obsolete. BUG=NONE Review-Url: https://codereview.chromium.org/2758583002 Cr-Commit-Position: refs/heads/master@{#457801}
-
twellington authored
BUG= Review-Url: https://codereview.chromium.org/2753773006 Cr-Commit-Position: refs/heads/master@{#457800}
-
tedchoc authored
BUG=702312 Review-Url: https://codereview.chromium.org/2750313005 Cr-Commit-Position: refs/heads/master@{#457799}
-
warx authored
Changes: (1) s/NULL/nullptr/g (2) git cl format; just a cleanup, do not want it included in issue 2756643002 BUG=NONE TEST=NONE Review-Url: https://codereview.chromium.org/2753223002 Cr-Commit-Position: refs/heads/master@{#457798}
-
lpromero authored
BUG=none R=rohitrao@chromium.org Review-Url: https://codereview.chromium.org/2755653002 Cr-Commit-Position: refs/heads/master@{#457797}
-
engedy authored
When a provisional load fails with no server-supplied error page, Chrome's own navigation error page is shown. This also triggers a background request to load navigation corrections (aka. Link Doctor). Once the results are back, there is a navigation to a second error page with the suggestions. Thes CL makes the SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe expect and wait for this second navigation. Otherwise the completion of loading the Link Doctor error page would be at race with that of subsequent navigations initiated in the test, leading to flakiness. BUG=637415,700514 Review-Url: https://codereview.chromium.org/2754173003 Cr-Commit-Position: refs/heads/master@{#457796}
-
jbroman authored
Review-Url: https://codereview.chromium.org/2761493002 Cr-Commit-Position: refs/heads/master@{#457795}
-
reed authored
https://skia-review.googlesource.com/c/9835/ BUG=skia:6366 NOTRY=True Review-Url: https://codereview.chromium.org/2750403005 Cr-Commit-Position: refs/heads/master@{#457794}
-
bsazonov authored
CreateGaiaAuthFetcher interface expects the caller to take ownership of the returned pointer. This CL makes this fact obvious and self-documented by changing return type to unique_ptr<GaiaAuthFetcher>. BUG=702574 Review-Url: https://codereview.chromium.org/2757873002 Cr-Commit-Position: refs/heads/master@{#457793}
-
dcastagna authored
crrev.com/2749873002 moved Ozone GPU initialization away from gl init and it now need to be explcitly called before initializing GL. This CL explicitly initialize Ozone platform in exo wayland clients. TBR=reveman@chromium.org BUG= Review-Url: https://codereview.chromium.org/2750173006 Cr-Commit-Position: refs/heads/master@{#457792}
-
yzshen authored
Without this fix, if the mojom target containing mojom::Foo is linked into a component, mojom::Foo::Deserialize() doesn't work outside of that component. The reason is that the method calls mojom::Foo_Data::Valiate() which is not exported. BUG=702397 Review-Url: https://codereview.chromium.org/2754003005 Cr-Commit-Position: refs/heads/master@{#457791}
-
Vasilii Sukhanov authored
BUG=702641 TBR=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2757893002 . Cr-Commit-Position: refs/heads/master@{#457790}
-
mkwst authored
R=rdevlin.cronin@chromium.org Review-Url: https://codereview.chromium.org/2756163002 Cr-Commit-Position: refs/heads/master@{#457789}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/ce88e77e62d8..adee4859cdb4 $ git log ce88e77e6..adee4859c --date=short --no-merges --format='%ad %ae %s' 2017-03-17 npm Cleanup in fx_agg_driver part 2 Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2753163003 Cr-Commit-Position: refs/heads/master@{#457788}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8189977..d92eee0f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2754273002 Cr-Commit-Position: refs/heads/master@{#457787}
-
qiangchen authored
On thread sanitizer, we found a data race issue for WebMediaPlayerMS' frame count variables |total_frame_count_| and |dropped_frame_count_|. In this CL We make those two variables atomic. BUG=701712 Review-Url: https://codereview.chromium.org/2751353003 Cr-Commit-Position: refs/heads/master@{#457786}
-
gambard authored
The Categories can have an additional action, fetch or view all. For now they are represented as two different bool. It is unclear if they can be set at the same time or not. They are also display on the UI with the same text "More". This CL creates a new API to expose them. BUG=none Review-Url: https://codereview.chromium.org/2751093003 Cr-Commit-Position: refs/heads/master@{#457785}
-
altimin authored
This refactoring prepares for wakeup-based throttling and introduction of the WakeupBudgetPool. R=skyostil@chromium.org,alexclarke@chromium.org BUG=699541 Review-Url: https://codereview.chromium.org/2754853003 Cr-Commit-Position: refs/heads/master@{#457784}
-
edchin authored
This CL makes visual improvements to the toolbar inside the tab grid. - The toolbar is overlaid the tab grid, with a dark blur effect view. - The toolbar properly responds to status bar height changes (such as in-call status, or horizontal no status bar). - The tab grid contents properly inset according to status bar height changes. Screenshots: https://drive.google.com/open?id=0BwS6YyQeisH5MHM4czh6akxwWDQ BUG=686770 Review-Url: https://codereview.chromium.org/2723453003 Cr-Commit-Position: refs/heads/master@{#457783}
-
krasin authored
We're close to replace FullLTO and CFI with FullLTO with their ThinLTO counterparts. This should reduce linking time by 2x-3x, and open a road for even better gains. This particular change sets up a bot that tests for CFI+ThinLTO. Eventually, when we switch the desktop build to ThinLTO, we'll retire all ThinLTO bots and make CFI/LTO bots to imply ThinLTO. BUG=660216 Review-Url: https://codereview.chromium.org/2759443002 Cr-Commit-Position: refs/heads/master@{#457782}
-
jif authored
When the NativeAppsCollectionViewController's parent controller is dismissed, |isMovingFromParentViewController| is false. The consequence is that the NativeAppsCollectionViewController was not unregistering itself from the InstallationNotifier. This led to crashes. TEST=On iPhone: 1/ Open the Google Apps settings menu (Settings > Google Apps). 2/ Click on "Install" on one of the app (at least one app must not be installed). 3/ From that AppStore UI, actually start the installation of one of the app. 4/ As the installation is happening, close the AppStore UI, and close the Google Apps menu by pressing the "FINISHED" button (*not* the back arrow). 5/ Wait for the download to finish without switching to an other app. 6/ Notice that Chrome crashes. BUG=701541 Review-Url: https://codereview.chromium.org/2760643002 Cr-Commit-Position: refs/heads/master@{#457781}
-
stkhapugin authored
BUG=None R=sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2758663004 Cr-Commit-Position: refs/heads/master@{#457780}
-
nektar authored
Revert of PlzNavigate: Enforce 'frame-src' CSP on the browser. (patchset #23 id:790001 of https://codereview.chromium.org/2655463006/ ) Reason for revert: Possibly broke browser_side_navigation_content_browsertests. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin10_Tests_x64%2F9276%2F%2B%2Frecipes%2Fsteps%2Fbrowser_side_navigation_content_browsertests_on_Windows-10-10586%2F0%2Flogs%2FSitePerProcessBrowserTest.CrossSiteIframeBlockedByParentCSPFromHeaders%2F0 Original issue's description: > PlzNavigate: Enforce frame-src CSP on the browser. > > Use a NavigationThrottle to check infringement of the 'frame-src' on the > browser-side. Before this patch, a redirect during the navigation could > led to a child frame to be displayed inside its parent, even if it was > disallowed by its parent. > > BUG=685074 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_site_isolation,linux_chromium_browser_side_navigation_rel > > Review-Url: https://codereview.chromium.org/2655463006 > Cr-Commit-Position: refs/heads/master@{#457757} > Committed: https://chromium.googlesource.com/chromium/src/+/1e3b610bfff1acd060ed8b3f595344402b833bad TBR=nasko@chromium.org,alexmos@chromium.org,clamy@chromium.org,creis@chromium.org,nick@chromium.org,dcheng@chromium.org,arthursonzogni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=685074 Review-Url: https://codereview.chromium.org/2754303002 Cr-Commit-Position: refs/heads/master@{#457779}
-
chrome://interstitialsbauerb authored
Also, allow configuring the interstitial via URL query parameters instead of reading them from the profile. Review-Url: https://codereview.chromium.org/2755733002 Cr-Commit-Position: refs/heads/master@{#457778}
-