GitLab

Bug fixed on the Chromium side, just adding a layout test as well
for full coverage.

BUG=395472
R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/462153002

git-svn-id: svn://svn.chromium.org/blink/trunk@180103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Let RenderObject::canUpdateSelectionOnRootLineBoxes() return false
if the renderer is in an orphaned render tree, to prevent
RenderSelectionInfo from calling selectionRectForPaintInvalidation()
which would cause the crash.

BUG=396596
TEST=editing/selection/move-node-in-selection-crash.html

Review URL: https://codereview.chromium.org/452293004

git-svn-id: svn://svn.chromium.org/blink/trunk@180102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Moving them to lib, wrapping them in script tags, and converting
the test to Mocha.

BUG=400388
NOTRY=true

Review URL: https://codereview.chromium.org/464003002

git-svn-id: svn://svn.chromium.org/blink/trunk@180101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes an issue where "last updated" data would be displayed before date
was populated, showing some weird data. I tried to use "template if" to
restrict when this would be painted, but couldn't get that to work, so I
resorted to using styling instead.

NOTRY=true
BUG=402661

Review URL: https://codereview.chromium.org/466783002

git-svn-id: svn://svn.chromium.org/blink/trunk@180100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Address type conversion subtlety over RawPtr<>s. We have at hand:

 Handle<Value> toV8(PassRefPtrWillBeRawPtr<NodeList>, ...);

 template<NodeType>class StaticNodeTypeList : public NodeList {
   public:
       static PassRefPtrWillBeRawPtr<StaticNodeTypeList> adopt(..);
       ...
   }

 typedef StaticNodeTypeList<Element> StaticElementList;

and the call

 toV8(StaticElementList::adopt(namedItems), ....);

For the toV8() call to be successfully resolved, the adopt() result
must be convertible to PassRefPtrWillBeRawPtr<NodeList>. For the non-Oilpan
case, we do have the

   PassRefPtr(const PassRefPtr<U>, EnsurePtrConvertibleArgDecl(U, T))

constructor at hand, which will convert the PassRefPtr<StaticElementList>
into PassRefPtr<NodeList>. We do not have the corresponding type-convertible
constructor over RawPtr<>, as providing that runs into problems when
using RawPtr<> as part of the PassOwnPtrWillBeRawPtr transition type.

Address/step-around-the-issue by being explicit about the conversion.

TBR=haraken,oilpan-reviews
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/451303003

git-svn-id: svn://svn.chromium.org/blink/trunk@180096 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The currently checked-in result was incorrectly put there by
https://src.chromium.org/viewvc/blink?revision=180085&view=revision, while
the actual results are correct.

BUG=401954
TBR=bungeman@chromium.org,fdegans@chromium.org

Review URL: https://codereview.chromium.org/467593003

git-svn-id: svn://svn.chromium.org/blink/trunk@180095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, adding cmumford@ to modules/indexeddb OWNERS

TBR=alecflett@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/466833002

git-svn-id: svn://svn.chromium.org/blink/trunk@180094 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/458353005

git-svn-id: svn://svn.chromium.org/blink/trunk@180091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts https://src.chromium.org/viewvc/blink?revision=180034&view=revision
and its two followups:
https://src.chromium.org/viewvc/blink?revision=180039&view=revision
https://src.chromium.org/viewvc/blink?revision=180051&view=revision

r180034 caused lots of browser_test failures in debug mode, all with the
following ASSERT:

ASSERTION FAILED: RuntimeCSSEnabled::isCSSPropertyEnabled(propertyID) || isInternalProperty(propertyID)
../../third_party/WebKit/Source/core/css/StylePropertySet.cpp(558) : int blink::MutableStylePropertySet::findPropertyIndex(blink::CSSPropertyID) const

Most of the failures I saw were in the PrintPreviewWebUITest suite. The followup
patches had to be reverted to make the revert of r180034 clean.

BUG=396992
TBR=timloh@chromium.org

Review URL: https://codereview.chromium.org/468543002

git-svn-id: svn://svn.chromium.org/blink/trunk@180090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Apparently, Failure does not include ImageOnlyFailure.


git-svn-id: svn://svn.chromium.org/blink/trunk@180089 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/422273002

git-svn-id: svn://svn.chromium.org/blink/trunk@180088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The original changes to the test expectations have already been reverted.
See https://codereview.chromium.org/466823002/


git-svn-id: svn://svn.chromium.org/blink/trunk@180087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Rebaseline font tests for Android after r288168 (https://codereview.chromium.org/453923002/)

Reason for revert:
Failure in blink_tests
The old files now seem correct.
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/18077

Original issue's description:
> Rebaseline font tests for Android after r288168
> 
> - svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml
> - svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg
> - svg/as-background-image/svg-width-100p-as-background.html
> - css1/font_properties/font_variant.html
> - virtual/antialiasedtext/fast/text/chromium-linux-fontconfig-renderstyle.html
> - fast/text/chromium-linux-fontconfig-renderstyle.html
> 
> 
> TBR=mvanouwerkerk@chromium.org,zerny@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179820

TBR=mvanouwerkerk@chromium.org,zerny@chromium.org,haraken@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/466823002

git-svn-id: svn://svn.chromium.org/blink/trunk@180085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Merge NamedNodesCollection and StaticNodeList classes into a single
StaticNodeTypeList templated class as these are identical besides the type
of Node they hold. NamedNodesCollection was holding Elements so it is now
named StaticElementList which is a typedef to StaticNodeTypeList<Element>.
StaticNodeList holds Node and is now a typedef to StaticNodeTypeList<Node>.

This avoids code duplication and allows for tighter typing when using a
StaticNodeList. As a side effect, memory used by StaticElementList (formely
NamedNodesCollection is now reported to V8 as StaticNodeList code was doing
so).

R=adamk@chromium.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/465483002

git-svn-id: svn://svn.chromium.org/blink/trunk@180084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Sync: `make update`

Run the tests: `make test`

R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/462973002

git-svn-id: svn://svn.chromium.org/blink/trunk@180082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removed part of the check related to the type of agent. This test was important when the engine used another JS engine.

ScriptState no longer participates in check. And now only used to obtain the ID of context.

The method createScriptCallStackForConsole now uses a method call createScriptCallStack forming a stack which is able to receive an empty stack and not adds a fake frame.

NOTRY=true

Review URL: https://codereview.chromium.org/460743003

git-svn-id: svn://svn.chromium.org/blink/trunk@180081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change removes all the following errors

CONSOLE MESSAGE: Invalid name for preference: foobar

by removing 2 tests that were the only users of some invalid
preference and removing some unneeded override in the css3/filters/
directory. It also adds a presubmit hooks so that we don't let
more errors creep into our tests.

Review URL: https://codereview.chromium.org/457893003

git-svn-id: svn://svn.chromium.org/blink/trunk@180080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

handleDidCancel() doesn't handle m_loader->cancel() in internalAbort().
It's for handling cancellation coming from other components.

BUG=none

Review URL: https://codereview.chromium.org/467593002

git-svn-id: svn://svn.chromium.org/blink/trunk@180078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The rebaseline at https://codereview.chromium.org/453923002 used system fonts.
Test fonts are once more being used.


git-svn-id: svn://svn.chromium.org/blink/trunk@180077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing/ to increase code readability and to avoid
unnecessary type checks. This CL focuses on ReplaceSelectionCommand.

R=leviw@chromium.org, yosin@chromium.org

Review URL: https://codereview.chromium.org/423413005

git-svn-id: svn://svn.chromium.org/blink/trunk@180076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The affected tests have returned to normal, remove suppressions.


git-svn-id: svn://svn.chromium.org/blink/trunk@180075 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove autogenerated patterns instead of just disabling them to avoid cluttering.

BUG=267592
R=vsevik

Review URL: https://codereview.chromium.org/458583004

git-svn-id: svn://svn.chromium.org/blink/trunk@180074 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Skia GPU and software do not appear to agree in this case.
The GPU is more correct, the tracking bug is investigating software.


git-svn-id: svn://svn.chromium.org/blink/trunk@180073 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This events will be used to figure out if given worker thread is started by the page being profiled and if so we will show messages in the worker on the same Timeline.

BUG=401895

Review URL: https://codereview.chromium.org/460363002

git-svn-id: svn://svn.chromium.org/blink/trunk@180072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGRenderSupport::layoutChildren() determines whether the size of the
nearest viewport has changed upfront, and then uses this information to
force a re-layout of relative-length children.

But the relative-length flag is always propagated up the ancestor chain
(see SVGElement::updateRelativeLengthsInformation), so we can
immediately tell whether there are any relative-length descendants. If
there aren't, we can skip the viewport change crawl and related logic.

R=pdr@chromium.org,schenney@chromium.org,fs@opera.com,ed@opera.com

Review URL: https://codereview.chromium.org/458833002

git-svn-id: svn://svn.chromium.org/blink/trunk@180071 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=383813

Review URL: https://codereview.chromium.org/463633004

git-svn-id: svn://svn.chromium.org/blink/trunk@180070 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
Custom validation message, to use for main message first character direction. For subMessage, if direction is auto, then first character direction is applied, else RTL/LTR values are applied.    
 
* HTMLFormControlElement.cpp:
Helper function for custom message, for the main message determineDirectionality is used. Sub Message uses element direction, if element direction is not present, then style direction is used.
* ValidationMessageClientImpl.cpp
Change of direction to web direction.   
* ValidationMessageClient.h
  ValidationMessageClientImpl.h
Pass direction and sub message information. 
* WebViewClient.h
Header file that will be used by chrome side and includes extra direction for subMsg. Old function is kept as placeholder till landing patch.

BUG=91638
R=tkent, leviw

Review URL: https://codereview.chromium.org/389343002

git-svn-id: svn://svn.chromium.org/blink/trunk@180069 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need to clear preprocessor when disabling inspector.

LeakExpectations : remove fixed bugs of inspector 

BUG=301515, 364408, 376188
R=haraken@chromium.org
R=kouhei@chromium.org

Review URL: https://codereview.chromium.org/458933002

git-svn-id: svn://svn.chromium.org/blink/trunk@180068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://src.chromium.org/viewvc/blink?view=rev&revision=180040 introduced
the WebCredentialManager interface, but neglected to create default
constructor/destructor implementations. This trivial patch corrects that
oversight.

BUG=400674
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/466713002

git-svn-id: svn://svn.chromium.org/blink/trunk@180067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The following sources are added:
- Node
- Array.prototype
- Date.prototype
- Object.prototype
- String.prototype

BUG=391593

Review URL: https://codereview.chromium.org/455343002

git-svn-id: svn://svn.chromium.org/blink/trunk@180066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also add a nice paper expand button.

BUG=399717
R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/458473003

git-svn-id: svn://svn.chromium.org/blink/trunk@180065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402801
TBR=timloh@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/463823003

git-svn-id: svn://svn.chromium.org/blink/trunk@180064 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Runtime.prototype.registerModule() should not be available publicly,
as changes in the configuration require the devtools restart.

R=eustas, pfeldman, vsevik

Review URL: https://codereview.chromium.org/460323002

git-svn-id: svn://svn.chromium.org/blink/trunk@180063 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Android Builder failed to compile

Original issue's description:
> Oilpan: fix build after r180052.
> 
> TBR=haraken,oilpan-reviews
> BUG=383813
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180061

TBR=haraken@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=383813

Review URL: https://codereview.chromium.org/461963002

git-svn-id: svn://svn.chromium.org/blink/trunk@180062 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken,oilpan-reviews
BUG=383813
NOTRY=true

Review URL: https://codereview.chromium.org/460983002

git-svn-id: svn://svn.chromium.org/blink/trunk@180061 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/458313005

git-svn-id: svn://svn.chromium.org/blink/trunk@180060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previous implementation did not block mixed content when the srcset attribute was empty.
This CL fixes that.

BUG=402792

Review URL: https://codereview.chromium.org/467533002

git-svn-id: svn://svn.chromium.org/blink/trunk@180059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch [1] removed the global capabilities set. The power profiler depends on whether
there exists a power service and it has a valid data provider. If these are met, only then
the devtools can do power profiling.

The checkbox "Power" should only be visible if the capability exists. Restoring the required
checks.

[1] https://codereview.chromium.org/388963004

Review URL: https://codereview.chromium.org/463853002

git-svn-id: svn://svn.chromium.org/blink/trunk@180058 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In method createScriptCallTackFromConsole we can get current execution context in function body without passing it in arguments.

Removed canGenerateCallStack argument from InspectorConsoleMessage cstor which uses the transmitted stack.

Review URL: https://codereview.chromium.org/458253002

git-svn-id: svn://svn.chromium.org/blink/trunk@180057 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now context menu item for documentation is not created if WebInspector.DocumentationURLProvider cannot provide a URL for selected property.

BUG=391593

Review URL: https://codereview.chromium.org/458983002

git-svn-id: svn://svn.chromium.org/blink/trunk@180056 bbb929c8-8fbe-4397-9dbb-9b2b20218538