GitLab

BUG=79722
R=inferno@chromium.org
TBR=avi@chromium.org

Review-Url: https://codereview.chromium.org/2741103004
Cr-Commit-Position: refs/heads/master@{#455994}

The addExtensions command gets sent on front-end relatively early,
when the onload event gets triggered.

However, in case of hosted mode, the load event happens before actual
InspectorFrontendHost initialization, since Runtime.js starts loading
and evaling all the dependencies by itself.

This patch protects from this race so that there's no annoying exception
thrown.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2744573002
Cr-Commit-Position: refs/heads/master@{#455993}

This patch introduces changes network waterfall canvas to use Path2D to
draw it's canvas items. This is in preporation to move it to use full
layers. (Followup patch will move the code to use the same path
for artifacts that are the same style)

R=caseq
BUG=697668

Review-Url: https://codereview.chromium.org/2731633002
Cr-Commit-Position: refs/heads/master@{#455992}

The gold plugin is needed only for linux official builds. However, since
it's only 17MB, it's better to always download it rather than having it
depend on GYP_DEFINES.

BUG=570091, 699210

Review-Url: https://codereview.chromium.org/2733043002
Cr-Commit-Position: refs/heads/master@{#455991}

BUG=631822,670539

Review-Url: https://codereview.chromium.org/2732203002
Cr-Commit-Position: refs/heads/master@{#455990}

f8fad4fa lossless incremental decoding: fix missing eos_ test

use if (br->eos_) break; as this snapshot does not contain:
16be192f VP8LSetBitPos: remove the eos_ setting

original commit message:

The patch  21735e0 introduced a bug where a goto path was not testing
the eos_ state.  If this happened just before a row_sync, a SaveState()
would be called that would store the eos_ state as '1' till the end
of the loop.  This usually was not a problem, except for the very last
chunk where we disable the incremental decoding altogether (we have all
the data). The termination tests were then going wrong.
The fix is to add a proper eos_ test and avoid falling in this inconsistent
state.

(https://chromium.googlesource.com/webm/libwebp/+/21735e06f7c1cb35562754e7f54365f24124ef15)

BUG=webp:332

Review-Url: https://codereview.chromium.org/2729473002
Cr-Commit-Position: refs/heads/master@{#455989}

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added CSSPropertyAPIFontFamily.cpp, which implements CSSPropertyAPI.h
- added parseSingleValue method to the CSSPropertyAPIFontFamily API
- removed CSSPropertyFontFamily from the switch
  statement in parseSingleValue, and calls the API instead.
- added api implementation details to CSSProperties.json5, indicating
  that CSSPropertyAPIFontFamily.h is generated.

A function pointer to the parseSingleValue function from the API for
the font-family property is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

Originally authored in patch 2641123002 by sashab@chromium.org

BUG=668012

Review-Url: https://codereview.chromium.org/2731953004
Cr-Commit-Position: refs/heads/master@{#455988}

This is part of the work to remove FrameHost.

BUG=691794

Review-Url: https://codereview.chromium.org/2727563004
Cr-Commit-Position: refs/heads/master@{#455987}

* Added Enable/Disable button in network blocking drawer.
* Persists the network blocking entries between devtools reloads.
* Changed code to use setBlockedURLs instead of add/remove counterparts.
* Moved icon notifier from main to network module.

see: http://imgur.com/a/G0VFI

R=pfeldman
BUG=691164

Review-Url: https://codereview.chromium.org/2692653003
Cr-Commit-Position: refs/heads/master@{#455986}

Remove FrameHost::eventHandlerRegistry(), and redirect all calls to
Page::eventHandlerRegistry().

BUG=691794

Review-Url: https://codereview.chromium.org/2741633002
Cr-Commit-Position: refs/heads/master@{#455985}

Cr-Commit-Position: refs/heads/master@{#455984}

https://skia.googlesource.com/skia.git/+log/94cbbba96f1a..6e1e27b7fccd

$ git log 94cbbba96..6e1e27b7f --date=short --no-merges --format='%ad %ae %s'
2017-03-10 reed Revert "prealloc room for some number of Elements to avoid malloc"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: Ib5c96dcdd2780c3d1fa04620e1f76db29e0bb33f
Reviewed-on: https://chromium-review.googlesource.com/452747Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455983}

Previously, we were not including the offset from the PaintLayer of the composited layer when calling PaintLayer::visualOffsetFromAncestor to compute GraphicsLayer
offset from the composited ancestor.

It's important to include this offset when converting from logical to visual
coordinates across a paginated layer boundary, because the offset influences the
fragment offset of the composited layer.

BUG=667213
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2738943004
Cr-Commit-Position: refs/heads/master@{#455982}

MD Bookmarks is switching to a new data store layer to help with binding
data changes to UI elements. This CL ties the new data store to the
existing UI elements.

Note that the new data store is currently missing a few features:
* Item selection
* Search
* URL routing

These features are broken by this CL (there are no user-visible feature
regressions, since this is all behind a runtime flag), but will be added
back in soon.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2735953002
Cr-Commit-Position: refs/heads/master@{#455981}

This is pre-work to move FrameHost::m_topDocumentRootScrollerController
to Page.

BUG=691794

Review-Url: https://codereview.chromium.org/2732363003
Cr-Commit-Position: refs/heads/master@{#455980}

We should do so in order to avoid code/test complexity by DOM mutation events.

BUG=539758

Review-Url: https://codereview.chromium.org/2738213004
Cr-Commit-Position: refs/heads/master@{#455979}

The use counts for animated CSS properties currently uses a custom
histogram which counts a property once per animation. This patch moves
the use counts to the existing UseCounter framework in order to bring
the counts in line with the CSS property UseCounters. In particular,
this is to ensure that properties are counted once per page instead of
once per animation.

This patch:
- adds a BitVector and corresponding functions to UseCounter
- adds test cases to UseCounterTest, this time with an optional
  legacyHistogram name
- exposes the new 'is counted' UseCounter function to Internals for
  testing
- adds layout tests to verify that the animated CSS property UseCounter
  has been correctly incremented for animations (standard and custom
  CSS properties) and transitions (standard CSS properties only).

One of the layout tests is failing because the standard CSS property
UseCounter currently excludes custom properties. This will be fixed in
a future patch.

BUG=458925

Review-Url: https://codereview.chromium.org/2678143003
Cr-Commit-Position: refs/heads/master@{#455978}

This rolls by just one revision, which happens to be a no-op change.
What's new (other than picking up recent plugin changes) is that
the packager now uploaded PDBs for Windows to chromium-browser-symsrv.

BUG=682500

Review-Url: https://codereview.chromium.org/2738253002
Cr-Commit-Position: refs/heads/master@{#455977}

This is a followup to https://codereview.chromium.org/2730633002/ to
finish inlining the function.

R=caseq
BUG=697668

Review-Url: https://codereview.chromium.org/2726183004
Cr-Commit-Position: refs/heads/master@{#455976}

DidCreateScriptContext() compares the context argument to the main world
script context. However, getting the main world script context will
initialize its WindowProxy, which can corrupt internal state when
swapping frames.

BUG=700077

Review-Url: https://codereview.chromium.org/2740873005
Cr-Commit-Position: refs/heads/master@{#455975}

BUG=681223
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2742523004
Cr-Commit-Position: refs/heads/master@{#455974}

NetworkProject's cleanup logic currently relies on resources in
resourceTreeFrame. This patch adds tests with scripts and
stylesheets which don't have underlying resource:
- contentscript-* tests validate bindings creating and removing
  UISourceCodes for content scripts
- dynamic-* tests validate bindings creating and removing
  UISourceCodes for dynamically-created styles

As a drive-by, the patch improves the InspectorTest.dumpWorkspace()
method to also produce a diff with the previous workspace dump.
This helps to read expectations a lot.

R=dgozman
BUG=670180

Review-Url: https://codereview.chromium.org/2738033002
Cr-Commit-Position: refs/heads/master@{#455973}

Currently, every UI.Icon sets background-position property in its
element.style.

In case of masks and gradients, this property might actually affect
the gradient position.

This patch starts using --spritesheet-position css variable to
actually set the icon position in the resources.

Drive-by: simplify classes for "force-white-icons".

R=dgozman
BUG=none

Review-Url: https://codereview.chromium.org/2740913003
Cr-Commit-Position: refs/heads/master@{#455972}

In situations where shared objects fail to install when an app is updated,
this change prevents loading of out-of-date shared objects because the shared
object name now changes with every app update.  Loading out-of-date
shared objects can crash the app.  Failing to find the shared object
(because the name has changed) gives a LibraryLoader registered with
CronetEngine.Builder.setLibraryLoader() a chance to unzip it from the APK.

R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2741773003
Cr-Commit-Position: refs/heads/master@{#455971}

Current guidelines for defining critical memory state is swapping will
occur in that situation. Update MemoryMonitorChromeOS to align the
guidelines.

- Use |available| field of base::SystemMemoryInfoKB if the OS supports it
- Don't count SwapFree as free available memory

BUG=696844

Review-Url: https://codereview.chromium.org/2731273003
Cr-Commit-Position: refs/heads/master@{#455970}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2741023002
Cr-Commit-Position: refs/heads/master@{#455969}

Expose the already existing PrefStore implementations, which are
owned through the profile, through the new prefs service. This
new prefs service will replace the current pref service prototype
used in mash and support synchronous deletions and decoupling the
creation of the underling pref stores.

The service is gated by a default-off feature flag.

BUG=654988

Review-Url: https://codereview.chromium.org/2740493002
Cr-Commit-Position: refs/heads/master@{#455968}

Review-Url: https://codereview.chromium.org/2744553004
Cr-Commit-Position: refs/heads/master@{#455967}

This is a preparatory step for splitting MD Settings to a main
and a lazy module.

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2726403003
Cr-Commit-Position: refs/heads/master@{#455966}

Per spec[1] and tests[2] the constructors for Blob and File and
their slice() methods should not throw if non-printable-ASCII type
is supplied; instead it should use "" as the type. In addition, the
type should be consistently lower-cased, by both the constructors
and slice() method.

[1] https://w3c.github.io/FileAPI/
[2] https://github.com/w3c/web-platform-tests/tree/master/FileAPI

BUG=509786
R=kinuko@chromium.org

Review-Url: https://codereview.chromium.org/1362963003
Cr-Commit-Position: refs/heads/master@{#455965}

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/627712

https://chromium.googlesource.com/chromium/src/+/246a46ddac248

BUG=697448
TBR=robhogan@gmail.com

Review-Url: https://codereview.chromium.org/2745653004 .
Cr-Commit-Position: refs/heads/master@{#455964}

moveCursorToSelectionEnd()  blocks the IME thread unnecessarily, which causes
back navigation to fail. So this CL removes moveCursorToSelectionEnd() and
replaces with mWebContents.unselect().

In RenderFrameImpl::OnUnselect(), the cursor is deleted entirely, which causes
text boxes to be unfocused as a side effect. To fix that, this CL collapses the
selection to the selection end, and renames the functions to CollapseSelection().

BUG=697756
TEST=run_chrome_public_test_apk --test-filter TabsTest.testTabSwitcherCollapseSelection

Review-Url: https://codereview.chromium.org/2734943005
Cr-Commit-Position: refs/heads/master@{#455963}

https://skia.googlesource.com/skia.git/+log/3304c447b953..94cbbba96f1a

$ git log 3304c447b..94cbbba96 --date=short --no-merges --format='%ad %ae %s'
2017-03-09 reed prealloc room for some number of Elements to avoid malloc

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: I801e486404da0a9addb6ed8c754aa2638da96b62
Reviewed-on: https://chromium-review.googlesource.com/452666Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455962}

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
- added parseSingleValue method to the CSSPropertyAPILineHeight API
- removed CSSPropertyLineHeight from the switch
  statement in parseSingleValue, and calls the API instead.
- added api implementation details to CSSProperties.json5, indicating that
  CSSPropertyAPILineHeight.h is generated.

A function pointer to the parseSingleValue function from the API for the
line-height property is stored in a CSSPropertyDescriptor, and is called
from CSSPropertyParser.

Originally authored in patch 2642783005 by sashab@chromium.org

BUG=668012

Review-Url: https://codereview.chromium.org/2735093005
Cr-Commit-Position: refs/heads/master@{#455961}

BUG=697971

Review-Url: https://codereview.chromium.org/2744753002
Cr-Commit-Position: refs/heads/master@{#455960}

This patch simply inlines _drawSimplifiedBarDetails. This is because
this function's functionality will be reduced in future patches and will
make it eassier to review follup patches.

R=caseq
BUG=697668

Review-Url: https://codereview.chromium.org/2730633002
Cr-Commit-Position: refs/heads/master@{#455959}

Safe Browsing will now be enabled for any app which opts in by setting
the flag `android.webkit.WebView.EnableSafeBrowsing` to "true",
regardless of Android version or Target SDK.

BUG=699193

Review-Url: https://codereview.chromium.org/2739003002
Cr-Commit-Position: refs/heads/master@{#455958}

BUG=687806
TEST=none

Review-Url: https://codereview.chromium.org/2723843002
Cr-Commit-Position: refs/heads/master@{#455957}

BUG=693226
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2733273002
Cr-Commit-Position: refs/heads/master@{#455956}

Disable sina.com.cn as if fails as part of v8.runtime_stats.top_25 on Linux

BUG=699579

Review-Url: https://codereview.chromium.org/2744733002
Cr-Commit-Position: refs/heads/master@{#455955}