- 29 Sep, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ia5396badfb38aee0b077f3be0baf44fd0edd8a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437636Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811555}
-
Liquan (Max) Gu authored
Change: * Fixed the issue of not being able to launch payment handler twice. The cause is that when PaymentHandler UI is opened and closed, the payment handler's PaymentAppProvider was used, instead of the merchant's. * Changed PaymentAppProvider to make it one per merchant's WebContents, not one per payment handler's WebContents. * Rename WebContents PaymentHandler's codebase to make it better distinguish between the merchant's and the paymentHandler's. * Move PaymentAppProvider::SetOpenedWindow() from service_worker_client_utils into PaymentRequestImpl --> ServiceWorkerPaymentAppBridge. Bug: 1131874 Change-Id: I831fec0f3cce0d19abf49d23ccf1e61689afe33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434101Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#811554}
-
Aaron Leventhal authored
It is safe to access layout after a call to HandleLayoutComplete(), and it should be done as soon as possible. Exactly what leads to the fatal errors should still be investigated anyway, but this is a simple fix and we still a way to repro. Bug: 1131848,1125186 Change-Id: Ia529928fdee731f9fcf81d65a80edb49aadee9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436418 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811553}
-
Ahmed Fakhry authored
This is part of the recording service work needed for capture mode. (See go/simple-recording-service). This CL defines the base APIs for audio encoders, and ports the PCM and Opus implementations from blink to //media. A follow-up CL should be to migrate blink's media recorder to use these new encoders. BUG=1131275, 1126586 TEST=Added tests at media_unittests --gtest_filter=*AudioEncodersTest* Also, Manually tested both encoders in my WIP recording service CL, and the output captured webm file contains recorded audio that plays back successfully. Change-Id: Iea132162d319a5b580e6b447e3d5658fbf731de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426146 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#811552}
-
Sergey Ulanov authored
InProcessVideoCaptureProvider uses VideoCaptureSystem on a separate device thread, but it was deleting it on the IO browser thread. Fixed InProcessVideoCaptureProvider to delete VideoCaptureSystem on the same thread on which it's being used. Bug: 1127447 Change-Id: Ibf867acea96a28dd992ae9d1139a5ec162d8ee8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427031 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#811551}
-
Daniel Libby authored
Instead of looping for the expected condition, use the LocalSurfaceId increasing as evidence that the expected visual properties update was delivered, and test for the expected values directly. If the test remains flaky, this will give a better indication of where things are breaking down. Also fix the math for the expected width of the second segment - for devices where there are an odd number of DIPs in width, the segments won't be equal. R=jonross@chromium.org Bug: 1089994 Change-Id: I1a81dc73055a4fca8ffc4b577b1b25046dcf23d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433306 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#811550}
-
Noel Gordon authored
ColorSpace is an internal detail of the image loader and should not be visible to clients: remove it from ImageLoaderRequest. The internal use is in ImageRequestTask: add a colorSpace_ member, and document that it used for RAW images (PIEX) only. After CL:2432150, it was decided that we just use the raw string PIEX color space value, so extend that idea and use the raw string in ImageLoaderUtil too (allows us to remove ColorSpace). No change in behavior. Spelling correction: ganna => gamma. Checked the veracity of the color space transform adobeRgb to sRgb and it is correct. This code appeared before the <canvas> element had color management. The <canvas> element supports that feature today in Chrome: add a TODO. Bug: 1132695 Change-Id: I12cad9a0aea106ce4a6c6dcbc2a9137bf0224e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437530Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811549}
-
Brian Sheedy authored
Stops hardcoding an appended '-public' onto the instance we use for the Diff step in the Gold code, instead calling a method to get which instance to use. This is because not all uses of Gold, e.g. ANGLE's, can use the public instance (because it doesn't exist). These cases can override the method to return the base/internal instance instead. Bug: skia:10778 Change-Id: I94de33cac9a7f6935ae1507461c75be0fbc01170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436649 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811548}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1099c11d5d12..ead81e2ba233 2020-09-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I66aecd41cf3037678ff07c05c12a67f260358c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436901Reviewed-by:
-
Kenichi Ishibashi authored
To have more reviewers in the directory. Bug: N/A Change-Id: If6ed70615faeec47547660ebbc75ed5ebd06a425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437574Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811546}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/19e9df68a7bb..2663e6012911 2020-09-29 timvp@google.com Vulkan: Dynamically grow descriptor pool sizes 2020-09-28 j.vigil@samsung.com GL_OES_texture_stencil8 autogen If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: CQ Change-Id: I3fad8eade31e99fcb070d58d1c4d2dcf4c06ca73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437101Reviewed-by:
-
David Schinazi authored
We currently have tools/metrics/histograms/OWNERS set up so that Net experts can approve changes to Net. Now that the split at https://crrev.com/c/2428796 has landed, we'd like to retain that approval process, so this CL adds a new OWNERS file. Change-Id: I5f0fc1c9ef473e01d4907a7861d0bf4a5840bd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436556 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#811544}
-
Meredith Lane authored
This patch has no functional difference, it is just a refactor. AX-Relnotes: N/A Bug: 1068668 Change-Id: I9b0f65e144e25e2b764df7689e5c939f824ad596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405042 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Satoshi Niwa authored
This is a follow-up CL for crrev.com/c/2408502 setSearchQuery() is only used when LaunchParam.searchQuery is filled at this point. Bug: 1126742 Test: browser_tests --gtest_filter="*FilesApp*SearchQueryLaunchParam" (Added by crrev.com/c/2434008) Change-Id: Id1bcc834ac9367de24cb29bc30fc357b5ec20580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434070Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#811542}
-
James Cook authored
Now that the regular linux bot builds both x11 and ozone/wayland, the regular linux codesearch bot will index ozone/wayland as well. We no longer need hacks to compile wayland into the chromeos code search bot. This CL is a manual revert + merge conflict fixes of: "Build the Ozone Wayland platform for codesearch-gen bots." https://chromium-review.googlesource.com/c/chromium/src/+/2245439 Bug: 1095360 Bug: 1085700 Change-Id: Icdf823b90808d6308b5b4bd1c14c4f5252cc0643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432137Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#811541}
-
Robert Ogden authored
Prerenders are being added to history on Android (see bug) because they are triggered in native code so the BackgroundTab logic fails to catch it. On non-Android, the prerendering WebContents doesn't have a browser and so it is not added to history. This CL adds an explicit check for prerenders to early return on all platforms in HistoryTabHelper. Testing this new code path is done with a local histogram since prerenders cannot be triggered in unittests, and browsertests don't run on Android. Bug: 1131712 Change-Id: I297d7d121e55118e7713090a970467999bd25e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429466 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811540}
-
Jazz Xu authored
This CL removes the DCHECK for pin state in media controls detailed view since we are not removing media controls from system menu immediately after user pinned media controls. So user can tap the media controls again while the system menu is still open and get back to the detailed view with the media controls pinned to shelf. Change-Id: I60235836686b535c0a06ee0bf99e97141ba9bf80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435560Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811539}
-
Prashant Nevase authored
While organizing the virtual tests for dark mode images in grayscale, common configurations were removed. But as earlier code did not have grayscale argument explicitly set, the results were same as default dark mode. This patch corrects the argument needed for grayscale and now expected image results look grayish. Bug: 1116914 Change-Id: Iddf66c043d754ee6ed1607ca5c6f9908afbed1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434191Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#811538}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsTetherConnectionDialog* Change-Id: I1440e55698e5369f8f79e4f3b4c39719b7f64acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436891Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#811537}
-
Jason Lin authored
Bug: b/167491603 Change-Id: I5ab220bda34b40f8dd4664ad7abed25bd89ba7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425550 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#811536}
-
David Vallet authored
BUG=1124062 Change-Id: I8ccceb481300089ad3218455ff691ff1dac2b3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421988Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#811535}
-
Dominic Mazzoni authored
Measures the amount of time spent unserializing changes to the accessibility tree and sending automation events. In order to scale reasonably well across different machines, this time is compared to the amount of time spent in renderer accessibility code, that way the test only fails if the disparity is too large. The test code is deliberately all one test for ease of review. As we add more tests, a lot of the code could be broken up into helpers. Bug: none Change-Id: I44a169a7c80d9ccea5cf70cb7450731a43638c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430304 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811534}
-
Bill Budge authored
- Reworks code that sets V8 flags for SharedArrayBuffer and Wasm Threads to also set the new V8 Atomics flag. - Atomics are now always enabled. - SharedArrayBuffer is enabled on desktop, and on Android only with site isolation. Bug: chromium:923807 Change-Id: If40bcbf66216680f0f52ec1bf02dce475b38b1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343566 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#811533}
-
kylechar authored
SkiaRenderer has launched on Windows so we no longer need an FYI bot to run tests. Remove all tests from Win10 FYI x64 SkiaRenderer GL (NVIDIA). Also removes gl_renderer_screenshot_sync tests from CQ, these were testing the old configuration would produce pixels, but we no longer care about GLRenderer. Bug: 809722, 1132963 Change-Id: I85d7c36d3758d524a9b63ac78923533b538177e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410822 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811532}
-
chrome://device-logReilly Grant authored
This change adds a section to chrome://device-log for the Serial API. Existing error messages are now directed here and the platform-specific enumeration backends have been updated to generate log entries when devices are added and removed, as is done for other device types. Bug: 1107826 Change-Id: I694b42fe82b96c44257c979b8a2ea276b34f3124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436277 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#811531}
-
Dominic Mazzoni authored
Bug: 1132546 Change-Id: Ia66ca06eb4aba9c63548faca66caf94009f81fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433258 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#811530}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I79e12433c7174345f6a921eb234efcf8e5ce4eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437694Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811529}
-
Ian Kilpatrick authored
This test doesn't add a lot of value now that we have: ng_layout_result_caching_test.cc ...to test cache hits/misses. There should be no behaviour change. Change-Id: I4d13d6f61cdfce0dd00dd3e85eab6d03a7b12d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256156 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#811528}
-
John Delaney authored
Adds overflox-x:scroll to the css for the containers which wrap the tables on the chrome://conversion-internals page. This stops the table from rendering outside the bounds of container on narrow screens. Bug: 1132929 Change-Id: If99697c784516ac9c0c8a004646ef29695b31683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436290 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#811527}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cb9160484da5..184c9b9164b7 2020-09-28 thestig@chromium.org mac: Make the system page size a run-time property If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1102194 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I45f0003e8781906284823c9cfde4648c3d6cb289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435916Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a9c65f64..e862368a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5aabb9d10643e0fdaeee5193e7f994ebc68ffeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436799Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811525}
-
Stephen Chenney authored
Text Decorations were not contributing to ink_overflow, leading to remnants on the screen when invalidated and causing the mis-sizing of composited layers containing the decorations. This change adds ink overflow calculations for LayoutNG fragment items. Legacy layout is unaffected. Tests added include both the paint layer sizing concern and the invalidation concern. Bug: 896295 Change-Id: I3b8cfd9d9c4f3efafd380e6718fd2eaf22229f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422356Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#811524}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df3ae5e6f975..88c194fccd3b 2020-09-28 treehugger-gerrit@google.com Merge "Fixed data source index assert checking against wrong constant." 2020-09-28 cferris@google.com Merge "Update for libunwindstack change." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib0f3f85458d99813ae3c8fd104b13b059de39fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436893Reviewed-by:
-
Lan Wei authored
MediaNotificationServiceFactory uses a non-existent #define for ChromeOS, defined(CHROME_OS), we should replace it with defined(OS_CHROMEOS). Bug: 1121653 Change-Id: Idd748e7e49c9b2bdc675ae55f1c2b49a6c5ee28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436169Reviewed-by:
-
Mike Wittman authored
This reverts commit 2c8b578a. Reason for reland: originally reverted because the change was broken by https://crrev.com/810801 and that change has since been reverted Original change's description: > [Sampling profiler] Factor out platform config 1/4 > > First in a series factoring the ThreadProfiler platform specific > configuration state from the code that takes action on the > state. Defines an IsSupported function that is true if the profiler > is supported on the chrome branding and channel for the platform. > > The end goal is to reduce the configuration complexity, to support > enabling per-thread on Android. > Bug: 1129939 > Change-Id: Ibbd6f4725804b40ac77e15aaa3bd15ad76a0e7b0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425165 > Reviewed-by: ssid <ssid@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810835} TBR=etiennep@chromium.org, ssid@chromium.org Bug: 1129939 Change-Id: Ie69c5c695bc286f070e34f70553ffd35562208b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436250Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#811521}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601315959-5577f3dbf01608bf6e215c63714e131a2bd389f7.profdata to chrome-mac-master-1601337561-8feee235133953607f7453082566ed5b7d8ffb34.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: I703ed5612f027a96a6e39464e9c3b10696a73990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437632Reviewed-by:
-
Lan Wei authored
CheckinRequest uses a non-existent #define for ChromeOS, defined(CHROME_OS), we should replace it with defined(OS_CHROMEOS). Bug: 1121653 Change-Id: Ieae0bdf874c006296bfedc4da3cd2394b4e3a9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434777Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601315959-4ec2d6a153e04750c200a2fe71bb63fd4f2d802c.profdata to chrome-linux-master-1601337561-307983a438d89a0d060ed0a79e008eada61629c3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org Change-Id: I4f5536ecc77a4bb7de555059c5ec9269c3c95415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437789Reviewed-by:
-
Peter Kasting authored
I didn't realize this existed when I wrote the initial change. Bug: 772945 Change-Id: Ib4dd142fc06b42f02c38811a7684f5564481471f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433587 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Rachel Wong authored
There are several AutocompleteMatch fields that provide rich entity information but are currently not used by the launcher. This CL adds rich entity fields to the omnibox results, which will then be forwarded to ash. Any changes which may override existing behaviour are gated behind a feature flag. Bug: 1130372 Change-Id: Ia92aaa88cc1c6af41bd3b820b85b978c7b108e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409685 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811516}
-
