- 27 Jun, 2018 40 commits
-
-
Josh Karlin authored
What: PrioritizedTaskRunner currently runs its tasks (from RunTaskAndReply) in prioritized order but not the replies. This CL adds a priority queue for replies to run in order as well. Why: At least for the cache, the reply task is equally important to the posted task and should run in priority order. Bug: 856674 Change-Id: Icea37adb96891473292e0c38805c42e84f9d4f5f Reviewed-on: https://chromium-review.googlesource.com/1114921Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570781}
-
sczs authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I312851c5408ad34f690dc0b456612506350d8be7 Reviewed-on: https://chromium-review.googlesource.com/1116347Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#570780}
-
Rayan Kanso authored
DatabaseTasks can create subtasks out of other DatabaseTasks in order to re-use components and not rewrite code. Change-Id: I04d84e90ddf4e2ac1986f7ccff122d210523d752 Reviewed-on: https://chromium-review.googlesource.com/1112665 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570779}
-
Mustaq Ahmed authored
With User Activation v2, activating a parent frame doesn't activate its subframes. We fixed these two tests by sending the click to subframes. This needed a workaround in auto-click.js because the mutation observer there in doesn't seem to work when a button element is added to a subframe. Bug: 802371 Change-Id: I786668c87b802565e99ad16223cafc8ac1fd6296 Reviewed-on: https://chromium-review.googlesource.com/868323Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#570778}
-
Justin Cohen authored
-Fix tapping NTP action cells when omnibox is focused. -Do not remove action items when most visited is empty. -Disable dynamic type sizes on most visited and action items. -Fix omnibox visibility on iPad when search provider changes. Bug: 846764, 852108, 850469, 848762 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie1c38be47fb9a60325387a78f55eb1a548dae831 Reviewed-on: https://chromium-review.googlesource.com/1110148 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#570777}
-
Vadym Doroshenko authored
This CL contains: 1.Filtering blacklisted matches in NewPasswordFormManager. 2.Extracting blacklisted matches to |blacklisted_matches_| variable in NewPasswordFormManager. 3.Implementing functions GetBlacklistedMatches and IsBlacklisted in NewPasswordFormManager. Bug: 854197, 831123 Change-Id: I50476c16c2ebfa8c8a1062889b8d133d323233f5 Reviewed-on: https://chromium-review.googlesource.com/1116962Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#570776}
-
bsheedy authored
Disables Skia's CCPR support for the VR browser since it somehow causes serious rendering issues. This workaround can be removed once the root cause is found and fixed. Requires that https://skia-review.googlesource.com/c/skia/+/137763 be landed and rolled first. Bug: 856404 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4121319cae3a465798077cfeac058d84e9e9dd93 Reviewed-on: https://chromium-review.googlesource.com/1116066 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#570775}
-
Arthur Sonzogni authored
The bug was introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/1107808 Soon after creating a new provisional DocumentLoader, the parser of the current DocumentLoader is canceled. It can causes document.onreadystatechange to fire. If window.stop() is called it can remove the new provisional DocumentLoader. This CL fixes the bug and add a regression test. Bug: 856759 Change-Id: Ifb39a75d04b250f0c97ebf07c5a9abf1f4631ff7 Reviewed-on: https://chromium-review.googlesource.com/1117038Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570774}
-
Allen Bauer authored
Bug: none Test: none Change-Id: Ifecd2ab5a68c843a835b68f41bd6ac3b248dabde Reviewed-on: https://chromium-review.googlesource.com/1115217 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570773}
-
Marc Treib authored
IsSyncAllowed, IsSyncRequested and HasUnrecoverableError have all been replaced by GetDisableReasons/HasDisableReason, so use those instead. Bug: 839834 Change-Id: Id4939bd4de6a43ae4bfd5c64b6aa79be51a82ebf Reviewed-on: https://chromium-review.googlesource.com/1116704 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570772}
-
Nico Weber authored
Not clear why it wasn't running, and network_service_browser_tests, not_site_per_process_browser_tests, viz_browser_tests already all run and pass -- and what's better than running browser_tests three times? Running it four times, so add vanilla browser_tests too. Bug: 843511 Change-Id: I682375c0c4a5a673a0e5410452d5560cad3ccebd Reviewed-on: https://chromium-review.googlesource.com/1117019 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#570771}
-
Nico Weber authored
The one test that used to fail seems to pass now. Bug: 815190,843511 Change-Id: I2e77719aa557b2055209d58dcb3c124bc0ad2576 Reviewed-on: https://chromium-review.googlesource.com/1116899Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2c74d85c16af..81f51975125c git log 2c74d85c16af..81f51975125c --date=short --no-merges --format='%ad %ae %s' 2018-06-27 titovartem@webrtc.org Fix pylint presubmit errors and warnings from untouched modules. 2018-06-27 titovartem@webrtc.org Extract fft to separate target to be able to move it to third_party Created with: gclient setdep -r src/third_party/webrtc@81f51975125c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id08c24336e0684dc9a932fcd885bdd50e4bdb86d Reviewed-on: https://chromium-review.googlesource.com/1116819Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570769}
-
Sahel Sharify authored
With wheel scroll latching enabled, wheel dom events in a scroll sequence are sent to the target which was under the cursor at the beginning of the scroll and retargeting happens either on the beginning of the next scroll sequence or when the target gets deleted in the middle of the current scroll sequence. With this cl if an event gets prevented by default, the wheel target gets reset to make sure that a new targeting happens for the next wheel event. Bug: 829662 Test: AsyncWheelEventsBrowserTest.WheelEventRetargetOnPreventDefault Change-Id: Id60476ae0772a53e938cf8738283576a8083f6a4 Reviewed-on: https://chromium-review.googlesource.com/1113666 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570768}
-
Hwanseung Lee authored
should throw an InvalidStateError when buffer has been already set in ConvolverNode Bug: 709656 Change-Id: Ia0826f9ffa2e180da1311f4cded8ff7fe5461147 Reviewed-on: https://chromium-review.googlesource.com/1077713Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#570767}
-
Koji Ishii authored
fast/text/emphasis-overlap.html fails in LayoutNG because what it is testing works correctly, but LayoutNG fixed crbug.com/40634 and that difference caused pixels to fail. This patch removes dependency to crbug.com/40634 behavior from the test, and hence it passes in LayoutNG. The behavior of crbug.com/40634 is now split to wpt/css/css-text/white-space/trailing-space-before-br-001.html in r570744 (CL:1116622). TBR=eae@chromium.org Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8acfa36f83bac02ae71bd8907e733f05ecf359fe Reviewed-on: https://chromium-review.googlesource.com/1116511Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570766}
-
Jan Krcal authored
This CL creates the bridge for the autofill_profile sync type. It only implements reacting to local changes, applying sync changes will be implemented in a follow-up CL. The CL only converts relevant unit-tests from AutofillProfileSyncableServiceTest. Tests corresponding to ProfileSyncServiceAutofillTest will come in later CLs. Bug: 836718 Change-Id: Ic91fad53a0623be416ceb4c1f96451c732cf5ac3 Reviewed-on: https://chromium-review.googlesource.com/1113187Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570765}
-
Vaclav Brozek authored
This CL teached the FormData -> PasswordForm parser to prevent the conclusion that there is a confirmation password field on a form which has no new password field. This state does not correspond to reality. Therefore this CL adds a DCHECK to verify this and also a sanitization step for processing the server data. Bug: 845426 Change-Id: I6ffffb31766f9271f0f8021f3aa249d1ee163730 Reviewed-on: https://chromium-review.googlesource.com/1116920Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570764}
-
codeimpl authored
The spec[1] says that the boundingBox attribute should be DOMRectReadOnly instead of DOMRect. [1] https://github.com/WICG/shape-detection-api/pull/41 Bug: 852838 Change-Id: I8666d56fcaf4ac77c29b497827b410ec0aeaa916 Reviewed-on: https://chromium-review.googlesource.com/1102838Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#570763}
-
Tiger Oakes authored
supersize html_report (in //tools/binary_size) is being redesigned to use a tree view to make it easier to navigate. Tree views are more familiar to users and open up additional features we plan to add, such as rendering size diffs by showing negative values. Symbols and files in the tree are organized by size, with larger items on top. You can preview an example report at: https://notwoods.github.io/chrome-supersize-reports/ Alternatively, compile your own report by running: ``` tools/binary_size/supersize html_report chrome.size --tree-view-ui --report-dir size-report -v xdg-open size-report/index.html ``` Design Doc: go/supersize-tree-view-ui Bug: 847599 Change-Id: I78add67bbc759903b1717585a9463dfd08dacceb Reviewed-on: https://chromium-review.googlesource.com/1113848 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#570762}
-
Raphael Kubo da Costa authored
Back in early 2016, some tests were marked flaky and whatever was causing the flakiness has since been fixed -- they are currently failing because the existing expectations no longer match the results that are produced. Rebaseline the tests and remove them from TestExpectations as per the discussion in the bug, while also adjusting some of the tests in the process: * fast/events/scale-and-scroll-iframe-body.html: Explicitly disable scrollbars in the iframe after http://crrev.com/398951, otherwise we end up with platform-specific PNG expectations due to the differences in the scrollbars. * fast/events/updateLayoutForHitTest.html: Avoid confusion by removing some style assignments that had been causing console errors ever since the test was added more than 10 years ago. Bug: 594672 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I24264f86ce1dcebdac2a6a9f912d3b292d39bdc0 Reviewed-on: https://chromium-review.googlesource.com/1113310Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#570761}
-
Adithya Srinivasan authored
Makes the tests simpler in many cases and also removes the -expected files. Bug: 781655 Change-Id: I15957ca318c56f4904bb68bc085880e70823d202 Reviewed-on: https://chromium-review.googlesource.com/1111910 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570760}
-
Juan Antonio Navarro Perez authored
Test flaky in: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-marshmallow-arm64-rel TBR=ntfschr@chromium.org,changwan@chromium.org,boliu@chromium.org Bug: 855732 Change-Id: If4fe61aa767bd92229692bddb4659901fa5b2da5 Reviewed-on: https://chromium-review.googlesource.com/1117065Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#570759}
-
edchin authored
This CL implements these metrics in tab grid: MobileStackViewCloseTab when a tab is closed via the X MobileToolbarStackViewNewTab when a new tab is created (only through the + button.) MobileTabReturnedToCurrentTab when users exit the tab switcher to return to the current foreground tab MobileStackViewNormalMode when user switches between regular & incognito MobileStackViewIncognitoMode when user switches between regular & incognito Bug: 818452 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I570a31af65bc929f646d005789cecb1a0afca442 Reviewed-on: https://chromium-review.googlesource.com/1116284Reviewed-by:Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570758}
-
A Olsen authored
Certain policies contain JSON - that is, for the admin to use them properly, they should set them to a JSON string that conforms to a particular schema. Until this change, that JSON was not being validated, and errors were not getting reported to the user. This CL enables validation for two JSON policies - DefaultPrinterSelection and AutoSelectCertificateForUrls. It uses a histogram to track how often these policies contain any errors, and it reports any errors encountered to the user in chrome://policy. However, it does not actually reject any policies unless they have the wrong root type. This is by design since the code that reads these policies is already robust. Didn't work on Android at first since these policies don't exist there - this is fixed by guarding these handlers with an #ifdef. Bug: 834804 Change-Id: I64100ab3bcab07c6f4c2c53117cc4e9225a609e8 Reviewed-on: https://chromium-review.googlesource.com/1106158 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#570757}
-
Juan Antonio Navarro Perez authored
Test has been flaky on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester TBR=klausw@chromium.org,mthiesse@chromium.org Bug: 856546 Change-Id: I25d4a94ea0e5a535dd960574432ad2ade882c0df Reviewed-on: https://chromium-review.googlesource.com/1117062Reviewed-by:
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I77083c1d94991640839f1d3e820359dc3088f070 Reviewed-on: https://chromium-review.googlesource.com/1116978 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#570755}
-
Arthur Sonzogni authored
When the FrameLoader start a new load. It replaces the current provisional DocumentLoader by a new one. Removing the first one can leave the frame without any loading DocumentLoader and triggers the 'load' event, which can detach the frame. The bug was caused by: https://chromium-review.googlesource.com/c/chromium/src/+/1107808 where the line checking whether the frame was detached or not was removed. It is now clear why this line was useful, so this CL adds it back. Bug: 856396 Change-Id: I1bdeb47e546dbb1805659bc986d590e9900c51d1 Reviewed-on: https://chromium-review.googlesource.com/1114975Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/97cb0ea3..b0de1093 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I48feb17d11ff526f8c82109c6834ac48df343dda Reviewed-on: https://chromium-review.googlesource.com/1116859Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570753}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f989b62823cb..484f9f764dc5 git log f989b62823cb..484f9f764dc5 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 sarath.singapati@huawei.com Corrected the traffic settings to reflect the settings by devtool. Created with: gclient setdep -r src/third_party/catapult@484f9f764dc5 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7fd748d18e27b813ac3018107ff3aafcba82f34c Reviewed-on: https://chromium-review.googlesource.com/1116820Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570752}
-
Greg Thompson authored
One ctor was leaving the hovering_ member in a non-deterministic state. BUG=855979 TBR=nzolghadr@chromium.org Change-Id: I4b49426d08940cd24bb31039bfa5a75b14aadb6d Reviewed-on: https://chromium-review.googlesource.com/1116788Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570751}
-
Miguel Casas authored
This reverts commit c1ee5625. Reason for revert: The necessary predecessor crrev.com/c/1104394 has been reverted (for other reasons, see crbug.com/822346#c33) Original change's description: > vaapi: decode on client NativePixmaps > > This CL teaches VaVDA to use client VASurfaceIDs to decode onto, saving > a buffer copy and removing a costly blit (DownloadFromSurface) on the > GPU Main thread. Three groups of changes: > > 1. In AssignPictureBuffers(): if |vaapi_picture_factory_| Create()s a > VaapiPicture with a VASurfaceID, we use those to decode onto and set a new > flag: |decode_using_client_picture_buffers_| > > 2. When the decoder calls CreateVASurface(), instead of giving it the first > |available_va_surfaces_|, we need to figure out the first VASurfaceID in > this |available_va_surfaces_| such that the corresponding VaapiPicture in > |pictures_| is available (i.e. in |available_picture_buffers_|). > Reason: libva holds on to some VASurfaceIDs, there's no simple one-to-one > correspondence like on ToT. > > 3. When we're ready to OutputPicture() to |client_|, instead of using the first > |available_picture_buffers_|, we find the corresponding one for the > passed |va_surface_id| (we could search all over |pictures_| but there's > always less |available_picture_buffers_|. > > Some other notable developments: > > - s/output_buffers_/available_picture_buffers_/ > - OutputPicture() loses a parameter. > - |decode_using_client_picture_buffers_| is still false for e.g. VP9 Profile 2 > or the ImportBufferForPicture() path. > - Pictures is made a base::small_map. (Originally from crrev.com/c/988512). > > Bug: 822346, 717265 > Test: v_d_a_unittest vp8/vp9/h264 passing on eve, running crosvideo changing > resolutions for a long time. No hickups, no dropped frames. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I3d5a4d3c83002c8d0977702c9b97ffec52b1db23 > Reviewed-on: https://chromium-review.googlesource.com/1021675 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568880} TBR=mcasas@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822346, 717265 Change-Id: I5e8cb9431f72a65f67782e59cb5ce52f7e1d4ce7 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1116938Reviewed-by:
-
W. James MacLean authored
Since the context menu can be dispatched an arbitrary time after the mouse event that sets last_mouse_move_target_, we should verify the pointer is still valid by making sure it's still in the owner's map. Bug: 856976 Change-Id: I928935b74d6fa99ba7769fa170a9c817f98d5a46 Reviewed-on: https://chromium-review.googlesource.com/1116862Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#570749}
-
Rohit Rao authored
The card style is now disabled behind a new IsSettingsUIRebootEnabled() experimental flag. These changes were inadvertently landed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1114605. BUG=805213 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7c22b635199810bab3332443e8a9251c073ca245 Reviewed-on: https://chromium-review.googlesource.com/1116919Reviewed-by:
-
chrome://translate-internalsNicolas Ouellet-payeur authored
This should make it easier to debug Translate internals. UI changes: 1. Add 'translate_recent_target' to the Preferences dump in the translate-internals page. 2. Add a box for the user to enter a new value for 'translate_recent_target', and an 'update' button. When the user clicks the button, the preference is updated. Bug: 855176 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I97437c792c8b6efb73bdb6d1c21f05c5ffff7d8a Reviewed-on: https://chromium-review.googlesource.com/1110739Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#570747}
-
Sam Maier authored
Bug: 749239 Change-Id: Id7b49e187deb91d8201d45029f58ef84f97fae3e Reviewed-on: https://chromium-review.googlesource.com/1115515Reviewed-by:
-
Noel Gordon authored
Flakes in RELEASE on linux-chromeos-rel CQ bot. Tbr: tapted Bug: 850372,857021 Change-Id: I548307fa8a93689a348f2e96504815e3fe27cf44 Reviewed-on: https://chromium-review.googlesource.com/1116879Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570745}
-
Koji Ishii authored
Blink and WebKit fails to remove trailing spaces preceding `<br>`. This patch adds a test for that case. Gecko, Edge, and the current build of LayoutNG passes this test. This was originally reported at http://crbug.com/40634. It turns out that fast/text/emphasis-overlap.html relies on this behavior. Before removing the reliance, adding this test to ensure this case is covered and to prevent regressions in LayoutNG. TBR=eae@chromium.org Bug: 40634 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iff877bac1c27c8689bdbc6949d01a9ea380463bd Reviewed-on: https://chromium-review.googlesource.com/1116622 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
stkhapugin@chromium.org authored
Uses new icons, adds a background for the icons, changes the icon offset to match the new omnibox layout. Bug: 821817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibdd074891eb1f4b0853c28b9117d1e84f05e070c Reviewed-on: https://chromium-review.googlesource.com/1114744Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570743}
-
Alexander Timin authored
Support temporarily increased priority for compositor tasks for input: - Explicit OnMainFrameRequestedForInput signal (new) - Implicit presence of input tasks. This patch does not change default behaviour, but add Finch hooks for enabling these options and controlling the number of tasks N. R=skyostil@chromium.org,alexclarke@chromium.org BUG=853771 Change-Id: Id82b712e46108c51a948a66cfd31556e04eb457a Reviewed-on: https://chromium-review.googlesource.com/1104677Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570742}
-
