GitLab

This patch removes the deprecated accessibility selection code from Blink.
This is timely, because the new selection code has been on for 1.5 weeks and
no major regressions have been encountered.

R=aleventhal@chromium.org, dtseng@chromium.org

Bug: 639340
Change-Id: Ibdf8a7575e229407fe3418a4efd5eed96b7b8540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620967Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662206}

For history webuis and the recent tabs menu, we offer the possibility
of using requests to Google's favicon server as a fallback mechanism,
instead of requesting from sync. We use LargeIconService to achieve it.
This behavior is guarded by a feature flag disabled by default. We also
fix a minor formatting issue in chrome/browser/about_flags.cc.

Bug: 955475
Change-Id: I1ff64611cfde1e995a14b36ea2496b33d214eea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603444
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662205}

If a notification is dismissed but not dealt with,
then show it again after 1 day.

If a notification is not dismissed, and password is not changed,
then notification is updated after one day, since the text showing
the how urgent it is should change.

Deleted some code that special cased the "expired" case -
this case actually has the same logic as "about to expire" case,
so it doesn't need a special case.

Added more unit tests for SAML password expiry notification.

Bug: 930109
Change-Id: Ie035ec788ee083d07261bca0e19f216e6bc7d6cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620642
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662204}

The cookie was a domain cookie, but host cookie is preferred.

This allows simplifying and re-enabling the test.

The test was failing with net::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN.
This CL removes the DNS rule and the SSL configuration (which were
required for the domain cookie, but can be removed for a host cookie),
which makes the test simpler and hopefully more robust.

Bug: 964264, 965993
Change-Id: I03412b9046b79a2cbb56ebdb95dd1661d67fb938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617360
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662203}

Also remove the base writer interface as it's not needed.

Bug: 961336
Change-Id: Ie942c35079ba45c37b549a977e952470a95d529c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613881
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662202}

This CL adds a workaround for the advertised supported VAImageFormats in
Intel's media driver (iHD). Right now, the driver is advertising some
formats that it actually doesn't support. Until this is fixed, we are
conservative and remove all the formats other than I420 or NV12 from the
list of advertised formats.

Some additional cleanup is done per https://crbug.com/956581.

Test: VaapiJpegDecoderTest.* pass on eve.
Bug: 955284
Change-Id: I734581ef7c533251559c66355755d9e7766239cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623491Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662201}

Old parser is disabled is final state of the launch of the new parser,
so everything should work for it. PasswordManager::ProvisionallySavePassword
sends ReportMissingForManager metric even if old parser is disabled (and
then it sends it incorrectly). This metrics is sent for NewPasswordFormManager
in PasswordManager::ProvisionallySaveForm.

Along the way extracted sending of SubmittedFormFrame metric to a separate
method and called it for NewPasswordFormManager.

Bug: 831123
Change-Id: If170658a030e2b34b8aa7b9bd70cc048d8de0fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624573
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662200}

Bug: 956459
Change-Id: I8c4c305347b9bc98f8f032c5f738baf3e728c940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621139
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662199}

CalculateIdealBounds() updates member variables and their properties.
It should not be marked as const method.
Remove the call from
CalculatePreferredSize() that is const. It is not needed, because
CalculateIdealBounds() is called when bounds change.

Tests: Existing shelf tests + manually
Change-Id: Iadf330ee25542fb329065df058d930a9cca5cb23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622385Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662198}

Disable:
- WebXrVrDeviceTest#testForNullPosesInInlineVrFromNf
- WebXrVrDeviceTest#testForNullPosesInInlineVrOnNavigation
- WebXrVrDeviceTest#testForNullPosesInInlineVrPostImmersive

These tests are failing on Nougat Phone Tester and android-pie-arm64-dbg.

TBR=bsheedy@chromium.org

Bug: 758296
Change-Id: Ide558551413af934fba02c68ed5a8e5e7a5933da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624827Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662197}

This change also makes the supervision server flags simpler, since we
are getting close to a final server implementation.

Bug: 958995
Change-Id: Ic3c07ef4a992faf6238bbd2a492848d26174a461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621010
Commit-Queue: Lucas Tenório <ltenorio@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662196}

This CL creates a new AudioLauncherActivity alias to the
MediaLauncherActivity that handles audio intents (while the main intent
handles video and images). We disable AudioLauncherActivity on Android
Go while leaving it enabled on enterprise-managed devices. This allows
us to continue to handle video and image intents on Android Go without
breaking the memory restrictions imposed on music players on Android
Go.

TESTED=Able to open video/audio/image files with Chrome on an
enterprise-managed device. Able to open video/image files with Chrome
on an Android Go device, but not given the option to open audio files
with Chrome.

Bug: 965166
Change-Id: Ia2b774a048ac430b658c29b8fb11bf8835709842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620610Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662195}

Bug: None
Change-Id: Ifd0b059157fa7e32a60fc90707d51a409f89ded0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620287
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662194}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ebe38ca9..927eded5

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ifbbefd3863b71fea73e80773c740a0c87be74770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624825Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662193}

Renaming from MDCLegacyInkLayer+Testing.h MDCLegacyInkLayer+Private.h
ios/third_party/material_components_ios/BUILD.gn

https://critique.corp.google.com/#review/248588133

Bug: 965882
Change-Id: I8a98c74440ee2edcb39bf9b1d6f8ed4c7e042de8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624185Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662192}

Before this patch, developing on http://localhost would not skip the
browser payment sheet, even though all requirements were met: single
URL-based payment method was requested without any additional data from
autofill, the method had a default payment app, and show() was called
with a user gesture. If the hostname was changed to
https://not-localhost.com, then skip UI would trigger.

This patch adds an exception for http://localhost to be classified as a
valid URL-based payment method for the purposes of the skip UI check.

After this patch, developers on http://localhost have the ability to
skip the browser payment sheet.

Bug: 965141
Change-Id: Idd639ceabf093ab8a82ccf52dd278bf142d42630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620511Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662191}

This CL updates MainController to use a regular _settingsNavigationController
when presenting the Google services settings. This ensures that when the
user attempts to open an URL from the Google services settings, the regular
close settings and open URL command is executed.

Bug: 963436

Change-Id: Ibec138d6cd3baf34c43f713f43c1e9cb908a8382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621132
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662190}

Bug discussion suggests the issue was fixed, and
NoTrackDoubleFieldsForSerializerScope no longer exists. Remove the
suppression.

Bug: v8:3143
Change-Id: Ic8bcea8d111ad8334914a817ca46a5f4a83558fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618147
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662189}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2efe6ea070c5..e66f7aeb4a32


Created with:
  gclient setdep -r src-internal@e66f7aeb4a32

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=lowell@google.com,kmilka@google.com,yutak@google.com

Change-Id: Iff6bb88968f1436a61f6ba6673179e4da5fc63bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625005Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662188}

Bug: 965517
Change-Id: Ic059d5b5a0c70701b657d66424d47f5c4de9ae41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623496Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662187}

TBR=alemate@chromium.org

Change-Id: I9377203afcf10794cd542af6192dceedd4f2ffd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618078
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662186}

Ths CL renames TrayNetworkStateObserver -> TrayNetworkStateModel
to better reflect its purpose.

Bug: 862420
Change-Id: I129419cb6278401bd2f6f710aecf633e8e71501f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622427Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662185}

A CL[1] over a year ago added an if check that caused autoscrolling to stop
if the cursor left the page and the middle button wasn't held in. Since
other Windows apps allow auto scrolling to continue in this case, it
makes sense to match that behavior and also allow it.

[1] https://crrev.com/5971e47dc08dbb773f58fd6fb13b1df7917fd295

Bug: 806562
Change-Id: Id7259b5242f21c2042f300d7f0a606179be89b5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618141
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662184}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I1af92be6b977ca537ba668573029b03518e9e6fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624766Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662183}

We can't assume a FrameOwner's content view is a local frame view here
since we might be removing a root scroller because it's no longer
valid; it could be that it once was a LocalFrameView but has since
been replaced by another type of view.

No test since this came from the fuzzer and only causes an issue when
run under UBSan.

Bug: 961597
Change-Id: Ia24c000ac53a795d0325c2aa8825e901344f3ec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618203Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662182}

Removes the Translate Settings entry from the Content Settings page if the
Language Settings UI feature is enabled.

Bug: 957688
Change-Id: Iee16ac5ca00bae2f14f398e80427cbcd23ac3984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622988Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662181}

Bug: 957688
Change-Id: I3d4afd4dadbabfb544b7741ae9365aac8bee29cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622326Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662180}

The root scroller doesn't account for non-overlay scrollbars correctly.
This will be a non-trivial fix and require some more time to think
through so this CL disables root scroller on non-Android platforms until
the issue can be fixed.

Bug: 948059,953285
Change-Id: I2425c907d7a2c9363cce39e69183063fafbed65e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617378Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662179}

This CL creates public/browsing_data/ and moves these headers into it:
  browsing_data_removing_util.h
  system_cookies_store_util.h

To match this, in //ios/web/, the following files are moved from net/cookies
to browsing_data/:
  system_cookie_store_util.mm
  system_cookie_store_util_unittest.mm

READMEs are added as well.

Bug: 942244
Change-Id: I509c1fc170952f8a4a72977dcc2b8d880b837610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624571
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662178}

This should pass now.

Bug: 961204
Change-Id: I78274311f576bb22ee96526e14cf16352c218090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624907
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662177}

The original event_sigcb and event_gotsig race conditions were resolved by
https://crbug.com/605894. However, the suppression was so broad that it covered
every event loop iteration using libevent. Several other bugs have crept in
in the meantime.

Add finer-grained suppressions for those bugs.

Bug: 23244, 965714, 965717, 965719, 965722, 965724, 965726
Change-Id: I646da30f7df1d0a19a4c1eb6ad7aebcd93ba099b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620705Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662176}

For light illustrations, use a translucent white instead of solid
off-white to frame the pictures.

For dark illustrations, remove the black background and use a
translucent black instead of solid gray to frame the pictures.
Also, remove the solid dark gray fill of the clouds some of the
illustrations had.

Light mode screenshot:
https://screenshot.googleplex.com/VknVOdbx3Yu

Dark mode screenshot:
https://screenshot.googleplex.com/fc0qf1Kot7p

Bug: 955462
Change-Id: Ica39d681d684ac29b51fdc123d402d6611f2507d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622871
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662175}

When a table-cell changes between having a restricted block-size and not
having one, that doesn't imply that we have to re-lay out all children.
Move the bit out of ConstraintSpaceFlags, so that we don't force a cache
miss on all children when this happens, but rather check if the size of
the children will actually change.

This is a follow-up on
https://chromium-review.googlesource.com/c/chromium/src/+/1621166

Bug: 964282
Change-Id: I56bca9eb820a008b54dfb7279860114939a1fe8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624325Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662174}

This CL sorts all the flag_descriptions in the OS_CHROMEOS section of
flag_descriptions.{cc,h} according to the ordering prescribed in the
comments at the top of flag_descriptions.h.

I did this previously in crrev.com/c/1477140 but it got out of order
pretty promptly, so this CL also tries a friendly reminder at the
bottom of the OS_CHROMEOS section ...

Bug: none
Test: unit_tests --gtest_filter=AboutFlag*
Change-Id: Ib1b9741656055208d5a5693f020e79e92e3ec0c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623651
Auto-Submit: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662173}

Remove "@private" from these <pin-keyboard> properties that are
actually public and are used by consumers of this Polymer module:

* enable-password
* password-element
* value

Bug: 964069
Change-Id: I2178de7e8ac9ff7e10ca24b5cb40ef723a0fd1eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622169Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662172}

Make the content property of the meta name=color-scheme parse as a CSS
color-scheme property value and add it at the presentation level as
specified in css-color-adjust.

Bug: 925935

Change-Id: I0d6d9faa3cbf782f2be3e6b4b09d8f1b951e9efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605907Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662171}

When the DSE changes, the empty text icon in the omnibox should become
the new DSE favicon or the default loupe.

Flags: kNewOmniboxPopupLayout and kOmniboxUseDefaultSearchEngineFavicon
are separate flags but "DSE in omnibox" feature is dependent on
"new omnibox popup layout" feature, i.e. first one is not working
without second, however the second one can work independently.

Bug: 945313
Change-Id: I6d46de24e284baef99be3c215e0c3c30e3d0ff53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617821Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Auto-Submit: Nazerke Kalidolda <nazerke@google.com>
Cr-Commit-Position: refs/heads/master@{#662170}

This cl enables the NoCreditCardAbort flag on ToT before landing the finch
experiment for stable:
https://critique.corp.google.com/#review/248771530

Bug: 955857
Change-Id: I5e41b09eed0fa18affa0749d8b43e0f78ba229de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622414Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662169}

This reverts commit cda7826e.

Reason for revert: launch approvals pending.

Original change's description:
> Enable new session sync logic by default
>
> The new logic has better privacy and reliability properties, and has
> been experimented with on dev and canary channels. We now enable it by
> default to launch with M75.
>
> Some unit tests had to be updated to reflect the new behavior, and some
> additional refactoring is used to improve the accuracy of some function
> names.
>
> Bug: 882489
> Change-Id: I9eb0816cbec1024581efc227b551781a6fbd6559
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543389
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#645925}

Bug: 882489,965951
Change-Id: I04b12de7ab33368fbfe4e5579b2ed974ba78a7c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624574
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662168}

Handle unknown Mojo enum values in PerformRequest function.

BUG=b:129432579
TEST=unit_tests

Change-Id: Ie48643728a1d22b97b135f983ee05f1b78a8af59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611600
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Polina Bondarenko <pbond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662167}