- 22 Oct, 2020 40 commits
-
-
Hayato Ito authored
Disable WebViewAccessibilityTest.FocusAccessibilityNestedFrame. TBR=dlibby@microsoft.com Bug: 1141313 Change-Id: I2939705a8e0a9ba3c94ba131493a77b1586ed440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491575Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#819764}
-
Felipe Erias authored
The scrollbar-width CSS property allows the author to set the maximum thickness of an element’s scrollbars when they are shown. Its value is one of the keywords "auto", "thin", and "none". This is part of the CSSScrollbars feature (status: test). See the CSS Scrollbars spec for more details: https://drafts.csswg.org/css-scrollbars Bug: 891944 Change-Id: Iddc833d6af877c312a11452a6cfdcb05d45b1a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488947Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Cr-Commit-Position: refs/heads/master@{#819763}
-
Mugdha Lakhani authored
Expose an API to perform a prerender (implemented using NoStatePrefetch). A browsertest and a javatest have been added to verify the expected behavior. Bug: 1136091 Change-Id: I158b5b954fbbf2e3cb9821180d6afd6aa042abd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470634 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#819762}
-
Kent Tamura authored
Having both of fieldset-percent-height.html and fieldset-percetage-block-size.html is confusing. Merge the new one into the old one. Change-Id: Ibcdf17d744c4cd622a8db33f6706cdc9f65ad416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491573 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819761}
-
philipel authored
Bug: none Change-Id: I0bb244b3795da211d43a30684a61e079d127a68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489881Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Philip Eliasson <philipel@chromium.org> Cr-Commit-Position: refs/heads/master@{#819760}
-
Kent Tamura authored
We'd like to share the logic with LayoutNG. This CL fixes some failing tests with LayoutNGTextField flag. This CL has no behavior changes for now. Bug: 1040826 Change-Id: I0c5fa3da1eab44b35c0395298c72ba123bdd1ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491700Reviewed-by:
-
Mohamed Amir Yosef authored
This is preparation for adding the functionality of moving multiple passwords from settings view. Mocks are in the linked bug. TBR=karandeepb@chromium.org Bug: 1139263 Change-Id: I8d801c73e5566a9c44c9a69ea099fe2116d8cdde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481124 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#819758}
-
Patrick Brosset authored
Unfortunately the devtools frontend and a bunch of tests that check it live in 2 separate repos (chromium.src and devtools_frontend), this means that sometimes a frontend change will cause tests to fail, and the only way to deal with this is first disable those tests in chromium.src then land the frontend change, then go back, fix and re-enable those tests. This disables 2 color-swatch tests in order to land: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2480042 Bug: 1137438 Change-Id: I0c81bc188260173f5b041dd53d63d866fabf43df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490282Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819757}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603322998-a2bfaa167e3697b2b14734e406c0399abff8eaf1.profdata to chrome-linux-master-1603346243-3f07f08fc669370b6060ed7693324b959ad870ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I003ed2c4807c7d0c6e1f8e15ea82e796a555a445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491664Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819756}
-
rbpotter authored
Currently, the request list path in optimize_webui is computed based only on the host name. Add a '-v2' to the path for Polymer 2 builds (only applies to OS settings), to avoid the possibility of v2 and v3 builds accessing the same request list when generating dependency files. Collisions result in v2 dependencies being listed in the v3 build.d file, and vice versa, leading to build failures. Bug: 1132403 Change-Id: I4d92676db501669ddb99b204abfc4413dd8e2087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491241 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#819755}
-
Wojciech Dzierżanowski authored
AutoPictureInPictureTriggeredWhenFullscreen can be moved from the InProcessBrowserTest-based (i.e., full browser) PictureInPictureWindowControllerBrowserTest to the ContentShell-based PictureInPictureContentBrowserTest. We can get rid of some of the unnecessary baggage without sacrificing coverage. In particular, fullscreen in this case means sizing the video to the size of the window rather than actual fullscreen. Compared to the PictureInPictureWindowControllerBrowserTest version, the new test doesn't try to verify PiP window visibility. That's because there are other tests that do it specifically, and the focus of this test are video element state transitions. Bug: 1058087 Change-Id: I7decc1674811c7c25c538b65bdcd46d67b07e8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470525Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#819754}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8317652a9b4c76df9fc0ae138ed79d63add1a6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491350Reviewed-by:
-
sandromaggi authored
This refactors |GetFieldValue| to take an |ElementFinder::Result| instead of a |Selector|. Bug: b/168107066 Change-Id: I015c7159872e5328648ba0990275540886c5ecc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478943 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#819752}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/337086da0b11..0517bfe506ad 2020-10-22 thestig@chromium.org Remove `FXDIB_Format::kRgba`. 2020-10-22 thestig@chromium.org Remove `FXDIB_Format::k8bppRgba`. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ib77649cde5d1bae65679ce30f31a4ea1b59af433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491347Reviewed-by:
-
Mark Cogan authored
In mid-2017, files used only for the experimental "clean" architecture of iOS Chrome lived alongside the "classic" iOS Chrome files. To docu- ment which files were exclusive to the new architecture, some README.md files were created in some directories. The split between old and new architectures is long gone, and many of the files these READMEs refer to no longer exist. This CL just deletes them. TBR: stkhapugin@chromium.org Change-Id: Ic5b4df4535effff269ae9a4f56f07e3e79f394e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489886 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#819750}
-
Gang Wu authored
Bug: 1056501 Change-Id: If85d5c9d4ae144c10ba3c4a14cd1702508825f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485343Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819749}
-
Polina Bondarenko authored
Modify policy description and extend owners. BUG=b:170187468 TEST=none Change-Id: I721b1ce65daf77cd975d4c1a4032de77a04e4be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490104Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#819748}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c51c18a5866c..cab003ff2dd9 2020-10-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I084658668005afde2bc69f37e07b92a69746a5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491349Reviewed-by:
-
Joshua Berenhaus authored
Some of the Edge engineers got confused by this string and thought their histogram was missing from the xml file. I tested this string with them and they understood the failure better. Thought it might be useful for the entire project but feel free to suggest other options or push back! Change-Id: I6fa6aa98329e419ca6f3b687a42a683ba7bd6828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487691Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
-
Clemens Arbesser authored
This CL removes the behavior where the client would overwrite failed action statuses with navigation error, if present. It seems that the navigation error flag may be set too often, but more crucially, overwriting the status makes debugging harder. The backend can still investigate navigation_info to determine whether a navigation error occurred. Bug: b/170401521 Change-Id: I7d164f8c1a3746e8b7c1786461d30c1178002fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485166Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#819745}
-
Ramin Halavati authored
User type filter is updated to return correct type for ephemeral Guest profiles. This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop| flag. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Id5743e7d22cb9a1043e64ae7b6a696f41d0724d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470656Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#819744}
-
Jan Wilken Dörrie authored
This change replaces existing usages of autofill::PasswordForm with password_manager::PasswordForm in //ios. Bug: 1067347 Change-Id: Ie696e85f6cc8bd0ecfefd1baf0feba827ca92b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487323Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#819743}
-
Piotr Tworek authored
The code uses size_t, so it needs to include stddef.h. This works fine in default setup using libcxx, but fails with libstdc++. Bug: 957519 Change-Id: Id6bca0bbc911253a3be9a67b01dc348e467490ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489303Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#819742}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9606cffa66d0..c4af5cd3397d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I68cd6d1c00dbd0e979d3bf04bb7103101c13793a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491522Reviewed-by:
-
Dave Tapuska authored
Last usage of WebFloatRect has been removed on the blink public API. BUG=738465 Change-Id: I83917a10a80dda63c735918969f37103f7877816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490255Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819740}
-
Hsin-Yu Chao authored
The flag was added in commit 771fcd50 and fully launched in M84. Remove the flag and callers. Bug: 1129107 Change-Id: I4be9840dc4ed13e9b3e4bc8cb8259c2997bba96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423667Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819739}
-
Michael Irani authored
If you navigate to "Change language and input settings" page and then back to "Keyboard" page, the arrow pointing back to "Change language and input settings" is not highlighted when in ChromeVox mode Steps (in ChromeVox mode): 1. Device 2. Keyboard 3. Change language and input settings 4. Back button Bug: 1029954 Test: Manual Change-Id: Ib6c15179f2d217d84365927e2371a83961286f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487866 Commit-Queue: Michael Irani <michaelirani@chromium.org> Auto-Submit: Michael Irani <michaelirani@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819738}
-
Sam Zackrisson authored
This updates all AEC3 metrics to a longer, uniform expiry date. Bug: chromium:1140068,chromium:1140069,chromium:1140070,chromium:1140072,chromium:1140073,chromium:1140076,chromium:1140077,chromium:1140078,chromium:1140083,chromium:1140074 Change-Id: Ia89e725870ba76c48ec6ea99989d8d0b48fdc77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485103 Commit-Queue: Sam Zackrisson <saza@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
These validations are also done in ServiceWorkerStorage as of crrev.com/c/2473783. Remove checks in ServiceWorkerRegistry to simplify //content side. The previous CL didn't add validations in GetUserKeysAndDataByKeyPrefix(). This CL moves these validations to ServiceWorkerStorage. Bug: 1016064 Change-Id: I9396a3c4e6424ec1ba02f77932c2eb0fd6678465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491763Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819736}
-
Hitoshi Yoshida authored
RenderFrameHostImplBrowserTest.SameSiteNavigationResetsDocumentUsedWebOTP fails with segmentation fault if we enable pro-active same-site Browing-Instance swap. It is because the active main frame can be updated during a navigation, and a local variable |main_rfh| becomes invalid. This CL fixes the issue with accessing the frame dynamically. Bug: 1136383 Change-Id: I9707f846b384a195fc7cfa563f9165e486cae501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490972Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#819735}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d56c381aa518..8462cfcb03a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hayato@google.com Change-Id: Ic44125b40fc0c3364adea623f3e3f70256f8dba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491196Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819734}
-
Sam Thorogood authored
This is internal cleanup work so that there are fewer inline types inside the Extension APIs. Change-Id: I332fb6dbb4d78c46c599e1ba83e27d361d1ba40a Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440721 Commit-Queue: Sam Thorogood <thorogood@google.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819733}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/7e8ea22e4056..94384b5c685a $ git log 7e8ea22e4..94384b5c6 --date=short --no-merges --format='%ad %ae %s' 2020-10-18 marpan vp9-rtc: Fix to control for disabling loopfilter 2020-10-12 angiebird Add vp9_extrc_update_encodeframe_result() 2020-10-09 angiebird vp9_extrc_get_encodeframe_decision() 2020-10-15 jzern install vpx_ext_ratectrl.h 2020-10-09 angiebird Call vp9_extrc_send_firstpass_stats() properly 2020-10-09 angiebird Add vpx_rc_frame_stats_t 2020-10-08 angiebird Add vp9_extrc_send_firstpass_stats() 2020-10-07 angiebird Add vp9_extrc_init/create/delete 2020-10-07 angiebird Add callback functions for external_rate_control 2020-09-24 angiebird Add codec control for external rate control lib 2020-10-01 angiebird Add SetEncodeConfig and DumpEncodeConfigs Created with: roll-dep src/third_party/libvpx/source/libvpx R=jzern@google.com Change-Id: I49854d71e1f1b3dcd5f15e6214b81c6df40a04fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491682 Commit-Queue: Jerome Jiang <jianj@google.com> Commit-Queue: James Zern <jzern@google.com> Auto-Submit: Jerome Jiang <jianj@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#819732}
-
Hitoshi Yoshida authored
Code in Blink depends on some generated code in general. And its dependencies can be indirect. For example, t/b/r/bindings/modules/v8/properties_per_feature_installer_for_testing.cc includes t/b/r/bindings/core/v8/v8_origin_trials_test_dictionary.h through some other header files. But they have no dependency chain in GN file, and thus flaky compile errors can happen. This CL adds dependencies to connect a target to compile the .cc file and a target to generate the .h file. Bug: 1138802 Change-Id: I1f535475ffaaaa0373330dc66dc3ed3951a571e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477053Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#819731}
-
Ian Struiksma authored
Test PrefillFormAndFill fails often on Mac, disabling now so we can enable the other Mac tests. Bug: 1141208 Change-Id: Ia4f9a09ced6484f4941f5683b4ae499c009d7452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490849 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#819730}
-
Luciano Pacheco authored
Add module for - list_test.js - context_menu_handler_test.js - command_test.js - array_data_model_test.js - cr_test.js - event_target_test.js Bug: 1133198 Change-Id: I839c440ea5072b3daacf21bfa69db5a0f7ce2e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486531 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9606cffa66d0..c4af5cd3397d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If75054824159c673a96a3378dd93c56cad4adff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491321Reviewed-by:
-
Prashant Nevase authored
Pass dark mode bit set on PaintFlags to DrawImage to be used in cc::GpuImageDecodeCache. This is part of raster-side dark mode. In GpuImageDecodeCache, the dark mode bit on DrawImage would be used for deciding to apply dark mode filter on the image. Bug: 1094005 Change-Id: Ib14262c2111eb64f814ebc9682b307b3812b1e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467817 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819727}
-
Reilly Grant authored
It appears that in addition to returning "AccessDenied" when attempting to enumerate GATT characteristics Windows can also return "AccessDenied" when trying to open a service. This patch avoids failing service discovery entirely by simply ignoring such inaccessible services. Bug: 1058849 Change-Id: If4cf178bb30a12305cdadbc379922302c14671c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099762 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#819726}
-
Hayato Ito authored
external/wpt/webdriver/tests/maximize_window/maximize.py>>test_fully_exit_fullscreen is flaky on linux. TBR=kyleju@chromium.org Bug: 1141282,977228 Change-Id: Ib331f9ddc12ffc82883d2aaee777d512817cdc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490911Reviewed-by:
-
