- 29 Oct, 2019 40 commits
-
-
James Cook authored
After running the C++ preprocessor ax_enums.mojom.h expands to 100,000 lines of code. ax_enums.mojom-forward.h is 300. Switch headers to use ax_enums.mojom-forward.h where possible. This usually means removing default arguments from functions. Bug: 1001715 Change-Id: I792ab8a22ce6c86763f35a7815af7ada9a1ce04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759821Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#710497}
-
zhaoyangli authored
- Added new files for constants. - Added constants target in BUILD.gn for new files. - Added/Modified headers of where the constants are used. This is preparing for SigninEarlGreyUI and SigninEarlGreyUtils EG2 migrations. Bug: 922813, 1015907 Change-Id: I41fc3223ebef4ba4e52e7f60e670eb6fdb0b42b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885225 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#710496}
-
Peter Kasting authored
This is nice-to-have on its own as it removes const_casts, and gives a small perf boost by no-oping when calling Layout() twice with the same size with an intervening different size calculation (e.g. GetHeightForWidth(...)). However, I'm mostly writing it because it's a necessary precursor to fixing logical constness bugs in KeyboardShortcutItemView that produce layout glitches. That class needs a non-modifying way of getting at detailed layout info like the width and height of the first line of children, which after this change will be captured in StyledLabel::layout_info_. Bug: 1015717 Change-Id: Ia62ef35dc421d5fe80861afec0e0a9cdda855866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874713 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#710495}
-
Lei Zhang authored
AwPrintManager and PrintViewManagerBasic are the only subclasses of PrintManager that use |pdf_writing_done_callback_|. The two classes do not interact with one another, and no other code changes |pdf_writing_done_callback_|. Given this, since both classes initializes |pdf_writing_done_callback_|, there is no need to check if the callback is null. Change-Id: I73c8a309e3cb7fde0286950e0ef2be2211881373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885108 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710494}
-
Oriol Brufau authored
Symbol markers are painted as geometric shapes, not as text. However, they are still represented by a text run, which may break into multiple fragments. To avoid painting the symbol multiple times, the symbol is painted only for the first one. Before this patch, this was simply done by checking that the 'from' data of the NGTextFragmentPaintInfo was 0. However, markers can have a non-normal unicode-bidi, because the value is inherited from the list item, or via the ::marker pseudo-element once it gets implemented. The problem is that some unicode-bidi values can insert bidi control characters like U+202A, U+202D, U+2066 or U+2068. This makes the first 'from' data to be greater than zero, so the symbol was not painted. This patch checks whether the first 'from' characters are bidi controls, if so, the symbol is painted. Otherwise it's not painted. BUG=1018696 TEST=external/wpt/css/css-lists/list-marker-symbol-bidi.html Change-Id: If5ec4eee624f27ab63df81940f1fc2ea727a5681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884291Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710493}
-
Ingvar Stepanyan authored
Until http://crrev.com/c/devtools/devtools-frontend/+/1872581 is merged. Bug: 1016772 Change-Id: I7322b65b3b0aff789aba909f326c6306eec619d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888670Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ingvar Stepanyan <rreverser@google.com> Cr-Commit-Position: refs/heads/master@{#710492}
-
deepak1556 authored
size is defined in `<xutility>` with VS 2019 Bug: none Change-Id: I337599b8808f36d2c2c3ad1b327352d440c9dea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879683 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#710491}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I033f535716aa7f281114c6fdbb3ae12109109f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888491Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710490}
-
Pavel Shmakov authored
Instead of rotating screen, which is now handled without activity recreation, just use Activity#recreate(). Change-Id: I96a91ab09409d3cc4f9868741846bde11c9fdcba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887690 Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#710489}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f67b33f0e7b..567c7481c849 Created with: gclient setdep -r src-internal@567c7481c849 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:934252,chromium:None,chromium:1018879 Change-Id: I8cfcd2f8c0260ba6929a6d590c2143f08371202e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888135Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710488}
-
Moe Ahmadi authored
- Makes changes to support having no selected matches. For instance, 'Enter' should do nothing when there are no selected matches. - Selects the first match after populating the matches only if it can be the default match. For NTP zero-prefix suggestions, no match is allowed to be the default match. Therefore there will be no default selection. - Adds a new test and makes changes to the existing ones. Bug: 243926,1016845 Change-Id: Iba56b0aef467c917d96cd01966f15d18258264df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884266Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710487}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/287b0a670fbf..88a74e59f04c git log 287b0a670fbf..88a74e59f04c --date=short --no-merges --format='%ad %ae %s' 2019-10-29 ianelliott@google.com Vulkan Android: Remove support for EGLConfig's with GL_RGB10_A2 & GL_RGBA16F 2019-10-29 courtneygo@google.com Roll dEQP to VK-GL-CTS Created with: gclient setdep -r src/third_party/angle@88a74e59f04c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I4ac261a579fd591db6364f352b7e275b29c4484c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888056Reviewed-by:
-
Xianzhu Wang authored
This is because we only rebaseline-cl for unexpected failures. We can't remove lines from TestExpectations because the lines contains expectations other than Failure. Bug: 1012792 Change-Id: Iaa710b002af7f4f75eb15bdefe4d7a14bb9da675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883624Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710485}
-
Aaron Krajeski authored
Looks like the winding rule was missed. Bug: 1015360 Change-Id: I3d48ac413780c97492f69de78ff6f43cec94ac67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888117Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#710484}
-
Andrew Grieve authored
CIPD does not allow them. Splitting this off from larger change where the problem was hit: http://crrev.com/c/1885951 Bug: 693079 Change-Id: I068bf8fd01044f5c80307f7f68de5bd03b1ed1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888373 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#710483}
-
Peter Kasting authored
(1) Make the "experimental keyword mode bubble outline" color match the keyword color. It already did in light mode; not matching in dark mode looks like an oversight. (2) Make these two colors both match the dropdown URL color. They were already very close, and I believe we intended them to match, but then tweaked the URL color in the dropdown to guarantee sufficient contrast in the hovered case. Bug: none Change-Id: I374cd6e6a0c9f7d089114f64f6c95cc35e6b648c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887664 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710482}
-
Dirk Pranke authored
We no longer have any builders supporting the jumbo build config, and it's time to now update all of the build files to remove the jumbo templates. Before we do that, though, it's probably good to figure out how to handle existing uses of the jumbo builds. This CL asserts that |use_jumbo_build| is set to false. Once we've run with this for a while (to ensure that people have adjusted their configs), we can probably update any CI build configs to remove the use of it and the other jumbo-related GN args and then remove the actual declare_args() of the three jumbo args, turning uses of them into warnings. Bug: 994387 Change-Id: Ibe395e51c837692ff9a7b6d01141c32ddab5459b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874583 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#710481}
-
Jasper Chapman-Black authored
Pure refactor to support future tree-building features (e.g. filtering symbol names, filtering symbol types, highlighting...). Two main components: * Add TreeBuilder, constructs a file tree from an unzipped SizeInfo object (and other configs, in the future). * Split LoadSizeFile (which unzipped the size file and built the tree) into file-unzipping and tree-building steps. Benefit: Searching or filtering will only rebuild the tree and not perform the costly 1-second decompression step. Intended use is that caspian_web.cc will create a new TreeBuilder on every config change. Bug: 1011921 Change-Id: I73f37bacc6657b8c33e4bdcd873e97a80f27a10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884828 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#710480}
-
zhaoyangli authored
Preparing for SigninEarlGreyUI and SigninEarlGreyUtils EG2 migrations. Bug: 922813, 1015907 Change-Id: I47e4678e40f1820b22938463c5a791c04a662f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884286 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
-
Sajjad Mirza authored
Without this implementation the class is accidentally abstract and cannot be instantiated. Bug: 1018949 Change-Id: I6bbe1bacd430182876c6d3765626d57f9a2f4880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885494 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#710478}
-
Reilly Grant authored
To avoid modifying the existing update logic too much the gamepad logic generates synthetic keyboard events in response to button presses. Bug: 1001198 Change-Id: Ifa4d94b19b1079f13e95f0dbd0ccab3dcb9b77c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879757 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#710477}
-
Scott Violet authored
Using floor means the top/bottom layer and the content may get 1-pixel out of sync. Using round() helps avoid this. BUG=none TEST=none Change-Id: If5aa3445dbd0293c0f3e3ccbe7ad34bce4bbb62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888130Reviewed-by:
-
Min Qin authored
BUG=1013759 Change-Id: I00b0490b7e7fd8294fb90b2ccd1e060181ad5691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884538 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#710475}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/73d5bb57e64f..6eb7d0ec3ecf git log 73d5bb57e64f..6eb7d0ec3ecf --date=short --no-merges --format='%ad %ae %s' 2019-10-29 senorblanco@chromium.org Add some missing #includes. Created with: gclient setdep -r src/third_party/dawn@6eb7d0ec3ecf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I2c3d9d7996977431102b1212ad734b617c216b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887683Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 81 82 83 84 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I3d95f6ca1b3ecd6293d1d5f28470fb08bc1e6cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886076Reviewed-by:
-
Henry Jian authored
This (mostly) reverts commit f0ecb909, except that it increments the current_version.gni instead of reverting it. Reason for revert: I need to modify the shell apk and push it now but this CL needs to wait for WAM server change to be pushable. Original change's description: > [Android WebAPK] Link to a shortcuts file from the manifest. > > Instructions for enabling Android shortcuts: > https://developer.android.com/guide/topics/ui/shortcuts/creating-shortcuts > > This is the first step for enabling shortcuts. The server will populate > shortcuts.xml depending on the Manifest shortcuts provided (and also > generate additional string resource files). > Bug: 1010471 > Change-Id: I2e0a6118a22869766e4b5e849dabc6533cd2d306 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864805 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707889} Bug: 1010471 Change-Id: I0b302074e4b218f96e7ec8b7b1686ea1b6825b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885213 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#710472}
-
Ken Rockot authored
This is all the super-low-hanging fruit. Bug: 1000959 Change-Id: I46afc55d5110f50d60a3ace65916abbd44066a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884575 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#710471}
-
Elly Fong-Jones authored
This item is a synonym for the dots menu's Distill Page item, and available under the same conditions. It is always enabled even if the distiller service doesn't think the current page is distillable. Bug: 1016610 Change-Id: I163d571b4480537fe5b53fe3d589e2719331bbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888111Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#710470}
-
John Budorick authored
Bug: 836332 Change-Id: I2c2482bc2f811aee4233682b965feab2fedbb37e Tbr: rdevlin.cronin@chromium.org No-Try: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888552 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#710469}
-
Findit authored
This reverts commit b40da6df. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 710364 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I0MGRhNmRmYmZhYmJmMTI1ZGExMzAwN2NlZTRjODFkZDBiOTdjN2MM Sample Failed Build: https://ci.chromium.org/b/8898232731881505168 Sample Failed Step: gfx_unittests Original change's description: > Lift fallback font unittests to share them across platforms > > This CL is lifting the parameterized unittests originally > wrote for windows to a common file to be available to > other platforms. > > Test from KnownExpectedFonts will now also run on Linux. > * Added the test cases for linux. > Test from Glyphs are now running on every platforms. > > Adding a matching_glyphs count to font_fallback_linux.cc. > Previously, a default font was returned for a single character > even if it was not matching the character, it was still the > best match. If no codepoints are found, the font is considered > a no match. > > Change-Id: Ie4f871281737e254bbdbea9e04f8e527f1049569 > Fixed: 3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879956 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710364} Change-Id: I7595c3b2ab6f5e8828f3570b3a43e63e80dbcfea No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888785 Cr-Commit-Position: refs/heads/master@{#710468}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f8df30f1ad44..b07147b04082 git log f8df30f1ad44..b07147b04082 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 sugoi@google.com Provoking vertex fixes 2019-10-28 sugoi@google.com VK_EXT_provoking_vertex support 2019-10-28 jonahr@google.com Fix vulkan builds in ANGLE on MacOS 2019-10-25 sugoi@google.com Removed stencil reference from PixelProcessor::States 2019-10-25 amaiorano@google.com Fix LLVM7 partially initialized ManagedStatic 2019-10-24 sugoi@google.com Fixed using an offset in Blitter::blitFromBuffer() Created with: gclient setdep -r src/third_party/swiftshader@b07147b04082 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:1015454,chromium:b/143288278,chromium:1015904 Change-Id: I0c957affa260014664c34f0257fba3fff4bf664b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888057Reviewed-by:
-
Johannes Henkel authored
Also we're not creating these any more via StringUtil in blink, so these two helpers can go. Change-Id: Id676e4c35bc00392166f00f645178cd17720d02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888270 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#710466}
-
Elly Fong-Jones authored
This changed during the bundle restructure but gcapi was never updated to match. Bug: 958976 Change-Id: I1a1e50823d454ba807fc352373909fdb395a8a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888110Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#710465}
-
Mohamed Heikal authored
While the check is under discussion and its documentation being improved, this check is temporarily disabled (by setting the limit to be 'over 9000' aka 100). Bug: 1012373 Change-Id: Iba21eadbdd77ddec94443b7d904959a1e324ac8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888372 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
Victor Fei authored
This is a reland of 81487c55 The original change was reverted because it failed win7 bots for the following tests: DumpAccessibilityTreeTest.AccessibilityButtonNameCalc/uia DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/blink DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/win This reland fixes these test failures on win7. Original change's description: > Exposing button's children internally and to AT > > The motivation behind this change is that we want text pattern APIs to > access the text content of both native buttons and ARIA role=button. > In order to achieve the above, we need to be able to serialize button > element's children to AXTree. This change enables all children of button > to be exposed in the AXTree. > > Additionally, if the button's children are text only and also exposed > in the Browser Accessibility tree, screen readers may double speak the > button's name. To prevent this, if button's only child is a static text > we mark the button Browser A11y node as leaf. > > On Android, we treat all its Browser A11y button nodes as leaves and > expose no child. > > Summary: > -------------------------------------------------------------------- > BEFORE: Exposed in AXTree & Browser A11y Tree (BATree): > > native button | role=button > single text child: AXTree[N],BATree[N] | AXTree[N],BATree[N] > BATreeAndroid[N] | BATreeAndroid[N] > > complex children: AXTree[N],BATree[N] | AXTree[Y],BATree[Y] > BATreeAndroid[N] | BATreeAndroid[Y] > -------------------------------------------------------------------- > AFTER: Exposed in AXTree & Browser A11y Tree (BATree): > > native button | role=button > single text child: AXTree[Y],BATree[N], | AXTree[Y],BATree[N], > BATreeAndroid[N] | BATreeAndroid[N] > > multiple children: AXTree[Y],BATree[Y] | AXTree[Y],BATree[Y] > BATreeAndroid[N] | BATreeAndroid[N] > -------------------------------------------------------------------- > > Note: > According to the ARIA spec (below), the children of role=button are > presentational, which means they should not be exposed to ATs > (a.k.a. should all be treated as leaf nodes). > However, we need the button contents to be exposed sometimes because > they may contain many rich, interactive descendants such as buttons > inside a calendar popup and screen readers need to interact with these > contents (See https://crbug.com/689204). > > Additionally, Firefox also expose the children of both native button and > role=button. > Due to the above, we decided to departure from the ARIA spec and not > enforce the leafiness of buttons. > > ARIA && core-aam specs: > https://w3c.github.io/aria/#button > https://www.w3.org/TR/core-aam-1.1/#exclude_elements > > ~~~~~~ > Note: > The actual functional changes are in the two files below, the rest are > tests: > content/browser/accessibility/browser_accessibility.cc > content/browser/accessibility/browser_accessibility_android.cc > third_party/blink/renderer/modules/accessibility/ax_node_object.cc > ~~~~~~ > > Bug:1013609 > > Change-Id: Ia7c4bac9940b34dd3a3122938057cb48e847b76a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845810 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709728} Bug: 1013609 Change-Id: I088fac4c42a9c95ddee16e40f28f0154da1a9f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883619Reviewed-by:
-
Asanka Herath authored
This CL does a few things: * Moves the ftp feature flag from //chrome to //content. There are a few places in //content that assume the network service supports FTP despite //content never configuring it to be so. Rather than replumb these code paths I've elected to move the switch down to //content. Once FTP is deprecated, these code paths will disappear. * Updates content::IsURLHandledByNetworkService() to only return true for FTP if the FTP feature is enabled. * Updates ProfileIOData::IsHandledProtocol() to only return true for FTP if the FTP feature is enabled. Unlike content::IsURLHandledByNetworkService(), this function doesn't affect how navigations work, but rather informs other subsystems about whether a URL is likely to be handled by the renderer or not. * Adds the "enable-ftp" flag to about:flags. This will allow users to (temporarily) enable FTP during the turn-down period. * Tests all of the above via //chrome/browser/net/ftp_browsertests. Bug: 333943 Change-Id: Idf90cf6332637c92b41036d80815dd20e37ffad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860934 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#710462}
-
Carlos IL authored
The code in this CL does not include handling user interaction with the interstitials, so they will be displayed, but will not react to commands. Bindings for commands will be added in a follow up CL. Bug: 1016581 Change-Id: I7817205e6f48b0380e8e15a3faa9b8d134028624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872945Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#710461}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers and add an attribute to disable CFI-icall checking. Bug: 1018834 Change-Id: I72ec694120fa8443396fd317771560c8f922a4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884460Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#710460}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/94885526dc61..882b743a85b7 git log 94885526dc61..882b743a85b7 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 seanabraham@chromium.org chromeos_config: make tatl and tael experimental 2019-10-29 saklein@chromium.org service/sdk: Add chroot size check. 2019-10-29 manojgupta@google.com cros_fuzz: Don't error on missing corpus directory. 2019-10-29 tcwang@google.com afdo: Fix bug that afdo builders check wrong artifact name. 2019-10-28 dtor@chromium.org Add -kvm as another suffix to non-unibuild board list 2019-10-28 richardfung@google.com Remove betty-arcnext 2019-10-28 mmortensen@google.com Add api/controller unit tests and mock responses for GetChromeVersion. Created with: gclient setdep -r src/third_party/chromite@882b743a85b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia8fc5d3d5fa78b1d353c3d6b176e109840522a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888052Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15b40236bd8b..b69001f36f76 git log 15b40236bd8b..b69001f36f76 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 robertphillips@google.com Make GrFillRectOp and GrTextureOp consistent re AA-upgrading and size checks 2019-10-29 egdaniel@google.com Cache simple descriptor sets on GrVkTexture. 2019-10-29 kjlubick@google.com [canvaskit] Add tentative support for savelayerrec 2019-10-29 egdaniel@google.com Use GrSurfaceProxyView in RenderTasks. Created with: gclient setdep -r src/third_party/skia@b69001f36f76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: I33cc5b7b5c1eb50d11c43cca5b3b1da92be2527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888053Reviewed-by:
-
