- 01 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/56c610b14521..8cc4d0dc32a1 2020-12-01 wl@gnu.org * src/tools/chktrcmp.py (trace_use_pat): Update to current use. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I81294af2fa018b248ec5ed199602e1c5709a1796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567659Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#832333}
-
Bao-Duy Tran authored
Certain unit tests are having environment-specific failures due to mixed usage of hermetic test data and non-hermetic prod configs. This refactor is in preparation for fixing such non-hermetic-ness. Besides, it's also in preparation for further reduction in usage of deprecated input_methods.txt [1][2] (remnant from before the migration to extension-based input methods circa 2011), towards its full removal. Nowadays the canonical configs for 1P input methods on CrOS is google_xkb_manifest.json [3]. [1] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/input_methods.txt;drc=5ab33d25bc676b63e4afbcfade6f9265a5f5a3ea [2] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/gen_input_methods.py;drc=0303b222088853ce1c0af2bbc7f47937746eda97 [3] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json;drc=03ae97c2c311ac00d3e9a59203f4921c9e87e707 Bug: 970790, 1134526 Change-Id: I622bb36e8cd054d26431870cb2d0e70a3e1fe472 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chromium.try:linux-chromeos-rel,linux-chromeos-dbg;luci.chromium.try:linux_chromium_chromeos_asan_rel_ng,linux_chromium_chromeos_msan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554276 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#832332}
-
behdad authored
The crash reported in bug might have been caused by compiler deducing auto to refer to a BeginFrameArgs rather than a refference to BeginFrameArgs. So this change is going to fix this. Bug: 1153583 Change-Id: I2943230dc92b09ce3e352aff77d03a087e00b985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566710Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#832331}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606780634-4bcba867177e99782f7fa7f8d4c0822ffa36a5f3.profdata to chrome-win64-master-1606802354-186e0b734d39b05126048ed00a5f975d199f5c7c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6952206a58353475364e8870d4caea0f7a702fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567664Reviewed-by:
-
Koji Ishii authored
Applies the same changes as |LayoutNGBlockFlowMixin|. This patch should have no behavior changes. Bug: 1061423 Change-Id: Id33a5fdda4c05dd3e4f16e8e16727a963da3a9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567055 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#832329}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/42433abb9596..e644010395ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iba35af5ba8cd13ab49c2eb5ffbd51739671043fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567801Reviewed-by:
-
Leo Lai authored
BUG=b:172748724 TEST=chromeos_unittests. TEST=deploy a test-only function in DBusHelper, make sure the signal arrives with CL:2563522. Cq-Depend: chromium:2563522 Change-Id: I3fb14ff069cd710a9df496df7a293cc73466cec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563430 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#832327}
-
Omar Morsi authored
Before this CL, enterprise.platformKeys API tests were run by the C++ side of the test opening a web page (basic.html) which runs the javascript code (basic.js). This CL is implemented with the following two goals. 1- Moving the JS tests to a background script which will run automatically after the extension is force-installed. This is a first step towards extending this background script to test the API behavior on the loginscreen. 2- Extending the tests to allow the C++ side to control which tests will run. Bug: 1148294 Change-Id: Iac04b0fbfd8951b1095fa3e93c24366c7c0aa338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560301 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#832326}
-
Christoph Schwering authored
The condition had been weakened in crrev.com/c/2550785 to the effect that the cached form is updated when the language has become available or changed since the seen was form last. This uncovered a bug in the sectioning. Especially since we may have an alternative way of receiving the language in crrev.com/c/2561838, the sectioning bug outweighs the benefit of the cache update. This CL is essentially a revert of crrev.com/c/2550785. Bug: 1154080 Change-Id: If70e8c4806ec2215c5a9f7c342789b7d53925656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566752Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#832325}
-
Alex Ilin authored
To force the light mode on the Reauth confirmation screen, we override the preferred_color_scheme web preference in SigninReauthViewController. However, a web preference overridden via WebContents::SetWebPreferences doesn't survive a recomputation of WebPreferences. This means that the preferred_color_scheme returns back to its default value. The comment to the SetWebPreferences method suggests to put the recomputation logic in ChromeContentBrowserClient. This CL does exactly that. This CL also adds a browser test to verify the behavior and catch possible regressions. Bug: 1153368 Change-Id: I8697e13095ba58d120f6ce61352caa32a982be0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565684 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#832324}
-
Clemens Arbesser authored
This CL (hopefully) fixes several flakily failing integration tests. - In one case, the translate popup could block the tap on a website element. Furthermore, possibly related to crbug.com/1140957, tapping some of the elements did not reliably work. The workaround is to disable translate and tap a different element. - In two other cases, tests were flaky because espresso timed out waiting for the UI to be idle. I was not able to reproduce, but since we have had similar issues in the past who were related to animations, I have removed the progress bar from those tests. We will have to monitor the builders to confirm that this fixes the flakes. Bug: 1149965 Change-Id: I149b7c930d6e57f496ab4c1f0991c34aac04b578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567393 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#832323}
-
sandromaggi authored
After noticing that other attribute changes (e.g. "checked" on an type="checkbox" element) might also require sending out a "change" event, I no longer consider |SetFieldValue| atomic enough: It already does 2 steps (setting the attribute + sending the event). I propose to remove (or rather not introduce) |SetFieldValue| and use |SetElementAttribute| + |SendChangeEvent| instead. This CL does *not* change the current |WebController::SetFieldValue| method. To reduce duplications it should however be removed and its using actions changed to the above approach as well instead. Note: The swap in the |action_info| oneof is safe, because the mini-actions are not yet implemented on the backend. The fields are currently only reserved to prevent their use. Bug: b/172542134 Change-Id: I8330bc68565be5f07d3055e471653a787049c600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563303 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#832322}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e644010395ee..05e6cccec435 2020-12-01 fmayer@google.com Merge "Send tracing session id via signal." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iad16139e856beccd7db715aaa6e1d06641d49433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567640Reviewed-by:
-
Rune Lillesveen authored
Prepare for supporting @font-face support in shadow trees by allowing font selectors to be associated with TreeScope instead of Document. Bug: 336876 Change-Id: I90ce9064e3c57c28c06ef02bb7e11c711ba1e4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562379Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#832320}
-
chrome://internals/web-appAlan Cutter authored
This CL adds a debug flag chrome://flags/#record-web-app-debug-info to enable recording debug info about preinstalled web apps to be exposed in chrome://internals/web-app. This is useful for debugging default web app configuration issues on Chrome OS where it is very hard to access the stderr output. Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478199&signed_aid=Y1p_RZ3XA-u9yfve8h9FcA==&inline=1 Bug: 1152680 Change-Id: Ide8968dfd12d650dd24d124d24a6a521f020e95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559935Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#832319}
-
Benoit Lize authored
Bug: 998048 Change-Id: I340b637565c466b13b281b30f340970f5da8212c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563691 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#832318}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f1e2bbd8..4f7b9247 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8c5afb969db5692a795cb9696612c6f9fe53c4c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567797Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832317}
-
Alice Wang authored
This CL adds a new flag param for web sign-in flow and put the text |No thanks| behind the flag. Bug: 1153253 Change-Id: I1403c3790cc954a24d2dce2f9cfacb7fd8fa7a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563269 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#832316}
-
Bartek Nowierski authored
Change-Id: Iad90f5b80ec9effdb9737568ef83a8e8676ae31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563382 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#832315}
-
Changhao Han authored
DevTools frontend CL: https://crrev.com/c/2557071 Bug: chromium:1152391 Change-Id: I7d5fc0e8a8ca4249a7ee9c01ba427771ddfb7725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566799 Commit-Queue: Changhao Han <changhaohan@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#832314}
-
Wei Lee authored
Bug: b/172339594 Test: Check the icon is updated for both platform app and SWA version Change-Id: If9b779f2164c2f47e123a670b99720e2c847a448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567238 Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#832313}
-
Azeem Arshad authored
This CL fixes issue with GetCurrentAppUrl method in AndroidSmsAppManagerImpl. This method is used in a few different places to determine the url of the currently installed app. This method currently loops through migration domains in order and returns the first installed app. This logic fails when the user may have manually installed apps from non-preferred domains. This causes other related code that uses this method to use the incorrect url. Fixed this by always checking for preferred domain first. Fixed: 1154053 Change-Id: I2c93a7486ad23a135787ce1a7a8f3faacf4c6b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566791Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#832312}
-
Yuki Shiino authored
idl_type.py - Adds new_union_definition_object to help implement NewUnion. blink_v8_bridge.py - Adds member_ref_t to represent an input/output type to/from a member variable. Example) member_ref_t func(member_ref_t new_value) { member_var_ = new_value; return member_var_; } - Adds clear_member_var_expr to clear the content of a member variable. These will be used in https://crrev.com/c/2522861 . Bug: 839389 Change-Id: I738f5a3a18acbbcd09ff4e2fd6b235a8845d43ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563520Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#832311}
-
Maxim Kolosovskiy authored
Button titles scraping for unowned forms might be heavy. So, it should be enabled only in Dev and Canary. Before this CL, channel-based filtering was implemented with the AutofillFieldMetadata feature. As the experiment spans for many years, it is better to hardcode the behavior on the client side. Different behaviour in different channels is to be deprecated once we deprecate the old metadata and use the rich metadata pipeline. Bug: 1111809 Change-Id: I0cd31b4961338a2b07b10c37164b6bc75f8d8808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526083Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832310}
-
Maksim Moskvitin authored
This CL moves trusted vault crypto functions to a dedicated header, because they were used in multiple files and it leads to code and constants duplicates. Bug: 1113598 Change-Id: I5450a1ec0f9836471c5e5d3669e7cd2173527d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565510Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#832309}
-
Francois Beaufort authored
As WriteOnRequestCompleted is always called whether the push operation is cancelled successfully or not, this CL removes the unused cancelled callback. Bug: 1151857 Change-Id: I5f5bb163e52afe2f9b163a043fa25eb5def9cc8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554607 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#832308}
-
Denis Kuznetsov authored
Bug: None Change-Id: Ie5bd6620ca391f50a1db48657a249cad5400edea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564759Reviewed-by:
Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832307}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d96af00c9286..8f303e8141bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tschumann@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1112738 Tbr: tschumann@google.com Change-Id: Ifd6ed7afe74f6b301b60e44e3ab8e05d3430e000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567491Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832306}
-
Anastasiia N authored
Add primary account description with a link pointing to Sync Settings. Show management status for supervised users. Screenshots: http://screen/8FKJx5YBtEY4X6Y, http://screen/5EWijZQ5sCaUJMf (managed account), http://screen/63ivfWWtMvpKn8D (child account) Bug: 1144113 Change-Id: I15cb13ac6763882e671ac57c13bd81825b61a8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549763 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#832305}
-
Olesia Marukhno authored
This suite tests the Views bubble with the Cocoa browser window, but we haven't supported that configuration in over a year. Bug: 1148277 Change-Id: I5d4ceda74d7c15ae0df9eaa619b29e50a4a934ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550812Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#832304}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/42433abb9596..e644010395ee 2020-12-01 primiano@google.com install-build-deps: add gn+ninja+clang-format prebuilts for windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879 Tbr: perfetto-bugs@google.com Change-Id: I6e137e0e2da51d0fd9be800631dbdbb6c2ad4edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567637Reviewed-by:
-
Francois Beaufort authored
This CL removes the unused callback of NFC client CancelWatch method and cleans some stuff. This has no functional changes. Bug: 1151857 Change-Id: I66e96efd23ec72330410b39e9c19e7f68d1431b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557083 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ec8113a86a79..9cfe927efca2 2020-12-01 szuend@chromium.org Add Trust Token tab for requests in the network panel 2020-12-01 bmeurer@chromium.org Preserve absence of column number when persisting breakpoints. 2020-12-01 alexrudenko@chromium.org [DarkMode] turn off legacy patching for imagePreview.css 2020-12-01 jacktfranklin@chromium.org [Dark Mode] migrate sources/sourcesPanel.css 2020-12-01 alexrudenko@chromium.org Use deviceEmulationFactor to position grid labels 2020-12-01 mathias@chromium.org [Dark Mode]: migrate accessibility/accessibilityProperties.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1055327,chromium:1126824,chromium:1151864,chromium:1152736,chromium:1153123 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9111a48dbbdfb90f617f0ff6428a76c23b2c18dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567811Reviewed-by:
-
Francois Beaufort authored
This CL removes the unused method CancelAllWatches() that used to cancel all watch NFC operations. It also removes one duplicated web platform test that was referencing obsolete NDEFScanOptions id. Change-Id: I1a702cae22b7525a9229da818bec91255a273f4b Bug: 520391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554575Reviewed-by:
-
Yoav Weiss authored
This is a reland of [1], which got reverted in [2] due to a mix or regressions and progressions on the bots. I'm now re-attempting to land this with a Finch trial. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1953204 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2023497 Bug: 788757 Change-Id: I5193d6a00dae358c047a87478abfadbccccb2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560124Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#832299}
-
Sam Sebree authored
[Controls Refresh] Implement test coverage for dark mode scrollbars are not dynamically updated bugfix Due to time constraints, the following CL was landed without full test coverage: https://chromium-review.googlesource.com/c/chromium/src/+/2522563/7 This CL adds proper test coverage for the change. Bug: 1148004 Change-Id: I693c7dcb3d1d9c250e730eba1f63212f9caf4349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564600 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#832298}
-
Jasmine Chen authored
This CL makes VmPermissionService pass tokens to CameraHalDispatcher for client authentication. PluginVm. Bug: b/170075468 Test: build and deploy simplechrome, packages and verify camera works in Change-Id: I8d51fb4ca6f82cc5648125fe8552a6f04a99ef5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532477 Commit-Queue: Jasmine Chen <lnishan@google.com> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#832297}
-
Alex Rudenko authored
The order of transformation makes a difference when device parameters such as deviceScaleFactor don't equal 1. Bug: 1151864 Change-Id: I7d0b5fc2a19b5d1ab18053068b190aff7c7f2079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563477 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#832296}
-
Manuel Rego Casasnovas authored
If the bottom-down corner of an element's overflow rect is before the top-left corner of the containing block, we cannot reach it with scroll and it shoulnd't be added to overflow. But if that happens only in one axis but not in the other, we still need to add it to the overflow. This patch changes the return condition to be an OR instead of AND. The test is passing without this patch, but this has caused regressions before LayoutNGLayoutOverflow was enabled and we were avoiding to compute the overflow of positioned elements twice (r809272). BUG=1150774 TEST=external/wpt/css/css-position/positon-absolute-scrollable-overflow-001.html Change-Id: I84afd63178ae23d07b14e93add78295c2e737a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562845Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#832295}
-
Sean Harrison authored
Add an additional pref to indicate whether the device in question has the privacy sandbox settings UI available. Modify the 2 existing prefs to be syncing. Create an OWNERS file for chrome/browser/privacy_sandbox, and add some members of the chrome friendly settings team to it. Bug: 1152336 Change-Id: Ie39a763a703fc2c2ee092d14513fca31784037ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565572Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#832294}
-
