- 04 Jun, 2020 40 commits
-
-
Rakina Zata Amni authored
Adds the "SameSite" level to the ProactivelySwapBrowsingInstance feature flag. This CL also adds helper functions (to parametrize tests, etc.). The implementation for same-site proactive BI swap is done in another CL - crrev.com/c/2121522. Non-content uses of the functions: crrev.com/c/2210605, crrev.com/c/2196105, and a few others. For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: I283ad31297ce6dd93bb6f02e8159488d62c5d989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214588Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#774980}
-
Jia authored
This cl will allow clients to add Content (with id) to the search service. It will also return Position in the result. The next cl will remove search tags and some test util functions. Bug: 1090132,1084610 Change-Id: Ib9ebd33f67557b4c186ce78dcf3521ab39c7fd64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225677 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#774979}
-
Maggie Cai authored
Disalbe test TabletModeControllerScreenshotTest.ScreenshotVisibility because it is crash on some builders. See the bug for more details. BUG=1091085 TBR=skuhne@chromium.org Change-Id: I8383c7dc9cb17f4271d18d35b5fc3a315fa67b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228438Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#774978}
-
Yi Xu authored
Bug: 1087019 Change-Id: I4d9d40decbcff3fbc0f0e7d20c64fe7e5622d12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229959 Auto-Submit: Yi Xu <yiyix@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774977}
-
Ankit Kumar authored
Currently simulated tab events are sent to PDF plugin whenever PDF plugin is focused. Ensure that simulated tab events are only passed in case of focus received from tab/shift-tab. Bug: 989046 Change-Id: I994d401f6896bc7dcb6f41669c38757b52413873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224881Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774976} -
Eero Häkkinen authored
This CL changes media stream device controller so that it checks that hardware supports PTZ before requesting a PTZ permission. This CL implements the actual hardware support test only on Linux. Bug: 934063 Change-Id: I51551a8f486252d652985667055f24d221ac6f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223936 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#774975}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I4921bd4b970fdd65fd2561f22bc2832768c28063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228742Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#774974}
-
Dominic Farolino authored
In crbug.com/1090391, we're seeing crashes due to an incorrect referrer header, so this CL, similar to crrev.com/c/1896251 and crrev.com/c/1954211, inlines the request referrer serialization so we can get a better stack trace from the process that the request was in before it was sent to the Network Service. There is a TODO to undo this, since it is not ideal, and is just debugging behavior. R=dcheng@chromium.org, mmenke@chromium.org Bug: 1090391 Change-Id: Ibd186d02cf13b6bb515867323e6107b7de6a3191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229205Reviewed-by:
-
Ramin Halavati authored
Removes the following expired metrics and cleans up: - PasswordManager.DropdownShown.OffTheRecord - PasswordManager.ItemSelected.OffTheRecord Bug: 1089229, 1089224 Change-Id: Ib368be6cb43823bbd3bfcca2a7e0af2d6c7080d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228310Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#774972}
-
Ramin Halavati authored
Removes the following expired metrics and cleans up: - Autofill.SuggestionShown.OffTheRecord - Autofill.SuggestionAccepted.OffTheRecord Bug: 1088632, 1088634 Change-Id: Ic5e0d5e821b6de743d769e6828d0828511142499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228549Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
Nicholas Verne authored
Upgrading is a long and potentially flaky process. If the flakes are due to remote repos being unavailable, retrying the upgrade is useful, since some apt commands in the upgrade can continue where they left off. This should increase the number of upgrade successes in the wild. Bug: 1084825 Change-Id: Ib0adf945fb60eb2e682204d949cf7aa7a273d0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228590 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#774970}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0a6d1c0a60fe..fb76b959eed4 2020-06-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib3fab7f80df2f794e738851b6ca6be39212141fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774969}
-
Panos Astithas authored
R=eroman@chromium.org Bug: 646113 Change-Id: Ia62bfc2531336e289e315eb035fc0fcf15c81ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225279 Commit-Queue: Panos Astithas <pastithas@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774968}
-
David Grogan authored
Previously FlexNG would give the item in this example min-height: 0, not whatever the min-size: auto algorithm dictated. <div style="display: flex; flex-direction: column"> <div style="min-height: min-content"> ... There's still a behavior difference from legacy flex containers because they honor min-height: min-content[1]. NG always treats them as auto[2], flex-minimum-height-flex-items-023.html demonstrates this. Looks like this case already differs between Firefox and legacy, so hopefully compat problems between FlexNG and legacy are few. It's still unfortunate to introduce a third behavior for this case, even if the new behavior is spec compliant. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/layout_box.cc;l=4039;drc=feef24515266f41efe38da79056a216a8ae9d459 [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/ng/ng_length_utils.cc;l=74;drc=feef24515266f41efe38da79056a216a8ae9d459 Bug: 1088223 Change-Id: I17f5f5dd55b159da04e9693c0992c9a635862eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224599 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#774967}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f2d4abb2ef18..988659151960 2020-06-03 jmadill@chromium.org No-op incomplete framebuffer invalidation. 2020-06-03 kbr@chromium.org Fix validation of PVRTC compressed texture sizes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ia3960551303efd50ad4337a4489043210dc43e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229232Reviewed-by:
-
Takashi Sakamoto authored
- This feature is behind the flag: PartitionAllocGigaCage. - This feature is only available on 64bit chrome. - Currently 32GB address space is reserved for PartitionAllocator. - 16Gbyte for direct map allocation (1 pool), and - 16Gbyte for normal buckets allocation (1 pool) - Need to invoke PartitionAllocGlobalInit() before alllocating memory via PartitionAllocator. Bug: 1086388 Change-Id: I370d2422e5f3ee5825334da3a4914730b0fbee93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174031 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774965}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c48caaae49d0..4aca9066d548 2020-06-04 mtklein@google.com move #include out of header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I4556396ec77d989e9267cda0786594ba1df2164f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229918Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: If3cec92aae534d6b09b67c77e28faa4c748f9596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229980Reviewed-by:
-
Adam Rice authored
The following histograms will expire after M85: SafeBrowsing.WebSocket.Elapsed.Blocked SafeBrowsing.WebSocket.Elapsed.Abandoned SafeBrowsing.WebSocket.Elapsed.Safe Remove them. Also remove dead code from WebSocketSBHandshakeThrottle that was only used for metrics collection. Closed: 1089804 Change-Id: Ia49057fbd9d1890f1a2aba7241275383a47f3c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226478Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#774962}
-
Dominic Mazzoni authored
Chromium now exports tagged (accessible) PDF files. This design doc explains the details - in a nutshell, when printing to PDF we also generate an accessibility tree, and then use the information from the accessibility tree to add the relevant semantic information to the PDF. https://docs.google.com/document/d/e/2PACX-1vQWAFQw-r5yluBUueyrQLtxMGnJEeq3iTt1FWAtqbm39g2UgcliTWdOFRjMQ4FSbudTh60oIgt2TN3d/pub In order to make this more efficient, this change introduces a new accessibility mode for PDF exporting. This allows us to request only the needed attributes from PDF files, rather than every possible accessibility attribute needed. The accessibility attributes are consumed in printing/common/metafile_utils.cc; you can see that currently we just need the role, name, list attributes, and table attributes, plus the DOM Node ID of each node, which is how we correlate nodes in the accessibility tree with drawing commands in the PDF. Bug: 607777 Change-Id: I900f8ff1b4ccf5e958a80e770fc4d805da101e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220253 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774961}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591170216-be28c2b4718a2f482f298b7a886d3f3e5fe30114.profdata to chrome-win32-master-1591214254-e18b6c29801bc822569148c5ef87c3e9d9cb875d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I25a6ac0cbe08ed866d0440ce6e568579ab942587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229268Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/447cd3e6230f..21544ba0beb5 2020-06-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e728aee5..8c883b89 (774589:774827) 2020-06-03 mbonadei@webrtc.org Include correct ABSL_DECLARE_FLAG header. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I496fa8523e3273c320829e1a07e3e822fc686629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229235Reviewed-by:
-
Johann authored
Replace usage with a call directly to the constructor. Change-Id: I3ab02580039b45d042fe5698481e172542dffeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226109 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#774958}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0395ca9b6683..62b08f845fb9 2020-06-03 enga@chromium.org Test that vertex attributes can overlap If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I73e94dffcd3e9147e8d18d7fef0c3096417532d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229277Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I88309576619ef3c43af822e79fe16ba2cdc8a7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229801Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I844405c3fb1482311831b13dd04f8c15ea5ad776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229958Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774955}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e0e3b5576a5..10fb08669daa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mxcai@google.com Change-Id: If21692d37d8854eb855342d4c29fd5a4aa65c406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229230Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774954}
-
Jinsuk Kim authored
This CL replaces TabModelSelectorTabModelObserver with ActivityTabTabObserver for keeping the current tab up to date. Bug: 966272 Change-Id: I817bdd27cc09b1848574f833820c4d219b0a8b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215762 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#774953}
-
Francois Doray authored
The Blink Scheduler limits wake ups from throttleable TaskQueues to 1 per second as soon as the page becomes hidden and non-audible. This CL adds a feature to additionally limit the wake up rate to 1 per minute after 5 minutes in background (both values are configurable). Local experiments show that this improves battery life when multiple background tabs are open (see doc linked on the bug). Potential future improvements: - Allow N unthrottled wake ups after a page is backgrounded. Increment the budget of unthrottled wake ups when a page communicates with the user by updating its title/favicon, playing a sound or displaying a notification. This could improve support of Calendar or Reminder apps. - Wait until network is idle before intensively throttling wake ups. The intention is not to throttle pages that are loading. The 5 minutes grace period may already opt-out most loading pages. Bug: 1075553 Change-Id: Id46052276bec3384390b002cc5fd2f501e89670a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171976 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#774952}
-
Stephen McGruer authored
The h2 server turns itself on by default in wptserve, but we don't support it in blinkpy yet. To avoid quietly grabbing port 9000, pass --no-h2 to wpt for now. Bug: 1090491 Change-Id: Ie326b86dd1305d1173740c85afc8eecded17e277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229582 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#774951}
-
Maggie Cai authored
[Sheriff] Disable flaky test external/wpt/html/semantics/forms/constraints/form-validation-reportValidity.html. This test is flaky in multiple builders. Here is a link to the flaky portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVydQsSBUZsYWtlImpjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L2h0bWwvc2VtYW50aWNzL2Zvcm1zL2NvbnN0cmFpbnRzL2Zvcm0tdmFsaWRhdGlvbi1yZXBvcnRWYWxpZGl0eS5odG1sDA. And it show up in the portal for https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/18707. TBR=tkent@chromium.org Bug: 1041973 Change-Id: I2f1e66c40a04baad9db740f81c56febba791ce08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228304Reviewed-by:
-
Daniel Cheng authored
Bug: 1091083 Change-Id: Iffe64da78d65205e5fd6d5edf2283d3c62d16f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229779 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Before: We had PaymentRequestOptionalTotal flag in runtime-enabled flag, base-feature in components/, base-feature in content/. After: We don't have PaymentRequestOptionalTotal anymore. The original PaymentRequestOptionalTotal flag callers call the DigitalGood flag instead. Change: * Remove unnecessary OptionalTotal flag. Since the CL[1] introduced the PaymentRequestOptionalTotal flag in unnecessary places, this CL removes those unnecessary occurrences. * Merge the PaymentRequestOptionalTotal flag to DigitalGoods flag [1] https://chromium-review.googlesource.com/c/chromium/src/+/2150974 Bug: 1066531 Change-Id: I67ac986442f805bbac156e45cb3353edf658c245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222909Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#774948}
-
Kenichi Ishibashi authored
This CL replaces ServiceWorkerStorage::GetNewRegistrationId() call with the corresponding mojo method as a preparation for the Storage Service migration. This CL increases the android binary sizes by ~30kb. Most of the increase (~29kb) comes from mojo generated code and there isn't much we can do to reduce them. Introducing the mojo interface is necessary for migrating ServiceWorkerStroage to the storage service. See the design doc [1] for the motivation of the migration and plans. [1] https://docs.google.com/document/d/1hO0WEuoEOgEBlf5nDE3fDjuQY2bV_d5hLtk25iBo0LM/edit?usp=sharing Bug: 1055677 Binary-Size: Size increase is unavoidable (see above) Change-Id: I33e1e72b1da94ae02dfbe2a929895fc36e216e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217935 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774947}
-
Chong Gu authored
Filter tests that are flaky/failing/crashing. Adds ~7 minutes of bot time and run time per build. Bug: 757053 Change-Id: I992a061a2f9cf03bc0026bff4a2a838e1ec84d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228594 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#774946}
-
Chris Hall authored
Mark AXNodeObject::IsDefault as final. Written collaboratively with Aboxhall and Meredithl. Change-Id: I201b2579fde618ab2858442f0ab8da7b88dc68f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227724Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I45ade222d613b9180ae5ee96b752d744d24aae94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229667Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1220c3995354..447cd3e6230f 2020-06-03 mbonadei@webrtc.org Roll chromium_revision 0cd53b97..e728aee5 (770251:774589) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idd4011fecd50d9919b95169ca2368e146a3a165a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229273Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/84620d395a4d..e65444f91de0 2020-06-03 brucedawson@chromium.org Fix Python3 bugs in package_from_installed.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8a45c163fbf8f4332257cc93647b122d95868d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229274Reviewed-by:
-
Anupam Snigdha authored
While updating the text input state, the VK visibility request was being set unconditionally even if the VK policy was not defined. Added checks to ensure that the VK visibility request is only set when the ExecutionContext is valid and the last request set it to value other than none. Bug: 1088364 Change-Id: Ibb62f906de4df42881028af6791b84b53b34d3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224652Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774941}
-
