- 09 Nov, 2019 40 commits
-
-
Ian Kilpatrick authored
Beginning to look at more of the crash reports, and there are a lot of cases where the layout tree is in a bad state, particularly around OOF-positioned elements. In parallel to fixing these: https://chromium-review.googlesource.com//1906708 ...this patch aborts if we don't have a paint fragment. Bug: 1022545 Change-Id: Ia4941c0da187f1de9b3f1e882dfcb841207e654a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906777 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714095}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ied2b3904cf5a33e2feb1ce26228c32e34736b116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907948Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714094}
-
Miyoung Shin authored
This CL converts ColorChooserFactory mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Ie667fcb4919ef1f0e020d9b62973028d0795b72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886552Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#714093}
-
Wei-Yin Chen (陳威尹) authored
TBR=yusufo@chromium.org Bug: 1023079 Change-Id: Ia7c4d37734ae424792ffc1e6e6f278fc780760fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907518Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714092}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I3b4b205f0cce6c5b6fa17472939942957957895f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907217Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714091}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d6b9b0a1f413..a4c1aaad8d5f git log d6b9b0a1f413..a4c1aaad8d5f --date=short --no-merges --format='%ad %ae %s' 2019-11-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e615bdb3..5145d23f (713980:714086) 2019-11-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2b5d8199..e615bdb3 (713876:713980) 2019-11-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b19a2944..2b5d8199 (713775:713876) 2019-11-08 ilnik@webrtc.org Reset RtpFrameReferenceFinder on long pause 2019-11-08 brandtr@webrtc.org Remove dead kDummyVideoSsrc and FPS_TO_INTERVAL from video_common.h. 2019-11-08 danilchap@webrtc.org Revert "Cleanup MultiStreamTester" Created with: gclient setdep -r src/third_party/webrtc@a4c1aaad8d5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: Ic51ab5fe1ac1851ddaf04cfcf0485921cc0a8d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907220Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9b2e22593bbf..3573aac4baff git log 9b2e22593bbf..3573aac4baff --date=short --no-merges --format='%ad %ae %s' 2019-11-09 bhogeswararao@google.com Add gwifi to usergroup_baseline Created with: gclient setdep -r src/third_party/chromite@3573aac4baff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9085cc49b81a520343fbf5168ce025431b16db33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907215Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f2af41c8..c6814905 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I450e1ce7145606daa233564323c673d0b74d2dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906813Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714088}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I909922f9b849d970c49fe307036eda76348a81d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907777Reviewed-by:
-
Anupam Snigdha authored
Problem: Input panel policy only gets evaluated when textinputstore acquires focus. We call AssociateFocus and SetFocus for every focus change that led to multiple redundant focus messages to TSF. Input panel policy is set to auto only when the user taps on the edit control. It calls AssociateFocus and SetFocus instead of just OnStatusChange on the focused textinputstore. This leads to an inconsistent showing of the virtual keyboard because the policy switch sometimes happens after the focus gets evaluated by TSF. Solution:When browser launches, address bar is focused and the text input state is set to URL. The input pane policy is manual on focus. The text input state change notification calls AssociateFocus which also calls SetFocus internally on the document manager in TSF. Calling SetFocus again queues up redundant focus messages in TSF that interferes in other focus messages so we removed this call in this patch. When user taps on the address bar, input pane policy is changed to automatic on ShowVirtualKeyboardIfEnabled call. This notifies TSF with just a status change of the dynamic flag instead of calling AssociateFocus and SetFocus (which would have triggered lot of redundant focus messages to TSF. When the user opens google.com, the script sets focus on the input box which triggers a DetachTextInputClient from the address bar and also a text input state change notification. This sets the text input type to be SEARCH. In between this transition, null TSFtextStore gets focus that also calls AssociateFocus and TSF transitions its focus from URL to null and then from null to SEARCH. The input pane policy is set to manual until the user taps on the search box as we don't want to raise the virtual keyboard on focus and without user interaction on the page. Once the user taps on the search box, we set the input pane policy to automatic and call status change to notify TSF about the change. When TSF calls GetStatus to query for the dynamic flag, it will have the manual input pane policy disabled and the virtual keyboard will come up. Current flow of focus notification to TSF: When text input type is none i.e. no editable element is in focus, we call AssociateFocus on text input type and set the input panel policy to manual only when the text input client is detached or changed. This happens when user switches focus between address bar and a webpage. We call SetFocus only when the text input type is anything other than none. We don't call AssociateFocus and SetFocus at the same time to reduce redundant focus changes that leads to VK issues. Test: ui\base\ime\win\tsf_input_policy_unittest.cc Bug:1014365 Change-Id: I2a2dd28a8ae514cfa4912f5051cde351928b2ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895750 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#714086}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3a5aa758a93af2d21f3dc617e51dd6d2fa4cc272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907867Reviewed-by:
-
Austin Eng authored
This is a reland of 32cfad60 The original CL was reverted because it uncovered a state leak elsewhere in ANGLE. Original change's description: > Merge WEBGL_multi_draw_instanced into WEBGL_multi_draw > > The WebGL working group decided there is enough WebGL 1 support for > instancing that it would be simpler to only expose the instanced > version of the extension. > > This also rolls WebGL 2701c13..69e333c which includes the spec and > conformance test changes. > > Bug: chromium:890539 > Change-Id: Ib4dccf56f488cedf8161268ac3467d27c9b371c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881712 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710310} Bug: chromium:890539, chromium:1022080 Change-Id: I25fce02e99f0298b2f585f6ecdf47c0a0d0657d7 TBR: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890541 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714084}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/39b4b38f4f36..600a26d50a04 git log 39b4b38f4f36..600a26d50a04 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 rafael.cintron@microsoft.com Fix ResourceHeapAllocation Memory Leak Created with: gclient setdep -r src/third_party/dawn@600a26d50a04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Iaf14869659e69bf4abd6765abe11c4f0bc4eae89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907515Reviewed-by:
-
Bettina authored
Bug: 1010764 Change-Id: I8ab0a2f7fe028a68698be93741e20779c4209f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902230Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#714082}
-
Aidan Wolter authored
This reverts commit 8db01995. Reason: Broke downstream repository that doesn't have required dependencies Bug: b/143701391 Change-Id: Icb8c9bd3be5637b5766083991ea799068814c5a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907768 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#714081}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I3d538948fc753f31601a42894448f66d00d0003f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906342Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714080}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eddbd257ba24..9b2e22593bbf git log eddbd257ba24..9b2e22593bbf --date=short --no-merges --format='%ad %ae %s' 2019-11-09 vapier@chromium.org run_tests: run xbuddy unittests inside the SDK Created with: gclient setdep -r src/third_party/chromite@9b2e22593bbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iba6409567304e10c26af9ce83f93aa37485e0abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907600Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5c0e6e52bd5e..012d15196023 git log 5c0e6e52bd5e..012d15196023 --date=short --no-merges --format='%ad %ae %s' 2019-11-09 jdarpinian@chromium.org Stop using __has_include<Cocoa/Cocoa.h> Created with: gclient setdep -r src/third_party/angle@012d15196023 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1015591 Change-Id: I680677f2c716bb02849aec42726c9101006a5eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907167Reviewed-by:
-
Etienne Pierre-doray authored
Change-Id: Ic9ec415c89d5637ccc992abeeacb4b72c847411a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906629Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#714077}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/33f2ff73aa70..eddbd257ba24 git log 33f2ff73aa70..eddbd257ba24 --date=short --no-merges --format='%ad %ae %s' 2019-11-09 achuith@chromium.org dev_server_wrapper: Conditionally import cherrypy. Created with: gclient setdep -r src/third_party/chromite@eddbd257ba24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I949fa010c5b68d212af05bc6dd9296c9e96c4dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907712Reviewed-by:
-
siyua authored
Move cloud token data out of WalletMaskedCreditCard and make it a separate sync data type. Reason is: In the future, one actual card can have multiple sets of cloud token data so we need to change this field to a repeated one, but converting a sync data type with repeated field to data that can be stored in the autofill table is pretty complex. There is no reason to do that since the cloud token data will be stored in a separate table anyway. As long as there is a server id that can be used to match the actual card and the cloud token data of the card, we should be fine. Bug: 1020740 Change-Id: I1595d3dccf2b154b3fcaea59e710b75d07a692ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897004 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#714075}
-
Dan Beam authored
It's possible that a user backgrounding a tab results in a focusout, which can call stopAutocomplete(). I'm not aware of any reason why we should disallow stopping autocomplete for inactive tabs, so remove this restriction from the policy. Bug: 1020025 Change-Id: I937a67f1f45549629baa7fa0fd7e6901d2d37f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907563 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714074}
-
Tom Anderson authored
This CL uses GL PBOs to upload textures as an alternative to glTexImage2D. This allows copying frames into the buffer in parallel, which gives a ~4.5x boost over a plain memcpy() on my machine. With this change, I can playback 8K60 video without any dropped frames. The difference in tracing can be seen between [1] and [2]. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1013332 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1013332#c5 BUG=1013332 R=kbr CC=rjkroege,backer Change-Id: I02482d483a34374e8b49ca497c493c95f4d35019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888403 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
John Lee authored
Bug: 989131 Change-Id: I08b4da7bf37dcd0353f3553844ef7c9e8bf1cf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900659 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714072}
-
Mason Freed authored
Change-Id: I9aaae6c438fad8a1c8141fb6acf6d10bd6f2629c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906114 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714071}
-
Olivier Li authored
The markdown conversion renders it as something that comes up as a broken link which is misleading. This can't be fixed so backticks make it non-clickable which is less confusing. Change-Id: Ic995fb464b52a9a555cf4ff3fc99bae29e819ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906509 Auto-Submit: Oliver Li <olivierli@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Lambros Lambrou authored
This adds a permission-checking Delegate interface, which would implement the permission-checks, and provide the results via asynchronous callback to the PermissionWizard. This also adds the logic to poll the permission-checker and show the appropriate UI. This will skip showing any pages whose permissions are already granted. A dialog (page of the wizard) is only shown for each denied permission. If all permissions are granted, nothing at all will be shown to the user. If at least one permission is denied, the wizard will be shown, and the user will see the "All set!" page at the end. Still TODO: add a mechanism for the caller of PermissionWizard to know when the user cancels or completes the wizard. This would, for example, allow a command-line tool to wait until the wizard is finished before quitting with an exit-code. Bug: 1015201 Change-Id: Icf977d122c548b31c91c4ae0a71200c43ed241cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902116Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#714069}
-
Mei Liang authored
Change-Id: Ie793b24525fe683ddb6385034ecb3442b99b780d Bug: 1022200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907407Reviewed-by:
-
Alex Cooper authored
Removes the unused linear/angular acceleration/velocity attributes from VRPose. These attributes were used for the head pose in WebVr, but are not used in WebXr. Also cleans up some WMR code that calculated similar values for the old WebVr gamepad which was previously removed. Bug: 1017843 Change-Id: Ie5c4259068c3c3b98d0eae4ab71fe92ffac76e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903617Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#714067}
-
John Abd-El-Malek authored
Change-Id: I50993bca97f68dd35226aa43037a38302dc61263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902270 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#714066}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d9164777415c..56af378833d9 git log d9164777415c..56af378833d9 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 bsheedy@chromium.org Revert "devil: update default adb to 1.0.41." Created with: gclient setdep -r src/third_party/catapult@56af378833d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1005504,chromium:1021285 Change-Id: I130459de18793757361721ef55809ee1b88199c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906296Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::MediaLog replacing AssociatedBinding with AssociatedReceiver. Bug: 955171 Change-Id: Ifd17b4cb3f16d1841b7395df3866ce410d1f40d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903177Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#714064}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ef55c4e738de..31edef751a8d git log ef55c4e738de..31edef751a8d --date=short --no-merges --format='%ad %ae %s' 2019-11-09 chrisforbes@google.com Update deqp to vulkan-cts-1.1.6.1 Created with: gclient setdep -r src/third_party/swiftshader@31edef751a8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/144183516 Change-Id: I1eff80dfdda06366ab637e54767f7e80577fdfcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906323Reviewed-by:
-
Avery Musbach authored
Bug: None Change-Id: Ifa91ffcab13cff43ef4d19f3ad84c56e8cd86904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906250Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#714062}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::ContentDecryptionModuleClient using AssociatedReceiver. Bug: 955171 Change-Id: I4759d6f44fbd8a4dcc78659b316c660cba603ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903229Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::RestrictedCookieManager replacing StrongBindingSet with UniqueReceiverSet. Bug: 955171 Change-Id: I33d2ba7fa454a6949fe00626687192c7640db8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903230Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#714060}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c2f1f6188127..5c0e6e52bd5e git log c2f1f6188127..5c0e6e52bd5e --date=short --no-merges --format='%ad %ae %s' 2019-11-08 jmadill@chromium.org Capture/Replay: Implement more state for mid-execution replay. 2019-11-08 lehoangq@gmail.com Metal: multiple bug fixes Created with: gclient setdep -r src/third_party/angle@5c0e6e52bd5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I24585fb81731a8044a446ae2496320c304442856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906322Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts media::mojom::RendererClient from media/mojo/mojom/renderer.mojom to new Mojo types using AssociatedReceiver, PendingAssociatedReceiver, and PendingAssociatedRemote. Bug: 955171 Change-Id: Icc9a50f32b17b2e94ba075844e7da0b99a5f9791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903174Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Daniel Libby authored
From code inspection and tests, there are no longer any compositing queries when calling UpdatePaginationRecursive. Bug: 1007989 Change-Id: I74dea1aee271763e0d464c98ca3458015d3accd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901359Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#714057}
-
Jarryd authored
The variables used to be constants, but with the new experiment around incognito pool size, they are no longer constant. This change updates the variable names to reflect the aforementioned. Bug: 1017120 Change-Id: Ic65bf5bc58ef54177946b84deeb6d9f098d03140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906317 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#714056}
-
