- 05 Jun, 2019 40 commits
-
-
Navid Zolghadr authored
Add callback supports to the RenderWidgetTargeter and use the async targetting in drag and drop code and register a callback to send drag events using the callback. Note that since drag and drop events aren't WebInputEvent it is not possible to use FindTargetAndDispatch function of RenderWidgetTargeter at this time. The original CL https://chromium-review.googlesource.com/c/chromium/src/+/1596840 was reverted due the added test being flaky. This CL is the same as the original CL expect it has the same test with another way of checking the logic. TBR=sadrul@chromium.org Change-Id: I95ac25a554a2964c3c5a0ebeee97b4d041d74a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642979Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#666334}
-
Jesse Schettler authored
WebContents::GetDelegate() can return nullptr when handling a keyboard event. BUG=b:64863368 TEST=While browsing a PDF with an ARC Custom Tab, press Ctrl and verify no crash occurs Change-Id: I113a41d23f27409d52bcfe313cb4142f7562f905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645816Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#666333}
-
Kyle Horimoto authored
The "configure network" dialog displays a configuration error in some cases when it should not. This was caused by the fact that we were inspecting the last_error attribute of NetworkState, even if there is no current error. To fix this issue, I removed the NetworkState::GetErrorState() function and updated clients to simply call the error() function instead. Bug: 968474 Change-Id: I2d351057ec8b0d2d35a0ea8a46a4515413bec9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642692Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666332}
-
Natalie Chouinard authored
Fix issue with support library Fragment constructors being removed by Proguard when they are only used through reflection via Fragment.instantiate. Bug: 969590 Binary-Size: Expecting to recoup some once all Fragments are migrated Change-Id: I14f92ad651069bde7212ce20e6f7b934f2f49232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641443 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#666331}
-
Joshua Pawlicki authored
The verifier will work with both crx2 and crx3 (at least, until crx2 is gone forever...) Bug: 970891 Change-Id: I85665748a816e952f80df6e5509fb71fc0743d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643353Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#666330}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961073,969812 Change-Id: Iff5ca80465118a03cb6d5b544ad67acc7b22b9d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640784 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#666329}
-
Abhijeet Kandalkar authored
ListHashSet is deprecated in favor of LinkedHashSet. HeapLinkedHashSet's invalidate iterators when the container is modified. This does not happen in this usage, so replacement is simple. Bug: 614112 Change-Id: I43ed7c4c12ed5b1c6cdb369210a60c3da2358bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641162Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#666328}
-
Xiyuan Xia authored
- Replace ShutdownController mojom interface with cpp; - Current ShutdownController -> ShutdownControllerImpl; Bug: 958217 Change-Id: I53a78b3366934aeaf2da36d39d889e0b73801f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643985 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#666327}
-
Kurt Horimoto authored
crrev.com/c/1529921 resizes the WebViewContentView to match the CRWWebControllerContainerView's frame when it's added to a new window. However, BVC resizes the container view to match the content view bounds in |-displayWebState:|. The frame was later reset by the fullscreen resizer when BVC.broadcasting is reset to YES when the animation finishes. This CL updates |-displayWebState:| to account for the current viewport insets so that the frame remains constant during the settings dismissal animation. Bug: 963108 Change-Id: Ifd44277f7c88bfea60e292387468483a521e5f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644419 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666326}
-
John Emau authored
This change updates our eslint configuration to parse ECMAScript 9 syntax which includes the object literal spread operator. Change-Id: I9fadc40b2832e92a32f4ee94fddaf9c719046413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639178Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: John Emau <johnemau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#666325}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I50319fd4bfe60035d1c4535ec971692bbfb2428d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666324}
-
Robert Liao authored
BUG=937566 Change-Id: I43e91f3b8b35cb44e9463f417522fdb28cee0ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642241 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#666323}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961068 Change-Id: Idf3c932175ebf7d17187648fd508e471f06c40ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640781Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666322}
-
Robert Ma authored
wptserve (especially its pywebsocket component) produces too many log messages to stderr which can block the pipe since the parent process (wptserve.py) does not read from the pipe until the server exits. This change redirects the stderr of wptserve to a log file (in a way that's still compatible with the error logging and cleanup logic in ServerBase, see _log_errors_from_subprocess and _remove_stale_logs respectively). Bug: 968904 Change-Id: I08200bf7d895c844652cd50e627e270671f25369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641436 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#666321}
-
Robert Liao authored
BUG=937566 Change-Id: If69c7186b7870369f179cf72ba42b65d8e808160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644460 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#666320}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961064 Change-Id: I1aa3f6165fdc264b1cfdd7ae20b4fc354495c19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639052 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#666319}
-
Min Chen authored
1. Extend the expires time of 'Power.PowerButtonMenuAction' by some branches. 2. Add label for feedback source type kFeedbackSourceAssistant, which might be missed while adding the type. Bug: None Change-Id: I088f8a9041b6d293bad64469d2a72dc1da050f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643499 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666318}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d2f31cc65dea..075cb05bdeb5 git log d2f31cc65dea..075cb05bdeb5 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 jbudorick@chromium.org tryserver: add a 10 minute timeout on fetching CL info from gerrit. Created with: gclient setdep -r src/third_party/depot_tools@075cb05bdeb5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7126b721a096019ceed371b2fa5c3db687b8f210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645794Reviewed-by:
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961075 Change-Id: Ib3c729da5cf45d77c9130f66cedb911434ccd03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641562 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#666316}
-
Xida Chen authored
It appears that this expected.txt is causing the failure on Mac: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/23664 https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/12244 Deleting this should work. Bug: 968791 Change-Id: I6134b3c67fa38a316b66ab97be2eb7a46525d364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645378Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666315}
-
James Cook authored
The color computation tries to inset its samples by 1 pixel on each edge, but that doesn't work for 1 pixel wide images. Skip the inset if the image is too narrow or too short. See bug for details. Bug: 970343 Test: Added to gfx_unittests Change-Id: If558a8bbacb27d9011da93868ad3b6f0e72f8754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644299 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
about://gpuMaggie Chen authored
Some gpu bugs are related to the monitor refresh rate. Adding this display information will help us on gpu debugging. Bug: 964095 Change-Id: I54d468dd192110a77f2aa46f7d441ed257f06491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644232Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666313}
-
James Cook authored
Follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/1640601 Remove unused C++ message handlers: * Search engines * Fonts * Import browser data None of these are used in OS settings. Bug: 960937, 950007 Change-Id: I8a74207f03d2ed66cbf919dfa16cbe6dce04b8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645131 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#666312}
-
Bill Orr authored
The output XML contains a relative path to the mojom file. On Windows, the expected path contains '\' separators, but the actual contains '/'. tools/metrics/histograms/update_use_counter_feature_enum.py will update the enums.xml file, but uses a hardcoded path. The fix is to use a hardcoded path for third_party/blink/public/mojom/web_feature/PRESUBMIT.py as well. Bug: 966496 Change-Id: Iad605bea175ee86abe7bb8c160ae2be30bf8f65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627636Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#666311}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961029 Change-Id: I189cfe1a129ed7af4f87d256e3ecf1d9d84a392a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638920Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666310}
-
Michael van Ouwerkerk authored
Bug: 969978 Change-Id: I320b622be2113fb3b6edb98e48e9178c92c826b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645304 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#666309}
-
James Cook authored
Ports most of //c/test/data/webui/settings/settings_main_test.js to the OS settings page. Initializes CrOncStrings in the test because the test does not load os_settings_ui.js, but the global must exist for the network page. Adds assertions for CrOncStrings to make this failure more obvious in the future (otherwise the error is just "reading property of undefined" without a useful line number). Bug: 967910 Test: browser_tests Change-Id: Ia86483a2c204d82387a6c771a02075f76acc3681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642249Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c55eb1b1. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." a5b31124 "DetachLayoutTree clear hover/active state on dom removal." 04c3df15 "Canvas::TestMetrics: Measure the TextMetrics info after loading the font" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ie8eeb95b20de14ce7b41e9a695f35f1f2a9028b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645496Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666307}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961017 Change-Id: Ie2d163715da8322c8727030a153ed9600462a7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636866 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#666306}
-
Maggie Chen authored
When this command line option is added, a dialog box with GPU process ID will pop up at the process launch for the short-lived unsandboxed GPU process that collects GPU information. This is to separate the the other command line option --gpu-startup-dialog which is for the main GPU process. Bug: 961662 Change-Id: I0a3a91270a1ba7d793f3998b397aac541b28da8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642489Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666305}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961039,969160 Change-Id: Ied0a27fde7a99c5d801a49adc235c712e5fedce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638923 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#666304}
-
Karolina Soltys authored
This reverts commit 0c8cf257. Reason for revert: The upstream CL got reverted. Original change's description: > [scheduler] Registering the current task executor. > > I'm saving to TLS the current task executor on registration, and providing > it for the base::CurrentThread() trait. > > Bug: 968047 > Change-Id: I753213ff57249ed55d10cb0a576ec56975a4088e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642562 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Karolina Soltys <ksolt@chromium.org> > Commit-Queue: Karolina Soltys <ksolt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666291} TBR=skyostil@chromium.org,alexclarke@chromium.org,ksolt@chromium.org Change-Id: Iebd1add6a23939b48ae2c25335b49ce2869a2f97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645777Reviewed-by:
Karolina Soltys <ksolt@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#666303}
-
Andrew Xu authored
When showing the system tray with the shortcut, the auto-hide shelf is shown and the system tray gets the focus. Then tapping on the shelf button will change the focus and system tray (including shelf) is dismissed. The shelf button starts to handle the gesture event after the shelf is closed. As a result, the shelf button does not respond to gesture events. In this CL, when a touch-pressing event comes and shelf is visible, ShelfBezelEventHandler holds the shelf until the touch-releasing event arrives. It is effective because ShelfBezelEventHandler receives the event before SystemTrayEventFilter. Bug: 902680 Change-Id: Id04780e2211c0ab19691db811496e703950f81d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639082Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#666302}
-
Yun Liu authored
android-code-coverage keeps failing https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-code-coverage Looks like it is searching for 8 cores, which should be 32 cores, e.g.: https://chromium-swarm.appspot.com/task?id=453ef7394666fa10&o=true&w=true Bug: 967011,961808 Change-Id: Ib1b958e0e27c29868cad080786a9aa83767c2773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644878Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#666301}
-
Gabriel Charette authored
This reverts commit 973df87d. Reason for revert: Let's not land TaskTraits that don't do what they say. We can reland this in the base::experimental:: namespace or something but I'm strongly against having it while it's not supported and tested. Original change's description: > [scheduler] Adding base::CurrentThread trait. > > I'm adding a trait specifying that the task should run on the current > thread. It will be one of the 3 possible destinations (alongside > ThreadPool and BrowserThread), specifying which will be made mandatory > in a future CL. > > A future CL will add the desired functionality backing this trait. > > Bug: 968047 > Change-Id: I16f244911b9e25da354148b034bd766c988dec11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642559 > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Karolina Soltys <ksolt@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Karolina Soltys <ksolt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666288} TBR=torne@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,ksolt@chromium.org Change-Id: I2c100ff743dd25aeabf943c2ee47d4f811141340 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645307Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
The default font returned by Skia should take the initial size from the default value kDefaultBaseFontSize specified in PlatformFont. R=robliao@chromium.org, asvitkine@chromium.org CC=benck@google.com Bug: 944227 Change-Id: I6b230b80c349abbe5968edb3cebdd6e89db4c4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642738Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Alex Ilin authored
BrowserAddPersonEnabled policy controls whether Chrome allows Add Person from the user manager. Hovewer, it doesn't inhibit the user from creation of a new profile from the profile menu in the menu bar on Mac. This CL removes Add Person menu item if BrowserAddPersonEnabled policy is set to false. Bug: 807860 Change-Id: Id8a34bbe164cad8998de2d36f2d23b9396d95c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645224Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666298}
-
Denis Kuznetsov authored
Over time we have to introduce new parameters for Register/ RegisterWithCertificate requests, and this list is growing unmanageable. We need to add one more parameter, so this CL just groups such parameters into a single struct with reasonable values for defaults. Change-Id: I362ffda59f0b78cc25541953f8afb3e2df11b1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625124 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#666297}
-
Xiyuan Xia authored
Bug: 958228 Change-Id: I7fbe6243e15daaf800f720f4b022360124ec661f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642962 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#666296}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 971262 Change-Id: I0a5a2b0ea5cb6d046b0efbdbb4c67637afb015aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645130Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666295}
-
