- 23 Oct, 2018 40 commits
-
-
Yoshiki Iguchi authored
This reverts commit 155c0b00. Reason for revert: This breaks the lock screen notification. Original change's description: > Show notification counter even on lock screen > > - Unblock notifications in SessionStateNotificationBlocker > - Hide the message center by seeing the session sate (previously, it > saw the count of notifications) > - Change height below scroll, by checking the visibility of message > center (previously, it checked only the height) > > Bug: 893945 > Test: manual > > Change-Id: I39d30d0949d0f44078193ab7e4859f66eeebf880 > Reviewed-on: https://chromium-review.googlesource.com/c/1282426 > Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601824} TBR=yoshiki@chromium.org,yamaguchi@chromium.org,tetsui@chromium.org Change-Id: I5b2ded9c9f3212ab3cd085a3ea0721e69b6fae45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893945 Reviewed-on: https://chromium-review.googlesource.com/c/1296330Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#601930}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b07dffd979d..25837bf17019 git log 1b07dffd979d..25837bf17019 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5a2069501490..19603b9e7b20 (1 commits) Created with: gclient setdep -r src/third_party/skia@25837bf17019 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I0996dd6b597de0c36331f28319eee232e325df67 Reviewed-on: https://chromium-review.googlesource.com/c/1296372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601929}
-
Robert Sesek authored
Bug: 828031 Change-Id: I395c4b33b7ac394645bf626c00185b4f9efcc289 Reviewed-on: https://chromium-review.googlesource.com/c/1294309Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#601928}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0339f0866c5f..7d5d4ab1dd6f git log 0339f0866c5f..7d5d4ab1dd6f --date=short --no-merges --format='%ad %ae %s' 2018-10-23 perezju@chromium.org [sounwdave] Revert to old /describe dashboard API Created with: gclient setdep -r src/third_party/catapult@7d5d4ab1dd6f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I69194ff1847f8fb5cbaaad226f81da4bd56bd5a3 Reviewed-on: https://chromium-review.googlesource.com/c/1296371Reviewed-by:
-
Nicolas Ouellet-payeur authored
- When annotations.xml is modified in a CL, run a full test of traffic annotations to catch more errors. - When there are duplicate hash codes (e.g. after renaming in annotations.xml), fail even if error-resilient mode is on. These 2 things combined means the buildbot will fail on CQ instead of only failing on the waterfall. Bug: 876855 Change-Id: Ib4ada288f4aa29943d1413bd81c4ec7c22735fc6 Reviewed-on: https://chromium-review.googlesource.com/c/1291813 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#601926}
-
Yi Gu authored
This test is really flaky. Findit suspects that it was caused by a v8 update. TBR owners for furthur investigation. TBR=hablich@chromium.org NOTRY=true Bug: 898156 Change-Id: I69b3929f6b26772fba0b0a3ada8ea3aa3b807424 Reviewed-on: https://chromium-review.googlesource.com/c/1296319Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601925}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8c0f6ea8. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26607 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I6dc6392e83ff5d7092def49b12ac8e19eddbf28f Reviewed-on: https://chromium-review.googlesource.com/c/1296310 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#601924}
-
Morten Stenshorne authored
In the initial layout pass of a multicol container with auto height, there'll be no known breaks, but we will honor the contraints of any outer fragmentation context, and insert pagination struts if necessary. These pagination struts need to be ignored when we calculate the height requirements imposed by orphans and widows requirements, or we risk making the inner multicol too tall. Bug: 891703 Change-Id: Ia9281508fcbba3572d653f1bbf863f045db71827 Reviewed-on: https://chromium-review.googlesource.com/c/1296492 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#601923}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9a5da497b568..ac19414512d8 git log 9a5da497b568..ac19414512d8 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 6). Created with: gclient setdep -r src/third_party/webrtc@ac19414512d8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibdc8b548f059075051c61e34ccf4ffef6effcb90 Reviewed-on: https://chromium-review.googlesource.com/c/1295742Reviewed-by:
-
Leszek Swirski authored
Work stealing is deprecated by script streaming on the task scheduler, and broken anyway by ScriptResource-controlled script streaming. Bug: 557466 Bug: 761977 Bug: 865098 Bug: 866868 Change-Id: Ie01d239b052ad7499e9884687bf95376a5cf6f9a Reviewed-on: https://chromium-review.googlesource.com/c/1258168 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601921}
-
Michael Lippautz authored
- LayoutWorklet and PaintWorklet are supplements to LocalDOMWindow which ties the lifetime of JS wrappers to the lifetime of the window - TransformStreamTest does not crash anymore Bug: 843903 Change-Id: Iea6d46f32fd22d10aa3581ff0712778d4c9ca6ba Reviewed-on: https://chromium-review.googlesource.com/c/1296591Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#601920}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a50f4057..42645509 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I46ffdd66aee488c4c590279381388cf59b1825da Reviewed-on: https://chromium-review.googlesource.com/c/1296309Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601919}
-
Victor Costan authored
storage::CallbackQueue and storage::CallbackQueueMap are non-trivial to understand, as they use fairly involved template machinery. Most importantly, their Run() methods appear to perfectly forward their arguments, but actually end up copying them, in order to be able to pass the same arguments to multiple callbacks. This CL removes the custom types in favor of std::vector and std::map. In return for slightly more lines of code (but not binary size), the code is significantly easier to follow. Change-Id: I563675c4aa6c4e771cd4979712996d878f9a8aa0 Reviewed-on: https://chromium-review.googlesource.com/c/1295593 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#601918}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1c752c1ef387..38da6cc72e36 git log 1c752c1ef387..38da6cc72e36 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 primiano@google.com Merge "perfetto-ui: Clear search bar when displaying message" Created with: gclient setdep -r src/third_party/perfetto@38da6cc72e36 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia033cd3d798d0b8743891228f63229ea2458e78e Reviewed-on: https://chromium-review.googlesource.com/c/1296369Reviewed-by:
-
Antonio Gomes authored
As part of the s13n effort to migrate users of SigninManager APIs in favor of using the associated IdentityManager APIs, this is a straightforward CL that replaces uses of SigninManager::IsAuthenticated() to IdentityManager->HasPrimaryAccount(). BUG=890788 Change-Id: I0d83e058a6cc641c3e3b98b36803bf7854b36ac3 Reviewed-on: https://chromium-review.googlesource.com/c/1291669Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#601916}
-
Denis Kuznetsov authored
This is a follow-up for CL 2959853003 that added a new enum value. Bug: None Change-Id: I528b0078ec036630f7747c4a4f85bfcd6d2a3158 Reviewed-on: https://chromium-review.googlesource.com/c/1296251Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#601915}
-
Misha Efimov authored
- Remove obsolete and unused options. - Get gn args from cr_cronet for consistency. - Use build directories different than normal out directories. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: I7c75b13d6138b97e6f8f1548225319571f974616 Reviewed-on: https://chromium-review.googlesource.com/c/1287074Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#601914}
-
Mark Cogan authored
This has been moribund for several years. Bug: 775332 Change-Id: Ie27ae997ebc9ba7c8d0794e6c51375b5caa71b39 Reviewed-on: https://chromium-review.googlesource.com/c/1296171Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#601913}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ccdc15e888e..05d8699f331a Created with: gclient setdep -r src-internal@05d8699f331a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia5a259beb1ce6c7d57c52997c270045118d27bbf Reviewed-on: https://chromium-review.googlesource.com/c/1296370Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601912}
-
Camillo Bruni authored
Conditionally enablding runtime call stats is not straight forward. Hence we add a separate benchmark that uses the slow RCS metrics. Bug: chromium:883322 Change-Id: I66bc754f59ea62f0b7a922a3ca22535f568597d7 Reviewed-on: https://chromium-review.googlesource.com/c/1294034Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#601911}
-
Brian Osman authored
Change-Id: I1b1d883dfae7611459547b308f0e42f291c36679 Reviewed-on: https://chromium-review.googlesource.com/c/1293790 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#601910}
-
Daniel Bratell authored
Not all sources lists have been kept up to date with code movement/removal and it seems to make some isolate steps in cq sad for some CLs (mine). Change-Id: I030e6068e857de2957b4e20a3e53fc26af3017a8 Reviewed-on: https://chromium-review.googlesource.com/c/1288873Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601909}
-
Jan Krcal authored
This CL improves reporting of remote entity changes in the sync engine. It splits remote updates into two buckets: one for the initial sync and another one for later incremental updates. This is useful for ephemeral storage where the initial sync is a common scenario. Bug: 897658 Change-Id: Ibab27b0e6a94e3917c1794c48065a8ae34a495eb Reviewed-on: https://chromium-review.googlesource.com/c/1294031 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#601908}
-
Findit authored
This reverts commit 01ccf727. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 601879 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDFjY2Y3Mjc3NjRjNTE1MTUzNDc4ZDJiYjM0MGYwNjg4NzRkNjZkNQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/16124 Sample Failed Step: browser_tests on (none) GPU on Mac on Mac-10.12.6 Sample Flaky Test: PictureInPicturePixelComparisonBrowserTest.VideoPlay Original change's description: > Enable the pixel by pixel comparison test for Mac OS. > > 1. Tested on Mac and verify everything works as expected. > 2. Removed the unnecessary call of GetNativeWindow(). > > Change-Id: I377e6bfb004548887b9623b0094da91fa36b4d1c > Reviewed-on: https://chromium-review.googlesource.com/c/1279301 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601879} Change-Id: I54c6f61e3cb1f6bbd0997ccc1e8d616c9977d21d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898146 Reviewed-on: https://chromium-review.googlesource.com/c/1296312 Cr-Commit-Position: refs/heads/master@{#601907}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e40cdcfce94..4ccdc15e888e Created with: gclient setdep -r src-internal@4ccdc15e888e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia1153b13855e23177bd0977126754192f359ba4d Reviewed-on: https://chromium-review.googlesource.com/c/1295743Reviewed-by:
-
Stuart Langley authored
More work to have unittest closure compiled. Fixed the closure and linter errors after making these changes. No logic changes. Bug: 860355 Change-Id: Iaddb21d332877f901997e513c92fcb0b6b1c210e Reviewed-on: https://chromium-review.googlesource.com/c/1295972Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#601905}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: I8f1fce1850629fef4f7d2eb81adc57a6f74429ea Reviewed-on: https://chromium-review.googlesource.com/c/1292879 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Joel Hockey authored
Change method API to take resulting FilePath as input pointer, and return bool to indicate success or otherwise since it is not guaranteed that input will always convert. Bug: 878324 Change-Id: I17f99201c2c4b5105cceb48d6a3c0d57b80c5f7b Reviewed-on: https://chromium-review.googlesource.com/c/1295634 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#601903}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9f335772. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26606 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I7b2098968d56e8bb52fa36cf8b02451e7b1ad4ad Reviewed-on: https://chromium-review.googlesource.com/c/1296061 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
When NetworkService/ServiceWorkerServicification is on, MimeSniffingThrottle is used for responses from service workers. Previously, downloading is skipped when any of throttles handle the response, so using MimeSniffingThrottle undesirably prevented downloading. This CL is to make downloading work properly when a service worker serves the response. Also, when a response is NOT served from ResourceDispatcherHost, DownloadManagerImpl needs to be created in NavigationRequest. Currently it happens only when NetworkService is on. This CL adds a condition where S13nSW is on and a service worker serves the response there. TBR=jam@chromium.org Bug: 896696 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I222d8148cf65d15492393ebcd6ed582deb14022f Reviewed-on: https://chromium-review.googlesource.com/c/1290434 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#601901}
-
Pavel Shmakov authored
Lifecycle dispatching is important for modularization and decoupling. Currently we see activities having heaps of code in lifecycle methods touching lots of different classes. These classes often pass the events further down to their dependencies. To have less coupling, classes should be able to subscribe to lifecycle events and handle them on their own. This is especially important for the destruction event. Having a public destroy() method and relying on some other object to call it is unreliable and easily produces memory leaks. See, for example, https://chromium-review.googlesource.com/c/chromium/src/+/1172425/4/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java With DI, this is even more important. Whereas without DI whoever creates an object "owns" it, and is responsible for destroying it, with DI there is no such ownership (at least for scoped classes), as the instances are created and held by Components. At the same time, DI makes implementing lifecycle dispatching easy. In this CL I introduce the lifecycle dispatching and provide a simple usage example in Contextual Suggestions classes. Another example can be seen in the upcoming CL: https://chromium-review.googlesource.com/c/chromium/src/+/1281102/1/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java Bug: 887926 Change-Id: I81a43406df320544bc55732f622704109631a232 Reviewed-on: https://chromium-review.googlesource.com/c/1283256 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#601900}
-
Marc Treib authored
Before: Reconfigure Sync only when the *last* handle is released. After: Reconfigure Sync whenever a handle is released, whether there are any others or not. On desktop, this fixes the case where a chrome://settings/syncSetup tab is left open and forgotten somewhere, which previously prevented Sync from ever applying new settings. On Android/iOS, only one Sync setup UI can be visible at a time, so this doesn't change any behavior. However, we now need to be careful not to needlessly re-create the handle. Bug: 884159 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib61d063ac8b6e76d05a5b72d17de7b1e031a51dd Reviewed-on: https://chromium-review.googlesource.com/c/1280208 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Victor Costan authored
This reverts commit 56d26cfc. Reason for revert: Crashes in Canary - https://crbug.com/897576#c3 Original change's description: > sqlite: Upgrade from 3.24.0 to 3.25.2 > > The new release changes how ALTER TABLE RENAME is implemented, and > requires an update to WebSQL's SQLite authorizer. This CL includes the > update, and extends the LayoutTest for the authorizer to cover the > newly implemented column renaming functionality. > > Bug: 892852 > Change-Id: I58fdc2927cacb6ccc84a741d7fc519fb2e5b8721 > Reviewed-on: https://chromium-review.googlesource.com/c/1266881 > Reviewed-by: Chris Mumford <cmumford@chromium.org> > Commit-Queue: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600637} TBR=cmumford@chromium.org,pwnall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892852 Change-Id: I6f5ace9dcb431d5423232880e8f1b2cf0873066a Reviewed-on: https://chromium-review.googlesource.com/c/1296062 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#601898}
-
Mythri Alle authored
Http caches are owned by network service when network service is enabled otherwise they are owned by browser thread. HttpCaches are cleared by StoragePartitionHttpDataRemover on browser thread when network service is not enabled. However, with network service enabled they are cleared by a different mechanism by the network service. GeneratedCodeCaches are owned by the browser process and clearing them should be cleared by the browser process. Hence clearing the GeneratedCodeCache along with HttpCaches in StoragePartitionDataRemover doesn't work. This cl refactors the clearing of code caches into a separate class, so it can be used both with and without network service. Bug: chromium:892652 Change-Id: I5238de412f35f3dc90ae69c37b76e83d34a0d089 Reviewed-on: https://chromium-review.googlesource.com/c/1270946Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#601897}
-
Majid Valipour authored
ElapsedTimer is a small useful utility class for measuring time. As a wise Greek may put it: "The unmeasured time is not worth having". Here is discussion that inspired this CL: https://chromium-review.googlesource.com/c/chromium/src/+/951922#message-fca340ea66b052ad7ee1d6e92d42b61ac549456d Change-Id: Iebd3d49c1965fd0b1a16ad0eeee7af302a6afbf3 Reviewed-on: https://chromium-review.googlesource.com/c/1295177Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d28f8451a549..1c752c1ef387 git log d28f8451a549..1c752c1ef387 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 primiano@google.com UI: seamlessly migrate to catapult UI for legacy traces Created with: gclient setdep -r src/third_party/perfetto@1c752c1ef387 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:117977226 TBR=perfetto-bugs@google.com Change-Id: Iba831326e2c67abc5a3a3f3a15a7df3dc8899849 Reviewed-on: https://chromium-review.googlesource.com/c/1295741Reviewed-by:
-
Gauthier Ambard authored
Preparation to create a new SettingsSwitchItem for TableView. Bug: 894791 Change-Id: Icd88aa0a5af519172b0750782f3b029ac2cc7d29 Reviewed-on: https://chromium-review.googlesource.com/c/1296189Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#601894}
-
Alexander Hendrich authored
This CL adds UMA to the re-registration flow to observe number of triggered, successful and unsuccessful re-registrations attempts. DD: go/handle-purged-user-sessions Bug: 870616 Change-Id: Ic963d321fb84cac55a61571b49e4a41554872589 Reviewed-on: https://chromium-review.googlesource.com/c/1283026 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Christian Biesinger authored
This matches how we create constraint spaces, and is more efficient. Change-Id: Ifd52cf754efd9d921d8042175756988909db15f8 Reviewed-on: https://chromium-review.googlesource.com/c/1292563 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#601892}
-
Mikel Astiz authored
We've recently received reports of DCHECK failures reflecting an inconsistent state in the processor's tracker. The problematic scenario is as follows: 1. There's a pending local creation, which starts with a temporary server ID. At the processor/tracker level, this means an empty ID. 2. A remote deletion is received for the same entity (same client tag hash), which is treated as conflict. 3. The default conflict resolution will choose to "undelete" the entity, that is, the creation should prevail over the deletion. However, the temporary server ID must be overriden with the real one as provided in the remote update (deletion). Prior to this patch, ProcessorEntityTracker::RecordIgnoredUpdate() did partially handle this scenario because the server ID in |metadata_| was updated. However, the analogous ID in cached |commit_data_| also needs to be updated. The underlying issue has been around for very long but was reproduced consistently with recent ongoing experiments that exercise local deletions far more often. Bug: 896138 Change-Id: I53a4e0447d2b809c5691a739a220046c8642156a Reviewed-on: https://chromium-review.googlesource.com/c/1296169 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#601891}
-
