GitLab

Removed some code that can simply rely on the Blink
PictureInPictureController and made use of the DisplayType() in WMPI.

Bug: None
Change-Id: I7f6aac46cdd99c8a35d9ae95e1e3024e11f54960
Reviewed-on: https://chromium-review.googlesource.com/1069214
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561745}

Upon reading the full list of team drives that a user has access to, if we
discover any drives that are still in resource metadata but no longer in the
list returned from the server we will recursively delete them.

Bug: 715355
Change-Id: I1e7d4c8f9de95413a2b62c5ce07fb7672342e41c
Reviewed-on: https://chromium-review.googlesource.com/1071277
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561744}

When MockWebMIDIAccessor works as a loopback device, it delays the data
dispatch. However, it passes an expiring buffer when posting the task.
That causes a UAF on a layout test.

Bug: 846182
Change-Id: I016da63055fecc7c4d2eeb3f8f7286135b4020a2
Reviewed-on: https://chromium-review.googlesource.com/1071367Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561743}

Change-Id: Icd703a923a5ec6c461b71adaff0be12769513e0d
Reviewed-on: https://chromium-review.googlesource.com/1070805Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Brad Lassey <lassey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561742}

Bug: 839646
Change-Id: Ibfeee6aefedcc4c46b432d1f2df02089d521d214
Reviewed-on: https://chromium-review.googlesource.com/1065204Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561741}

https://chromium.googlesource.com/angle/angle.git/+log/ba1627086779..b2eda420234d

$ git log ba1627086..b2eda4202 --date=short --no-merges --format='%ad %ae %s'
2018-05-24 jmadill dEQP: Add attrib init helper function.
2018-05-24 jmadill Fix style inconsistency in packed enum json.
2018-05-24 jmadill D3D9: Fix incorrect parameter to setBlendDepthRasterStates.
2018-05-24 brandon1.jones Use os.path.join instead of slashes
2018-05-24 jmadill Order packed enums according to JSON.
2018-05-24 jmadill Move packed enum code to common/
2018-05-16 tobine Roll to latest LVL as of 5/16/18
2018-05-24 jmadill Fix run_code_generation for huge diffs.
2018-05-17 jmadill dEQP: Add EGL 1.5 getPlatformDisplay.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: Id428453daca5c336546485d3b24056383b70b99a
Reviewed-on: https://chromium-review.googlesource.com/1072922
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561740}

Bug: 637351
Test: manually verified as in the bug
Change-Id: I27c833a2a9514af9b105126d1db2d0adffe358c0
Reviewed-on: https://chromium-review.googlesource.com/1059369
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561739}

Bug: 839676
Change-Id: I203a06e7c4136f0d359d265010bd9b74ee08426a
Reviewed-on: https://chromium-review.googlesource.com/1071492
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561738}

This reverts commit 8f1ca782.

Reason for revert: ash_unittests failing since

https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5825

on

SplitViewTabDraggingTest.DragMaximizedWindow
SplitViewTabDraggingTest.DragSnappedWindow

errors like

Received signal 11 <unknown> 000000000000
#4 0x7fe9f7749306 MallocBlock::FromRawPointer()
#5 0x7fe9f7745daa DebugDeallocate()
#6 0x7fe9f7773a73 tc_free
#7 0x7fe9f77061ad (anonymous namespace)::TCFree()
#8 0x7fe9f7705cf3 ShimCppDelete
#9 0x7fe9f77056e5 operator delete()
#10 0x7fe9f9832475 ash::wm::WindowState::DeleteDragDetails()
#11 0x7fe9f977aa09 ash::DragWindowResizer::~DragWindowResizer()


Also FindIt Says So :).

Original change's description:
> Cros splitscreen: Implement the tab dragging feature in tablet mode.
> 
> It's an initial implementation of the feature.
> 
> See the UI mock: https://docs.google.com/presentation/d/1zCV2v5rXFUndWC5ECMKj06i5WNbRJ-uZWyZTFxU8dEE/edit#slide=id.g21b4c071a9_0_116
> 
> See Doc for expected behaviors: https://docs.google.com/document/d/1rm8_JyTY883IiNNis6LGtI1jsx_WHCWm5KY7hwAGOe8/edit#heading=h.i5t24a7vxw8j
> 
> See recorded video: https://drive.google.com/open?id=1KcqAyHrxj6zheSEkgGz-ozlg7mILrmxT
> 
> 1) Add a new feature flag --enable-features=DragTabInTabletMode And also expose
>    it to chrome flag --enable-drag-tabs-in-tablet-mode
> 2) Only tab(s) area can be dragged.
> 3) For a maximized window, its tab(s) can be dragged out to create a new window
>    to either be maximized or snapped to one side of the screen, or can also be
>    merged back to the original window
> 4) For a snapped window, its tab(s) can be dragged out to create a new window to
>    snap to either side of the split, or can also be merged to an existing window
>    to either side of the split
> 
> Change-Id: Ieb2e8921d5c116a83e1b7998d992f8e32a904099
> Reviewed-on: https://chromium-review.googlesource.com/1020294
> Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561620}

TBR=sky@chromium.org,oshima@chromium.org,xdai@chromium.org

Change-Id: If981a184d7fba350ad3776fdb2236bef6cf61b9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1072969Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561737}

If a toolkit-views MenuRunner is destroyed while a menu is open, the
menu is closed. Often this occurs because the ui::MenuModel is also about
to be destroyed. Normally this is fine.

However, if an event has already been generated by the user to select
a menu item, which hasn't yet been processed by the event queue, it's
possible for a retained NSMenu to still have access to the ui:MenuModel
raw pointer via its delegate (the Cocoa MenuController), causing an error.

To fix, reset the MenuController when a MenuRunnerImplCocoa is released
in this way. MenuRunnerImplCocoa has the only reference to MenuController
so this will cause its -[MenuController dealloc] to clear itself as a
delegate of the NSMenu it's still showing.

Adds MenuRunnerImplCocoa.MenuRunnerImplCocoa which tickle the asan
bots without the fix.

Bug: 823373
Change-Id: I9fc08108569a80f6b1c279f4eeef89f4a14d9dcf
Reviewed-on: https://chromium-review.googlesource.com/1071275
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561736}

This reverts commit a745fe44.

Bug: 846551

Reason for revert: Suspected for failures in


* http/tests/devtools/audits2/audits2-limited-run.js
* http/tests/devtools/audits2/audits2-successful-run.js

since

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/16181

Original change's description:
> DevTools: [Audits] Roll Lighthouse to v3.0-beta
> 
> Bug: 772558, 846211
> Change-Id: I4f74ea0d4a84908d2e7c4ccfe7035ee421bdf023
> Reviewed-on: https://chromium-review.googlesource.com/1070532
> Commit-Queue: Paul Irish <paulirish@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561412}

TBR=pfeldman@chromium.org,paulirish@chromium.org,phulce@chromium.org

Change-Id: I71f125736ac908f37c3d90988b85de51f4fb283c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 772558, 846211
Reviewed-on: https://chromium-review.googlesource.com/1073008Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561735}

This cl removes the NON_BUBBLING_GESTURE from ScrollInputType since it
is only used in layer_tree_host_impl_unittest.cc.

On a follow up cl, I am gonna add AUTOSCROLL to the ScrollInputType.

Bug: 845960
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5c63225416e41a3a7586ac7a710fe9b472b53a10
Reviewed-on: https://chromium-review.googlesource.com/1070432
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561734}

This CL deletes the API |ContentViewCore.isAlive| and lets the callsites
use |WebContents.isDestroyed| (after negation) instead.

!CVC.isAlive() and WebContents.isDestroyed() basically serve the same
purpose that indicate WebContents (and its associated objecs) are in
the destroyed state. Once they return true, no calls should be made
on WebContents.

WebContents now defines |mIsAlive| for the deleted api to be replaced
with !WebContents.isDestroyed(). It is set to false by CVC.destroy()
or native WebContentsAndroid dtor, whichever comes first, to indicate
that WebContents is on its way to destruction. (WebContents.destroy()
also leads to setting it to false by way of WebcontentsAndroid dtor).

Bug: 598880
Change-Id: I8aa864e4efdd5c326e62c284bbda5987dc0e60a5
Reviewed-on: https://chromium-review.googlesource.com/1058728Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561733}

Use android.support.v4.content.ContextCompat#startForegroundService(Context, Intent)
instead of ContextUtils.startForegroundService(Context, Intent).

Bug: 769683
Change-Id: I3989dd04257e1f8ebe61228d6ec6876f04c9faba
Reviewed-on: https://chromium-review.googlesource.com/1065958Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561732}

This CL adds a base class for detailed view controllers in
UnifiedSystemTray. A detailed view controller is owned by
UnifiedSystemTrayController, and its lifetime is limited to during the
detialed view is shown. For the usage of DetailedViewControllerBase,
see an example of network detailed view: https://crrev.com/c/1071490
(which is still WIP).

This CL also adds SystemTrayItemDetailedViewController. This class is
there in order to incrementally remove the hack, and will be removed
before launch.

Design doc: go/cros-qs-restyling

TEST=manual
BUG=835733

Change-Id: I8391dd6360946f0b6cb6fc99f0644d37d824a704
Reviewed-on: https://chromium-review.googlesource.com/1071547
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561731}

This lets Concierge correctly associate a VM with the current user

Bug: 842561
Change-Id: Id313c9d7514575850ba4961afe968acd7d797ec9
Reviewed-on: https://chromium-review.googlesource.com/1072210
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561730}

Currently, all executables and shared libraries are expected to add the
exe_and_shlib_deps dependency manually.  However, it is easy to forget to do
this.  In such cases, the build will likely fail at the link step due to missing
libc++ symbols.  It may not be obvious how to fix this issue.

This CL adds exe_and_shlib_deps as an implicit dependency to executable and
shared_library targets so that developers don't have to manually add it.

BUG=845700
R=dpranke
TBR=torne

Change-Id: I30edcf0bcd6559b1aaa211a42863b04bc57d4d99
Reviewed-on: https://chromium-review.googlesource.com/1069720
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561729}

This reverts commit 79573b37.

Reason for revert: Suspect for msan failures starting

https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7284

errors like


=1==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x26931324 in is_empty ./../../base/unguessable_token.h:68:45
    #1 0x26931324 in blink::IdentifiersFactory::IdFromToken(base::UnguessableToken const&) ./../../third_party/blink/renderer/core/inspector/identifiers_factory.cc:95:0
    #2 0x26b81609 in blink::InspectorNetworkAgent::InspectorNetworkAgent(blink::InspectedFrames*, blink::WorkerGlobalScope*, v8_inspector::V8InspectorSession*) ./../../third_party/blink/renderer/core/inspector/inspector_network_agent.cc:1809:23
...
 Uninitialized value was created by a heap allocation
    #0 0xac2699 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cc:45:35
    #1 0x2e6764af in blink::WebSharedWorker::Create(blink::WebSharedWorkerClient*) ./../../third_party/blink/renderer/core/exported/web_shared_worker_impl.cc:392:27
    #2 0x2ac0c8ea in content::EmbeddedSharedWorkerStub::EmbeddedSharedWorkerStub

Original change's description:
> shared worker: Give the renderer a factory bundle when NetworkService is enabled.
> 
> Similar to frames, the shared worker needs a factory bundle in order to
> load non-NetworkService URLs like chrome-extension://.
> 
> This fixes the remaining test failure but we're still missing test
> coverage. I think the factory bundle needs to be propagated to
> ServiceWorkerSubresourceLoaderFactory for use with network fallback.
> 
> Bug: 839982
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I2c489a17fb30364e477d691bc346f7656b07906d
> Reviewed-on: https://chromium-review.googlesource.com/1069956
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561423}

TBR=falken@chromium.org,dcheng@chromium.org,kinuko@chromium.org,nhiroki@chromium.org

Change-Id: Iada07ec8bdddf612dbd441f702ede3dc8239ad21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839982
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1073007Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561728}

Make entire row clickable, change icon to arrow, and restore background
styling from old UI.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7a0bf76890887e0a02cecb17d470324cab5d4ec7
Reviewed-on: https://chromium-review.googlesource.com/1071114
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561727}

Moving a local object in a return statement prevents copy elision.

Bug: none
Change-Id: Iff8ef8a55f26ea273b9cefd0207700d6450f7f3a
Reviewed-on: https://chromium-review.googlesource.com/1071499Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#561726}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b887ecda57d6..04b73c195727

$ git log b887ecda5..04b73c195 --date=short --no-merges --format='%ad %ae %s'
2018-05-11 bmgordon cros_sdk_lib: Rescan loopbacks during chroot setup
2018-05-23 ayatane Run tests when building infra Go binaries

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:752562,chromium:764150,chromium:839581,chromium:None


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I9a2dd44468169b73ae835707be14812a876adaeb
Reviewed-on: https://chromium-review.googlesource.com/1072805
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561725}

The basic strategy is as follows:
- Assistant UI creates suggestion chip w/ icon placeholder.
- Assistant UI requests icon download from AssistantController.
- AssistantController requests download from AssistantImageDownloader.
- AssistantImageDownloader downloads image using BitmapFetcher.
- On success, AssistantImageDownloader runs callback to Assistant UI.
- Assistant UI updates icon for suggestion chip view.

This is a similar flow to what is currently done for rendering
Assistant cards. The BitmapFetcher logic is modeled on what is
currently done by AccountAvatarFetcher.

See bug for demo.

Bug: b:79599200
Change-Id: I9ee09a2458ce955a5e4926fcef43864a05e4454e
Reviewed-on: https://chromium-review.googlesource.com/1066179Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#561724}

ARC's widget bounds and actual arc task bounds aren't exactly the same.
Use the shadow bounds, which is given in pixels, to draw the frame's
background to match the arc task width.

BUG: 836331
TEST: manually tested with dsf 1,2, 2.25 with arc apps

Change-Id: Id19316aa9f52ca07bb44d24ef22fc7ca78da2a6f
Reviewed-on: https://chromium-review.googlesource.com/1071487Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561723}

This moves the paper-input-container styling to the network components
so that it applies consistently in Settings and in dialogs.

It also includes some other minor fixes and adds styling to each
dialog to match Settings (primarily for line-height).

Bug: 844259
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice417ced7cd3758c8270cfc00a221aa4b15fe466
Reviewed-on: https://chromium-review.googlesource.com/1072235Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561722}

https://chromium.googlesource.com/catapult.git/+log/9a12da75442c..c02f8a85059d

$ git log 9a12da754..c02f8a850 --date=short --no-merges --format='%ad %ae %s'
2018-05-24 benjhayden File dashboard bugs on crbug instead of github.
2018-05-24 benjhayden Add minify script.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I7121e3ea17df56076f274386564f0c96101e0b57
Reviewed-on: https://chromium-review.googlesource.com/1072798
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561721}

Found the "--paper-input-max-width" is only used within settings/ so moving
it to settings-shared style sheet.

Bug: 832177
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84f2f8b46f4d2c7a95c32ec57ed4be1339bfa5dd
Reviewed-on: https://chromium-review.googlesource.com/1070932Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561720}

The landmarks is one point with the implementation of Core Image Framework,
but an array of points along landmarks are more accurate with Vision Framework.

Bug=835078

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng
Change-Id: I8b09068bc95309fc66d3a8bd6726ac951815eb4f
Reviewed-on: https://chromium-review.googlesource.com/1070766Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/master@{#561719}

The video is now notified that it is no longer in PIP which allows it
to cleanup its UI.

Bug: 845561
Change-Id: I046da987e51f2568c6af05a3c51a7c0124a6abbe
Reviewed-on: https://chromium-review.googlesource.com/1067748Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561718}

Decide at initialization whether or not a RenderWidgetHostViewMac will
be displayed in its NSView or through a ui::Compositor.

This fixes a bug whereby some windows (DevTools is a good example)
would, through the vagaries of initialization order, draw a single
frame to the NSView, which would then never go away, and cover up the
ui::Compositor's version of the content (which was then updating
correctly, though not visible).

Bug: 840173, 845807
Change-Id: If051d249956b10c9e56450ed1f58b9048d331562
Reviewed-on: https://chromium-review.googlesource.com/1070764
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561717}

These changes allow the new extension updater to capture more error details,
which would help investigate the significant discrepancies the update
results of the running Finch experiment.

Bug: 722942
Change-Id: I269bbadc71bf736a79e0aa95aed6d1fc78f4e288
Reviewed-on: https://chromium-review.googlesource.com/1065196Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561716}

All other paths in this function log something upon failure, so let's
add a log here as well, to make it clearer what happened.

Bug: none
Change-Id: Idf9394d6389a90ff3869d9d8ce8b7b8950f7b1aa
Reviewed-on: https://chromium-review.googlesource.com/1072915Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561715}

Enable tablet mode using Ash switches. Add new FileDisplay tests; make
them run in tablet mode (for starters, more in future changes).

FileDisplay tests are not supported on Mash: so add Mash exclusions to
the Mash bot filter list for the new tests herein:

  FileDisplay/FilesAppBrowserTest.Test/fileDisplayDownloads_TabletMode
  FileDisplay/FilesAppBrowserTest.Test/fileDisplayDrive_TabletMode

Minor: add trusted event dispatch clean-up TODO.

Test=browser_test --gtest_filter="FileDisplay/FilesAppBrowser*"

No-Presubmit: true
Bug: 839243
Change-Id: I0349d9f9292d4ac5c02470a6f8d98105af2f86ab
Reviewed-on: https://chromium-review.googlesource.com/1071501Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561714}

Previously TrayDetailedView directly depended on SystemTrayItem. It did
not work with UnifiedSystemTray.

In this CL, bubble related actions from TrayDetailedView will be
delegated to DetailedViewDelegate.
This CL also includes SystemTrayDetailedViewDelegate, which implements
the default behavior for old SystemTray.

In upcoming CLs DetailedViewDelegate implementation for
UnifiedSystemTray will be added.

Design doc: go/cros-qs-restyling (See "detailed view" section)

TEST=ash_unittests
BUG=835733

Change-Id: I54074335f982ab4e1d07abdb88c5347e6c1d7ff1
Reviewed-on: https://chromium-review.googlesource.com/1068560Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561713}

Loads all of the users team drives and writes them to metadata.

To be called on startup, subsequent team drive changes will arrive via
the users default corpus change list processing.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1063471

Bug: 715355
Change-Id: Id9cbc31cb81abc3cac7620984f65cb85c85fba4f
Reviewed-on: https://chromium-review.googlesource.com/1068644
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561712}

reuse the one in //components/autofill.

The pre-existing one contains a lot of helpful factory methods.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I715859456af7dc72c1f30f3aeace8bc906febb58
Reviewed-on: https://chromium-review.googlesource.com/1070567
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561711}

Per spec, height should not exceed 640dip.

Note that this fix will truncate content exceeding 640dip but our final
content will be sized appropriately so truncation will not be an issue.

See bug for before/after. Note that there was previously some issue
with the anchoring logic but that is no longer an issue.

Bug: b:79432250
Change-Id: I14274ed38c1dd3ecbd1d8fb8e765b646787ed609
Reviewed-on: https://chromium-review.googlesource.com/1072636Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#561710}

After this patch, SignedExchangeHandler starts accepting
"application/signed-exchange;v=b1" content-type in addition to v=b0.
(But Accept-Header still advertises only v=b0.)

For b1 signed exchanges, OCSP response from cert chain is passed to
CertVerifier::Verify(), and signed exchange without valid OCSP response
is rejected.

For now, b1 has minimal test coverage, but when we drop b0 support after
M68 branch cut, we'll be able to convert existing tests to b1.

This also makes IgnoreErrorsCertVerifier set OCSP results if request has
a non-empty ocsp response. This allows LayoutTests to work.

Bug: 815024
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I611d68c1d4f26b1f97ea81f8f9f9b89ba3ad0d84
Reviewed-on: https://chromium-review.googlesource.com/1060933Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561709}

This was requested by pkasting. The owners were specified here:
https://chromium-review.googlesource.com/c/chromium/src/+/1070328#message-2ce2b6f61c3e2e42f9aea96203f51b74b83523da

Change-Id: I44c2605cb0972b6be723c3f880c5bd0dabb75f27
TBR: pkasting@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1072558
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561708}

Making var names consistent accross ArcExternalProtocolDialog. Also a
couple of style fixes for params comments.

Bug: None
Change-Id: Iae821c8d3a30e9e6886cda9f380dc050ceba9ef5
Tets: Build
Reviewed-on: https://chromium-review.googlesource.com/1069715Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561707}

Currently change list loader and directory loader use AboutResourceLoader to
get the root folder id. However, with team drives the root folder id is a
constant (the team drive id) and we need a way to supply this value when the
change list loader and directory loader are loading changelists for team
drives.

The RootFolderIdLoader pure virtual class allows us to provide an abstraction
for reading the root folder id either from AboutResource or a constant string.

Bug: 835703, 715355
Change-Id: I7d0766c5f813353186d3fbd3f6b20219c809eb4e
Reviewed-on: https://chromium-review.googlesource.com/1068527
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561706}