- 07 Sep, 2020 40 commits
-
-
Jiewei Qian authored
SWA internal name is used for metrics and tast tests. This CL updates the comment to reflect this. Change-Id: I8f6fe694996c6a1ed186a8afb54578b2564981eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386903 Commit-Queue: Jiewei Qian <qjw@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#804677}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c8f4177cf443..9de988b61cfc 2020-09-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I89ae74f40e5799241ce36eca4ba37b4f9f0c90e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395116Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804676}
-
Hirokazu Honda authored
Bug: 1029212 Test: None Change-Id: Ic50815a31cdcdc6cb2b7a8426554871f710b8a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392287Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#804675}
-
Maksim Sisov authored
In case of touch events, we may not find currently focused windows as menu windows might be created on touch up events. Thus, GetCurrentFocusedWindow returns nullptr. To fix that, use a concept of a currently active window. That is, Wayland sets a window to "active" state if it has had a focus. There can be only one focused window at a time. Thus, if there is no a focused window, use currently active window as a parent. That's the best effort one could make to find a parent window for a newly created non-toplevel window. At some point, it might be worth reconsidering the design and make aura always pass parent widgets for new windows if applicable. Bug: 1123521 Change-Id: Ib9479632e049df082ed17e3089680006a32f19fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385279 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#804674}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/72f6b99c29f2..f184cb61cea6 2020-09-07 syoussefi@chromium.org Add perf test for multisampled render to texture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I8f5a2cdf9b959981e068ed06d8d7001c8b8c603b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395255Reviewed-by:
-
Kent Tamura authored
LayoutSliderContainer should be attached to SliderTrackElement because LayoutSliderContainer adjusts the position of SliderThumbElement, which is a child of SliderTrackElement. Now LayoutSliderContainer inherits from LayoutBlockFlow, not LayoutFlexibleBox. It doesn't need the flex behavior at all. SliderContainerElement still needs to attach LayoutFlexibleBox to center the SliderTrackElement vertically. * LayoutBox::SkipContainingBlockForPercentHeightCalculation() Skip UA shadow elements for percent-height calculation in the quirks mode. This change is necessary for the test fast/forms/range/range-thumb-height-percentage.html. INPUT height:20px; SliderContainerElement display:flex; height:auto; SliderTrackElement height:auto; SliderThumbElement height:50% Before this CL, the height of the SliderThumbElement was 10px. The initial layout of the SliderThumbElement made its height to 0 because the SliderContainerElement didn't determine its height yet. |layout_scope.SetChildNeedsLayout(track)| in |LayoutSliderContainer:: UpdateLayout()| triggered another layout of the SliderThumbElement, and it made its height to 10px because the SliderContainerElement had 20px height this time. After this CL, both of the SliderTrackElement and the SliderThumbElement are not laid out twice. We need to update SkipContainingBlockForPercentHeightCalculation() so that the SliderThumbElement can find the INPUT box for its percent height calculation. This CL should have no behavior changes. Bug: 1040826 Change-Id: I9175f5cd032b82f15b90165036dc770e5dc56ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390937Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#804672}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNodeEditor::Prepare()| to return null for letting |LayoutText::SetTextWithOffset()| to use slow path when text content contains generated break opportunity because it is hard to figure out how many characters removed from text content. On <b><i><s>ab\n</s>\n</i>\n</b>, text content is "ab\nZZZ", where "Z" represents U+200B, removing "\n" after "ab" makes text content to "ab". Bug: 1125262 Change-Id: I071822dd8be836ee947766ae1877873f35c3af99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395136 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Philipp Hancke authored
for spec compliance the field can/shall be null instead of an empty string for udp candidates. BUG=chromium:1125168 Change-Id: I201e6a700ba7c4bcba45f0af6ccf809971d1df0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390659Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#804670}
-
Jiewei Qian authored
Eliminate the unnecessary negation in if condition, because we can use operator bool to check the callback is provided. Change-Id: Ib21c24a4ecf37ca98191fbbe0f8bdf8d7dd52efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395001 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This CL passes the hints for DelayCompetingLowPriorityRequests from BlinkOptimizationGuideWebContentsObserver in the browser process to LocalFrame in a renderer process. Subsequent CLs will actually plumb the hints into the resource scheduler. Bug: 1112515 Change-Id: I567b44f13d8fcce157be5bdab7271021997b04d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389380 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#804668}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599436335-07b3baabca6d9e1cf8136b51219c861829ab3330.profdata to chrome-win32-master-1599440287-c6b20cb063f56842ee44f7264cf204fda7b2b645.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I327f68641bc1bc2fb0ca0fa0fa0987411458034a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395115Reviewed-by:
-
Minoru Chikamune authored
Still not sure the root cause, but WebSettingsTest#testAccessCacheMode is failing on Android L and M. And this failure is caused by HeapMojoReceiver for ImageDownloaderImpl.receiver_. This CL specifies HeapMojoWrapperMode::kForceWithoutContextObserver not to close connection when the associated ExecutionContext is detached. Bug: 1102041, 1049056 Change-Id: I4a88ec57f2b04671a2d7ffad953600713442f648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395195Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#804666}
-
Hirokazu Honda authored
This is a reland of e97a414a The original change was reverted because of causing crbug.com/1124751. The fix is two lines, see https://chromium-review.googlesource.com/c/chromium/src/+/2391192/1..4. Original change's description: > media/gpu/vaapi: Introduce ScopedVABuffer and use for encoding and Vpp > > VaapiWrapper owns VABufferIDs of the VA buffers that are used > outside of VaapiWrapper. This CL moves the ownership out of > VaapiWrapper. The VA Buffers are owned by ScopedVABuffer in order > to prevent the buffer leakage. > Ths ScopedVABuffer will be used for other VABufferIDs later. > > Bug: b:166646505, b:162962069 > Test: video_encode_accelerator_tests on atlas > Test: media_unittests --gtest_filter=VaapiVideoEncodeAcceleratorTest > Test: vaapi_unittest --gtest_filter=VaapiUtilsTest > Change-Id: I7b0dda7491d29ebba70bc42051a8657144209dda > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379423 > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804103} Bug: b:166646505 Bug: b:162962069 Change-Id: I3bf5a10ac025460190ff5f627b88b95c649c6130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391192 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#804665}
-
Yuichiro Hanada authored
Bug: b:148193316 Test: tast run arc.PreImeKeyEvent Change-Id: I8ba1437e5a94f3a251d9a7e658df2d995ddd3dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391184Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#804664}
-
Kuo-Hsin Yang authored
This is the first step to rewrite MemoryKillsMonitor. The histograms Arc.OOMKills.{Score,TimeDelta} are not as useful as Arc.OOMKills.Count. Bug: 1124182 Change-Id: I78aa4510939a79cce2917b326d62409c61113001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390935Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#804663}
-
Fumitoshi Ukai authored
Bug: 1121776, 1123704 Change-Id: I15df4eca2d27a3a36f9d980b851b1fec76c3cdb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394839Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@google.com> Cr-Commit-Position: refs/heads/master@{#804662}
-
Kenichi Ishibashi authored
The test will be moved out of content/. Replace BrowserTaskEnvironment with TaskEnvironment. Bug: 1016064 Change-Id: I018eeacf44a3d10462ee12c5c688d804115097f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394898Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804661}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e63aa953ddfd..10121443c16d 2020-09-07 capn@google.com Regres: Roll dEQP to latest tip-of-tree If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib5839eee1e756bbedb9b1350df9162a087c9d46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395055Reviewed-by:
-
Moja Hsu authored
From https://www.w3.org/TR/mediacapture-streams/ To apply the ApplyConstraints algorithm to an object. We need to remove the existing constraints from object. Bug: b:151048287 Test: Tested on kukui and eve. Change-Id: I711a1e6dff9ae9dc77fc622cddfac07ceace12b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386918Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804659}
-
Koji Ishii authored
This patch creates "hyphens-data.zip" in $OUT directory. Bug: 1093555 Change-Id: I5b5e71165c40ebd187284038b796941898b29bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391020Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804658}
-
Luciano Pacheco authored
This is a reland of fc33ef5c Change getBreadcrumbPath() to check if '#location-breadcrumbs' wasn't found to fix the issue when running on linux-chromeos-dbg. Original change's description: > Files app: Change opening a folder navigates to the folder > > Change Files app to navigate to the directory when a "selectionURL" > provided in the launch params. Before this CL Files app would only show > the directory selected. > > This change is to support the workflow from Issue:1090211. From ARC++ > the intent to "ACTION_VIEW_DOWNLOADS" will open the Files app in the > Downloads folder. > > Bug: 1090211 > Change-Id: Ic6b9d290936f4a25576f3bfd5a799c37f6fa2195 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379345 > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804071} Bug: 1090211, 1125408 Change-Id: Ib1efce5415589842f671420e5adfb1bfd3ea5d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393412 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#804657}
-
Matt Falkenhagen authored
Tbr: lazyboy Change-Id: I2c05fe707f912a7de3d32e2cccdcb458b8c6482b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390596Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#804656}
-
Alex Danilo authored
CL:2332079 changed default application opening logic to prefer an installed app over opening in the browser. Change this logic to detect an HTML file extension and bypass the installed application selection so that the browser remains the preferred opening target to avoid user surprises. (N.B. Users can still manually select the installed app as default for HTML). Bug: 1121396 Tests: unit_tests --gtest_filter="*ChooseAndSetDefaultTask_FallbackHtmlTextApp" Change-Id: I1359be9d06b2ff27c7928c59ba68a92a66430584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391944 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#804655}
-
Hiroki Nakagawa authored
CREDIT: The most of changes were written by dom@chromium.org. Bug: 1112515 Change-Id: I979f221adf30edbe41a3e575283ddd4c1d6105a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387905 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599392499-5f1a0f6e1a1c9970588b5fc93f7f304261bea72c.profdata to chrome-win32-master-1599436335-07b3baabca6d9e1cf8136b51219c861829ab3330.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ia69e7672dc0e6085a85d4f824b8f8db46274b27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394782Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I2fdfad924829f8853b75134e0b0502caa485d0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395075Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804652}
-
Minoru Chikamune authored
HeapMojo wrappers require ExecutionContext to reset mojo objects when ExecutionContext is detached. Bug: 1049056 Change-Id: Idcf6ecc1d642ae0a64ecca88e6ccc3df5bc416ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220127Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#804651}
-
Kuo Jen Wei authored
Bug: 1069608 Test: Pass 'tast --verbose run <betty> "camera.CaptureUnittests"' 15 times in a row. Change-Id: I30d6872ad9a6d30a41cc14648a12d71a1fed274a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387911 Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#804650}
-
Nancy Wang authored
This reverts commit 28dc1f25. Reason for revert: <INSERT REASONING HERE> ChromeVoxOptionsTest.punctuationEchoSelect failed on multiple build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20 ASan%20LSan%20Tests%20%281%29 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20288 Original change's description: > Add Punctuation Echo Setting to ChromeVox Options Page > > The Punctuation Echo Setting has three TTS verbosity levels for speaking punctuation: None, Some, and All. > Before, the user could only change the Punctuation Echo Setting with the Cycle Punctuation Command. > This change allows the user to change the Punctuation Echo Setting from the ChromeVox Options Page. > > Bug: 1124445 > AX-Relnotes: Add Punctuation Echo Setting to ChromeVox Options Page > Change-Id: I726e43b9dccf23fc12acd83e2430492b042d130d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388402 > Commit-Queue: Josiah Krutz <josiahk@google.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804485} TBR=dmazzoni@chromium.org,dtseng@chromium.org,josiahk@google.com,akihiroota@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1124445 Change-Id: I118981ed60220213555f2f118332bee447da9960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391426 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804649}
-
Matt Falkenhagen authored
Also remove unused Send() method. Change-Id: I68118f84c4851c85310ec04287126c47042c3e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394600Reviewed-by:
-
Taoyu Li authored
- Accept VPN from device policy in ONCValidator - Display VPN pod before log in to allow connecting - But disable "Add" button in VPN panel Bug: b:144202836 Change-Id: Ie5f6302549686e74aea5e0c395014ad257ee5d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383366Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Taoyu Li <taoyl@chromium.org> Auto-Submit: Taoyu Li <taoyl@chromium.org> Cr-Commit-Position: refs/heads/master@{#804647}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009060800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/fhV-3inPiCU3tG0HsfArMtIM_aBoXZJHLaTOXCJTRyQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I0a72a89bf7ccd929494a223f897f73e70ff65baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394566Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804646}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599344926-92dcc092f6ed37c869416de168d5e2d44fa5c2d5.profdata to chrome-mac-master-1599436335-52e1c862010d0691dd04c2a7a430ef4fc681e61e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic53528ccbe7630c9a3146ba7bdf417434c0c0651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394779Reviewed-by:
-
Matt Falkenhagen authored
Follow-up to r777235. Aligns with blink::ResourceResponse. It's impractical to audit all network::mojom::URLResponseHead::New() sites but I expect it's safe. It looks like the default changed around Aug 2019 with these CLs: - https://chromium-review.googlesource.com/c/chromium/src/+/1742782 - https://chromium-review.googlesource.com/c/chromium/src/+/1953671 Change-Id: If179612f23f0f4dbbaa1c2db2da9ebc1bb092e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387038Reviewed-by:
-
Xianzhu Wang authored
TBR=schenney@chromium.org Bug: 1124979 Change-Id: I6a3de95b6f5c60f7d6fb571240dcce4ef6b980a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394725Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804643}
-
Kent Tamura authored
This CL has no behavior changes. However, this might improve runtime performance slightly. Bug: 1124623 Change-Id: I74d90f763ce2ecc4c90c80eb22d712882ab00cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392165 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Yuichiro Hanada authored
ARC++ notification can have an input field. ARC++ notification should have kSkipImeProcessing property to support text input with ArcPreImeKeyEventSupport feature. Bug: b:148193316 Test: Can delete characters by backspace on text input on a notification. Change-Id: I4a2644e7079be21122228aaee6ac31beb3838206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391421Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#804641}
-
Darren Shen authored
We previously only used Mojo directly for rule-based input methods. Connect to Mojo if the input method is FST-based. Change-Id: I9a93ecaa13acca18e8d9ff07311d2b147c77f5c2 Bug: 1019541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371084 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#804640}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9a0ca71719dbb7e1888ed260358e71c858f871f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394776Reviewed-by:
-
James Cook authored
No code change, just comments. Bug: none Change-Id: I16fe794ae2e153c0bba3073372d8afacd01f5cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394375 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#804638}
-
