- 12 Dec, 2019 17 commits
-
-
Melissa Zhang authored
This reverts commit 2898ec18. Reason for revert: likely causing https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 and https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 Original change's description: > viz: Split OverlayProcessor into Windows and Mac Subclass. > > OverlayProcessor class is used for both Windows and Mac, and the only > difference is in it uses different overlay candidate validator classes. > The validator classes implementation are simple, and achieve the same > effect with splitting OverlayProcessor into Mac and Windows subclass. > > This allows us to delete OverlayCandidateValidator and its Mac subclass > and its Windows subclass. > > This is CL 6/? of overlay processor refactor. > > R=rjkroege > TBR=kylechar > > Bug: 963597 > Change-Id: I78265a8941720daa32cbd672ef85c7a547938b8d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953824 > Reviewed-by: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: weiliangc <weiliangc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723971} TBR=rjkroege@chromium.org,weiliangc@chromium.org,kylechar@chromium.org Change-Id: I7f97902903f14d9822ab464923679be1c14aee9c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962134Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#724058}
-
Kyle Horimoto authored
This CL: (1) Causes the UI to expand to the width of the container when in small-screen mode. Previously, it was constrainted to a smaller width. (2) Reduces padding in some places to line up with mocks provided by elizabethchiu@. (3) Moves the "features vary" footnote slightly higher to reduce the overall height of the setup flow UI so that it fits within OOBE on small-screen devices in landscape mode. Screenshots: Small screen, dialog, portrait: https://screenshot.googleplex.com/jMgbFewcrAH Small screen, dialog, landscape: https://screenshot.googleplex.com/QyiVuuCOY4s Small screen, OOBE, portrait: https://screenshot.googleplex.com/OcOyX5hPeec Small screen, OOBE, landscape: https://screenshot.googleplex.com/Kfjnav01j5V Large screen, dialog: https://screenshot.googleplex.com/vLnHTPWRie0 Large screen, OOBE: https://screenshot.googleplex.com/0eGWJaoLzO7 Bug: 1012295 Change-Id: I28cc765b11fde3bc3c319056dd74b876a85fdcbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951270 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#724057}
-
Xiaocheng Hu authored
CreateFragmentFromMarkupWithContext() may fail to create a fragment from some markup. crrev.com/c/1922919 incorrectly removes the handling of this case and results in a regression. This patch adds back the handling. Bug: 1032673 Change-Id: If02997859f3ccc074df3da1d91e974b2dc4794ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963107Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#724056}
-
Melissa Zhang authored
This reverts commit 6cabc3d3. Reason for revert: Likely breaking https://ci.chromium.org/p/chrome/builders/ci/mac-chrome Original change's description: > Convert //components ObjC Instance Variable Names From Trailing to Leading Underscore > > Clang-Tidy performed all of the transformations in this change > except for the following: > * components/viz/common/gpu/metal_api_proxy.mm > Instance variable references from macros. > > BUG=1030028 > TBR=thakis@chromium.org > Remaining //components mechanical refactor. > > Change-Id: Ibde1cacb5f2b7f12ceb22c0716adaefde1cbd24a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961137 > Reviewed-by: Robert Liao <robliao@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724035} TBR=thakis@chromium.org,ccameron@chromium.org,robliao@chromium.org Change-Id: I7a75dc0e4df7800861c16ba77619db1f6aa37a57 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962138Reviewed-by:
-
Eleni Dimitriadis authored
Change-Id: I5a7cdb72744fb1979ff1aa6b0ab8d06b5ba83ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961452Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Eleni Dimitriadis <edimitriadis@google.com> Cr-Commit-Position: refs/heads/master@{#724054}
-
Francois Doray authored
The features are enabled by default. M80 just branched. Now is a good time to cleanup the experiment code. Bug: 872820 Change-Id: I4b15082cb77ca8c966618b753de8a1365d32e2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959372Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#724053}
-
danakj authored
Use OnceCallback where possible because the callback is only used once and RepeatingCallback and BindRepeating otherwise. Bug: 1007633 Change-Id: I473ca8d919a2e52da422ed7f2102224357caa76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963095 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#724052}
-
Andrew authored
WriteFile creates files with permission 0666. This is not obvious from the header's description. If the folder has different permissions, the function fails and the error is not obvious. BUG=none TEST=none Change-Id: I20c67cdeca7e80a2e4324dbc9be13010b4801119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962024Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: Andrew Lassalle <andrewlassalle@chromium.org> Cr-Commit-Position: refs/heads/master@{#724051}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1e51a388bcf7..26fe81162362 git log 1e51a388bcf7..26fe81162362 --date=short --first-parent --format='%ad %ae %s' 2019-12-11 yvesg@webrtc.org Roll chromium_revision 59395671..ac00cfc7 (722888:723527) 2019-12-11 philipel@webrtc.org Execute cached video encoder switching request if encoder switching is allowed after the switch request was made. Created with: gclient setdep -r src/third_party/webrtc@26fe81162362 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifaf265f002b84ea2569d9cf7bf2259231fc00496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962537Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724050}
-
Jiawei Shao authored
This reverts commit 7dd53909. Reason for revert: this CL is not the root cause of the try bot failures. Original change's description: > Revert "WebGPU: Create GPUDevice in the callback of RequestDeviceAsync()" > > This reverts commit 2625327a. > > Reason for revert: This is likely breaking https://ci.chromium.org/p/chromium/builders/ci/Mac%20Retina%20Debug%20%28AMD%29 > > Original change's description: > > WebGPU: Create GPUDevice in the callback of RequestDeviceAsync() > > > > This patch updates RequestDevice() into an asynchronous function > > RequestDeviceAsync() and moves the creation of GPUDevice into the > > callback function passed as a parameter of RequestDeviceAsync(). > > > > BUG=chromium:996713 > > > > Change-Id: I7208a107670ca6e79ad3a4a3107f35ae26330edf > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955171 > > Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> > > Reviewed-by: Austin Eng <enga@chromium.org> > > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#723595} > > TBR=zmo@chromium.org,kbr@chromium.org,cwallez@chromium.org,shaobo.yan@intel.com,yunchao.he@intel.com,jiawei.shao@intel.com,yang.gu@intel.com,kainino@chromium.org,jiajie.hu@intel.com,enga@chromium.org,hao.x.li@intel.com > > Change-Id: I7f78422e0c841a17692a7030690fe911202aebeb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:996713 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961353 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723712} TBR=zmo@chromium.org,kbr@chromium.org,cwallez@chromium.org,shaobo.yan@intel.com,yunchao.he@intel.com,jiawei.shao@intel.com,yang.gu@intel.com,kainino@chromium.org,jiajie.hu@intel.com,enga@chromium.org,hao.x.li@intel.com,melzhang@chromium.org Change-Id: I5fb3d180e89a88803e93668b57dc5e5b3ea5f481 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:996713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963373Reviewed-by:
-
Avery Musbach authored
There is currently no important reason for OverviewGrid::AddDropTargetForDraggingFromOverview to call OverviewItem::OnSelectorItemDragStarted on the drop target. I originally did that to hide the drop target's close button, but because it was animated, the behavior was found unsatisfactory as described in Issue 954642. [1] fixed the bug, and also removed the need for the function call in question. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1900127 Bug: 954642 Change-Id: Iadef44cc213158a3cc797670a46c97c4f0aa2bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962596 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#724048}
-
Xiaoqian Dai authored
Previously the window's original backdrop mode is not reset back to its original backdrop mode if the window ends in overview or splitview. This CL fixes that. Bug: 1030857, 997885 Change-Id: I7f0bbc24ca8257ed1bfeb8cb41517268b6f2c2c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963109Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#724047}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/98ea80082239..f7bccf2868c0 git log 98ea80082239..f7bccf2868c0 --date=short --first-parent --format='%ad %ae %s' 2019-12-11 brgoddar@microsoft.com Datagrid: Make the header context menu keyboard accessible Created with: gclient setdep -r src/third_party/devtools-frontend/src@f7bccf2868c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5707c2bfc37135ee9328fd627e3b7be54d31d48c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963141Reviewed-by:
-
Bettina Dea authored
This reverts commit 8c91b029. Reason for revert: Only want to log this metric on startup to keep metric simple. Original change's description: > Log metric when password is first signed in. > > Previously, SaveProtectedPasswordHash did not log > a metric when a password is saved into the hash > manager on first signed in. > > Bug: 1032322 > Change-Id: I66fca65496ccd5866536d954f60e4773d66d3a4d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959046 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Bettina Dea <bdea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723508} TBR=vasilii@chromium.org,vakh@chromium.org,bdea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032322 Change-Id: Ida2a7b78027b392702c79fa6fd613b827567723e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963209Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#724045}
-
Melissa Zhang authored
This reverts commit 6eb0faea. Reason for revert: dependent CL https://crrev.com/c/1953824 Original change's description: > viz: Move Strategy List to OverlayProcessorStrategy > > Now that there is OverlayProcessorStrategy class always holding an > OverlayCandidateValidatorStrategy, move some data and shared functions > from validator class to the overlay processor class. > > This is also part of merging overlay validator into processor. > > This is CL 7/? of overlay processor refactor. > > R=rjkroege > > Bug: 963597 > Change-Id: I55a961a818da60a0cb9d5a7c5b322d2c86d1945d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953754 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723999} TBR=rjkroege@chromium.org,weiliangc@chromium.org Change-Id: Ifdd245ff37b013a6bd8367120aeb2d03f9fabca4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962137Reviewed-by:
-
Melissa Zhang authored
This reverts commit af90d887. Reason for revert: dependent CL https://crrev.com/c/1953824 Original change's description: > viz: Merge OverlayValidatorOzone Into an OverlayProcessorOzone Subclass > > Merge the OverlayCandidateValidatorOzone class's functionalities into > OverlayProcessorOzone which is a subclass of > OverlayProcessorStrategy. > > This is CL 8/? of overlay processor refactor. > > R=rjkroege > TBR=kylechar > > Bug: 963597 > Change-Id: I0033f59825898b16eefceb67357211dfb0fb578c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954538 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724029} TBR=rjkroege@chromium.org,weiliangc@chromium.org Change-Id: Iad7649faf60e688578931ec1ce6ea21f42b15329 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962136Reviewed-by:
-
Noel Gordon authored
If the feature flag is enabled, enable file-ng rendering style for the directory tree. Bug: 992819 Change-Id: I8a9c216ef3c9e3d2eaf1c25fe847feaf78706ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954801 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#724042}
-
- 11 Dec, 2019 23 commits
-
-
Rakib Hasan authored
Revert "Reland "[web tests] Add layout-test-results/ prefix to all artifact relative paths in json results"" This reverts commit d1a27f9f. Reason for revert: The change is breaking the blink builds. Below is an example build. https://ci.chromium.org/p/chromium/builders/try/linux-blink-rel/24569 Original change's description: > Reland "[web tests] Add layout-test-results/ prefix to all artifact relative paths in json results" > > This reverts commit 2e7eb004. > > Reason: In crrev.com/c/1925687, the functions within the Port class were modified to set > their output directory to the artifacts directory. Some scripts like run_webdriver_tests.py > will not create the artifacts directory, therefore whenever classes like WPTServe were > instantiated an exception would be raised because the artifacts sub-directory was not created. > This CL will make the server classes create the artifacts directory. It will also add an optional > parameter for the output directory to the server starter functions in the Port class. > The default value for these parameters will be the artifacts directory. > > Original Description of commit reverted: > > Revert "[web tests] Add layout-test-results/ prefix to all artifact relative paths in json results" > > This reverts commit 9138bb30. > > Reason for revert: Suspect to cause: > https://crbug.com/1032504 > > Original change's description: > > [web tests] Add layout-test-results/ prefix to all artifact relative paths in json results > > > > This will make the artifacts paths consistent with the isolate output directory paths. All > > test runners should follow this standard for outputting artifact paths in the JSON results. > > > > Bug: chromium:1026494 > > Change-Id: I36dbbb2a9bec507182610e959edf55f1819d2ca7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925687 > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Reviewed-by: Robert Ma <robertma@chromium.org> > > Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org> > > Commit-Queue: Rakib Hasan <rmhasan@google.com> > > Cr-Commit-Position: refs/heads/master@{#723270} > > Bug: chromium:1026494 > Change-Id: I272242b00b9334c8bc6b6443638ead5aa17db54f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960716 > Commit-Queue: Rakib Hasan <rmhasan@google.com> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724006} TBR=johnchen@chromium.org,jbudorick@chromium.org,robertma@chromium.org,rmhasan@google.com Change-Id: Iccbacb0ea91551ae1b48e0cc236d804c4066c9ba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1026494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963352Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#724041}
-
Dana Fried authored
* Regression tests for attached bugs * Fixes to address another minor issue the tests uncovered Bug: 1012136 Change-Id: Ie57b9d37a997dc748d92dd68a27b42c106cde087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962592Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#724040}
-
Daniel Murphy authored
This reverts commit 71d64a4f. Reason for revert: This seems to be causing attachment errors in gmail - I'm guessing that we still report these as files somehow? Bug: 1033165 Original change's description: > [IndexedDB] Remove child policy permissions for blobs from IndexedDB > > Now that blobs from IndexedDB are backed & read by the IndexedDB system, > they are no longer sent to the renderer as files. This means no content > policy changes or grants are necessary. > > Tracking document: > https://docs.google.com/document/d/18suNOOzuEJbqgRJF0MB2VqdTyYqS4cvI2PGaCpyPXSw/edit?ts=5de6dc30&pli=1#heading=h.tw2iw2qfgduj > > Bug: 1015212 > Change-Id: If3d2fd80b3254f19a56ab16ed7fc39cf5f0cf684 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955813 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: enne <enne@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722617} TBR=dmurph@chromium.org,rockot@google.com,enne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015212 Change-Id: If5307dfa39ab1a74e62dec21dd55dd71d81a52ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963206Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#724039}
-
Eric Karl authored
Generally a safer pattern, as users can't forget to end access. Also useful for future uncleared-texture-access protection. Bug: 1003686 Change-Id: Ibff747378c4d89fca7396cf35cda39c99698a7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951764Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#724038}
-
Robert Liao authored
Clang-Tidy performed all of the transformations in this change. BUG=1030028 Change-Id: Icdf3d24e4c7add6718227db0e112b3f374ce8a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959394 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#724037}
-
Simon Que authored
CI: -win32-archive-rel -win32-archive-dbg -Libfuzzer Upload Windows ASan -Windows deterministic -Mojo Windows -win-celab-builder-rel -win-asan -Win 10 Fast Ring -win-annotator-rel -win-pixel-builder-rel -win32-arm64-rel -WebRTC Chromium Win Builder -WebRTC Chromium FYI Win Builder -WebRTC Chromium FYI Win Builder (dbg) -win-swangle-x86 -win-swangle-x64 -win-swangle-tot-angle-x86 -win-swangle-tot-angle-x64 -win-swangle-tot-swiftshader-x86 -win-swangle-tot-swiftshader-x64 Try: -win_archive -win_mojo -win-asan -win-annotator-rel -win-swangle-try-x86 -win-swangle-try-tot-angle-x86 -win-swangle-try-x64 -win-swangle-try-tot-swiftshader-x86 -win-swangle-try-tot-angle-x64 -win-swangle-try-tot-swiftshader-x64 -win-libfuzzer-asan-rel -win10-blink-rel -win7-blink-rel -win10_chromium_x64_rel_ng_exp -win-celab-try-rel Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I476de2fe97d88f3b636b97b91457b0b61ffe30d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924184Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#724036}
-
Robert Liao authored
Clang-Tidy performed all of the transformations in this change except for the following: * components/viz/common/gpu/metal_api_proxy.mm Instance variable references from macros. BUG=1030028 TBR=thakis@chromium.org Remaining //components mechanical refactor. Change-Id: Ibde1cacb5f2b7f12ceb22c0716adaefde1cbd24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961137Reviewed-by:Robert Liao <robliao@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#724035}
-
Lukasz Anforowicz authored
This CL hides full redirect URLs from ResourceLoadInfo - only the origin of the redirect URLs can be depended on, because in some cases the path and/or query may be sanitized away. The CL: - Replaces ResourceLoadInfo::url field with |origin_of_final_url| field - Replaces RedirectInfo::url field with |origin_of_new_url| field - Makes follow-up changes in code that uses the fields above. In particular the following potentially behavior-affecting (i.e. not just tracing or logging-related) changes in the production code are being made: - |origin_of_final_url| (rather than the final URL) is used in - ClientSideDetectionHost::ResourceLoadComplete when populating ClientMalwareRequest::UrlInfo::url protobuf. - |original_url| (rather than the final URL) is used in - NavigationBodyLoader::StartLoadingBody when fetching from code cache. - NavigationBodyLoader::NotifyCompletionIfAppropriate when populating WebURLError::url_ field. - HatsWebDialog::OnMainFrameResourceLoadComplete when checking if the request was made to kSurveyHost - Makes some other, opportunistic changes: - Populates |original_url| in addition to the final url in LoadingPredictorTabHelper::DidLoadResourceFromMemoryCache Bug: 973885 Change-Id: I8887ce1b3d9edb7163dca4714b750db167404af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899888 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#724034}
-
Evan Stade authored
Moved from chrome.browser.ui.widget to components.browser_ui.widget This establishes the testing target for //components/browser_ui/widget Bug: 1030785 Change-Id: I866d3b18ea90cee59564cb51ec024d2f3c491a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959931Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#724033}
-
Ian Prest authored
As described in the bug, |ElementProviderFromPoint| was hanging when performing hit-testing on the PDF toolbar buttons. Stepping through the code, it was apparent that the loop in that function was alternating between two different elements, and never exiting... but only when the monitor scale-factor was something other than 100%! Stepping a little deeper, it became apparent that the problem was in |BrowserAccessibilityManager::CachingAsyncHitTest|. It is passing the |scaled_point| when it recurses on the |root_manager|, meaning that the point was getting scaled twice in that case. The result was that |CachingAsyncHitTest| would return a different element depending on whether you called it on the root manager or a child manager... and these were the two elements that we were alternating between in |ElementProviderFromPoint|. The solution is to pass the original |screen_point| to the recursive call. (I also reordered the code to make the flow more obvious.) Bug: 1032299 Change-Id: Ief01a2e961d14ad75eec3f1017a98c57f77613a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957129Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#724032}
-
Mason Freed authored
See [1] for a description of a project to potentially dispatch legacy DOM mutation events on CEReactions timing. For that project, these use counters were added. The conclusion of the project, at least for now, is that the usage is too high to warrant changes. To clean up the old code and regain a bit in node.h, I'm removing the use counters. [1] https://docs.google.com/document/d/1vYBKZGjE-EEFHy-sidffEqKNxuBSENcym3ql-3jDYfk/edit Bug: 859391 Change-Id: I82c6ed19e067d44ee320b3ab60ec465c1a48c137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962893 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
This CL removes the GetInitiatorSchemeBypassingDocumentBlocking method from ContentBrowserClient. This method used to be called by implementation of Cross-Origin Read Blocking (CORB) before NetworkService shipped. This dependency is gone now. Before this CL, the only remaining caller of this method was AppCacheSubresourceURLFactory::CreateLoaderAndStart. The method was called to exclude content script requests from request_initiator checks (this exclusion was introduced in r624685). Such exclusion is no longer needed, after request_initiator=website (see r694827 and r710554). Bug: 940068 Change-Id: I736f1414ffe890da9cd6477d377f4482168befae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926541Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#724030}
-
Weiliang Chen authored
Merge the OverlayCandidateValidatorOzone class's functionalities into OverlayProcessorOzone which is a subclass of OverlayProcessorStrategy. This is CL 8/? of overlay processor refactor. R=rjkroege TBR=kylechar Bug: 963597 Change-Id: I0033f59825898b16eefceb67357211dfb0fb578c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954538 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#724029}
-
Henrique Nakashima authored
This is a step to move feature-specific logic out of ChromePreferencesManager and delete it. Bug: 1022102 Change-Id: I04bab089d99529fa6786a26f9518b36864051d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954556Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#724028}
-
llin@chromium.org authored
Bug: b/145774037 Test: Manual Change-Id: I81b3d2b7d20cb600db09a1d60bad7ce8c64d9b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955028 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
-
Wez authored
Allow CancelableTaskTracker to be configured not to cancel off-sequence tasks, using a Feature. This allows us to evaluate the impact on performance metrics of not cancelling off-thread tasks (e.g. database operations). Tasks running on the posting thread continue to be cancelled normally, since callers rely on that guarantee. This is a re-land of https://chromium-review.googlesource.com/1949777, fixed to avoid implicit initialization of the global FeatureList if the setting needs to be checked before the FeatureList has been initialized. Bug: 1030235, 1009795, 1031427 Change-Id: Iab9c2a6fdcf20c2c428df79b35417e4296ac89d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963191 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#724026}
-
Nate Fischer authored
No change to production logic. This adds integration tests for NetworkMetricsProvider and AndroidMetricsProvider (both of which were already integrated). This does not test the providers work as expected (glancing at the code, I don't see why they would break in AW, so I think their unit tests are sufficient), it only tests that they log some sort of value for their proto fields or histograms. Bug: 1011991 Test: run_webview_instrumentation_test_apk -f AwMetricsIntegrationTest#* Change-Id: Ifa4a59b06ced2f089fc326bc4dd88f8c0fe49cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961217Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#724025}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8852b8bbb1c1..1159fec7d02e Created with: gclient setdep -r src-internal@1159fec7d02e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:984162 Tbr: jbudorick@google.com Change-Id: I52a3fc5e8097a71bb0ebf908ad2ecffe585260a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962543Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724024}
-
Natalie Chouinard authored
Inline and remove the following deprecated methods in favor of their contextless versions: - ChromeBrowserInitializer#getInstance(Context) - SyncController#get(Context) This was a mechanical refactor done with Android Studio, followed by some manual cleanup of unused variables and parameters. Should be submitted after downstream change lands: https://crrev.com/i/2295459 Change-Id: I4e875cedbcd49b294616fe7ee88a2bfd512b4749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960179Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#724023}
-
Anushruth authored
This reverts commit dd747e31. Reason for revert: Clang has segfault in go/chrome-ci-builder/linux-chromeos-chrome/75 Original change's description: > Roll clang n332890-c2443155-1 : n333629-caa41209-1. > > Ran `./tools/clang/scripts/upload_revision.py caa412090666c10f854322cdc701c1cbf8ed726e`. > > Change-Id: I7cb80e1332fadd08e39e5e4d6cd224c270ee5f74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959582 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Reid Kleckner <rnk@chromium.org> > Reviewed-by: Bob Haarman <inglorion@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724004} TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org,inglorion@chromium.org,inglorion@google.com,akhuang@google.com Change-Id: Iaef4152abe0631ffae48ffb973a49f13bd8c00c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962602Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#724022}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If051341242dd90e83feb5b2f9941201ccc63167a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962542Reviewed-by:
-
Nigel Tao authored
This is attempt #2. Attempt #1 (crrev.com/c/1898151) was rolled back (crrev.com/c/1944286) due to performance and RAM usage regressions (crbug.com/1023129, crbug.com/1023191). During that time, there has been some optimization work done in the upstream Skia project, especially around RAM usage, so we are trying again. Still, as crrev.com/c/1898151's commit message says, this change isn't about performance per se, it is about tracking upstream Skia. Nonetheless, here are some before-vs-after total times for Chromium's "image_decode_bench -i 10" program for x86_64, on a selection of GIF images that noel@chromium.org collects: old_time new_time ratio file_name file_size 0.000139 0.000325 0.43 bar.gif 265 0.000217 0.000315 0.69 radient.gif 1034 0.001144 0.001045 1.09 mondrian.gif 3792 0.002364 0.001987 1.19 rain.gif 10272 0.008795 0.005614 1.57 flag.gif 41738 0.020884 0.013044 1.60 warp.gif 106420 0.377886 0.286732 1.32 hex.gif 1072114 A ratio higher is better: more than 1.00 means that the new GIF decoder is faster than the old one. Bug: 1014044 Change-Id: Iba304db1ceea0661e0ca57308c2a68b2c48297a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958292Reviewed-by:
-
Evan Stade authored
Bug: none Change-Id: I293d340188fc23ffe701f13260eb9e4915f4c3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959713Reviewed-by:
-
