- 01 Oct, 2019 40 commits
-
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 214 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-03-29. Change-Id: I9d6a210147e8729a474786f021f153667f5749f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829679 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#701647}
-
Morten Stenshorne authored
LayoutInline::ChildBecameNonInline() is called when a child of an inline becomes in-flow block-level (e.g. when its position changes from absolute to static) and we need to set up a continuation chain because of this. Part of this operation is to wrap the in-flow block-level child inside a new anonymous containing block. AddChildIgnoringContinuation(), which is what we call when inserting new children, did a few nice things to such anonymous containing blocks, which ChildBecameNonInline() didn't do, most crucially, setting the position of the anonymous containing block to relative if the inline is relatively positioned (to contain absolutely positioned descendants). So if the continuation was set up as a reaction to something becoming block-level, rather than being set up as part of inserting new children, the anonymous containing block of block-level children of the inline didn't get position:relative, which made any absolutely positioned children escape its relatively positioned inline parent, and find a containing block further up (the viewport, in the included testcase). To fix this, break out the code that sets up such an anonymous block into a separate method, and have ChildBecameNonInline() call it. Bug: 732397 Change-Id: I06b120c3173403ba6db3b93019e95a66575ba0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833581Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#701646}
-
Geoff Lang authored
The the passthrough command decoder did deferred image bindings, it didn't ensure that the correct GL texture was bound first. This caused canvas -> WebGL copies to fail when they are using IOSurface backed canvases. BUG=990368 TBR=true Change-Id: I5d555c7a715d0f47382053840c3db78576dc4e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819520 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#701645}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/a7d9ac2af4684747c4524cbeba9737b04dce3e3e..bd522862a0b4c84a0ed8e37096d1c361dc6beaa9 Bug: none Change-Id: I38612b6cfdc378bbca6163f725445dae3d42eec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829582 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#701644}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1008826 Change-Id: I6b05ebd733f1a69f4194f3b2ea7febd2b1812ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832697Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701643}
-
Ahmed Fakhry authored
This CL implements the new spec for adding an item to overview while overview is active. The new animation is a fade-in plus scale-up of the new added window in its final position in the overview grid. BUG=990831 TEST=Manually Change-Id: Ie7721e59af02f4fc2d5ca5664a43e8b13f6dd752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832477 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#701642}
-
Etienne Bergeron authored
This CL is adding the RenderFontParams explicit to the font constructor. On Linux, the call to GetFontRenderParams(..) is making a call to the FcFontMatch to retrieve the rendering parameters. It is quite common on Linux to iterate through fonts returned by FcFontSort(...) and to create gfx::Font with them. There is no need to make a second call to GetFontRenderParams(..) [and to FcFontMatch] since the rendering parameters are known (see etFontRenderParamsFromFcPattern(...)). On windows, the call to GetFontRenderParams(..) returns the same parameters, no matter which font family is provided. R=robliao@chromium.org Bug: 1008531 Change-Id: Ia368e3c797cf43b3bd726f871e01389b41092c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830061 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701641}
-
Skipping chromeos-betty-chrome, since betty's broken. BUG=762641, 1010136 TBR=satorux@chromium.org Change-Id: Iea95d313597a770cd80cc332ee8df18b0993e644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833521 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701640}
-
Alexander Cooper authored
This reverts commit c96640df. Reason for revert:Suspected cause of 1010101 Original change's description: > Support WebXR Inputs Using OpenXR > > Support webxr input using OpenXR And Enable related WebXR input tests. > This change can be tested with this page. > https://immersive-web.github.io/webxr-samples/controller-state.html > > Bug: 986394 > Change-Id: I346d7808769a2ab1979d0f1f023b9c815611f292 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808086 > Commit-Queue: Zheng Qin <zheqi@microsoft.com> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701357} TBR=alcooper@chromium.org,zheqi@microsoft.com Change-Id: I8775e296a86a286f607987fda1528cbe28150439 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832712Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#701639}
-
Oleg Davydov authored
UserCloudPolicyManagerTest didn't work for chrome branded builds, because it tried to show sync consent screen on fake user login, and therefore made browser tests to hang waiting for user interaction. This commit adds an option to skip all post-login screens. Bug: 976987 Change-Id: Ie42980bc4791efe9a455780c5dff9ec8c8abbd76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833465Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701638}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e49df747da7e..755417dd7907 git log e49df747da7e..755417dd7907 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 jaime@janeasystems.com GLES2: Use require_constant_initialization for g_Mutex 2019-10-01 cnorthrop@google.com Vulkan: Narrow skip lists for 3D and 2DArray tests to Compute Created with: gclient setdep -r src/third_party/angle@755417dd7907 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:3188,chromium:3189,chromium:3810 Change-Id: I4f4960b14c2c4373ca1f8bebed2921d2e3150ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833905Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701637}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a7914a872657..8c500751cd1c git log a7914a872657..8c500751cd1c --date=short --no-merges --format='%ad %ae %s' 2019-10-01 halcanary@google.com experimental/minimal_mtl_app: more cleanup 2019-10-01 jvanverth@google.com Add TransferBuffer and AsyncRead support to Metal. 2019-10-01 bsalomon@google.com SkColorInfo: It's SkImageInfo minus the dimensions. Created with: gclient setdep -r src/third_party/skia@8c500751cd1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I3728b99f083c48d7bb6f10003111875eb41a7fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833292Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701636}
-
Michael Liao authored
Changes: - Adding label to search input, number of matches and line number - Added SR functionality for when the search finishes and # of matches Keyboard Nav CL: https://chromium-review.googlesource.com/c/chromium/src/+/1819493 Different ways to read search result status: https://imgur.com/koruZRk Bug: 963183 Change-Id: Ia5dc1608d3cffe3c6164f15da895896b4191b008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613675 Commit-Queue: Michael Liao <michael.liao@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701635}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/gfx to the recommended methods/types. Bug: 1007851 Change-Id: Iac0a7b8e9bb05a9f9c3f498bc43c078e0d7ee64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831862 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701634}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7c079f650def..65235d3ae771 git log 7c079f650def..65235d3ae771 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 nisse@webrtc.org Add GetStats at end of PeerConnection quality tests 2019-10-01 nisse@webrtc.org Avoid memcpy in JavaToNativeEncodedImage 2019-10-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aa4c7d6a..443491f4 (701411:701518) 2019-10-01 nisse@webrtc.org Delete old placeholders for moved api/ header files Created with: gclient setdep -r src/third_party/webrtc@65235d3ae771 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Ida0c6a0e838a58148f9f4428d08f6ff134f58b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701633}
-
Trevor Perrier authored
This CL changes the Lite mode FRE to include a "Learn more" link that points to the Chrome Lite mode help documents. This uses p-link "lite_mode" The wording on the FRE page has also been changed to make indicate that Lite mode sends web traffic to Google. Bug: 997248 Change-Id: Idb2f69ecfefe68f1a5f6d8052d393d213283e64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830106Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#701632}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010061 Change-Id: I06b679d48413f0b30bc72fe88b199205c6b37429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834061Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701631}
-
arthursonzogni authored
Add regression tests for https://crbug.com/1003167. This checks what happens with cookies in iframes when using special URLs like about:srcdoc, about:blank, and data-URLs. This checks normal navigations and history navigations. This is able to trigger the DumpWithoutCrashing() in: network::RestrictedCookieManager::ValidateAccessToCookiesAt Tests= - NavigationBaseBrowserTest.CookiesInheritedSrcDoc - NavigationBaseBrowserTest.CookiesInheritedAboutBlank - NavigationBaseBrowserTest.CookiesInheritedAboutBlank2 - NavigationBaseBrowserTest.CookiesInheritedDataUrl Bug: 1003167 Change-Id: I73b9e62021490cfb74caf49c32009171dd9bea00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831762Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#701630}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010061 Change-Id: I184d6bdef8cc39577faab29f9b7b87314cf5776f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833900Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701629}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010061 Change-Id: Ie2519fec6a3faaf65437dcc218699b5b8a666fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833294Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701628}
-
Xiaocheng Hu authored
NoTry: True Tbr: eae@chromium.org, futhark@chromium.org Bug: 825895 Change-Id: I4b483d2960c216f4dd99a38d3004b9ac9a1df3d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833907Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#701627}
-
Ryan Hansberry authored
Owners of a BluetoothDiscoverySession may delete the object upon receiving confirmation via callback of stopping it. Move all necessary calls to clean up internal state to before these callbacks are invoked. Bug: 1007594, 490401 Change-Id: I113820c818b07eb9695842f8ee2a93ccc03945b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833045Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#701626}
-
Etienne Bergeron authored
This CL is extending the duration of the histogram until the FontLink code for removed. "FontFallback.GetLinkedFonts.CacheMissTiming" "FontFallback.GetLinkedFonts.FontCount "FontFallback.GetLinkedFonts.Timing" Adding drott@ as metrics owner since it's better to have two owners for histograms. R=asvtine@chromium.org Bug: 1006980 Change-Id: If78758fc68a3e9ebfda3b4e0d5cd96d558ccd3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829789 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701625}
-
Theresa Wellington authored
BUG=1009781 Change-Id: I44d3f515e32eba65a558cd970825f387c51ede5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833894 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#701624}
-
Alex Keng authored
This change fixes a bug for <color> where the color-viewer (The big circle to the left of the 'hue slider', color-selection-rings (the small circles on 'color well' and the hue slider), and the colored rectangle of the in-page color control are black due to the auto adjustment from the forced color mode. The fix is to turn off the auto adjustment for these particular UI elements when high contrast mode is enabled. The test controls-new-ui-high-contrast/color-picker.html is also updated (based on controls-new-ui/color/color-picker-appearance-color-well-click.html) to verify that selected colors are correctly shown in the high contrast mode. Bug: 994219 Change-Id: I51c73b3ba2b30010bf1388fc67a07d0033090e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832608 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#701623}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cf9b9029..5a8a51c2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic9b033fca913dc08d8e42875bfd72781cdf96762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833801Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701622}
-
Kyle Horimoto authored
Prior to this CL, the dialog title was missing when configuring a network. This was caused by [1], which renamed the |type| property to |type_| instead, but did not also update the HTML to reflect this name change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1803724 Bug: 1009409 Change-Id: I4bbb10d1fad65cd6b94da8e8248852205565cf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832628 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#701621}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010061 Change-Id: I741e49ba958631aa46dd9a77995a5060ce12b200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832913Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701620}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 99c3aa1b. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" ab4b7009 "[Native File System] Aborting a directory iteration succeeds" 8d24de75 "Port rotate-interpolation.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/i18n external/wpt/css/css-text/line-break external/wpt/css/css-text/overflow-wrap rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: If0484606f7cfda539717e167c269c1e7f405600d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833761Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701619}
-
Sorin Jianu authored
This change has no effect on the component updater since the component updater uses CRX ids derived from their public key hashes. chrome/updater is using Omaha-style app_ids that don't look like extension CRX ids. Therefore, chrome/updater needs the app_id value from CrxComponent. TBR=waffles@chromium.org Bug: 1001126 Change-Id: Ibb32637a03d4b4167f603873822f492295a55835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832325 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#701618}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010119 Change-Id: Id12b237e6659a80b27a510358ba661dcee6440cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833892Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701617}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b689fa536c9b..9203f768126d git log b689fa536c9b..9203f768126d --date=short --no-merges --format='%ad %ae %s' 2019-10-01 fmayer@google.com Merge "remove duplicate assignment" 2019-10-01 lalitm@google.com Merge "ui: migrate all slice queries to use track_id instead of ref/ref_type" 2019-10-01 fmayer@google.com Merge "Print problems with profiles in new pprof converter." Created with: gclient setdep -r src/third_party/perfetto@9203f768126d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I0ff972542a87f609198c3060046da77aa54ecafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833516Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701616}
-
Francois Doray authored
This change converts IDBFactory mojom interface client in blink to use BrowserInterfaceBroker. This is a prerequisite to keep track of the execution context associated with each transaction in the browser, which is required to opt-out of page freezing frames that hold IDB transactions. Bug: 936482, 980533 Change-Id: I9f5ad10532da91a772078e253dd0cb92a8c34e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815852 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#701615}
-
John Chen authored
This is a reland of 8f486945 Original change's description: > [ChromeDriver] Stop using --ignore-certificate-errors > > ChromeDriver was passing --ignore-certificate-errors switch to Chrome, > regardless of whether user wants to ignore certificate errors or not. > Fixing by stop passing this flag to Chrome, and relying on using > Security.setIgnoreCertificateErrors command when user wants to ignore > certificate errors. > > Bug: chromedriver:3148 > Change-Id: I5e8493f4cca48ebaeb211c95cd7fd645891c8659 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824005 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699890} Bug: chromedriver:3148 Change-Id: I96ce5e6746af65e01407e7c6c92fed7428d686ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829802Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701614}
-
Askar Aitzhan authored
Chrome Reporting API requires those fields to be set, otherwise the request get rejected. Bug: 1006757 Change-Id: If39bd56287719579ba1067488a38c2216eed5ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814830 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701613}
-
Andrey Shponko authored
If the order of notifications is inverted we should use the bounds of the latest notification popup to determine if the next popup will fit. Change-Id: I90fd83278175c068e6bf65121f8b2f834e044ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827005Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#701612}
-
Tommy Steimel authored
This CL adds a circular colored background to dismiss buttons in the GMC dialog. This fixes a contrast issue where the X was not always visible against the media artwork. Bug: 1006049 Change-Id: Ib56353437fce6e4ec1ad8e15268e5bbbb284607c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829537Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#701611}
-
Stefan Zager authored
BUG=1009201 R=dcheng@chromium.org Change-Id: I85655f4de68dea44f213fe819742fdcaf44d2775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831260Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#701610}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3044c24181e9..2a412ea20590 git log 3044c24181e9..2a412ea20590 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 chrisforbes@google.com Remove array restriction from EOpEqual, EOpNotEqual Created with: gclient setdep -r src/third_party/swiftshader@2a412ea20590 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141916742 Change-Id: Ib430f9a3b610676469195e4caf33cc01c2df76c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701609}
-
Lily Chen authored
This change makes the named test work under SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure. Namely, any cookies accessed in a third party context must be marked with the attributes "SameSite=None" and "Secure". Bug: 1006816 Change-Id: I9eb7e46df890a7ac520768a4b2ba3b15f654462c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833742Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#701608}
-