- 06 Dec, 2019 40 commits
-
-
Darin Fisher authored
Avoids a UAF by disconnecting the mojo::Receiver and mojo::Remote from the pre-finalizer. Bug: 1016574 Change-Id: Icdbba0e7798a93318df9931b4f1fe9004b6b8501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952085Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722542}
-
Caleb Raitto authored
This link never pointed to the correct destination. Change-Id: I99f95d13fb336b5306dd745f66a7cc23f80de2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955327Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#722541}
-
Mason Freed authored
See the bug for repro information. It is possible to attempt to send the "ready" event from within an EventDispatchForbiddenScope, while unloading an invalid SVG image. This happens when the SVGImage destructor tries to notify its frame that it will be detached. With this CL, we again allow events to be dispatched under the assumption that this is a separate Page (where script is disabled), and thus any events dispatched from these calls will neither reach the Element/Document/Page which added the restriction nor any script in the "sub-Page" itself. Bug: 1029262 Change-Id: Ibc72f58b102742530fb5ccf1ee47e58b16503a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949228 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#722540}
-
Ken Rockot authored
This adds a new MediaSessionService interface as the service's main interface, as well as a content::GetMediaSessionService helper for browser code to access the in-process implementation, formerly a Service Manager service. Clients are converted to use the new Content API to bind service interfaces, rather than going through a Service Manager Connector. Bug: 977637 Change-Id: I4abd935105777b2d603fcfa568ddf4c00c98752f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942714 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#722539}
-
Bo Liu authored
proxy is destroyed in WillShutdown which is called when LayerTreeHostImpl is destroyed. It is possible input mojo pipes are still alive and continue to AttachSynchronousCompositor, leading to a use after free. So add a null check. Bug: 1028360 Change-Id: Idbd04b0602e59ce330956d5a976403ad5cf18b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953388 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#722538}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/11e6944ec5a8..63c155195925 git log 11e6944ec5a8..63c155195925 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 jonahr@google.com Also use GL_RENDERER to determine vendorID 2019-12-06 jmadill@chromium.org Revert "Re-land "Add new test runner harness."" 2019-12-06 josh@joshmatthews.net Add /APPCONTAINER linker flag to shared libraries in UWP builds. 2019-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader bbd0694f9ab2..b9f03f47d5f5 (18 commits) 2019-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src e72b61c7c20d..a3ee4384fb57 (2 commits) Created with: gclient setdep -r src/third_party/angle@63c155195925 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Ifd382db513bdb585e6740a9493b398a19793778f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955661Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722537}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4107aca1. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." 5ffc0155 "Fix allow/sandbox attribute timing issue on browser side" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I796bf55e95a86e63cb16b1c8d865defe5344e20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953391Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722536}
-
Peng Huang authored
Bug: 1029066 Change-Id: I2b9f1e45dfbdabe2dfe01834d76dd9e225546865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954176Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722535}
-
Ovidio Henriquez authored
This change updates content/browser/bluetooth/OWNERS to add odejesush@chromium.org as an owner. Change-Id: If20304b43d0cdc9d087dc00ceb845019cbead020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951763 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#722534}
-
Mark Mentovai authored
ksadmin moved from MacOS to Helpers in Keystone 1.2.13.112, 2019-11-12. A symbolic link from the old location was left in place, but may not remain indefinitely. Try the new location first, falling back to the old if needed. Change-Id: I278746a44ab35795a2294d812fd26b676b96d7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950747Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#722533}
-
Rayan Kanso authored
Only take the first 3 related apps declared in the web manifest into account when determining if there are any related apps. Change-Id: I4a0ba7372351f3b4e541a920794aaaab812184f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953715 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#722532}
-
Brian Sheedy authored
This reverts commit 0a7aae5f. Reason for revert: Somehow saved the wrong images. Original change's description: > Update VR data URL goldens > > Updates the VR browser data URL golden images. The security token icon > was recently updated to be a warning triangle instead of an "i" in a > circle. > > TBR=alcooper@chromium.org > > Change-Id: Iafebbb86ca660be5a92c8202431f06001e7afd0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954881 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722361} TBR=bsheedy@chromium.org,alcooper@chromium.org Change-Id: I6596838d6e67fa29317ee84cf6de0dc5a21ecd1a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955797Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#722531}
-
Joe Downing authored
Change-Id: Ic6a900d974a9f49493dea88238be77ac5324442e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954325 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#722530}
-
Rayan Kanso authored
Add OWNERS file for installedapp directories in chrome/android/java. These are the same owners of installedapp in other directories as well. Change-Id: I75e24357d9c878e9009b8d4f370d5db5dade593e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954477Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#722529}
-
Jasper Chapman-Black authored
Previously the WebAssembly web worker assumed that it should render in diff mode if and only if it was passed a |before| to compare against. With .sizediffs, this assumption no longer holds - the WebAssembly worker extracts both .size files from a single field, so we have to tell JavaScript that it's a diff. Change-Id: I972f7eaca9508c87c033b3f78ad169afa70f2ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954194 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#722528}
-
Jimmy Gong authored
- This is another step in removing deprecated printer settings code. - This CL removes the feature flag, kCupsPrintersUiOverhaul. Bug: 1005905 Test: browsertests Change-Id: Iac6ba4980478ce5bef2e5724aa3be4eb2c0783ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937653Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#722527}
-
Bin Wu authored
1. Net.QuicSession.ClosedByRtoAtClient.SentPacketCount. 2. Net.QuicSession.ClosedByRtoAtClient.ReceivedPacketCount. Change-Id: Ifc91f3d97758b8f4f3db4c306199e40878665e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954248Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#722526}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1518fd34d888..80bc1acb9c2b git log 1518fd34d888..80bc1acb9c2b --date=short --first-parent --format='%ad %ae %s' 2019-12-06 danilchap@webrtc.org Add implementations of the VideoRtpDepacketizer interface 2019-12-06 orphis@webrtc.org Reland "Add support for RtpEncodingParameters::max_framerate" 2019-12-06 titovartem@webrtc.org Fix: IvfFrameGenerator won't decode frame on release build Created with: gclient setdep -r src/third_party/webrtc@80bc1acb9c2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I521fd606ee3ce38a7e9c99ee931303dc56f7b3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722525}
-
Nick Diego Yamane authored
crrev.com/c/1771407 moved window closing logic out of DWTHX11 into DWTHPlatform and XWindow and (likely accidentally) lost delayed resize cancellation before dispatching actual window close operation [1]. Present CL adds back such logic, now into XWindow::Hide(), which is called from DWTHPlatform::Close() -> WTH::Hide() -> PlatformWindow/X11Window::Hide(), just before dispatching real DWTH close task. This is a tentative fix for crashes reported at crbug.com/1021490, as it has not been possible to reproduce them locally. [1] https://crrev.com/c/chromium/src/+/1771407/14/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc#190 Bug: 1021490 Change-Id: Ibee9ad3edd1631901f869f7ebf60bc0d10bc7d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940939Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#722524}
-
Jimmy Gong authored
- This is the first part of removing legacy printer settings code. - Future CL's will iteratively remove each piece of the feature flag and the code gated by it. Bug: 1005905 Test: Ran browsertests + end to end manual Change-Id: I4e4680e7eb2dcd08d03f69538fc09331b3f39a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935152Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#722523}
-
Mark Mentovai authored
31470459b624 Fix line endings on files introduced in 359fc4a1336d Change-Id: Ifdcc53168584ccaaaa645bfbd2f2a86311906cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954252Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#722522}
-
Patrick Monette authored
Now that there's longer any experiments with shutdown hangs, this CL removes the feature flag and defaults the background task runners of the incident reporting service to CONTINUE_ON_SHUTDOWN Bug: 478209 Change-Id: Iec41d087911fadf518d4537da942ed7939b1aa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954196Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#722521}
-
Chris Lu authored
Bug: 1014959 Change-Id: I1272d6475984716e3b7be14624bd617a5a17410a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946059 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#722520}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f9c33d61a661..de3a9d11f377 git log f9c33d61a661..de3a9d11f377 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@de3a9d11f377 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2505eb01a14c6ecfdbf45928ef119d0edd69a683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955473Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722519}
-
Vladislav Kuzkokov authored
Avoid generation on platforms that don't use it. Bug: 964919 Change-Id: Iacba48977c6f9eb089f41dd5409e33f1fad222e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954013Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#722518}
-
Sophie Chang authored
Change-Id: I0e82e38ed2782f6998971b3ce5291193ccd36983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954406Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722517}
-
Thomas Lukaszewicz authored
Removed hard-coded color references for the overlay scrollbar and added the relevant color ids. Added appropriate selectors for gtk native theme. Bug: 1003612 Change-Id: I5c7a8354a151249e2fc5e2a52244c441a15979fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950861Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#722516}
-
Sammie Quon authored
This can be triggered if screen is rotated while in overview. Overview will handle resetting paint blur itself when it is exited. Test: manual Bug: 1016267 Change-Id: I004083270a7f99a9b61913295367616da3a6d14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952083Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#722515}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d45b969a0906..c87235c08e05 Created with: gclient setdep -r src-internal@c87235c08e05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2a2536c301238dbf16e4160ae2802d8123eddd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954731Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722514}
-
meacer authored
Change-Id: Icdc8ce22ae2ae017a11e8ccf2de64feedac456b7 Bug: 1014711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953231Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#722513}
-
Markus Handell authored
Our WebmMuxer doesn't support changing saved format mid-track. This change causes calls to MediaRecorder OnError which emits an event and causes recording to stop. Bug: 1013590 Change-Id: If1dd020dc61980feff33883a4967ac24fc0e0255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893856Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#722512}
-
James Cook authored
Chrome OS SplitSettingsSync has a separate control for syncing OS data types that isn't controlled by the browser's sync-the-feature. Change ModelType::OS_PREFERENCE and OS_PRIORITY_PREFERENCE to run when the transport layer is enabled. They already are controlled by a separate consent flow in OOBE via pref kOsSyncFeatureEnabled. Introduce a temporary base::Feature to disable sync AUTO_START on Chrome OS so that this feature can be tested manually. For example, you can run --enable-features=SplitSettingsSync,SyncManualStartChromeOS and check chrome://sync-internals to see what types are syncing. Bug: 1013466 Test: added to sync_integration_tests Change-Id: I76720c2277781d073e100ac6d9ee935867be8868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951577 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#722511}
-
Kramer Ge authored
To prevent confusion whether delta can be negative. Change-Id: I6c2f3fc31347c0a0af55fb2b9d91ab364d56370c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954319 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722510}
-
W. James MacLean authored
This CL continues removing deprecated BrowserPlugin code. Bug: 533069 Change-Id: Id81d316a7ac7df7270db84e69b2304f559c9d6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951324 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#722509}
-
Torne (Richard Coles) authored
Add an activity to the shell to launch WebView in a second process, separate to the main process used by the shell, to enable manual testing of the support for using WebView from multiple processes at once with WebView.setDataDirectorySuffix. Change-Id: Id97ce8cc9ef4fc38a7cefc90128645d1deeca5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953385 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#722508}
-
Peng Huang authored
Bug: None Change-Id: I40b36e01f42da2dd0e21d5395155073feb356355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955659 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#722507}
-
Nate Chapin authored
ScriptRunner has special cases in Document to allow it to pause/unpause, but ContextLifecycleStateObserver is the standard way to pause/unpause. Bug: 1029822 Change-Id: Ie8b5e427e6a217ba6a1aad9af7a286ce22444918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949225Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#722506}
-
Mihai Sardarescu authored
Bug: 1028182 Change-Id: I6222333fddbc96cc81b7e53445c9dcefa53cd1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954472 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#722505}
-
Nektarios Paisios authored
In crrev.com/c/1930061 the accessibility focus event in TableView was tweaked so that it would always fire after the accessibility information had been updated. However, there are instances when the accessibility information is updated more than one time. We need to fire the focus event after paint, to ensure that the accessibility tree has become stable and won't update right away again. The order of the problematic operations are: 1. The Task Manager refreshes its contents at a constant interval. OnItemsChanged is called which calls SortItemsAndUpdateMapping and which in turn calls UpdateVirtualAccessibilityChildren. This would update the accessibility focus as well. 2. OnPaint is called and in some cases, whenever the contents of the Task Manager are sorted, SortItemsAndUpdateMapping would also be called, which updates the virtual accessibility children a second time without updating the focus, since the focus had already been updated. R=sky@chromium.org, dmazzoni@chromium.org Bug: 811277 Change-Id: Ifbf8a6908f3411030912f30981aa3c22f1874f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946691 Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#722504}
-
Etienne Bergeron authored
The PlatformFontWin is deprecated and was replaced by the usage of PlatformFontSkia on Windows. The feature PlatformFontSkiaOnWindows is activated by default. This CL is removing the feature and the code. Bug: 944227 Change-Id: I644321594b4ef6f33e29dfbc36d507d0c695a1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924979 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#722503}
-