GitLab

Broke compilation on windows clobber builder: mc : error : -u switch cannot be used with non-Unicode message file!

> make utf-8 default encoding for remoting_localize.py
> 
> Review URL: https://codereview.chromium.org/140793007

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/141003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245500 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332403
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/141683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245495 0039d316-1c4b-4281-b951-d872f2087c98

thakis pointed out these are in resources.pak and so are unnecesary here.

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/141603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245494 0039d316-1c4b-4281-b951-d872f2087c98

Because of introducing an async call during initialization, the new appstate was being changed. Playing a song adds a 'time' field to the appstate. Having a time field causes pausing the audio player once the initialization is finished.

To avoid this, a copy is made, to avoid altering the input 'playlist' object.

TEST=Tested manually. Partly browser tests.
BUG=335422

Review URL: https://codereview.chromium.org/141273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245493 0039d316-1c4b-4281-b951-d872f2087c98

Try to insert again this image resources for showing item for task manager dialog.
(https://codereview.chromium.org/132543003/)

R=oshima@chromium.org
BUG=121242
TEST=NONE

Review URL: https://codereview.chromium.org/141083008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245491 0039d316-1c4b-4281-b951-d872f2087c98

 * Rename base_file_size to GetEstimatedFileSize
 * Simplify UpdateMaxWrittenOffset interface

BUG=334171

Review URL: https://codereview.chromium.org/140833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245490 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/140793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245489 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335290

Review URL: https://codereview.chromium.org/140783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245488 0039d316-1c4b-4281-b951-d872f2087c98

Replace the giant DictionaryValue with std::map.
No behavior change is intended.

Remove unused FakeDriveService::FindEntryByContentUrl().
Fix util::ConvertResourceEntryToFileResource() to set EntryKind of hosted documents correctly.
Stop depending on the results' order in SearchOperationTest.

BUG=334544
TEST=unit_tests

Review URL: https://codereview.chromium.org/135643005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245487 0039d316-1c4b-4281-b951-d872f2087c98

We should not consider event filtering info to be empty if a filter
is for a <webview> guest, i.e. it has an instance id.
This probably was an oversight while adding has_instance_id_/instance_id_
to EventFilteringInfo.

BUG=None
Test=None

Review URL: https://codereview.chromium.org/140633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245486 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/140513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245485 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245484 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165260:165278&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/137163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245483 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/140173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245482 0039d316-1c4b-4281-b951-d872f2087c98

When a client crash detected, the associated QuotaReservation object reclaims its reserved quota.
And then, in-flight operations should be ignored.

Review URL: https://codereview.chromium.org/139833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245481 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an API that SAML IdPs can use to pass credentials to
Chrome OS during login instead of relying on password scraping.

BUG=127095
TEST=New browser test + manual

Review URL: https://codereview.chromium.org/138133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245480 0039d316-1c4b-4281-b951-d872f2087c98

R=enne@chromium.org
BUG=333045

Review URL: https://codereview.chromium.org/137993013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245479 0039d316-1c4b-4281-b951-d872f2087c98

We want to count the last the last swap in the embedding
chain. Usually there is a hardware swap for this but on mac
there doesn't appear to be one. This uses the decoder swap
for now until we know the canonical swap call and add a trace
there.

TBR=nduca@chromium.org
NOTRY=true

No-try since this is blocking this from working on the mac and I've run the tests locally.

Review URL: https://codereview.chromium.org/141163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245478 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add RGB565 Texture readback support in gl_helper (https://codereview.chromium.org/88033002/)

Reason for revert:
content_gl_tests failing on multiple gpu bots on the chromium.webkit buildbot.

Example: http://chromegw.corp.google.com/i/chromium.webkit/builders/GPU%20Mac10.7/builds/19123

Original issue's description:
> Add RGB565 Texture readback support in gl_helper
> 
> Plan is to add a RGB565 readback and copy conversion for RGBA8 to RGB565 in GLHelper.
> 
> BUG=323150
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245431

TBR=dtrainor@chromium.org,sievers@chromium.org,hubbe@chromium.org,aelias@chromium.org,piman@chromium.org,siva.gunturi@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=323150

Review URL: https://codereview.chromium.org/137783022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245477 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 244857 "net: Remove classes which were used only by Chrom..."
>
> > net: Remove classes which were used only by Chrome Frame
> >
> > UploadData and UploadFileElementReaderSync were used only by Chrome Frame
> >
> > BUG=None
> > TEST=build
> > R=mmenke@chromium.org
> > TBR=jam@chromium.org for content/child/resource_dispatcher_unittests.cc
> >
> > Review URL: https://codereview.chromium.org/131903004
>
> TBR=hashimoto@chromium.org
>
> Review URL: https://codereview.chromium.org/139263007

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/140733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245476 0039d316-1c4b-4281-b951-d872f2087c98

It is not necessary to explicitly make the GrContext current.
The underlying GL context is automatically made current via a
callback setup by all implementations of cc::ContextProvider.
Ganesh calls this callback before issuing any GL command, which
ensures the the appropriate GL context is current.

BUG=334886

Review URL: https://codereview.chromium.org/135753006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245475 0039d316-1c4b-4281-b951-d872f2087c98

Changed the API to take a HTML5 DirectoryEntry.

loadDirectory(DirectoryEntry entry).

BUG=335299

TBR=thakis@chromiun.org

Review URL: https://codereview.chromium.org/132313009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245474 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the drive sync handler to the background page and showes the drive
sync status obtained by the handler in the progress center.

BUG=327213
TEST=manually

Review URL: https://codereview.chromium.org/131403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245473 0039d316-1c4b-4281-b951-d872f2087c98

Currently showing the app launcher window on a Chrome cold start is
blocked by profile loading and other browser startup tasks, which can
take a while.

This CL allows the Mac app launcher window to be shown empty, with a
progress spinner. Once the the profile has finished loading, the window
is populated with a subtle icon fade-in animation.

Screenshot at http://crbug.com/335433#c1

BUG=178260, 335433

Review URL: https://codereview.chromium.org/117683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245472 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245471 0039d316-1c4b-4281-b951-d872f2087c98

DesktopScreenX11Test.GetWindowAtScreenPoint in views_unittests is faling on "Linux Aura Tests" after this change.
http://build.chromium.org/p/chromium.linux/builders/Linux%20Aura%20Tests/builds/701

> Linux Aura: Added --use-system-title-bar flag.
> 
> This flag makes browser windows use the system window dressing and title
> bar, instead of the custom frame. This is a Linux Aura equivalent of the
> "Use System Title Bar and Border" preference in Linux GTK. (Eventually,
> this part will be controlled by the same preference, rather than this
> flag.)
> 
> With this flag, browser windows use the native system window decoration,
> with our custom close/minimize/maximize buttons removed, and the tab
> strip being condensed vertically with square corners (like the maximized
> tab strip).  Popup browser windows (including V1 apps and the Developer
> Tools window) drop the blue custom frame altogether in favour of the
> native frame.
> 
> BUG=317859
> TEST=With --use-system-title-bar, open a browser window. Both maximized
> and restored windows should have a system native title bar, and the tab
> strip should be compacted into a single row (as when maximized).
> TEST=With --use-system-title-bar, open a hosted app window. It should
> have a system native title bar, with no second blue title bar.
> 
> Review URL: https://codereview.chromium.org/111723012

TBR=mgiuca@chromium.org

Review URL: https://codereview.chromium.org/139303014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333600

Review URL: https://codereview.chromium.org/139543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245468 0039d316-1c4b-4281-b951-d872f2087c98

Avoid unneccessary copy of structures gfx::PointF
by passing them by const ref rather than value.

Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.

Pass by value creates unneccessary overhead which should be avoided.

BUG=159273

R=danakj, enne, piman

Review URL: https://codereview.chromium.org/139233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245467 0039d316-1c4b-4281-b951-d872f2087c98

It is allowed to send metadata and file contents at the same time with Drive API.

BUG=260539
TEST=unit_tests

Review URL: https://codereview.chromium.org/139153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245466 0039d316-1c4b-4281-b951-d872f2087c98

Made red outline match NSPopUpButton pixel for pixel.

R=rsesek@chromium.org
BUG=325492

Review URL: https://codereview.chromium.org/138943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245465 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334379

Review URL: https://codereview.chromium.org/138593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245464 0039d316-1c4b-4281-b951-d872f2087c98

Added some quick searches that are usually performed in
sync to find out which objects are not updated and have
pending updates not being done.

Currently it implements IS_UNSYNCED, IS_UNAPPLIED_UPDATE, both, and
IS_DEL.


BUG=154378

Review URL: https://codereview.chromium.org/138273009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245463 0039d316-1c4b-4281-b951-d872f2087c98

This patch converts methods getLeadPath, setLeadPath, getSelectedPaths and setSelectedPaths to *Entry/*Entries.

TEST=Tested manually. Partly browser tests.
BUG=320967

Review URL: https://codereview.chromium.org/138033007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245462 0039d316-1c4b-4281-b951-d872f2087c98

Without rebuilding, stale command states are used.
That may leave menu items incorrectly enabled/disabled.
Fixes a regression from http://crrev.com/244436

BUG=334604
TEST=Bug doesn't repro; omnibox and textfield context menu items are enabled or disabled as expected on each menu invocation.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/137893017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245461 0039d316-1c4b-4281-b951-d872f2087c98

This adds necessary BindTexImage/ReleaseTexImage calls to
ResourceProvider::TransferResource.

BUG=334747

Review URL: https://codereview.chromium.org/132873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245460 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements nacl_irt_clock on non-sfi mode,
which is simply proxying to the glibc implementation.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to call a newly added function from plugin via AT_SYSINFO.

Review URL: https://codereview.chromium.org/139303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245459 0039d316-1c4b-4281-b951-d872f2087c98

Delete no-op branch in isolate after fix for https://code.google.com/p/swarming/issues/detail?id=63 .

BUG=321878
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/140383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245458 0039d316-1c4b-4281-b951-d872f2087c98

chrome.management.uninstall is changed as follows unless the extension is trying to
uninstall itself:
- The confirmation dialog is shown by default.
- A user gesture is required.

BUG=178319

Review URL: https://codereview.chromium.org/137793011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245457 0039d316-1c4b-4281-b951-d872f2087c98

This was caused by a recent regression after refactoring. The volume manager was not available in the background file operation manager.

In this CL, the above problem is resolved by moving calls to the volume manager to the foreground.

TEST=Tested manually. Partly browser tests.
BUG=333180

Review URL: https://codereview.chromium.org/137743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245456 0039d316-1c4b-4281-b951-d872f2087c98

Useful in case the network is unavailable.

BUG=333399

Review URL: https://codereview.chromium.org/137563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245455 0039d316-1c4b-4281-b951-d872f2087c98