- 09 Apr, 2019 40 commits
-
-
Jordan Demeulenaere authored
Screenshot: https://screenshot.googleplex.com/eq53CdQQLEv.png (that will be in a DFM for M75). Change-Id: I6374d259c6a18b8973896ef20c313beeaea19f35 Binary-Size: Adding background images for the Autofill Assistant feature Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556842 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649085}
-
Sigurdur Asgeirsson authored
Bug: 910288 Change-Id: I6be552cecabd5a2061065541b4deca1b3fbee9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557423Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649084}
-
Denis Kuznetsov authored
PolicyTestServer can now simulate errors for device_attribute_update and policy fetch requests. Bug: 950471 Change-Id: I3b9bf3c84dbe500dec34254b8e8ebf06225c359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556811 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#649083}
-
Jonathan Backer authored
This allows us to use TYPED_TEST and to support GLRenderer and SkiaRenderer and remove a bit of boilerplate. TBR=kylechar@chromium.org Change-Id: I30382a03165b6d25ff20a03b67ccb20034ea99f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558791 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#649082}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e82336dd47a5..7ed01b7a5be9 git log e82336dd47a5..7ed01b7a5be9 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 ilkos@google.com Merge "Add start_ts to process and thread tables" Created with: gclient setdep -r src/third_party/perfetto@7ed01b7a5be9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9a9fc812083453a1514678eb3fcfa524d3a41404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559834Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649081}
-
Gauthier Ambard authored
This CL changes the alpha of the (dis)appearing items during a rotation. The default behavior of the MDCCollectionViewFlowLayout is to set the alpha to 1 for all those operations, creating an effect where the appearing items are displayed at the same time as the disappearing ones, both with an alpha of 1. Bug: 949659 Change-Id: Icd768e6b3f041749c335ab70bd1c9d41d7c2b7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554674 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#649080}
-
Florian Uunk authored
This will help us get some idea of how useful it would be to have identity representation for our current user base, and will allow us to track if we increase it with future changes to get users to name their profiles. Change-Id: Ic47a66a2e06ec16fdbf273cd86642e4467a030e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541188Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#649079}
-
Andrew MacPherson authored
Use AudioParameters::HardwareCapabilities to determine valid per-device min and max buffer size values. Also allow changing the hardware latency to values within this range when opening an audio device via getUserMedia using the latency constraint. Bug: 842877 Change-Id: Ib4a5c4ba63b4a079a2784421e5a6ab16cd294082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543397 Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#649078}
-
Jeremy Roman authored
Change-Id: Ie1ca6b92de96f28ef81bdadbe2be593f3617cdc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559015Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649077}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79cb521bf4a0..88192dcff2d1 Created with: gclient setdep -r src-internal@88192dcff2d1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I9cb242ee03c98a120295424a4f65c5284a7dbbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559833Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649076}
-
Marc Treib authored
These have been replaced by ReadyForStartChanged(). ReenableDatatype() was more powerful, in that it could also re-enable a type after an actual data type error, while ReadyForStartChanged() is only for "unready" errors. However, those extra powers were never used/needed. The three remaining callers of ReenableDatatype() are migrated to ReadyForStartChanged(). If one of the affected data types is disabled (e.g. via turning off the relevant pref), it will now show up in sync-internals as "Datatype not ready at config time" instead of "disabled by policy", which was never true anyway. Bug: 867846 Change-Id: Ie6516b3ff37ea70da46c6a1cf0d9b3fa345ce19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557025Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649075}
-
Rouslan Solomakhin authored
Originally landed in: https://crrev.com/c/1553170 Reverted in: https://crrev.com/c/1556857 Reason for revert: |current_update_reason_| is used before initialization in PaymentRequestSpec::RecomputeSpecForDetails() and PaymentRequestShowPromiseTest.CanShipAfterCheckingAddress still flakes. Justification for the reland: Initialized |current_update_reason_| to UpdateReason::NONE in the PaymentRequestSpec constructor and removed PaymentRequestShowPromiseTest.CanShipAfterCheckingAddress test entirely. Original change description: > Spec change: > https://github.com/w3c/payment-request/pull/672/files > > Intent to implement and ship: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/Lc2qCQgqqqk/NKOqwNweBQAJ TBR=danyao@chromium.org, yusufo@chromium.org, kenrb@chromium.org Bug: 817073 Change-Id: I7333337b8e50ae12ff609fdc82690726dd6d116b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558792 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649074}
-
Lowell Manners authored
With this change, ProfileOAuth2TokenService is now constructed only when creating an IdentityManager, eliminating the need for ProfileOAuth2TokenService factories. Change-Id: Ie52e179058ef87193bbf6cb0dda45208392c9572 Bug: 939372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529018Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649073}
-
Boris Sazonov authored
Disables flaky test. Example of a failed build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Lollipop%20Phone%20Tester/21318 TBR=cduvall@chromium.org Bug: 950772 Change-Id: I168e55655b7dfb0dc13e057648156e89ddca89a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559320Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#649072}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ed2d0537be1..79cb521bf4a0 Created with: gclient setdep -r src-internal@79cb521bf4a0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I0da29f83d38c4ec166f34626321eb6033fbbe956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559831Reviewed-by:
-
Kush Sinha authored
Screenshot: https://crbug.com/933482#c3 Bug: 933482 Change-Id: I0a260745503bb46be895896c95492a9c35815d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556794 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649070}
-
Anders Hartvoll Ruud authored
This is needed for the Cascade Project, which will use CSSPropertyName as the HashMap key. HashTraits requires the key object to support "empty" and "deleted" values. This is implemented by storing kEmptyValue and kDeletedValue in an integer which is shared with the CSSPropertyID. Constructing empty or deleted CSSPropertyNames is not advisable outside of HashTraits, hence the relevant constructor is exposed via friendship. (Inspired by PropertyHandle). BUG=947004 R=futhark@chromium.org Change-Id: I48bfb3707f73f0cadd7696075fce622352f9dee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553555Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#649069}
-
Dominic Battré authored
This reverts commit d5b00821. Reason for revert: Breaks compilation. ../../content/public/common/web_preferences.h:18:10: fatal error: 'third_party/blink/public/mojom/v8_cache_options.mojom.h' file not found #include "third_party/blink/public/mojom/v8_cache_options.mojom.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Original change's description: > OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth > > This CL moves bluetooth folder from public/platform/modules to > public/mojom/ to gather mojom files to mojom folder with > creating web_bluetooth_mojo_bindings. > > Bug: 919393 > Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Doug Turner <dougt@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#649061} TBR=kinuko@chromium.org,blundell@chromium.org,haraken@chromium.org,jbudorick@chromium.org,dougt@chromium.org,hnakashima@chromium.org,jkim@igalia.com Change-Id: I0ebd0abd67e8ed975cb2f517800296493cdda513 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559180Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#649068}
-
Dominic Battre authored
This CL fixes a crash that was introduced in ~PrefNotifierImpl(). The call of pref_service_->HasInMemoryUserPrefStore() dereferenced the user_pref_store_ of the PrefService which was destroyed before the pref_notifier_ was destroyed. Bug: 942491, 946668, 945772 Change-Id: I1f5749e013311a4a13f94214435f8a1b7e99329f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559138Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#649067}
-
Stephen McGruer authored
Intent to ship with 3x LGTM: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/UMxgGkxhdCo/CHZ2H9DsBgAJ Bug: 948657 Change-Id: I9c9ac4969f5708c310c9a8a95120fd5a0d3cdc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553448Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#649066}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b81b08e4eeb2..304f857d260e git log b81b08e4eeb2..304f857d260e --date=short --no-merges --format='%ad %ae %s' 2019-04-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src e8c2d95ed45f..d90aae9a5a6c (5 commits) Created with: gclient setdep -r src/third_party/angle@304f857d260e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I09554af90addb34beaf15df17df335effdc61bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559267Reviewed-by:
-
Peter E Conn authored
This change is apart of a larger sequence of CLs for implementing notification delegation auto-enrolment. See https://crbug.com/945258. Bug: 945278 Change-Id: I6e3d29049c78a2803d376d55247b2dd2bdeb3c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547738 Auto-Submit: Peter Conn <peconn@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#649064}
-
Marc Treib authored
This changes syncer::GetTimeDebugString from base::TimeFormatFriendlyDateAndTime to using icu::SimpleDateFormat directly. This results in a locale-independent format, which (a) eases debugging, and (b) is also more consistent with the rest of chrome://sync-internals. This also lets us include the time zone, which again helps with debugging, especially when comparing with server-side logs. While we're here, this also removes the weekday (which seems useless) and switches to a 24-hour clock. Before: Monday, April 8, 2019 at 6:36:38 PM After: 2019-04-08 18:36:38 +02 Bug: 948074 Change-Id: I6e166850201cc7fc9f8c32c7e3aacf7f661c74c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556810Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649063}
-
W. James MacLean authored
Simple re-factor to avoid allocating with 'new'. TBR=alexmos@chromium.org Bug: n/a Change-Id: I4668235abf84eb3d07c2eb56f1a96196928cdf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559014Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#649062}
-
Julie Jeongeun Kim authored
This CL moves bluetooth folder from public/platform/modules to public/mojom/ to gather mojom files to mojom folder with creating web_bluetooth_mojo_bindings. Bug: 919393 Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
-
Dominic Battre authored
If ShowAndFocusNativeWindow() fails, the always_on_top_window_killer_win does not capture a screenshot because the test fails with a CHECK instead of a timeout. This CL just makes sure that a screenshot is captured every time ShowAndFocusNativeWindow() fails. Bug: 711256 Change-Id: Ica8a4ff7493ca0de36a17e147c9c2806c275f30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559173 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#649060}
-
Abhijeet Kandalkar authored
This is a reland of commit 98136ca8. Original change's description: > Revert "Rename platform/wtf/size_limits.cc to platform/wtf/size_assertions.cc" > > This reverts commit 7a110199. > > Reason for revert: Breaks the build -- must also update references in BUILD.gn. Not sure how CQ didn't > catch it. > > Original change's description: > > Rename platform/wtf/size_limits.cc to platform/wtf/size_assertions.cc > > > > Bug: 950138 > > Change-Id: If8e9c4bb1df64d05d94e1044b1856484641989d2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557482 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#648876} > > TBR=haraken@chromium.org,abhijeet@igalia.com > > Change-Id: I87618a4cdc6c520cdb279765966be908abf26e35 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 950138 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559017 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648880} Bug: 950138 Change-Id: I2dcc4e1a28717e17ed73199aab93fce3b1be6f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559102Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f0fbbe4639b..4ed2d0537be1 Created with: gclient setdep -r src-internal@4ed2d0537be1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I628b44fad320f19369dd70d75dc24b5437123a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559409Reviewed-by:
-
Marc Treib authored
This error was already shown in the avatar menu, but settings still looked like everything was working fine. The fix is in syncer::GetStatusLabels, which now returns SYNC_ERROR instead of PRE_SYNCED in this case. Pre-Unity, there was an actual message saying that Sync was reset from the dashboard, but with Unity it seems that we only ever show the generic "isn't working" message. Bug: 943983 Change-Id: Id7458bf8fab7e73fa1aa14934fe6505f0ba9980a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559176Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649057}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/86820d1f3a7d..e82336dd47a5 git log 86820d1f3a7d..e82336dd47a5 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 lalitm@google.com Merge "trace_processor: properly handle nulls for ref_type enum" Created with: gclient setdep -r src/third_party/perfetto@e82336dd47a5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I1028ec34717cdbb02da1077f0176e2c98b970fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559265Reviewed-by:
-
David Roger authored
When the reconcilor does multiple cycles, we need to be able to wait until all the cycles are finished. To enable this, this CL adds a SCHEDULED reconcilor state: when the reconcilor does multiple cycles, it will go to the SCHEDULED state without going through the OK state. For example, if there are two reconcilor cycles, the state will be: RUNNING -> SCHEDULED -> RUNNING -> OK Bug: 948140 Change-Id: I145c30eb38fdc06d72e88ddd4ecbc568440fa62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550430Reviewed-by:
-
chrome://sync-internalsMarc Treib authored
In some past investigations, it might have been useful to know since when an auth error state has existed. Bug: 948074 Change-Id: I4220dbea552725cd0d75b35e563e292f7d5eea12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557027Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 27dbbe2f. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I12987ab6505cca2413993d216f5a9204d02540af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559357Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649053}
-
Martin Kreichgauer authored
r1552248 changed the WebAuthn behavior for user refusing attestation consent to remove the attestation statement rather than fail the request. Hence we should change the button label of the new WebAuthn UI attestation permission sheet (r1547344) from "Cancel" to "Block". Bug: 929423,850955 Change-Id: I885df62cae3dcadc858a63c11c8a0a619afbc360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559332 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#649052}
-
Maksim Moskvitin authored
Bug: 906611 Change-Id: I63a397b720c186df461d2e55dbe5ced19418d26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1449677 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Oleg Davydov authored
In order to investigate problems with force-installed extensions we have statistics of failures divided by feilure reason. One possible reason is “at the time of check extension is still installing”, in this case we want to know more precise stage of installation process. We already collect this stage in InstallationReporter/InstallationTracker, this commit enables sending this data to UMA to get broad picture of problems. Change-Id: I40153c2999c8393c8b927f9ef97b09f9fe016ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556850Reviewed-by:
Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#649050}
-
Marina Ciocea authored
The ICE transport object has been renamed in DTLS idl from transport to iceTransport. Update WPTs accordingly. Mark the ice connection state test flaky for now because the state surfaced in blink layer is currently not consistent with the state in WebRTC layer. Bug: 907849 Change-Id: Ifc88cb8e877ce15729c355f54c85cc1a34556d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533878 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#649049}
-
Clemens Arbesser authored
Bug: 806868 Change-Id: I8d258f57f8c376cf3bcbdfa33bf60aafa222e59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559074 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#649048}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6145021beb12..072a6f14b64c git log 6145021beb12..072a6f14b64c --date=short --no-merges --format='%ad %ae %s' 2019-04-09 msalama@google.com Add a metric that tracks native code memory footprint. Created with: gclient setdep -r src/third_party/catapult@072a6f14b64c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947012 TBR=skyostil@chromium.org Change-Id: I5d6bad653b902b3eba56ae6ab550e26aea801e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559408Reviewed-by:
-
Ramin Halavati authored
Incognito toolbar menu shows the number of incognito open windows in a disabled button that is not navigable and readable by screen narrators. The accessible title of the menu is updated to tell the number of open incognito windows. Example accessible title: "2 open incognito windows." Bug: 896235 Change-Id: Idc91eae7d40e0299b6b3d6448d3cb05b5fe7e968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553543 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#649046}
-
