GitLab

When creating a new GraphicsContextState the constructor initializes the state
with various default values. In GraphicsContext::realizePaintState we immediately
overwrite these values after creation. This patch adds a copy constructor to
GraphicsContextState to avoid that.

Even though this seems like a clear win, the benefits are not visible when
profiling. Looks like the overhead of the redundant initialization is
not very large. Still seems worth fixing though.

BUG=377687

Review URL: https://codereview.chromium.org/303613002

git-svn-id: svn://svn.chromium.org/blink/trunk@174985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the destruction of HTMLCanvasElement, we call
HTMLCanvasElement::existingDrawingContext(), whose behavior was changed
incorrectly in r162330 and was triggering the allocation of an ImageBuffer
during tear-down.  This is not only wasteful, but it can trigger a
garbage collection because the creation of an ImageBuffer will increase
the amount of externallay allocated memory that is declared to V8.
Triggering a GC during the finalization of a garbage collected object
is bad.

BUG=378289

Review URL: https://codereview.chromium.org/303803002

git-svn-id: svn://svn.chromium.org/blink/trunk@174984 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change the way clip rects are determined for multicol by using enclosing
IntRect instead of pixelSnappedIntRect to ensure that the colum contents
fully fits within the clip rect.

R=leviw@chromium.org, mstensho@opera.com

Review URL: https://codereview.chromium.org/300843010

git-svn-id: svn://svn.chromium.org/blink/trunk@174983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't really need these classes anymore, we can just use methods on
ContainerNode. This gets us one step closer to completely eliminating
ContainerNodeAlgorithms which now only contains one shared method related
to SVGElementInstance and cleanup code that Oilpan will eliminate.

Review URL: https://codereview.chromium.org/305603003

git-svn-id: svn://svn.chromium.org/blink/trunk@174982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Debug assertions in the GraphicsContext destructor were
dependent on object destruction order, which made them
incompatible with oilpan. The state validation logic
was refactored to make the state validation checks more
useful.

BUG=370793

Review URL: https://codereview.chromium.org/293963009

git-svn-id: svn://svn.chromium.org/blink/trunk@174981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reduces methods exposed on the throttle class and makes
throttling details hidden to XMLHttpRequest class.

- Use dispatchProgressEvent also for loadstart event
- Remove "throttled" from method names
- Move if-clause to switch how to dispatch a ProgressEvent based on its
  name to XMLHttpRequestProgressEventThrottle::dispatchProgressEvent()
- Remove dispatchThrottledProgressEvent and just call
  m_progressEventThrottle.dispatchProgressEvent for each event
- Make XMLHttpRequestProgressEventThrottle::dispatchEvent() private

BUG=none

Review URL: https://codereview.chromium.org/301643002

git-svn-id: svn://svn.chromium.org/blink/trunk@174979 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Forgot to do this during my last gardening stint :(

BUG=369600
TBR=ojan

Review URL: https://codereview.chromium.org/305623006

git-svn-id: svn://svn.chromium.org/blink/trunk@174978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

From private conversation with annevk - make the properties of the
TextDecoder object inspectable.

BUG=375847

Review URL: https://codereview.chromium.org/292243003

git-svn-id: svn://svn.chromium.org/blink/trunk@174977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376770

Review URL: https://codereview.chromium.org/304503004

git-svn-id: svn://svn.chromium.org/blink/trunk@174976 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since HTMLImportsController controls the lifetime of HTMLImportChild
instances, there's no need for HTMLImportLoader to be ref-counted.
We can just let it be owned by HTMLImportsController, as well.

R=morrita
BUG=

Review URL: https://codereview.chromium.org/298023007

git-svn-id: svn://svn.chromium.org/blink/trunk@174975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the first step of three in moving over EventTarget. The next step is to update the IDL of EventTarget to be WillBeGarbageCollected, and then to replace all RefPtr uses. Once all Node RefPtr uses have also been replaced, we can remove the ref-count from Node.

BUG=357163

Review URL: https://codereview.chromium.org/307433003

git-svn-id: svn://svn.chromium.org/blink/trunk@174973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prior to this change the webkit_unit_tests target did not enable the plugin for its compilation units.

TBR=eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/301543005

git-svn-id: svn://svn.chromium.org/blink/trunk@174972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Trivial change.

R=haraken
BUG=358074
BUG=377364

Review URL: https://codereview.chromium.org/298293008

git-svn-id: svn://svn.chromium.org/blink/trunk@174971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mechanical change, mostly bindings/core/v8, a few bindings/modules/v8.
(This will make sorting custom bindings trivial.)

2 exceptions due to files generated outside of bindings:
V8HTMLElementWrapperFactory.h
V8SVGElementWrapperFactory.h
...which are generated by core_generated.gyp in gen/blink.
FIXMEs added.
(core_generated.gyp also requires qualifying all its paths,
but that's another kettle of fish)

R=haraken
BUG=358074

Review URL: https://codereview.chromium.org/300863004

git-svn-id: svn://svn.chromium.org/blink/trunk@174970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After https://codereview.chromium.org/289973008/ lands,
there are no remaining call sites. And it's been a no-op
for over a month anyhow.

BUG=354688

Review URL: https://codereview.chromium.org/286263004

git-svn-id: svn://svn.chromium.org/blink/trunk@174969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now an easy change, this correctly adds qualified paths based on component.

There are still other places to qualify (notably v8/custom), which I'll do
separately, so we can't yet remove the other dirs from core.gyp, but we're
close!

Also some test fixes due to use of invalid interface types, and lotta test updates.

R=haraken
BUG=358074
BUG=377364

Review URL: https://codereview.chromium.org/306543008

git-svn-id: svn://svn.chromium.org/blink/trunk@174968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/H6lsGFqdy3Y/F2GlWvbl-TsJ

Review URL: https://codereview.chromium.org/303663004

git-svn-id: svn://svn.chromium.org/blink/trunk@174967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Both of the counters are at 0%:
http://www.chromestatus.com/metrics/feature/timeline/popularity/86
http://www.chromestatus.com/metrics/feature/timeline/popularity/245

In other worlds, there's hardly anyone to see the deprecation message.

BUG=240252

Review URL: https://codereview.chromium.org/303473004

git-svn-id: svn://svn.chromium.org/blink/trunk@174966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-OvFrybkW1E/Ucrct3sm6foJ

Review URL: https://codereview.chromium.org/301563002

git-svn-id: svn://svn.chromium.org/blink/trunk@174965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When finalizing the media element, its media player is also cleared
out. With Oilpan enabled, that media player object must not touch the
media element while destructing its "client", as it is not in a
valid state (its heap object member may have been finalized already.)

Arrange for that to not happen by having the media element enter a
'finalizing' state, which is explicitly checked for when the player
attempts to access the media element during destruction.

This is a shorter-term solution until the media player object itself
is moved to the Oilpan heap; http://crbug.com/378229 for handling that.

R=haraken@chromium.org,ager@chromium.org
BUG=377567
TEST=media/track/track-removal-crash.html
TEST=media/audio-delete-while-slider-thumb-clicked.html
TEST=http/tests/media/media-source/mediasource-closed-on-htmlmediaelement-destruction.html

Review URL: https://codereview.chromium.org/303593002

git-svn-id: svn://svn.chromium.org/blink/trunk@174964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Method StyleResolver::pseudoCSSRulesForElement is used from both WebPlatform
(via window.getMatchedCSSRules) and inspector in its styles sidebar pane.
Due to security reasons, this method "lies" about css rules applied for
visited and unvisited links so that it is impossible to sniff user history.

This patch makes inspector to adjust method results so that it knows which
rules are actually applied and which are not.

FYI: The previous version of this patch is https://codereview.chromium.org/228673002/
It was reverted due to regression of :host rules, thus this patch adds
a test to verify them.

BUG=356999

Review URL: https://codereview.chromium.org/300693004

git-svn-id: svn://svn.chromium.org/blink/trunk@174963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow up to Blink r174945.

TBR=amikhaylova@google.com, yurys

Review URL: https://codereview.chromium.org/307533006

git-svn-id: svn://svn.chromium.org/blink/trunk@174961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Ever since border-image-width was implemented in

https://bugs.webkit.org/show_bug.cgi?id=67657

border-widths values haven't been scaled with the zoom level for SVG
elements. Remove the special casing since it doesn't seems to be any
good reason for having it. Firefox doesn't do anything of the sort and
there is no specification support for it.

BUG=377447

Review URL: https://codereview.chromium.org/302643002

git-svn-id: svn://svn.chromium.org/blink/trunk@174960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=378222
R=alph@chromium.org

Review URL: https://codereview.chromium.org/297143011

git-svn-id: svn://svn.chromium.org/blink/trunk@174959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=377723

Review URL: https://codereview.chromium.org/302783010

git-svn-id: svn://svn.chromium.org/blink/trunk@174958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I'm going on leave for 11 weeks, and besides there's a suitable
mailing list for such notifications now.

TBR=rune@opera.com
NOTRY=true

Review URL: https://codereview.chromium.org/305673002

git-svn-id: svn://svn.chromium.org/blink/trunk@174957 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a preparation for moving WebSocketChannelClient to the heap.

This CL adds a template specialization to CrossThreadCopier.h so that ThreadableWebSocketChannelClientWrapper* can be passed to createCallbackTask().

BUG=340522

Review URL: https://codereview.chromium.org/267323004

git-svn-id: svn://svn.chromium.org/blink/trunk@174956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used to process only main thread events in both TraceEventBindings
and TimelineFrameModel. This drops the filtering by thread from TracingModel
and lets its clients process all events from the inspected target, performing
filtering on their own.
Also, this forks the enum for thread event names from that of timeline model --
they may occasionally overlap, but essentially these are two different enums.

BUG=361045

Review URL: https://codereview.chromium.org/301593002

git-svn-id: svn://svn.chromium.org/blink/trunk@174955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This updates r-b-t (currently breaking) following:
Bindings build: split compute_interfaces_info into 2 stages
https://codereview.chromium.org/300273005/

Sorry for breakage!
This wasn't caught earlier because files were renamed, then changed,
so the old bytecode (.pyc) was still being used.

TBR=haraken
BUG=358074

Review URL: https://codereview.chromium.org/301743008

git-svn-id: svn://svn.chromium.org/blink/trunk@174954 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change moves the HTMLStackItem to the oilpan heap. This removes a RefPtr from HTMLStackItem into the Node hierarchy which was/is causing a leak when we stop calling dispose from the Document's detach method.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/298043008

git-svn-id: svn://svn.chromium.org/blink/trunk@174953 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch change IndentOutdentCommand::tryIndentingAsListItem to check nullable
value returned by encloseBlock() before using it.

BUG=376721
TEST=LayoutTests/editing/execCommand/indent-inline-box-crash.html

Review URL: https://codereview.chromium.org/297203004

git-svn-id: svn://svn.chromium.org/blink/trunk@174952 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes CompositeEditCommand::splitTreeToNode not to split when
tree parent parameter |start| isn't descendant of |end| node parameter.

The root cause of issue 350843 is we call |positionInParentAfterNode()| with
dangling BLOCKQUOTE element which is tried to insert HTML element as result
of |splitTreeNode()|, which is called BODY element, and HR element; HR element
is child of BODY element.

BUG=350843
TEST=LayoutTests/editing/execCommand/indent-table-cell-crash.html

Review URL: https://codereview.chromium.org/306473003

git-svn-id: svn://svn.chromium.org/blink/trunk@174951 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add missing tracing of added Event member.

R=haraken@chromium.org
BUG=376349
NOTRY=true

Review URL: https://codereview.chromium.org/303703004

git-svn-id: svn://svn.chromium.org/blink/trunk@174950 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Finally, splitting bindings output!
Mostly straightforward, with 2 twists:
* need a separate cache directory for the scripts,
  not just the output directory
  (to avoid needing to precache twice)
* aggregate bindings files need to know the component

Followup is:
* Generate qualified paths in includes
* remove bindings subdirs from core includes!

R=haraken
BUG=358074

Review URL: https://codereview.chromium.org/306633002

git-svn-id: svn://svn.chromium.org/blink/trunk@174949 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org,haraken@chromium.org,dominicc@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/296703009

git-svn-id: svn://svn.chromium.org/blink/trunk@174948 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Explain what the method actually does
preflightSuccess -> loadActualRequest
preflightFailure -> handlePreflightFailure

BUG=none

Review URL: https://codereview.chromium.org/300893002

git-svn-id: svn://svn.chromium.org/blink/trunk@174947 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(We're not sure if they're real or not yet, but apprently they
seem to coming from the same cause)

BUG=364390
TBR=kouhei@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/302633011

git-svn-id: svn://svn.chromium.org/blink/trunk@174946 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376194

Review URL: https://codereview.chromium.org/295633003

git-svn-id: svn://svn.chromium.org/blink/trunk@174945 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A crash bug which an attached test case causes is following: 
1. Selection.deleteFromDocument calls Range.deleteContents which removes a node through Node.removeChild. 
2. Node.removeChild calls a DOMNodeRemoved event which removes the node. 
3. Then Node.removeChild asserts a DOM exception NOT_FOUND_ERR. 
4. Range.deleteContents picks the exception and it causes crash because Selection.deleteFromDocument calls Range.deleteContents with ASSERT_NO_EXCEPTION. 

This cl changes Selection.deleteFromDocument to delay the mutation event dispatching when it calls Range.deleteContents.
Especially, DOMNodeRemoved will be not kicked.

BUG=339186

Review URL: https://codereview.chromium.org/199383004

git-svn-id: svn://svn.chromium.org/blink/trunk@174944 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously the AnimationPlayer's finish event could have been dispatched
after the event handlers had been collected. As these events are queued
then dispatched asynchronously via ScriptedAnimationController some
special handling is required (tracking when the event is actually
dispatched).

BUG=376349

Review URL: https://codereview.chromium.org/284323004

git-svn-id: svn://svn.chromium.org/blink/trunk@174943 bbb929c8-8fbe-4397-9dbb-9b2b20218538