GitLab

Since the patch in CL1406976 for crbug.com/833797 landed (see [1]), there
is not any need to monitor this event since AccountManagerUIHandler is no
longer taking accounts out of the UI while data is being fetched, and so
there is no need to do this extra effort to make sure that such accounts
were added back once that fetch was complete.

Additionally, removing this method now paves the way to migrate away from
AccountTrackerService APIs entirely from AccountManagerUIHandler, and use
IdentityManager's APIs instead, so let's do it now as a precursor CL.

[1] https://crrev.com/c/1406976

Bug: 922785
Change-Id: I068e89eb7fa7774c3be0f9bf67e02a0b8dfb642d
Reviewed-on: https://chromium-review.googlesource.com/c/1437175Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#626231}

The callback received by this method as a parameter is only meant
to be run once, so let's make it a base::OnceCallback to be more
explicit, and to make the lifetime of such callback more clear.

Bug: 924102
Change-Id: I3492b59c055d61ed91c65a0b5d9418c925048213
Reviewed-on: https://chromium-review.googlesource.com/c/1429984Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#626230}

This ensures that the 'wake-lock' feature is not parsed in feature
policy directives unless the WakeLock runtime flag is enabled.

Bug: 925454
Change-Id: Ic8043be2f499295f4246d99866180c2aab222ad7
Reviewed-on: https://chromium-review.googlesource.com/c/1436201Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626229}

AudioSinkAndroidAudioTrackImpl::SetPaused() only checked
pending_data_bytes_already_fed_, whereas FeedDataContinue() requires
both this and that pending_data_ exists. Hence we protect this call with
an additional check on pending_data_.

AudioVideoPipelineDeviceTest.Mp4Playback and
AudioVideoPipelineDeviceTest.PcmPlayback both pass reliably on android.

Bug: internal/123356146
Change-Id: Ibb562ab04c9dca1fdaca5b4df743b4a59ec49cbb
Reviewed-on: https://chromium-review.googlesource.com/c/1437192
Auto-Submit: Nate Steinbock <steinbock@google.com>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626228}

https://skia.googlesource.com/skia.git/+log/094ab18b457e..d41c1876d834


git log 094ab18b457e..d41c1876d834 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 borenet@google.com Add chromium_revision tag to SKP CIPD package
2019-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 59b1ed4a60fc..59d756e530c5 (1 commits)
2019-01-25 brianosman@google.com Remove --readPath/-r from DM
2019-01-25 bsalomon@google.com Actually reuse GrTexture if SkPromiseImageTexture used with multiple
2019-01-25 brianosman@google.com Switch DM JSON output to use SkJSONWriter
2019-01-25 bsalomon@google.com Remove GrGpuResource::abandon from the public API.
2019-01-25 bsalomon@google.com Change the meaning of GrBudgetedType::kUnbudgetedUncacheable.
2019-01-25 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2019-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6ab37b0f2ca0..86f8bdb2934c (1 commits)
2019-01-25 bsalomon@google.com Require explicit GrWrapCacheable specification in more places.
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 76e400246439..6ab37b0f2ca0 (1 commits)
2019-01-24 ericrk@chromium.org Invalidate Vulkan CB state after vending it out via drawable
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9d803dd2..7fafb7b5 (477 commits)
2019-01-24 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-24 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 47ca1b2fa399..59b1ed4a60fc (1 commits)
2019-01-24 bungeman@google.com Use only icu c api in shaper.
2019-01-24 bsalomon@google.com Replace bool purgeImmediately with enum GrWrapCacheable.
2019-01-24 halcanary@google.com gm: delete boilerplate
2019-01-24 hcm@google.com Update Skia milestone to 74
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4806a9be530f..76e400246439 (1 commits)
2019-01-24 brianosman@google.com Remove SkColorSpace::Gamut enum
2019-01-24 brianosman@google.com Remove nearly all use of SkColorSpaceTransferFn
2019-01-24 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-24 djsollen@google.com Revert "Implement XP factory dumping"
2019-01-24 halcanary@google.com gm: use DEF_GM macro consistantly


Created with:
  gclient setdep -r src/third_party/skia@d41c1876d834

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:922851,chromium:922851,chromium:900965,chromium:922851
TBR=djsollen@chromium.org

Change-Id: Ib518e49466c2365644e176043f1b37a0418ac279
Reviewed-on: https://chromium-review.googlesource.com/c/1437009Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626227}

https://chromium.googlesource.com/angle/angle.git/+log/59d756e530c5..5904ee3f58e3


git log 59d756e530c5..5904ee3f58e3 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 syoussefi@chromium.org Vulkan: Fix timestamp query units


Created with:
  gclient setdep -r src/third_party/angle@5904ee3f58e3

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Change-Id: Ib412bcc3af35f41c37a8ef6483023e1a81ea80f6
Reviewed-on: https://chromium-review.googlesource.com/c/1437496Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626226}

The class has most functionality implemented, so it's more of a test
helper class than a mock.

Change-Id: I70b8bd66835b65e9f6af83827a0ea3682e954b4a
Reviewed-on: https://chromium-review.googlesource.com/c/1435685Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626225}

This change is to support the Switch Access focus ring style described
in this spec: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQBEKUk1sS_U/files/MCHtA7U1iMGr6-mR9r6ArPGAjSutDL__KP4

Bug: 925103
Change-Id: I6aeda730fd8717282cb49867840010aea7a92f83
Reviewed-on: https://chromium-review.googlesource.com/c/1435435
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626224}

I had voiced concerns about this when NoDestructor was introduced as a
strictly preferred alternative to LazyInstance @
https://groups.google.com/a/chromium.org/d/msg/cxx/rs_iizoAu6w/Gi6s0pmwBQAJ.
This CL migrates LazyInstanceTest.PriorityInversionAtInitializationResolves
to the NoDestructor thread-safe scoped-static-initialization paradigm.

It seems to be okay after all and this CL locks this in on all platforms.

Bug: 925323
Change-Id: I679beaf23934840b6070a8592dd6d678992d6943
Reviewed-on: https://chromium-review.googlesource.com/c/1436198
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626223}

This CL adds the '-f FAKE' flag to apk_operations.py. This complements
the '-m MODULE' flag, but performs fake bundle module install instead.
Changes:
* Always delete the fake module directories:
  /data/local/tmp/modules/
  /data/data/<package_name>/files/splitcompat/ (needs root)
* If -f flags is given:
  * Constraints:
    (1) '-f base' is illegal.
    (2) Explicit '-m base' is required (prevents potential ambiguity
        in the future).
    (3) FAKE and MODULE must be disjoint.
  * Print warning if command line flags not set up for fake modules.
    This requires chrome/android/BUILD.gn to specify
      command_line_flags_file = 'chrome-command-line',
    which get passed to apk_operations.py: _InstallBundle() so it can
    read the command line flags and check.
  * Extract the FAKE module split APKs, then copy them to
    /data/local/tmp/modules/.
* Update chrome/android/BUILD.gn to specify
  which get passed to apk_operations.py: _InstallBundle() so that
  it can check for '--fake-feature-module-install' in command line,
  and print warning if missing.

Bug: 922051
Change-Id: I5bba49e1e7e66a4a00f1ed1ca4128a805d995e95
Reviewed-on: https://chromium-review.googlesource.com/c/1435515Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626222}

ASAN makes this fuzzer sufficiently slow that it hits the Run() timeout,
so disable the timeout in ASAN builds.

Bug: 924030
Change-Id: I38055a3a8982564d2300fe10d717651f27d32dfc
Reviewed-on: https://chromium-review.googlesource.com/c/1433392
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626221}

Came up in crbug/917004. Although these changes don't help crash server,
it's nice to have them work locally.

Change-Id: I7208b95bc1ea784b2f3050b7f2f8a8e223133e9f
Reviewed-on: https://chromium-review.googlesource.com/c/1437539
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626220}

Previously I did not consider that menus would be very tall. I was
unaware that shift-clicking the chrome icon would show a potentially
very long list of all active tabs. This resulted in a menu that would
not show up (bottom shelf) or show up clipped (side shelf).

Added some unit tests for the tall menu case, and also for the case
where the anchor bounds size is 0 (for example, a click).

Bug: 913278
Change-Id: I460db943df268f7b1534bbdcffca9d5b96e750ec
Reviewed-on: https://chromium-review.googlesource.com/c/1428603
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626219}

BUG=924872
TEST=None

Change-Id: I5df8485c1a978d8f7ec29516d2900445bf225244
Reviewed-on: https://chromium-review.googlesource.com/c/1435682
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626218}

All pages importing it have already been migrated to $i18n{}, so these
dependencies don't seem needed anymore.

This changes following pages:
* chrome://media-router
* chrome://md-user-manager

R=dpapad@chromium.org

Bug: 677338
Change-Id: I05bcfba71ca1c8446ddfb14335d404bc382fc523
Reviewed-on: https://chromium-review.googlesource.com/c/1425719Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626217}

Bug: 916176
Change-Id: I3418fdbceea18391bb09e957e4846accf1b28447
Reviewed-on: https://chromium-review.googlesource.com/c/1413072Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626216}

This CL also adds a new utility function to render the icon to be
checked. A follow-up CL will add a unit test to reproduce the analysis
that led to lowering this number.

Bug: 805600
Change-Id: I7b93e1eececa4bb70659d8a89f782d0d9cbc5f44
Reviewed-on: https://chromium-review.googlesource.com/c/1431478Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626215}

Previously missed in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1412015

Bug: 827324
Change-Id: I265678736a857aaea394fdeb2d31860f73cf36ea
Reviewed-on: https://chromium-review.googlesource.com/c/1431516
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626214}

Bug: 921548
Change-Id: Ia8b315c56cc234cc32a06bbcd36720c29cf551d6
Reviewed-on: https://chromium-review.googlesource.com/c/1437537
Auto-Submit: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626213}

This renames UpdatePrimarySurfaceId() to
UpdateLocalSurfaceIdAndClientSurfaceEmbedder(), which better indicates what
it does.

There should be no functional change here, just docs/renaming.

BUG=none
TEST=none

Change-Id: Icfe5643c0225f2e158fe8843b03f08b7dec30495
Reviewed-on: https://chromium-review.googlesource.com/c/1437576
Commit-Queue: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626212}

Bug: 919356
Change-Id: I8b7769f6d6fef258f31dd16367d54b505284a7d8
Reviewed-on: https://chromium-review.googlesource.com/c/1437265
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626211}

In SuperSize console, clustering of symbols by name avoids collision by
checking object_path. But for symbols with missing object_path, such
collision is no longer guarded, and grouping can become too aggressive.

This CL softens the impact of missing object_path by using address to
resolve grouping for non-'**' symbols when object_path is missing.

Bug: 923936
Change-Id: I9856daa42ac93cd8b296324e8cfe5625e313bdac
Reviewed-on: https://chromium-review.googlesource.com/c/1431282Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626210}

Bug: 867008
Change-Id: I5d889fb6b023318e4d47dbc4818883d975c30960
Reviewed-on: https://chromium-review.googlesource.com/c/1422842Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626209}

Template URLs with nonzero prepopulate_id were implicitly
reordered by RemoveDuplicatePrepopulateIDs, though relative
order was preserved for elements with zero prepopulate_id.
This CL adjusts the algorithm to output the selected
representatives for each prepopulate_id in order of first
appearance in the original template_urls vector, stabilizing
the overall order (instead of partitioning as it did before).

Bug: 924268
Change-Id: Ic885065cbf20398dfff723a85aff35141e0cb9a5
Reviewed-on: https://chromium-review.googlesource.com/c/1428939
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626208}

This CL deduplicates verification code that was present in
- RenderFrameProxyHost::OnOpenURL
- RenderFrameHostImpl::OnOpenURL
- RenderFrameMessageFilter::OnDownloadUrl

The duplicated code is moved into new util functions.  The new functions
will be tweaked in the future to add more verification (e.g. to verify
|initiator_origin|).

Bug: 919144
Change-Id: I50515c42d7f5003dd1f782ba59349599dca0f88d
Reviewed-on: https://chromium-review.googlesource.com/c/1395886Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626207}

This is a reland of b21bf2bb

Original change's description:
> [Nav Experiment] Call LoadIfNecessary() in CWVWebView session restore.
> 
> The web view load scheduled by WKBasedNavigationManager::Restore() is
> deferred when used in CWVWebView's |resetWebStateWithSessionStorage|
> because the |_containerView| is not created until later. This CL calls
> LoadIfNecessary() explicitly after the view is created to trigger the
> session restoration.
> 
> This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
> enabled. A better approach would be to turn this test into a
> programmatic test so both navigation managers implementations are
> tested, but web::features symbols are not exposed in ios/web_view.
> 
> Bug: 862714
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet
> Change-Id: I21e694e3fef6a833f1cce04ff9cebd3784349111
> Reviewed-on: https://chromium-review.googlesource.com/c/1135435
> Commit-Queue: Danyao Wang <danyao@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Auto-Submit: Danyao Wang <danyao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#626170}

Bug: 862714
Change-Id: I853a8e030bef9f812605eac24c65d8237027f107
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/c/1437574Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626206}

Bug: 925365
Change-Id: Ie97bc90690811a865652e533c5ea6d540b5523b3
Reviewed-on: https://chromium-review.googlesource.com/c/1437007Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626205}

https://pdfium.googlesource.com/pdfium.git/+log/f0898a22bff3..148c14459dd2


git log f0898a22bff3..148c14459dd2 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 tsepez@chromium.org Deprecate 7-Arg form of CFXA_Node constructor.
2019-01-25 thestig@chromium.org Make CFX_MemoryStream XFA-only.
2019-01-25 tsepez@chromium.org Remove last CJX_ classes that do not meaningfully extend superclasses
2019-01-25 thestig@chromium.org Cherrypick a PartitionAlloc fix.


Created with:
  gclient setdep -r src/third_party/pdfium@148c14459dd2

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:897585
TBR=dsinclair@chromium.org

Change-Id: I25faf505b1ccf7f9ec01c4aa2050d0acab677680
Reviewed-on: https://chromium-review.googlesource.com/c/1437495Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626204}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc26fdabb612..bfb698e79191


Created with:
  gclient setdep -r src-internal@bfb698e79191

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I0a9498a0f1e869cab7201148dc1e373eb77f17fa
Reviewed-on: https://chromium-review.googlesource.com/c/1437494Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626203}

Using this API may be causing crashes, and it was only added for code
cleanliness. Remove it.

TBR=ellyjones

Bug: 924955
Change-Id: Id25bab33958381bd16ce4887c842943ccae99a34
Reviewed-on: https://chromium-review.googlesource.com/c/1437395
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626202}

Checking if Chrome version is compatible with ChromeDriver version.

Before ChromeDriver was set to support Chrome minimum supported version
and the next three consequent versions.
With this changes ChromeDriver will support from minimum supported
Chrome version up to Chrome current version + 1.

Bug: chromedriver:2685
Bug: chromium:925256
Change-Id: I179a75e7779dc4b4f22ac2f3f1f07c776396c233
Reviewed-on: https://chromium-review.googlesource.com/c/1436199Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626201}

Added navigation plus waiting for frame to initialize. That'll ensure
that AutocompleteHistoryManager was instantitated properly.

Bug: 920620
Change-Id: I418753c1b793eaa5349db6c1dd229e39eefe4fa7
Reviewed-on: https://chromium-review.googlesource.com/c/1437056
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626200}

This changes the entry point into the WebXR APIs, as described
by the latest spec changes. It makes the concept of which physical
piece of hardware is being used implicit. The CL is unfortunately
large, but that's almost entirely due to the number of tests that the
change affects.

Bug: 916299
Change-Id: I32f2acec810761bbddd1f6df6e8ca91673dd381e
Reviewed-on: https://chromium-review.googlesource.com/c/1383393
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626199}

Change-Id: I9565476be970dd3593a1d874338d71ca5df9f6fa
Reviewed-on: https://chromium-review.googlesource.com/c/1436153Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626198}

Removes service catalog uses in these directories, replacing them
instead with inlined collections of Manifest objects.

Test-only manifests have also been converted from JSON to C++ and are
inlined within corresponding test code.

Bug: 895616
Change-Id: I9ea61bbc263307feed4eec6e4e66f3a88e785eed
Reviewed-on: https://chromium-review.googlesource.com/c/1436877Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#626197}

The system may purge the web view associated with the chrome://inspect page if
it is left with logging enabled and many other tabs are used.

Since the web view is gone, a page reload must occur when the user navigates
back to the tab. The reload will cause all logs to be cleared from the
chrome://inspect page and will reset the button back to "Start Logging". Turning
off logging in InspectDOMHandler ensures that the state matches what the user
will see when they navigate back to the chrome://inspect tab.

Bug: 920823
Change-Id: I852d5a264f2d11424e8183fe1aeffb0299572537
Reviewed-on: https://chromium-review.googlesource.com/c/1435035
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626196}

This change implements instructions sent by Epson to properly setup
their printers; mostly just boils down to falling back on a provided
generic Epson PPD.

Bug: chromium:895037
Test: All current and added test cases pass. Verified non-Epson matching unchanged
Change-Id: Ie336586bed844e1b9f6671d36312a89ed16849bc
Reviewed-on: https://chromium-review.googlesource.com/c/1407918Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Auto-Submit: Luum Habtemariam <luum@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626195}

views wants to (more or less) own the DialogDelegate. This is currently
done via refcounting. To remove that dependency of the refcounts,
extract it into its own object, with lifetime contracts against
LoginHandler.

Now the threading and refcounting mess is largely confined to the
LoginHandler base class, rather than spread into the subclasses.

Bug: 908926
Change-Id: Ia7f88c23d051dff06492baee2b050f82265a59e3
Reviewed-on: https://chromium-review.googlesource.com/c/1388037Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626194}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I8b2793a95aa1a6642e0b87d98fe63747a55040b6
Reviewed-on: https://chromium-review.googlesource.com/c/1437398Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626193}

This is for consistency with Windows and allows minimized windows to be
activated.

BUG=924075
R=sky,fbeaufort

Change-Id: Ic86ffba47805b2ba4f5c8f049cdccd2e75be8d9b
Reviewed-on: https://chromium-review.googlesource.com/c/1437263
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626192}