GitLab

This refactoring encapsulates sync and async microtask queues into
CustomElementMicrotaskStepDispatcher class.
Also, it renames CustomElementMicrotaskQueue to CustomElementSyncMicrotaskQueue
for clarifying the difference from the async queue.

This is a preparation for fixing crbug.com/384516

BUG=384516
TEST=none
R=dglazkov@chromium.org, dominicc@chromium.org

Review URL: https://codereview.chromium.org/334253005

git-svn-id: svn://svn.chromium.org/blink/trunk@176434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because HTMLFrameOwnerElement.h includes Document.h, the consequence is
mostly that Document.h includes need to be added.

Locally, this reduces the number of recompilation steps when touching
HTMLFrameOwnerElement.h from 579 to 117, and when touching Document.h
from 1214 to 1160.

There is a risk of performance regressions due to outlining
Frame::deprecatedLocalOwner().

Review URL: https://codereview.chromium.org/343593002

git-svn-id: svn://svn.chromium.org/blink/trunk@176433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A layer's absolute clip rects are no longer valid when its
transform or the transform of an ancestor changes, since the
layer moves in absolute space. This CL clears the absolute
clip rects of a layer and its descendants when the layer's
transform changes.

BUG=246965

Review URL: https://codereview.chromium.org/334373002

git-svn-id: svn://svn.chromium.org/blink/trunk@176432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces ViewportElement.cacheHeight() method which is
called by viewport control in appropriate time to let viewportElement
cache its height. Currently, ViewportElement.willHide() method is
responsible for height caching.

ViewportElement.cacheHeight() must not invalidate DOM. This is not
the case for willHide() method due to the console.table implementation
which removes inner DataGrid views. The bug happens because of the
"scroller securing" (see ViewportElement.refresh method) being done after
the sequence of willHide() calls.

BUG=385685
R=aandrey, pfeldman

Review URL: https://codereview.chromium.org/340483003

git-svn-id: svn://svn.chromium.org/blink/trunk@176431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make iterator for Element's attributes more lightweight. Kill the
AttributeConstIterator class and make the iterator a simple pointer instead
(similarly to the Vector iterator). Also rename the AttributeIteratorAccessor
class to AttributeCollection as I think it looks better. This CL adds a typedef
so that the iterator is now used as AttributeCollection::const_iterator.

Also rename the attributesIterator() method to attributes() for simplicity.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/337753005

git-svn-id: svn://svn.chromium.org/blink/trunk@176430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=sigbjornf@opera.com
BUG=

Review URL: https://codereview.chromium.org/334623006

git-svn-id: svn://svn.chromium.org/blink/trunk@176429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/320423004

Review URL: https://codereview.chromium.org/320423004

git-svn-id: svn://svn.chromium.org/blink/trunk@176428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use stricter typing for NodeLists throughout the code base. This makes it
clearer what exact type we are actually dealing with. This also allows the
compiler to de-virtualize some function calls with C++11.

R=adamk@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/334713006

git-svn-id: svn://svn.chromium.org/blink/trunk@176427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove unneeded checks in RenderTreeBuilder, the same check is done in RenderTreeBuilder::shouldCreateRenderer.

Review URL: https://codereview.chromium.org/334263007

git-svn-id: svn://svn.chromium.org/blink/trunk@176426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/347583003

git-svn-id: svn://svn.chromium.org/blink/trunk@176425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/340723005

git-svn-id: svn://svn.chromium.org/blink/trunk@176423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=245436

Review URL: https://codereview.chromium.org/347513004

git-svn-id: svn://svn.chromium.org/blink/trunk@176422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/339493005

git-svn-id: svn://svn.chromium.org/blink/trunk@176421 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Media query evaluator assumes that device size cannot change, which is
wrong in emulation mode.

BUG=327641,386142

Review URL: https://codereview.chromium.org/308003007

git-svn-id: svn://svn.chromium.org/blink/trunk@176420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/340813002

git-svn-id: svn://svn.chromium.org/blink/trunk@176419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=384556
R=yurys

Review URL: https://codereview.chromium.org/347463006

git-svn-id: svn://svn.chromium.org/blink/trunk@176418 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik

Review URL: https://codereview.chromium.org/344583003

git-svn-id: svn://svn.chromium.org/blink/trunk@176417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removed m_stop and length comparison as they carry different units i.e. if there are two char text then m_stop will be 1 and length 2. As do not compare, needWordSpace does not set correct value.  

Also by default condition for needSpacing has been changed to true because if first character is space it was getting omitted. 

BUG=344873
R=leviw, eae
TEST=Word spacing in RTL with different segments handling.

Review URL: https://codereview.chromium.org/343443002

git-svn-id: svn://svn.chromium.org/blink/trunk@176416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaController::trace() needs to have the declaration of ExecutionContext
available, so as to determine what NeedsAdjustAndMark<> resolves to for
its (weak) ExecutionContext member.

R=haraken@chromium.org,zerny@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/344443008

git-svn-id: svn://svn.chromium.org/blink/trunk@176415 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This changes TimelineDetailsView to be a TabbedPane and lets us add
additional tabs for record types where we can show more details (e.g.
layer tree view or paint profiler). The old details remain in "default"
first tab. Also, for selected range stats, we now show range begin-end
as a part of details view, not in the header.

BUG=

Review URL: https://codereview.chromium.org/325313006

git-svn-id: svn://svn.chromium.org/blink/trunk@176414 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This switches trace events emitted from PlatformInstrumentation to use
trace event category consistent with the trace-based timeline.
Drive-by: fix category filter in TraceEventDispatcher.

BUG=361045

Review URL: https://codereview.chromium.org/337143002

git-svn-id: svn://svn.chromium.org/blink/trunk@176413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641
NOTRY=true
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/343563003

git-svn-id: svn://svn.chromium.org/blink/trunk@176412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're trying to make v8::TryCatch nestable.
In preparation for that, this CL adds ReThrow for nested trycatches.

BUG=362388

Review URL: https://codereview.chromium.org/313033002

git-svn-id: svn://svn.chromium.org/blink/trunk@176411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch updates owner document of Range objects when orphan Node object moved
to another document in new member function |Range::updateOwnerDocumentIfNeeded|.

Note: when we move non-null parent Node object to another document, it is done
by removeChild and appendChild and Range objects to reset to start of document.

The root cause of issue 350362 is boundary points of Range objects isn't
adjusted when owner document of Range and boundary points are different.

Because |Range::nodeChildrenChanged|, which adjusts boundary points for
|Node.appendChild|, is called for Range objects in another document which
isn't owner of Range.

This patch also updates "move-detached-child-in-range.html" to have right
value.

BUG=350362
TEST=LayoutTests/fast/dom/Range/range-extract-contents-after-move-to-another-document-crash.html
TEST=LayoutTests/fast/dom/move-detached-child-in-range.html

Review URL: https://codereview.chromium.org/332173003

git-svn-id: svn://svn.chromium.org/blink/trunk@176410 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641

Review URL: https://codereview.chromium.org/341483004

git-svn-id: svn://svn.chromium.org/blink/trunk@176409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/338993006

git-svn-id: svn://svn.chromium.org/blink/trunk@176408 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1) Remove more Backslash-as-JPY hacks (some encodings interpret backslash as yen
sign).

The code was added in https://bugs.webkit.org/show_bug.cgi?id=49714 (r73566).

The test used to be
editing/selection/find-yensign-and-backslash-with-japanese-fonts-expected.html

The feature was removed by https://codereview.chromium.org/27030014 (r159589),
but the removal was incomplete. This CL removes the leftover code and test
expectation files (the corresponding tests were removed by r159589).

2) Remove isJapaneseEncoding from TextEncodingRegistry.cpp; it was dead
code. There used to be bool TextEncoding::isJapanese() (see r16245) which was
used by WebCore/loader/Decoder.cpp... but TextEncoding::isJapanese no longer
exists, and isJapaneseEncoding appears not to be used any more.

BUG=
R=abarth@chromium.org, jshin@chromium.org

Review URL: https://codereview.chromium.org/335803002

git-svn-id: svn://svn.chromium.org/blink/trunk@176407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaQueryLists were re-evaluated for every styleResolverChanged(). The
evaluation of MediaQueryLists can only change when some media type or
features change. That is signalled through mediaQueryAffectingValueChanged().
Set m_evaluateMediaQueriesOnStyleRecalc there instead.

Since the media queries don't change this is not noticable through layout
or unit testing.

R=esprehn@chromium.org
BUG=382894

Review URL: https://codereview.chromium.org/322043008

git-svn-id: svn://svn.chromium.org/blink/trunk@176406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TimelineUIUtils now has two descendants:
- TracingTimelineUIUtils for tracing based timeline records
- TimelineUIUtilsImpl for timeline records based on Timeline agent events
This patch moves some of UI-specific getters from TimelineModel.Record into TimelineUIUtils instance methods. In the end we should have all ui logic that depends on particular backend details to be encapsulated in TimelineUIUtils instance.

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/344443007

git-svn-id: svn://svn.chromium.org/blink/trunk@176405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey, eustas, yurys

Review URL: https://codereview.chromium.org/344443003

git-svn-id: svn://svn.chromium.org/blink/trunk@176404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some modules, for example WebMIDI and WebCrypto, needs "Async Initializer".
The initializer should stay alive until the initialization succeeds (i.e. the
associated Promise is resolved), the initialization fails
(i.e. rejected), or the associated ExecutionContext is stopped.
This CL introduces the the constructor mode ScriptPromiseResolverWithContext.
If KeepAliveWhilePending is specified, the created resolver stays alive while
one of the above conditions meets.
Each initializer can stay alive by inheriting ScriptPromiseResolverWithContext.

This CL rewrites WebMIDI and WebCrypto async operations with it.

BUG=361041

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176381

Review URL: https://codereview.chromium.org/311733004

git-svn-id: svn://svn.chromium.org/blink/trunk@176403 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The crash was presumably caused by breakpointId handle being null because of exception in debugger. Generally debugger calls shouldn't throw but since some parts of it are implemented in JS there may be a stack overflow which would result in an exception and empty result handle.

BUG=381567

Review URL: https://codereview.chromium.org/341713008

git-svn-id: svn://svn.chromium.org/blink/trunk@176402 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As the WebSocket class handles suspend / resume, we can remove the suspend /
resume code from ThreadableWebSocketChannelClientWrapper.

BUG=384238
R=tyoshino

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176303

Review URL: https://codereview.chromium.org/333223002

git-svn-id: svn://svn.chromium.org/blink/trunk@176401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/337283004

git-svn-id: svn://svn.chromium.org/blink/trunk@176400 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a minor refactoring which moves the case of calculation
of cross-size of flex line for single line flex-container from
RenderFlexibleBox::repositionLogicalHeightDependentFlexItems
to RenderFlexibleBox::alignFlexLines which is more appropriate
and saves us from doing unnecessary work.  The old code was doing 
align-content for a single line, then reposition 
everything when aligning children.

Review URL: https://codereview.chromium.org/340513004

git-svn-id: svn://svn.chromium.org/blink/trunk@176399 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Static attributes are now supported by the base IDL parser, so these
overrides are no longer needed.

Followup to:
IDL parser: add StaticAttribute production
https://codereview.chromium.org/333853002/

...and prep for:
IDL parser: align with current Web IDL specification
https://codereview.chromium.org/329853005/

Review URL: https://codereview.chromium.org/336733002

git-svn-id: svn://svn.chromium.org/blink/trunk@176398 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- rename generatePopupContent.* to generateDetailsContent where appropriate;
- change generateDetailsContentForFrame to use TimelineDetailsContentHelper,
    thus removing redundant header;
- (drive-by) fix frame start time in case frames are built from trace events.

Review URL: https://codereview.chromium.org/341483005

git-svn-id: svn://svn.chromium.org/blink/trunk@176397 bbb929c8-8fbe-4397-9dbb-9b2b20218538

applyPropertyAll expands all shorthand property to longhand properties,
and apply each longhand property according to all's value (e.g. if
all's value is initial, initial).

Spec: http://dev.w3.org/csswg/css-cascade/#all-shorthand

BUG=172051
TEST=fast/css/all-shorthand.html

Review URL: https://codereview.chromium.org/339163002

git-svn-id: svn://svn.chromium.org/blink/trunk@176396 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The scrollbars does not paint as verticalScrollbarWidth() returns 0 in paint in case of overlay-scrollbars.
We should use actual scrollbar width while placing and painting the scrollbar.

BUG=385463

Review URL: https://codereview.chromium.org/337323002

git-svn-id: svn://svn.chromium.org/blink/trunk@176395 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Last user was removed with
http://src.chromium.org/viewvc/blink?view=revision&revision=171958

Review URL: https://codereview.chromium.org/341503002

git-svn-id: svn://svn.chromium.org/blink/trunk@176394 bbb929c8-8fbe-4397-9dbb-9b2b20218538