- 10 Sep, 2019 40 commits
-
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/sync. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=melandory@chromium.org Bug: 891670 Change-Id: I49d147d6d77c9f89f412d922de6f1a805c315419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786846 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695142}
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread when ServiceWorkerOnUI is enabled. This makes BrowsingDataServiceWorkerHelper aware of the core thread rather than assuming the IO thread. This enables unit_test "CannedBrowsingDataServiceWorkerHelperTest.*" to pass. Bug: 824858 Change-Id: I6c7e7db1bb0c5f7b9691fef51947304280ad3143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795528Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695141}
-
Adithya Srinivasan authored
Bug: 1002489 Change-Id: Ie9891d5924601429b4a966ea229a6b7c280a0ef4 Tbr: beaufort.francois@gmail.com No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795845Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#695140}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/audio. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=miu@chromium.org Bug: 891670 Change-Id: Ie208338463113dfc3e0542765156760b0aaaf6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786855 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#695139}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I83e8f73db520df8bb8e1d0b462afe70fd529df2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792956 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695138}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/01e97ae1b071..f7b1aa440dc0 git log 01e97ae1b071..f7b1aa440dc0 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 mbonadei@webrtc.org Fixing some typos. Created with: gclient setdep -r src/third_party/webrtc@f7b1aa440dc0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I0fdf8951ee03d4c00e2aa33673c178e28e39a06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795624Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695137}
-
Gabriel Charette authored
Backport some tests in /device/gamepad/public/cpp/gamepad_mojom_traits_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /device/gamepad/public/cpp/gamepad_mojom_traits_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=estark@chromium.org Bug: 891670 Change-Id: Ic5c828e2748caa0f834ac8a6dab5693e1394cb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787202 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695136}
-
Thomas Tangl authored
For each selectable profile a button is added to the profile menu. Screenshot: https://drive.google.com/file/d/1ovOWviTlbfqK2PVpMAJhUQehtmD7_J-R/view?usp=sharing Flag: profile-menu-revamp Bug: 995720 Change-Id: I7bbe82651523f092864f50ac36f099ece6405768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795444Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#695135}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/discardable_memory. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=penghuang@chromium.org Bug: 891670 Change-Id: I968828bdca2039cf3a1cd3a752cdcd69c36110c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786948 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#695134}
-
Martin Šrámek authored
...on Linux. It was previously already disabled on Android, now it's also flaky on Linux. TBR: guidou@chromium.org, olka@chromium.org Bug: 986602 Change-Id: I0c5278cbed764fd59fc433b3f62d5714c92bed07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795585Reviewed-by:
-
Camille Lamy authored
This CL removes the dependency on having a provisional DocumentLoader to execute the Unload event before its commit. This is a preparatory CL for removing the provisional DocumentLoader. This corresponds to the step 8k in the linked doc in the bug. Bug: 855189 Change-Id: I8e52cfb2932e751e4a51f50737b430b5b2ddc661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684998 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#695132}
-
Gabriel Charette authored
Backport some tests in /components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=melandory@chromium.org Bug: 891670 Change-Id: I46ee96d64d85db8fc4f320ef5a601d5bb7f42b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786806 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
-
François Doray authored
This reverts commit aa165da6. Reason for revert: The tests should no longer fail with the checks added in https://chromium-review.googlesource.com/c/chromium/src/+/1790331. Original change's description: > [Sheriff] Disable flaky test ProcessTests > > Disable ProcessTest.SetProcessBackgroundedSelf and > ProcessTest.SetProcessBackgrounded on Windows. > > Bug: 931721 > TBR=fdoray@chromium.org > > Change-Id: Ie5b2882c1d9d39ba5527d610c2a56223e01e74ed > Reviewed-on: https://chromium-review.googlesource.com/c/1470996 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#631862} TBR=rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 931721 Change-Id: Ia2017959c57a9acfb58bbb435a7c91154def29be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793527Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#695130}
-
Dave Tapuska authored
There were a number of doubly defined enumeration values. Move these to be enum classes so that they don't conflict with the values defined for the OPs themselves. BUG=794619 Change-Id: I0fbb3b02b7cc6bbb1dede3c5e5589525a4b5198a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775204 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#695129}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d0f1a86fea9..a47836e01af9 git log 2d0f1a86fea9..a47836e01af9 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/skia@a47836e01af9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I30923bfa7179301b17663ad2b332e8e88619cd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795623Reviewed-by:
-
Marc Treib authored
This adds/expands the tests to cover more "more changes" (between Sync-the-transport and Sync-the-feature). Most of the new changes aren't generally possible (i.e. aren't exposed in the UI so can't easily be triggered), but it's still best to properly cover them. Bug: 998455 Change-Id: I40477daba9f1f9f39604b1038802b193abe3ec33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795324Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#695127}
-
Stefano Sanfilippo authored
We follow the spec as it is right now, there is no need for TODOs and disabled tests. Bug: 940927 Change-Id: I32fffb519ce8e2cca8fe94389d9fa6d82da2c08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795322Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Auto-Submit: Stefano Sanfilippo <ssanfilippo@chromium.org> Cr-Commit-Position: refs/heads/master@{#695126}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/local_discovery. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=weili@chromium.org Bug: 891670 Change-Id: I2d20ba890d0416f9812b85efd87608ab7cb0ec26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786739 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695125}
-
Robbie Gibson authored
Bug: 1002088 Change-Id: I0cc2e56af84400470e34d992bd1af0d6539e81d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793167Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#695124}
-
David Bienvenu authored
This is the first step in registering Windows file associations for web apps, when a web app is installed whose manifest specifies that it can handle specific file extensions. Bug: 960245 Change-Id: I8a2c8932cb69af5caf7c79f11f7881fad0687b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788117Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695123}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/dbus. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 891670 Change-Id: I1f1909a3614aa8447654d5bb05f54cb8d7c3863d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786811 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695122}
-
Miyoung Shin authored
This CL converts DevicePtr and DeviceRequest in device to the new Mojo type, and uses pending_remote<Device> in adapter.mojom. Bug: 955171 Change-Id: I852ff06786de3fa189270fc9a6d777c67abd9d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788422 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695121}
-
Yutaka Hirano authored
I relied on ResourceLoadObserver::DidStartRequest but it is not called when the fetcher is detached. Move the logic into ResourceFetcher to fix that. Bug: 961614 Change-Id: I127ca847900b531558ed667a2e9865ced646823f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792209Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#695120}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0cd61b6e287c..01e97ae1b071 git log 0cd61b6e287c..01e97ae1b071 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 mbonadei@webrtc.org Move docs about native code development into a repo directory. 2019-09-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e25e7642..a87779d3 (694813:695071) 2019-09-10 mbonadei@webrtc.org Add placeholder target to move rtc_error out of the main API target. 2019-09-10 gustaf@webrtc.org AEC3: Downmix multichannel signals before delay estimation 2019-09-10 srte@webrtc.org Adds peer scenario connection interface. Created with: gclient setdep -r src/third_party/webrtc@01e97ae1b071 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Ica1b57e1b6a49cdb62ff1a36e5320d37d8ddc84e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795482Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 1001014 Change-Id: Ib07c934eccc2f89f89ca57f4fb35f05025006d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787418 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#695118}
-
Stepan Khapugin authored
Creates SceneActivityState enum to list possible scene states and makes the scene delegate create and update the scene state. Bug: none Change-Id: I45932fefcff42828a761b6d4d53fc1c034a3102e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789524 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This is phase 3.7 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ CL moves filtering_network_manager.cc|h|test from content/renderer/p2p to Blink. It places the header temporarily in Blink's exposed API. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I1dbe602fc0dc8620fdd84acc961d2c3b5dd7fe14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792856 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#695116}
-
Ramin Halavati authored
kEnableFilesystemInIncognito has been set to True by default since M76. Removing the flag and all code paths based on it's False value. Bug: 93417 Change-Id: I54f763148ff022ebcc478697e1909d6e86669fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787601Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#695115}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/add85d2b6cb6..9d28be075d5f Created with: gclient setdep -r src-internal@9d28be075d5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9665e86c9bd073b8f6299273732cc81a6f12626f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795563Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695114}
-
Denis Solonkov authored
This change implements first step of the compression script: compressing specified range and appending it to the library as a new section. At this point the new section is not loaded into memory. Bug: 998082 Change-Id: Ifdba4ef47f9698abaf5d2df2d8b07535e6ac7bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776045 Commit-Queue: Denis Solonkov <solonkovda@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695113}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9e5c47936b17..2d0f1a86fea9 git log 9e5c47936b17..2d0f1a86fea9 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 benjaminwagner@google.com [infra] Switch Mac builders to 10.14.6. Created with: gclient setdep -r src/third_party/skia@2d0f1a86fea9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I846b32bf4070bc611c15e30494d402e81d261bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795562Reviewed-by:
-
Antonio Gomes authored
This CL corresponds to phase 3.6 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I9925a69727b19631188f21671ae41e12982c0517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792849 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/unified_consent. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=tangltom@chromium.org Bug: 891670 Change-Id: I34de3ff3201c5cac61dd42f55497f92de4d63017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786823 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#695110}
-
Eric Willigers authored
offset-distance is a computed length-percentage. offset-anchor and offset-position are each a computed position (i.e. a pair of computed length-percentage). offset-path has absolute path commands. https://drafts.fxtf.org/motion-1/#property-index Change-Id: Ic63904ec78c09214a9feb5ff02d6f6f43ae8d420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794943Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#695109}
-
Anton Bikineev authored
This enforces that classes are either a. trivially destructible b. have a non-virtual dtor but are marked final c. have a virtual dtor Bug: 990913 Change-Id: Ie4e26b48b8b5d34087f000d86b77673679cc39fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792867 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
This patch adds entries to ignore some expected text diffs related to the fetch-request-xhr.https.html test. Change-Id: Ibde5f2989ece2535621d27167b407b6a3e908eb1 tbr: yhirano@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795525Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695107}
-
Vladislav Kuzkokov authored
Make CupsPrinter API fetch destination info as needed. This cuts time to get printer capabilities approximately in half. Bug: 996816 Change-Id: I8f06671b1ff3d28dda961fc6547886e5ee36a155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784725Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#695106}
-
Alex Clarke authored
We want to prioritize loading and compositing tasks until first contentful paint. This breaks video-poster-load-after-playing.html because that (introduces?) a race between blink::HTMLVideoElement::SetDisplayMode which sets displaymode kPoster and blink::LayoutVideo::ImageChanged() posted on frame_loading_tq which only caches the image size if the display mode is kPoster. When loading tasks are prioritized this doesn't happen causing the image to get stretched. This patch changes the code to additionally cache the image size if it's not set, which fixes the problem with the test with the new scheduler policy. Bug: 971191 Change-Id: Ic72d310c99d747258e7523fc069758538b35a337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787602 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695105}
-
Antonio Gomes authored
These are phases 3.4 and 3.5 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ The CL moves both classes together for simplicity and because one depends on another. In a secondary step, they will be moved out of the Blink exposed API. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Icd9bd32d860613db933dd19b2b88ee2ad16d5d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792846 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chrome://settings/passwordsMarc Treib authored
This requires making PasswordManagerPresenter multi-store-aware (which is actually pretty straightforward). For now, passwords from the two stores are not differentiated at all in settings; they just show up together in the same list. Bug: 1002063 Change-Id: I24faa431f73eb79c1f829889d8cd2c7f29552ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789296Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#695103}
-
