- 30 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/42f885238114..7e2cba6a5241 git log 42f885238114..7e2cba6a5241 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 bclayton@google.com utils/vscode: Change assembly file ext to .spvasm (#2995) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7e2cba6a5241 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: I41699d57e9c4f17699a9bc89ba7a8063731aff3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889670Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710739}
-
Hirokazu Honda authored
This reverts commit ac6f2444. Reason for revert: This CL breaks HW decoder on hana. Original change's description: > media/gpu/v4l2: Check request support in queue. > > The queue's support is currently checked in the video decoder but the > queue should be responsible to check whether it does support requests or not. > This patch moves the check for the request support to the V4L2Queue > constructor. > > BUG=chromium:1009921 > TEST=ran tast with video.DecodeAccelVDVP8ResolutionSwitch on veyron_minnie-kernelnext. > TEST=ran tast with video.DecodeAccelVDH264ResolutionSwitch on veyron_minnie-kernelnext. > TEST=ran tast with video.DecodeAccelVDVP8 on veyron_minnie-kernelnext. > TEST=ran tast with video.DecodeAccelVDH264 on veyron_minnie-kernelnext. > TEST=ran tast with video.DecodeAccelVDVP8ResolutionSwitch on veyron_minnie. > TEST=ran tast with video.DecodeAccelVDH264ResolutionSwitch on veyron_minnie. > TEST=ran tast with video.DecodeAccelVDVP8 on veyron_minnie. > TEST=ran tast with video.DecodeAccelVDH264 on veyron_minnie. > > Signed-off-by: Francois Buergisser <fbuergisser@chromium.org> > Change-Id: Icdceab06d3b263d0ce68993b3ee753bd650706dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880208 > Commit-Queue: Alexandre Courbot <acourbot@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709376} TBR=acourbot@chromium.org,fbuergisser@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1009921 Change-Id: Ib3cf55aa900296f882372d4cf092e947115859e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890190Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710738}
-
Arthur Hemery authored
Modified some content_unittest expectations to work with BackForwardCache enabled. Change-Id: Ia754e152a557a13acc25182791626d45e2e7913f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880044Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#710737}
-
Kamila Hasanbega authored
Revert "Reenable PromptForXHRWithoutOnSubmit and PromptForFetchWithNewPasswordsWithoutOnSubmit tests" This reverts commit 557416cf. Reason for revert: The tests started to fail here https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/30656?blamelist=1#blamelist-tab Original change's description: > Reenable PromptForXHRWithoutOnSubmit and PromptForFetchWithNewPasswordsWithoutOnSubmit tests > > The two probable reasons for the flakiness were: > - we didn't wait until the keystrokes were processed in the renderer. See > crbug.com/955455 > - we don't wait for the password store returning some results after navigation. > > Both are fixed in the CL. Let's observe the pass rate. > > Bug: 1013743 > Change-Id: Ic328afbe2cd652119a773c28d49ff450cf0d5405 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879237 > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709464} TBR=battre@chromium.org,vasilii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013743 Change-Id: Iee2265f768e89fb112157645c1fadd715c35fb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890051Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#710736}
-
Kamila authored
Change-Id: Ie023a5d635de0c976033d7f510a2a0f7bb9ca72e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890330Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#710735}
-
Rohit Rao authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/498c7945364e..ff524fb64625 $ git log 498c79453..ff524fb64 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 rohitrao UIWebView deprecation. Created with: roll-dep src/ios/third_party/earl_grey/src BUG=None Change-Id: I75e3ad30e3d9ff6534fe8ebc4d1a0b17bb9670f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888101 Auto-Submit: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#710734}
-
Marc Treib authored
Updating comments, removing some unused members and some typedefs that are only used a single time. Bug: none Change-Id: Icc7f37f9f0d8d9d7f707a5db6955726d0668b41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889653Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#710733}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/a2ca5d5c44..df0ca90392 TBR=aerotwist@chromium.org Change-Id: I3db2bf865e867523e5c883a9eb9129e70dd5f45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888671Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#710732}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/87a7b82520b8..470b2d5144a3 git log 87a7b82520b8..470b2d5144a3 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 mbonadei@webrtc.org Stop relying on GN's sources_assignment_filter. 2019-10-29 peah@webrtc.org AEC3: Adding a configurable render signal gain Created with: gclient setdep -r src/third_party/webrtc@470b2d5144a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Id42251ea9dda7b6ea3f6bc563aa5b38634b842c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889810Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710731}
-
Mikel Astiz authored
We've wondered why some tests failed flakily instead of failing deterministically due to blocking operations not being allowed in the UI thread. One explanation is the FakeServer's direct use of base::ThreadRestrictions::SetIOAllowed(), which doesn't revert the allowing of IO. This has the side effect that it would hide any misuse of blocking IO operations in sync integration tests. This patch fixes one remaining test surfaced as part of this work. Bug: 1004312,1009372 Change-Id: Id8e57485860873e78093c18069935a646514a469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883630 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#710730}
-
Elad Alon authored
Bug: None Change-Id: I8bed811ba52e7ecf0dd772c0222bc57d8b99f46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886821Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#710729}
-
Henrique Ferreiro authored
Bug: 919392 Change-Id: I3a90a95ebb307d812ac7cd80348853d061b74302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886681Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#710728}
-
Bruce Dawson authored
Using the system clipboard for tests causes race conditions (it's a shared resource), means that tests pollute global state, and causes tests to fail on Windows if the workstation is locked (opening the clipboard fails in that case). So, using the TestClipboard is important. This was tested by running this command: unit_tests --gtest_filter=SharedClipboardMessageHandlerTest* Before the clipboard contents were perturbed. After, they were not. Bug: 996325 Change-Id: Idec21ce709463bcd9c70d7d25f1a6bc851170ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881988 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#710727}
-
Javier Ernesto Flores Robles authored
This is a reland of 959cddb1 The failing test has been fixed. Original change's description: > [iOS][MF][EG2] Migrate keyboard observer test > > Remove deprecate test that would require new code to be migrated. > Update and enable keyboard disappear test. > Create app interface to interact with a shared instance of the observer > in the app. > Remove OCMock usage in the test. > > TBR=eugenebut@chromium.org > > Change-Id: Iaa5384f241e63b95ee516d4666b2e2adf65b7da6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881566 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709939} TBR=eugenebut@chromium.org Bug: 1018715 Change-Id: I64b81585275d799ab3bf7d325af5ef5d6000f6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886331 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#710726}
-
Jan Wilken Dörrie authored
In order to prepare for the switch of the return value of Value::GetList() from Value::ListStorage& to span<Value> this change adds an Insert API to Value, allowing callers to insert Values at arbitrary positiions in the list. The signature of the API is inspired by std::vector::insert, taking a insertion position and a Value, and returning an iterator pointing to the just inserted element. Bug: 646113 Change-Id: Ibacc9e1c22ee60b6f35661b66de951746e978b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887694 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#710725}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e1cda3916cee..c47ee16c44c1 git log e1cda3916cee..c47ee16c44c1 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 digit@google.com Vulkan headers: restore vulkan_fuchsia_extras.h include. Created with: gclient setdep -r src/third_party/swiftshader@c47ee16c44c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:143197472 Change-Id: If64b0440982cadc107e7675d1e60ead2341b4f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889674Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710724}
-
Marian Fechete authored
This CL removes the hard-coded fields from the Fallback data for credit card and address. Instead, a map is used, and the required fields can now be specified by their enum values. This allows us to remove the callback for the field getters and retrieve the fallback values directly from the map. Bug: b/141362833 Change-Id: I6cd8f7371557d096f82921d0bb8a21527c33e9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886820 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#710723}
-
Rune Lillesveen authored
Missing clampTo<float> in ComputeEndPoint() caused DCHECK failures. Bug: 1009307 Change-Id: Ic524e358b7ba94e5b77ffca94128762a08395172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879454Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#710722}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/80c3ae49..46994599 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9aadb04f66b6f10400368ff7eb85f5a9846898ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889015Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710721}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bb35bb4e5379..07be79e14506 git log bb35bb4e5379..07be79e14506 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader f8f6103eb89f..e1cda3916cee (2 commits) Created with: gclient setdep -r src/third_party/angle@07be79e14506 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I44a47b0445c023aa335ba5af95a0fe580fae1235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889673Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710720}
-
Kamila Hasanbega authored
This reverts commit 10d377be. Reason for revert: Speculative revert for webview_instrumentation_test_apk failing on https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI/6755?blamelist=1#blamelist-tab Original change's description: > printing: Mojofy PrintMsg_* in PrintViewManagerBase > > Replace PrintMsg_PrintingDone, PrintMsg_PrintPages, and > PrintMsg_SetPrintingEnabled IPC messages with new Mojo methods. Update > AwPrintManager and HeadlessPrintManager to also use these new methods. > > Bug: 1008939 > Test: Print a webpage and PDF > Change-Id: I3a403dd47ffc9c4debe819d26b00eccbd24b1180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876473 > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710576} TBR=sky@chromium.org,dcheng@chromium.org,thestig@chromium.org,changwan@chromium.org,jschettler@chromium.org Change-Id: Id6c6676aafab9e6abeb8d99bc18613a6ba5a2c60 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1008939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890070Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#710719}
-
Arthur Sonzogni authored
This reverts commit 4ddc16ab. Reason for revert: https://crbug.com/1019628 android_webview_unittests test suite can't run anymore. Error message: ~~~ [FATAL:test_suite.cc(197)] Check failed: base::PlatformThread::GetCurrentThreadPriority() == base::ThreadPriority::NORMAL (2 vs. 1) ~~~ Original change's description: > [base] Ensure that tests don't change the thread priority (reland #2). > > This is a reland of https://crrev.com/c/chromium/src/+/1865405 > The difference is that we don't check thread priority in > angle_unittest, as these tests change the thread priority on > purpose. > > This CL verifies that the thread priority is normal when a test process > is launched and before/after each test. The goal is to avoid having > tests that assume they run at normal priority be disabled because of > other misbehaving tests (e.g. https://crbug.com/931706). > > TBR=sky@chromium.org,michaelpg@chromium.org,thakis@chromium.org,eseckler@chromium.org > > Bug: 931706 > Change-Id: I8fb2230cbb9b9203884d1c440696d4ce2968dcaf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881707 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710326} TBR=sky@chromium.org,thakis@chromium.org,fdoray@chromium.org,zmo@chromium.org,michaelpg@chromium.org,eseckler@chromium.org Change-Id: I0b87cd77850ac928ae2d98fd31c8df01ec5ae1f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931706, 1019628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890030Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#710718}
-
Arthur Sonzogni authored
This reverts commit 26aa61db. Reason for revert: From bug https://crbug.com/1019618 Error message: ~~~ File "/b/s/w/ir/cache/builder/src/tools/binary_size/libsupersize/archive.py", line 1679, in _CountRelocationsFromElf relocations = re.search('RELCOUNT\s*(.+)', stdout).group(1) AttributeError: 'NoneType' object has no attribute 'group' ~~~ This is very likely caused by this CL. It prevents building the Clank Official binaries, so reverting it speculatively Original change's description: > Add number of native relocations to .size file metadata > > In furtherance of possibly putting a limit on additional native relocations > added to the binary. A count of native relocations is now included in the > metadata of the .size file. > > Bug: 1012373 > Change-Id: Id3b4aa17d920f20435edffa5cda9ab8c0a309ade > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879504 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709716} TBR=agrieve@chromium.org,mheikal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1012373 Change-Id: I39638201732b09a2228ba9c0fc4050f75d38934c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888934Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#710717}
-
Richard Knoll authored
After Chrome UI implementation review we decided that the origin looks better in the footer. This CL moves it there. We can also drop the scheme from the origin as it does not add value here. Before: https://imgur.com/EdtdTB3 After: https://imgur.com/PSIfHmz Bug: 1019323 Change-Id: I8c17372fba5ec6e6eed6aa666bd779aa6b31afde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887792Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710716}
-
Himanshu Jaju authored
Moves callbacks run on receiving ResponseMessage to a new class. This will be useful for p2p connection changes. Upcoming patch will move logic from SharingService to SharingFCMSender, so now PeerConnectionManager (in the future) can avoid dependency on SharingService for signalling messages. Bug: 1018274 Change-Id: I39ebfe0ef1862b6caa8a0c387e92ff0da797b1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882320Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#710715}
-
Vasilii Sukhanov authored
The reason for flakiness of EditableComboboxTest on Mac was the 'focus lost' event coming from the OS. It happens due to multiple tests running and creating windows simultaneously. On Mac ScopedFakeNSWindowFocus tries to mock the focus logic of the OS. However, when the window really loses focus, the test gets 'resignKeyWindow' message and it can make the test fail. The CL consumes that message. As checked locally, EditableComboboxTest isn't flaky anymore. Bug: 965601 Change-Id: I1695e466a74da1508f1c54d1697ae6b8e6546c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879292Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710714}
-
Chih-Yu Huang authored
Originally when changing resolution, V4L2SVDA just abondoned the surfaces at the image processor. This CL changes V4L2SVDA wait for image processor flushed all surface before changing resolution. Bug: b:143263138 Test: Run video_decode_accelerator_tests on kukui Test: Pass CTS mentioned at issue on kukui Change-Id: I5fb4dc164ba9b1d25a78694e706afdfd7d2acd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888866 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710713}
-
Manas Verma authored
Logging the number of times the opt-in promo is shown, and logging the user's decision. Bug: 949269 Change-Id: I18b01686a877c86199de5bf6248c04ad959e7433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867709 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#710712}
-
Sigurd Schneider authored
This test was not flaking because V8 forced a GC to suppress non-deterministm. Temporarily disabling to fix the issue. Bug: chromium:1019613 Change-Id: If0b4e8bbc135cd815e9f8a6765098cfa57a8eb96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889651Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#710711}
-
Ramin Halavati authored
The hard limit for incognito quota is removed and the quota is dynamically set based on a Finch controllable ratio of the amount of physical memory. Bug: 1017120 Change-Id: I218295f661a9080b61bfd0e1487f58678e3bfe1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878190 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#710710}
-
Koji Ishii authored
Following bot results are included. 87 88 89 95 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iccc444f5cba4ad8414697de0042fb59b13232ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888231Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710709}
-
Koji Ishii authored
This patch adds |NGInlineCursor::CursorForDescendants()|, which returns an |NGInlineCursor| that traverses descendants of the current item. This is needed to compute ink overflow of an inline box (WIP: crrev.com/c/1771360), but is likely to be needed in some other places too. Bug: 982194 Change-Id: I3432b3b73580f5b63591c7fc52c35e4b7e3576f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888868Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710708}
-
Rakina Zata Amni authored
We don't need them, and they're also causing failures in the bfcache bot. Change-Id: I60ed51a01efd0938192969d9cf116915f01df70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886071Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#710707}
-
Jacobo Aragunde Pérez authored
OzonePlatformScenic used to own a mojom::ScenicGpuHostPtr, but it was actually only used to initialize other objects. Instead, we moved ownership of this object to ScenicSurfaceFactory. Bug: 955171 Change-Id: Iad1bd211e543c663faab050b488578311a0b232a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886616Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#710706}
-
Takashi Sakamoto authored
Bug: 1007769 Change-Id: I8b864634100fecbb9cfd6ba9a97dd035c1e6da61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883472Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#710705}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/51a8c8c56e15..00bd42717766 git log 51a8c8c56e15..00bd42717766 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 perezju@chromium.org [Telemetry] Stop collecting legacy values in results object Created with: gclient setdep -r src/third_party/catapult@00bd42717766 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:992427 Change-Id: I9e94f072fd2442c118e5dde4bce0a5a45b39f20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710704}
-
Sergio Villar Senin authored
In order to remove the dependency, the web_media_player_action.h file was moved to public/common/media. Since the file is no longer in the public/web directory we are also renaming it to media_player_action.h (and the struct defined in that file to MediaPlayerAction). Bug: 1008303 Change-Id: Ic1a07733acf9e550b1fad717b891f81de16677a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884672Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#710703}
-
Austin Tankiang authored
When there is a forced directory change (e.g. through unplugging a usb), if the gear menu is currently open, the menu items do not update their status with the new directory. This can cause, for example, the 'Format device' item to still be active. This change forces an update on directory change. Modify the formatDialogGearMenu test to test this behaviour too. Bug: 1007566 Change-Id: I8158a2630e6711fb9b8e371faf7f689325043cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859810 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#710702}
-
Fredrik Söderquist authored
'to' animation is sufficiently special that we may as well treat separately altogether. Sink that part of the check out and clean up code using IsAccumulated(). Bug: 1017723, 231517 Change-Id: I27c63a423fa3ac24896bd4cf8f15f5aa101c4499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886813 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#710701}
-
Tom Tan authored
The instruction 'BRK #F000' does trap on Windows ARM64 which is different from other ARM64 platforms. Calling __debugbreak() which will produce the right encoding and always supported by MSVC and clang. Bug: 893460 Change-Id: I54e2d8de6ae7d9ba5929dc8e382e18a99d5aaeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879677Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#710700}
-