- 22 Nov, 2020 11 commits
-
-
Minju Kim authored
When UseNativeFrame is enabled, sets server-side decoration mode to wayland compositor. Currently, UseNativeFrame is enabled when browser type is not normal (popup, devtools) In this CL, 1. Implement SetUseNativeFrame / ShouldUseNativeFrame 2. Set the toplevel surface decoration mode according to use_native_frame When use_native_frame is true, sets a server-side decoration and a client-side decoration otherwise. 3. If xdg-decoration protocol extension is not supported, ShouldUseNativeFrame returns false even if use_native_frame is enabled. Test: Verified popup, devtools, and task manager have their own frame decorations on KDE Plasma, Sway that implement xdg-decoration protocol extension. Bug: 1127917 Change-Id: I08b6df1a3f04a30745bdf3f64ee6935b38ab5fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535896 Commit-Queue: MINJU KIM <mkim@igalia.com> Reviewed-by:Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#830023}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4efc2d3026a6..c26d663607fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I0bb8e38fbbf952659d9d9814dfadc75ec45c5c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553665Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830022}
-
Andres Medina authored
recently protobuf added a deprecated annotation to C++ code to warn when depreacated protobuf fields are in use. To allow continue use of deprecated fields in C++, a compiler exception was added. This turned out to be pretty widespread. Will disable for now protobuf deprecated warnings and remove the extra GN config so that the exception doesn't need to be present. Bug: 1151621 Change-Id: I9216c94079f90231f2cea81d9f46b6a39b0037fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553387 Commit-Queue: Andres Medina <medinaandres@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Andres Medina <medinaandres@chromium.org> Cr-Commit-Position: refs/heads/master@{#830021}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55067f5fc677..d9cd96b8c9cb 2020-11-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I25f34d73f736ef57d23b7baa2f1ffe09325dc397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552460Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830020}
-
Miyoung Shin authored
This CL is a part of moving mojom::FrameHost::UpdateState to blink, and moves |current_history_item_| in RenderFrameImpl to WebLocalFrame in blink, and removes plumbing HistoryItem from DocumentLoader to RenderFrameImpl, instead, the current history item is updated directly gotten from DocumentLoader. Bug: 1110246 Change-Id: I29b6c8deab6ca0c71b624fbf541491d6f0eb3628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536655Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#830019}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ied63be5387473db03949d87e8dd5b60d28767173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552977Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830018}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605981377-d6d90ccc8fce0ecedb98ee3072085cf579cbfc85.profdata to chrome-linux-master-1606002382-5ec7cdeb7885eb20b0c788a679a646f5259a6aab.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6666708cc481e958e5278d1b82f9d9bbbfe51504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553658Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605981377-acb174128f01fb74f1038a735f0fcec3621833c5.profdata to chrome-mac-master-1606002382-ffb6d8b980c2a7dd14be2223fb34da30cf3882df.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6da98d3607909a6be3f524a87f223eceea868198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553656Reviewed-by:
-
Peter Kasting authored
Bug: 1103086 AX-Relnotes: n/a. TBR: pinkerton Change-Id: I3b241eb7234727f314dd85d1bdbb3a41ceca5938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522860Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#830015}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I369cb54ffb49941e8b6a3e5c7d2a67e538104ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553478Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b29b40c61550..4efc2d3026a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I56d68821652558bbdd43db6e223ea71340b7446d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553479Reviewed-by:
-
- 21 Nov, 2020 29 commits
-
-
Clark DuVall authored
This reverts commit 86c3def7. Reason for revert: Possibly causing official bot build failure: crbug.com/1151664. Original change's description: > Add synthetic field trial for isolated splits > > This should make analysis easier for a binary experiment, since the > Finch dashboard can be used. > > Bug: 1150162 > Change-Id: Id90204398234938c441982d5c2bc5c6f7c63d575 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545874 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829494} TBR=mpearson@chromium.org,yfriedman@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1150162, 1151664 Change-Id: Ic70c9f7c0b3d9963d837040e23eddd6ac802bc03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553016Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#830012}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605947060-183d4d27205b63d3a90a6c8009c5994a08afd33f.profdata to chrome-win64-master-1605981377-9f9d5e108d8c2103433ae16a21c997ac6a5bf12c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If443f0342428999359a4305c1a45c9461efd72e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553523Reviewed-by:
-
Stephan Hartmann authored
Change-Id: I4400ac7c6004b49ec6e72c44f2754e2166642f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552586Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#830010}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ddb67f0b589..b29b40c61550 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1151643 Tbr: Change-Id: I95df586afb7a825a4755bf49bd5b375240b3f5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553473Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ib592be4f33d1dd912398cd4dddb51b928d59333c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553014Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830008}
-
David Maunder authored
The Product/UX requirements are: - Don't show price drops less than $2 or 10% - Don't show price drops longer than 1 week - Round to the nearest dollar for >= $10, show cents otherwise Bug: 1151146 Change-Id: I21f13199c4bd878b00a837ae74b472e6f500d2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551264 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#830007}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605954987-d4a60645e0ddc52fe486546ec89cf423ef760bbb.profdata to chrome-linux-master-1605981377-d6d90ccc8fce0ecedb98ee3072085cf579cbfc85.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ieeab44b3c948dd99e7382096ed08ae8ffd7998e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553472Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie4b66fcda58e464986edbd0e631c4a11bd75979a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553044Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830005}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605954987-219412fcdfee75b43cde24956a9c9d16d7791952.profdata to chrome-mac-master-1605981377-acb174128f01fb74f1038a735f0fcec3621833c5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1877724e404d30d7fba4318e140b74acad1177de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553469Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff63548cda40..8ddb67f0b589 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I01fc620e63ef5ecc057720564ac1a3f016e14d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553501Reviewed-by:
-
Alison Maher authored
After looking into invalidation for the -internal-forced-color property, I noticed other issues with invalidation in forced colors mode that get fixed in this CL. 1) Set the default for -internal-forced-background-color to StyleColor(CSSValueID::Canvas), similar to how the color property was handled. 2) The viewport background color sometimes would not get updated to the right color in StyleEngine depending on if ColorSchemeChanged() was called (for a different reason other than forced colors mode) before PlatformColorsChanged() was called. To fix this, update the viewport background color as part of PlatformColorsChanged() instead of as a part of ColorSchemeChanged(). 3) We also need to invalidate paint whenever the system colors change (which will also invalidate paint whenever forced colors mode changes). Bug: 970285 Change-Id: Idcf192897c86aa16aa934b7ccea9cd8a32dec591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536799 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#830002}
-
Dominic Farolino authored
This reverts commit ae499b4e. Reason for revert: We have plenty of crash reports to analyze now Original change's description: > Prefetch: Use CrashKeys instead of aliased stack variables for DumpWithoutCrashing > > Bug: 1132770 > Change-Id: Ie6d881707594ddae9a5ff12f9e5a373e89114db7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550585 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Commit-Queue: Dominic Farolino <dom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829343} TBR=csharrison@chromium.org,dom@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1132770 Change-Id: Ie1b85b29d4f429f3d2225f2a38f93079035afe37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553253Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#830001}
-
Toni Barzic authored
Handles null multiuser window manager in MoveWindowToCurrentDesktop. MoveWindowToCurrentDesktop may get called before the multi-user window manager instance is created (when the session state changes to active). For example when launching help app during first user run (after CL:2532143). BUG=b/173792145 Change-Id: I018d4ba614a7991ced0a8018c374908c445932ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553247Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#830000}
-
Alison Maher authored
According to the spec, box-shadow, text-shadow, and image should continue to be forced at computed-value time. This change moves the logic for forcing these values from StyleCascade to StyleAdjuster. Bug: 970285 Change-Id: I5d32863f1d8e943e23667dc8bb1f6b227d2d4773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533697 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#829999}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/41b3f9c1e4aa..546a7c98c897 2020-11-21 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 7f075c2a88c0 to 4c13659a2a39 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I9f5122bfb62cc06438cd13dfd18164fe1c4777f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551471Reviewed-by:
-
Josh Nohle authored
* Track the result of Nearby Share starting a bandwidth upgrade via the Nearby Connections library. This metric only records the result of initiating the change not the result of fully finishing an upgrade. Also, this metric does not capture automatic bandwidth upgrades initiated internally by the Nearby Connections library. Note: This is currently only emitted for receive flows because UpgradeBandwith() is only invoked for incoming connections. * Track the data transfer medium that the Nearby Connections library successfully switches to during a Nearby Share transfer. Manually tested for send and receive flows with successful and unsuccessful WebRTC upgrades. Bug: 1105579 Change-Id: I11fc1f4d05c60645818d5a8f8c60c120f72f438f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542462Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#829997}
-
Alison Maher authored
Forced colors should now happen at used value time. This change adds two internal properties to store the forced colors values of color and -internal-visited-color. These internal values are then applied to the visited/unvisited color at used value time when appropriate. In addition to color, we also needed to force the used/visited color value of -webkit-text-fill-color and -webkit-text-stroke-color. These are forced to currentColor to match the color properties. This ensures that text color is properly forced in forced colors mode. Note: This change will result in some functional differences with the how colors are inherited in forced colors mode. The related web tests have been updated to reflect this change in behavior. Bug: 970285 Change-Id: I8858077397419edc18e89c2b2817788ef42e904b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529950 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Alex Keng <shihken@microsoft.com> Cr-Commit-Position: refs/heads/master@{#829996}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff55951b0714..ff63548cda40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Id2f4eca44a6f629358b0caa5b3d227ccec30ada9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553099Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011210600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/2f1-xfFwpHJRJ1-KO5Wrl1_wZTEEcpeA1cErK0nusM0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ie76a31d765f7cfbde43f77bc5004b5dd02208c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553097Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605905851-000df8c5d9233d8cd72a75f96d63436b1fbb2537.profdata to chrome-win64-master-1605947060-183d4d27205b63d3a90a6c8009c5994a08afd33f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icc6183e49d55af76f484f4bbacf7b8a70f7ed05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553090Reviewed-by:
-
Fergal Daly authored
Add a dummy ExecJs at the end to ensure the crashing renderer is reliably caught. E.g. https://crrev.com/c/2551883/5 is just rebased onto this CL and is now (correctly) failing. Also convert ExecuteScript to ExecJs which is the preferred helper. Bug: 1148793,1111191 Change-Id: Ie70a49678a418d3c400d5a8394cf3e3fb1972b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550330 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#829992}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605938293-d0094673cff9061368c7d398071897c24cf0b757.profdata to chrome-mac-master-1605954987-219412fcdfee75b43cde24956a9c9d16d7791952.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iab8a3f1e9b68544b92d89ef262bce58688811986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553095 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605938293-31eb6c6115dde673481dc80b9e3d062ea1588481.profdata to chrome-linux-master-1605954987-d4a60645e0ddc52fe486546ec89cf423ef760bbb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idebc2eca702ade83e7c1119f39d74e868bdb1b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553094Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d90024d49829..ee40ec6dd679 2020-11-21 mtklein@google.com remove Op::pack If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: I2dcc6391ffbb7585fdc49c7b420f5520dfdfe585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552456Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7286fc67501c..ff55951b0714 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: If78c77373b28193678c333cc37acab30a544f5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553093Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I428adacce9e0b9bcbe7fa0ed7bc78cdc35b9bc11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553087Reviewed-by:
-
Nancy Wang authored
If the app icon has the pause or block badge, announce 'Paused' or 'Blocked' for Chrome Vox, when the icon item is selected/focused from shelf. Add the AppStatus to ShelfItem to record whether the app is paused or blocked, to announce 'blocked' or 'paused' when the shelf item is focused. Example: 'Gmail button. Blocked' / 'Gmail button. Paused'. Block badge has higher priority. When the app is paused and blocked, set the block badge, and announce 'Blocked'. Add test cases to verify the change, including the priority for the block and pause status. BUG=1144384 Change-Id: I8a849dae570152634d2f1c2767f37848e8ead474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550104 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#829986}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/446db4b07be8..7286fc67501c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I173dca07c938da44c9de8a85016b905a6e02f517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553088Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id550de419833dac59ec11b75cc4ce33db9e1112c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553011Reviewed-by:
-
