GitLab

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c9886cc22e82..132b4bab67e1

2020-09-02 tvanderlippe@chromium.org Migrate lighthouse to devtools_entrypoint
2020-09-02 jacktfranklin@chromium.org Move legacy css copy_to_gen to each subfolder
2020-09-02 tvanderlippe@chromium.org Migrate media to devtools_entrypoint
2020-09-02 tvanderlippe@chromium.org Migrate browser_debugger to devtools_entrypoint
2020-09-02 szuend@chromium.org [ts] Type-check sdk/RemoteObject.js with TypeScript

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1101738
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I47d757c1269344323168697893e222f40bf19ba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390984Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803919}

Fixed bug where home to overview nudge was not being hidden when
transitioning to overview mode. Fixed bug where
use_in_app_shelf_in_overview_ was not reset when ending overview mode.

Bug: 1123553
Change-Id: I8d00c0c685793d74ce5f813ebf3b2c8de1d7a88d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385897Reviewed-by: Xiyuan Slow <xiyuan@chromium.org>
Reviewed-by: Yulun Wu <yulunwu@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803918}

This is already checked on the browser side and should never be sent to
the renderer.

Bug: 1117282
Change-Id: Ic3a5f1501a8961e5b07c6a975979bae7ec9345f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389232Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803917}

This is gated by omnibox::kOmniboxTrendingZeroPrefixSuggestionsOnNTP

With the change the platform-specific defaults for signed-out users will
change as follows:

- Desktop: no request -> remote suggestions.
- Android: Most Visited -> remote suggestions.
- iOS: N/A. Continues to request Most Visited.

Bug: 1122669
Change-Id: I5b226c7d5d56912a93f3d6ac4b1e295e7c50e07b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388157Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803916}

This is a reland of 2cb2db95

Original change's description:
> Reland "PSM: Support PSM RLWE based message definitions in Chromium"
>
> This reverts commit 6e670242.
>
> Reason for reland: shell-encryption tests were failing for Win and Android, see: crbug.com/1124018. Then all tests have been disabled for all platforms except for ChromeOS, until the problem being solved from the upstream, then being rolled into Chromium.
>
> Original change's description:
> > Revert "PSM: Support PSM RLWE based message definitions in Chromium"
> >
> > This reverts commit 33d4fbea.
> >
> > Reason for revert: We believe this is causing the build failure that closed the tree: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/17171?
> >
> > Original change's description:
> > > PSM: Support PSM RLWE based message definitions in Chromium
> > >
> > > This CL adds the communication between client and server
> > > for issuing and retrieving determination using PSM. It also
> > > supports the usage of private_membership third_party protos
> > > package in device_management_backend.
> > >
> > > BUG=chromium:1094675
> > >
> > > Binary-Size: Increase is temporary.
> > > Change-Id: If791aa1a4a936e1d42fde397a33c1a19c640359d
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245131
> > > Reviewed-by: David Benjamin <davidben@chromium.org>
> > > Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org>
> > > Reviewed-by: Pavol Marko <pmarko@chromium.org>
> > > Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#803532}
> >
> > TBR=davidben@chromium.org,emaxx@chromium.org,tikuta@chromium.org,pmarko@chromium.org,amraboelkher@google.com,amraboelkher@chromium.org
> >
> > Change-Id: I33f2f9200c3ef24d7c6059d116a88807d83aa0f0
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1094675
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388267
> > Reviewed-by: Tommy Martino <tmartino@chromium.org>
> > Commit-Queue: Tommy Martino <tmartino@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#803555}
>
> # Not skipping CQ checks because this is a reland.
>
>
> TBR=davidben@chromium.org,emaxx@chromium.org,tmartino@chromium.org,tikuta@chromium.org,pmarko@chromium.org,amraboelkher@google.com,amraboelkher@chromium.org
>
> Bug: chromium:1094675
> Binary-Size: Increase is temporary.
> Change-Id: Ia5c92b07b3614228823d2b4e883eb03e80474f37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388621
> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org>
> Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803700}

TBR=davidben@chromium.org,emaxx@chromium.org,tmartino@chromium.org,tikuta@chromium.org,pmarko@chromium.org,amraboelkher@google.com,amraboelkher@chromium.org

Bug: chromium:1094675
Binary-Size: Increase is temporary.
Change-Id: Ice3d8f33850374cf479348fae08ca5aa7ad6abbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388108Reviewed-by: Amr Aboelkher <amraboelkher@google.com>
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Cr-Commit-Position: refs/heads/master@{#803915}

This separates the web test code out of content/shell/. While it is
built into content_shell, it is only part of it when --run-web-tests
is used, and is not conceptually part of the content shell library
being embedded in other shell apps like extensions's shell, ash shell,
or the views example app.

R=avi@chromium.org, mmoss@chromium.org, sky@chromium.org
TBR=

Bug: 866140
Change-Id: I1787d7bbd3be27d1232ab6ddab64db2b5df1d3a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389045
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803914}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b9e466df..2b9e3dd7

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1f56e707bc4bab2a98304fbc58267d3227e81966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390721Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803913}

V4L2 does not support modifiers with the current API.
This is a way to allow UBWC to be turned on for
Qualcomm SOCs by using a special format.

This should be reverted once V4L2 has an api that
supports modifiers.

BUG=b:149525848
BUG=b:166275274
TEST=none

Change-Id: I89e8d543fc8f021fd184bbfe26fdab689747c330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343804
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803912}

https://quiche.googlesource.com/quiche.git/+log/79b266156ffb..edf934d71e96

$ git log 79b266156..edf934d71 --date=short --no-merges --format='%ad %ae %s'
2020-09-01 renjietang Avoid sending huge chunks of data in EndToEndTest.PostZeroRTTRequestDuringHandshake.
2020-09-01 wub Move the histograms that records the release time offset from QuicGsoBatchWriter to QuicBatchWriterBase.
2020-09-01 renjietang Do not QUIC_BUG 0-RTT stream data retransmission before 1-RTT keys arrive.
2020-09-01 vasilvv Automated g4 rollback of changelist 329381168.
2020-08-31 vasilvv Re-land cl/328561880
2020-08-31 renjietang Remove session pointer from PendingStream.
2020-08-31 fayang Close connection on packet serialization failures in SerializePacket.
2020-08-31 ianswett Deprecate gfe2_reloadable_flag_quic_bbrv2_ignore_inflight_lo.
2020-08-31 fayang Deprecate gfe2_reloadable_flag_quic_fix_on_ping_timeout.
2020-08-31 bnc Update default HTTP/3 priority.

Created with:
  roll-dep src/net/third_party/quiche/src

R=dschinazi@chromium.org

Change-Id: Id28992d2e98cf181b58a3d35aa21e88a69100ef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388951
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803911}

Bug: 1094358
Change-Id: I497c5de67f50a9727750704b578a4fa7f1f0d30e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386281Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Panos Astithas <pastithas@google.com>
Cr-Commit-Position: refs/heads/master@{#803910}

This CL fixes a bug where SkiaRenderer was improperly interpreting
the scaling from CopyOutputRequests. For example, if we want to
scale from 2 -> 1, we should shrink the SkCanvas by invoking
canvas->scale(0.5, 0.5). Currently, SkiaRenderer inverts the
operands so we actually end up zooming with a scale factor of 2.

Also, this CL removes an extraneous `makeImageSnapshot` that I
used for debugging but forgot to remove. Oops...

Bug: 1098435
Change-Id: Ibb5f55721a243f10230b8840a5ce8836ee789ad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385930
Commit-Queue: Brian Ho <hob@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803909}

Do not ignore SVG grouping elements in the accessibility tree on ChromeOS, so Select-to-speak can properly order SVG elements when reading them aloud.

AX-Relnotes: SVG grouping elements will now appear in the accessibility tree on ChromeOS.

Bug: 892822
Change-Id: I50226cef7d5d19f4c9326a10bb48c8828c16cabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375989Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Joel Riley <joelriley@google.com>
Cr-Commit-Position: refs/heads/master@{#803908}

AX-Relnotes: Update http to https for ChromeVox Tutorial Link (tiny security fix)
Change-Id: Ia0d40e04f7165127d4f0b8e3db4e29cb96c40ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387408
Commit-Queue: Josiah Krutz <josiahk@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803907}

This CL reorganizes a bit how constants are determined for the layout
algorithm of the mover/munder/moverunder elements, trying to match
more closely the text in the specification. In particular, the three
main cases are now considered [1] [2]:

1. The base is an embellished operator with the largeop property.
2. The base is an embellished operator with the stretchy property and
   stretch axis inline.
3. Otherwise

These are verified by underover-parameters-* WPT tests. Tests 1 and 2
cover the corresponding cases in the spec. The other tests verify the
otherwise clause, but will require follow-up work [3] [4]. Finally, this
CL updates the TODO comments in the underover algorithm to point to new
Chromium bug entries.

[1] https://mathml-refresh.github.io/mathml-core/#base-with-underscript
[2] https://mathml-refresh.github.io/mathml-core/#base-with-overscript
[3] http://crbug.com/1124289
[4] http://crbug.com/1124285

Bug: 6606, 1124285, 1124289
Change-Id: I89f26214ce42b64671490c55bc59835f7afcbbcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390760Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Rob Buis <rbuis@igalia.com>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#803906}

Disabling tests that are causing the Win7 32 bot to flake.

TBR=dschuff@chromium.org

Bug: 1059468
Change-Id: I892f60b178ab2383c195377878ead30c0b60417d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390461Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803905}

BUG=

Change-Id: Ia3b6dc5f8dfd6036a55a2dd91e76b9c94d6f9535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388706Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803904}

The two enums are very similar and serve similar purpose. Consolidate
into one to avoid confusion.

This CL added parent access controller as a new ash public interface.
Currently, it only contains the SupervisedAction enum used in this CL.
We can expose/move other parent access controller API through this
interface (for example show widget).

Bug: 1121863
Test: unit tests
Change-Id: I020d51cd231d3f3a8f1a68103cb3cdc11feb90ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378764
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Slow <xiyuan@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803903}

Context:
CL[1] moved some PRImpl's parameters it needed into CPRImpl, and
retrieved them from CPRImpl when PRImpl needs it. This is problematic,
because PRImpl could outlive CPRImpl, and so doing it could cause
NullPointerError (see the bug). This CL partially reverts CL[1] but
keeps the changes of the constructor signature because this is more
succinct than passing each one of the parameters. Since CPRImpl would
take over the PRImpl logic going forwards, passing only CPRImpl would
avoid the frequent change of the PRImpl constructor's signature.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2357630

Change:
* Before: CPRImpl retains the values that PRImpl need; after: PRImpl
keeps a reference of the value that itself needs
* Added a few null check or assert for mComponentPaymentRequestImpl
in case it's used after release.

Bug: 1122148

Change-Id: I00ac6e4ca3fccccd114132209465757f52fa0dc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378538Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803902}

Using wpt-import in Chromium bfcb9fc4.
With Chromium commits locally applied on WPT:
41cb9e56 "[css-pseudo] Support text properties in ::marker"
cbbbd581 "Fix flaky wpt pointerevent_mouse-pointer-preventdefault"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org, mek@chromium.org:
  external/wpt/webstorage

NOAUTOREVERT=true
TBR=lpz@google.com

No-Export: true
Change-Id: Icdc5f48c2431f703d8c872c305b029f9f621adb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390720Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803901}

This is now only invoked where necessary (60+ cores).
Makes the test runner compatible with both modern machines and
linux-trusty-rel (which uses a very old Xvfb).

Bug: 1122100
Change-Id: Ib68f356efaa8fa361d0c377845bba165635d5362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385923
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803900}

1. Adds Wifi Sync to Multidevice Subpage
2. Update tests to include Wifi Sync
3. Adds new search string tags for Wifi Sync
4. Refactored conditionally adding features to
GetMultiDeviceOptedOutSearchConcepts

Bug: 1117619
Change-Id: Iac0b065b2d1f244ae1318e6e69415a626c10d39a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386395Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jon Mann <jonmann@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Claude van der Merwe <cvandermerwe@google.com>
Cr-Commit-Position: refs/heads/master@{#803899}

This patch ships the already implemented properties introduced by the
CSS Logical spec.

Spec: https://drafts.csswg.org/css-logical/#box

Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/E7f_WZOcTgQ/

Bug: 538475
Change-Id: I71b4a43fc3c4b14fb55ae456370d8cc4b04c903f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379720Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#803898}

Bug: N/A
Change-Id: Ibe79782fa3f8edc7027f1b6e1f9e6dda2661a3c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391040Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803897}

This is a tray icon to launch Bloom.
As the UX team has not decided yet how Bloom should be launched,
this is is a temporary prototype and as such it is not completely
fleshed out.
More specifically, no strings have been localized, and the icon is a
random other icon.

This is hidden behid the |EnableBloom| feature flag and as such will not
impact anybody.

Bug: b/165871172
Tests: ash_unittests --gtest_filter="Bloom*.*"
Change-Id: I87a708f933d450f98659abeb9398370b993d516c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368850
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Reviewed-by: Xiyuan Slow <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803896}

This delays the startDiscovery() call until we actually show the
discovery page instead of when the component is attached. This is
important for when a user has not gone through the onboarding yet.

Bug: None
Change-Id: I5c8911ae855bfdc6d66d5c0736f31be8b124e083
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388387
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#803895}

The WebAuthn DLL seems to load DLL too.

This is a follow up on :
  https://chromium-review.googlesource.com/c/chromium/src/+/2376878

From these hang reports:
  87b0bdd85d6426a8
  ed2e7a916cbfee87
  b6ab544feec07866
  3c4e02aff6f7ad7a
  ce79755a1e1abf2f

Stackframe:
  LdrResolveDelayLoadedAPI
 _delayLoadHelper2
 _tailMerge_cryptngc_dll
 WebAuthNIsUserVerifyingPlatformAuthenticatorAvailable
 device::WinWebAuthnApiAuthenticator::IsUserVerifyingPlatformAuthenticatorAvailable

R=joenotcharles@google.com, martinkr@google.com

Bug: 973868
Change-Id: I0e6fde3ce94f2e1e8105127df4ba492970821203
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386100Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803894}

https://skia.googlesource.com/skia.git/+log/1338a37a1add..90b027a36b4c

2020-09-02 mtklein@google.com disable -Wpsabi everywhere
2020-09-02 bsalomon@google.com Add idea of DataType to SkYUVAPixmapInfo.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: michaelludwig@google.com
Change-Id: I529e21e57e60be8bce31d819ab020f476571b15a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390701Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803893}

The screenshots in the bug.

Bug: 1124281
Change-Id: Ic7e494db812d11844e77b7956349109bf2656eb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390204Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Milica Selakovic <selakovic@google.com>
Cr-Commit-Position: refs/heads/master@{#803892}

The newer ones take StringPieces, which is generally safer, and more
user friendly for the consumers that already have StringPieces or
std::strings.

Bug: 1123179
Change-Id: Ida1aec4de6609db104702c3121c7eb03ef6582d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382485Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803891}

Bug: b:158566609
Change-Id: I9f198d00a40738e69b2240e8972aff60cd8b66f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388622
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#803890}

Adds a missing test for when the active profile is stored on disk but
not currently loaded. This is only relevant for Chrome browser as this
doesn't happen on CrOS.

Bug: None
Change-Id: I4f691f97ed7de882ec8f7f0886f6ebfff762a899
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388624Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803889}

To avoid possible IO task runner contention during show-on-startup
this CL defers auditing by a couple of minutes.

Change-Id: Ie01b66427bf7eca4c8a4570ff5679250b512e822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386416Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803888}

This reverts commit cdb7f942.

Reason for revert: Causes tablet instrumentation tests to fail

Original change's description:
> [ToolbarMVC] Hide MenuButton interactions in toolbar.top behind MenuButtonCoordinator
> 
> Most method calls are translated 1:1 by forwarding the call to the equivalent MenuButton or View method. A notable exception is handling of the tab switcher animation, which currently requires a view in order to perform canvas translation before drawing the button in its animated state. In this case, we provide a direct accessor for the view.
> 
> Bug: 1086676
> Change-Id: I172c7bb5d9eeee307a153ad355a2a93702d139ca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356690
> Commit-Queue: Patrick Noland <pnoland@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803701}

TBR=mdjones@chromium.org,pnoland@chromium.org

Change-Id: I17dfd57363490e97da7f686e88dff1d9556db827
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1086676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391003Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803887}

- Adds new icons
- current UI https://imgur.com/nnyirs2
- UI spec https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.g7dc3c1fe01_5_115

Bug: 1093185
Change-Id: I2b11a74364f06c4b0667e0dc8351577f36f94890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382016Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#803886}

crbug.com/1123934: Handle errors in WebUI
crbug.com/1123942: Pass attachments to WebUI
crbug.com/1123943: Pass contact name to WebUI

Bug: None
Change-Id: I5b6c1552f730733408337373f995ad05c10e9dfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389204Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803885}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4855aad4994b..c9886cc22e82

2020-09-02 adithyas@chromium.org Portals: Fix for duplicate messages after activation
2020-09-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-09-02 sigurds@chromium.org [ts] Add helpers to assert element type
2020-09-02 jacktfranklin@chromium.org Tidy up runtime CSS component server code
2020-09-02 jacktfranklin@chromium.org Fix 404 layoutPane.css in unit tests
2020-09-02 tvanderlippe@chromium.org Typecheck ui/Fragment.js with TypeScript
2020-09-02 petermarshall@chromium.org [typescript] TypeScript-ify accessibility/AccessibilityNodeView.js
2020-09-02 aerotwist@chromium.org Update Closure Compiler and fix associated errors

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1069487
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I149566baa71f3468575be70478447fe8b4d7bd5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390425Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803884}

https://android.googlesource.com/platform/external/perfetto.git/+log/b7642c19404f..3ffd1d826be3

2020-09-02 dproy@google.com Merge "metrics: Add a way to serialize descriptors in memory"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I5ee972d4fe91ea91dec5e00507675060e2ed0e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390424Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803883}

Now UpdateScreen observes power changes only when it is shown.

Bug: 1124201
Change-Id: Ic67f2e3c4fc6c6fb528235d74faa2f2929c819b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390220
Commit-Queue: Danila Kuzmin <dkuzmin@google.com>
Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803882}

FormInputAccessoryMediator is fetching suggestions from Autofill and
PasswordManager when the keyboard state changes, even in cases when the
keyboard becomes invisible and the user is not seeing any of the fetched
suggestions. If the user wants to see suggestions, he has to open the
keyboard, and then suggestions are fetched again.

This is leading to a bug in a password generation flow, when the
keyboard is hidden prior to a submission of form with generated
password, and a request to refetch suggestions breaks the flow.

Bug: 1122049
Change-Id: Ia65489304333e3887d35a7976b83874f892fe033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377813Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/master@{#803881}

Bug: 1108983

Change-Id: I1db76c911fb0ddef7fe42a8d7ee23714bd42319e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389121Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803880}