- 30 Jan, 2018 40 commits
-
-
Ken Rockot authored
Gets rid of the ThrottlingURLLoader::CreateLoaderAndStart override which takes a callback instead of a SharedURLLoaderFactory. Moves LoaderCallback into URLLoaderRequestHandler to clarify its relation to implementations of that class. Introduces SingleRequestURLLoaderFactory as an implementation of SharedURLLoaderFactory that handles a single loader request using a OnceCallback provided at construction time. Adapts NavigationURLLoaderNetworkService to use the new API. Bug: 721414 Change-Id: I1030aef2096edeb4fe525999e6b7d1a626a4110c Reviewed-on: https://chromium-review.googlesource.com/889650 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532985}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c62a1ec..adcf8626 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib596ed4a556f44b753050fbf2518b3d55ad05d2a Reviewed-on: https://chromium-review.googlesource.com/893280Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532984}
-
Charles Zhao authored
Change-Id: I2bef2e12d3a5fa5ac42535da709bfe9d337fdaa1 Reviewed-on: https://chromium-review.googlesource.com/892181Reviewed-by:
Philippe Hamel <hamelphi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#532983}
-
Steve Kobes authored
These weren't caught in http://crrev.com/532638, but they are failing on win7_chromium_rel_ng: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/91452 Bug: 711468 Change-Id: Iae4b8a5e5a56e96bc835556fe6cc5fcdf11dedac Reviewed-on: https://chromium-review.googlesource.com/893214Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#532982}
-
gogerald authored
Bug: 763417 Change-Id: Ia02e2e00f2e6a315ae16ee8de852e756a79c0de6 Reviewed-on: https://chromium-review.googlesource.com/891978Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#532981}
-
Daniel Blakemore authored
A new mailto handler provider is being added to Chrome for iOS. This flag will wrap all invocations of the new provider during development. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9e24a5f256fc5e220120e173080a67301084b506 Reviewed-on: https://chromium-review.googlesource.com/876729Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Daniel Blakemore <danblakemore@google.com> Cr-Commit-Position: refs/heads/master@{#532980}
-
Nico Weber authored
Follow-up to https://chromium-review.googlesource.com/c/889942/ Also update a very old comment that I believe tries to say that the fallthrough is intentional: In https://websvn.kde.org/trunk/kdelibs/khtml/rendering/bidi.cpp?r1=56133&r2=56134&pathrev=65933 the code and comment looked like so: switch(dirCurrent) { ... case QChar::DirEN: if(status.lastStrong != QChar::DirAL) { // if last strong was AL change EN to AN ... } case QChar::DirAN: dirCurrent = QChar::DirAN; ... All the constants have been renamed several times, but the comment was touched just once after being added in https://websvn.kde.org/trunk/kdelibs/khtml/rendering/bidi.cpp?limit_changes=0&view=markup&pathrev=42417 in Mar 2000 (in a commit saying "merge of the new_rendering branch." -- I couldn't find where the new_rendering branch is. Probably in some CVS repo, but I didn't manage to find it) and that's in 56134 linked above, which changed it from // if last strong was AL change EN to AL to // if last strong was AL change EN to AN which looks like a typo fix. This CL was uploaded by git cl split. R=fmalita@chromium.org Bug: 177475 Change-Id: I55de0202f9a67436a4abb630291d1280ee489d4d Reviewed-on: https://chromium-review.googlesource.com/890430 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#532979}
-
Dominick Ng authored
This CL removes several different app banner testing files, and replaces them by calling the necessary JavaScript setup code in one test file. For instance, all tests will no longer have the "appinstalled" title overwriting, as that will only be active when the appropriate setup JavaScript is run. This allows future tests to be more easily added, and reduces collisions when manipulating the page title. BUG=806923 Change-Id: Ia28837b8675a2e1fe329cb1df1be4798ddb03d02 Reviewed-on: https://chromium-review.googlesource.com/892182 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#532978}
-
Sigurdur Asgeirsson authored
Bug: 799526 Change-Id: Id1f4e62914232e4cf37d550f6914690334f7ddee Reviewed-on: https://chromium-review.googlesource.com/893207Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532977}
-
Stephen Chenney authored
The ImageBitmap constructor that takes pixel data and a width and height does not check for success of the skia MakeRasterCopy call, that will return null for a host of reasons. Add the check. R=junov@chromium.org BUG=805972 Null check in ImageBitmap:ImageBitmap Change-Id: I4cd8464b21c3b14488ae8a948864b091f17d006a Reviewed-on: https://chromium-review.googlesource.com/887678Reviewed-by:
-
Ian Clelland authored
The code checks both the runtime flag and the origin trial status, when the origin trial check implicitly checks the runtime flag first. Removing this antipattern will allow us to eventually mark the inappropriate checks as private, and reduce inadvertent bugs. Bug: 799949 Change-Id: I8af29c46a0f5eefacb366e87d378c86b7d4ac71f Reviewed-on: https://chromium-review.googlesource.com/891573Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#532975}
-
liberato@chromium.org authored
OnSurfaceDestroyed was unconditionally dereferencing |target_surface_bundle_|, but this can be cleared once the codec enters a terminal state. A null target bundle should just be ignored anyway. Bug: 806630 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I612c8a0c95ec0e3b918789384f44ad3a01fd2559 Reviewed-on: https://chromium-review.googlesource.com/893638Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#532974}
-
Jialiu Lin authored
For some rare cases, service_ in CheckClientDownloadRequest is already set to null when OnDownloadDestroyed is called, which as a result will make item_ still dangle there, and causes crash at the DCHECK(item_==NULL). Bug: 806785 Change-Id: I384f66ca94d6695d870a632d52b9be26a0f9a3a3 Reviewed-on: https://chromium-review.googlesource.com/891808Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#532973}
-
Ian Clelland authored
This fixes the problem where Feature Policy can be independently disabled through runtime flags (or chrome://flags), while the features which depend on it, such as FeaturePolicyForPermissions, remain enabled. Bug: 806362 Change-Id: Ied92dc74022a02f22a11c3ce68bd62c1aa98eaae Reviewed-on: https://chromium-review.googlesource.com/893598Reviewed-by:
-
David Bokan authored
It looks like we sometimes recompute the root scroller on an HTMLFrameOwnerElement that's still connected to the DOM tree but doesn't have a ContentFrame. One way this can happen is through layouts caused from unload handlers. This CL adds an early out in ApplyRootScrollerProperties since a detached frame doesn't need it's properties reset. Bug: 805317 Change-Id: I6d285b10a69f74f05604bda5f654fca96fc35238 Reviewed-on: https://chromium-review.googlesource.com/887733 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#532971}
-
Peter Kotwicz authored
This CL: - Replaces calls to ExternalNavigationDelegateImpl#isSpecializedHandlerAvailable() with calls to #countSpecializedHandlers() because #isSpecializedHandlerAvailable() has just one caller - Replaces ChromeBrowserTestRule with NativeLibraryTestRule - Uses a mock context for both ContextUtils#getApplicationContext() and for TabRedirectHandler instead of just for TabRedirectHandler - Makes TestPackageManager#queryIntentActivities() and TestExternalNavigationDelegate#queryIntentActivities() use same implementation. - Changes tests to register relevant http:// and https:// handlers at the beginning of the test. This is a change of behavior. Previously, most URLs would be handled by the "foo" external app - Changes TestExternalNavigationDelegate#mQueryIntentOverride from tristate to boolean. The "true behavior" was nuked but the "false behavior" was preserved. BUG=None Change-Id: If212afde6e4c12d4f08576c4bd26392b8732bc09 Reviewed-on: https://chromium-review.googlesource.com/891744 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#532970}
-
Victor Costan authored
Our SQLite VFS [1] wrapper implementation unconditionally wraps xCurrentTime(). However, when SQLite is compiled with the SQLITE_OMIT_DEPRECATED option [2], xCurrentTime() is null for the VFS implementations that ship with SQLite, because xCurrentTime() was deprecated in favor of xCurrentTimeInt64(). This CL replaces the unconditional wrapper with a conditional wrapper. This ensures that our VFS wrapper exposes an xCurrentTimeInt64() implementation when used with a modern SQLite library (like the one bundled with Chromium), and an xCurrentTime() implementation when using an older SQLite version (which might be the case when using the library bundled with the operating system). [1] https://www.sqlite.org/c3ref/vfs.html [2] https://www.sqlite.org/compile.html#omit_deprecated Bug: 807093 Change-Id: Id26cc4517a1a23692e7860ed620348c027db990f Reviewed-on: https://chromium-review.googlesource.com/892484Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#532969}
-
Devlin Cronin authored
The i18n custom bindings create v8 values from results for language detection, but do so in an inefficient way (constructing a base::Value and then converting to v8::Value). Update this to use gin::DataObjectBuilder to construct the v8 value directly, and, while we're at it, use some C++11 awesomeness in movable types. Bug: None Change-Id: I80597627b0b3803e50ecbe34009682161d178c7d Reviewed-on: https://chromium-review.googlesource.com/892202Reviewed-by:
-
Nate Chapin authored
Change-Id: I26c2a054b9f1e5eb076acd677e1223058825f6d6 Bug: 803416 Test: fast/loader/document-open-iframe-then-detach.html Change-Id: I26c2a054b9f1e5eb076acd677e1223058825f6d6 Reviewed-on: https://chromium-review.googlesource.com/887298Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#532967}
-
Stephen McGruer authored
Change-Id: Idf6dd882d2d50b1ec349f245d76717553ee266b3 Reviewed-on: https://chromium-review.googlesource.com/882002Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#532966}
-
Hidy Han authored
Bug: 724160 Change-Id: I9ede628f60f2ff32d09bcec9ef365db9246f4c98 Reviewed-on: https://chromium-review.googlesource.com/871046 Commit-Queue: Hidy Han <hidyhan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532965}
-
https://webrtc.googlesource.com/src.git/+log/79d331b09102..cf30d8b1ec22 $ git log 79d331b09..cf30d8b1e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=NONE,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I30491d79540eafe636e555734277e417854399fb Reviewed-on: https://chromium-review.googlesource.com/893525Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532964}
-
Steven Bennetts authored
There is an edge case where SortNetworkList may destroy the default network, causing a crash. This CL fixes that. Bug: 805322 Change-Id: I3d880dacc567babea08d7b9f21c5c8759e290f83 Reviewed-on: https://chromium-review.googlesource.com/883971 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#532963}
-
Robert Ogden authored
Bug: 807049 Change-Id: Ia223724629db4f04a676a023a4dbda365a0dbba3 Reviewed-on: https://chromium-review.googlesource.com/893719Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@google.com> Cr-Commit-Position: refs/heads/master@{#532962}
-
https://pdfium.googlesource.com/pdfium.git/+log/af9f83656f98..1917cdd8c90b $ git log af9f83656..1917cdd8c --date=short --no-merges --format='%ad %ae %s' 2018-01-30 dsinclair Cleanup some CPDFSDK_Widget XFA code. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic7870559e0596ac43919bf0732a649998e138926 Reviewed-on: https://chromium-review.googlesource.com/893599Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532961}
-
Helen Li authored
The file is not named correctly. This CL uses the correct name suffix. Bug: 721401 Change-Id: I9c0976bc802cee9f3c13141e6edb0b4ba81de97a Reviewed-on: https://chromium-review.googlesource.com/891440Reviewed-by:
-
Nico Weber authored
This CL was uploaded by git cl split. R=zhenw@chromium.org Bug: 177475 Change-Id: I87d874d14490cd2476ef10f7b0aeaa058aa9273f Reviewed-on: https://chromium-review.googlesource.com/889961Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532959}
-
James Cook authored
The policy for test code in //ash is that it should live in the directory of the code under test, which in this case is //ash/wm. This fixes a TODO in //ash/BUILD.gn Bug: none Test: ash_unittests Change-Id: Id40eaa137991efbb47b83c322eb6cf9c7bb405ec Reviewed-on: https://chromium-review.googlesource.com/892198 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#532958}
-
Samuel Huang authored
This reverts commit 53b1b7da. Reason for revert: The new test webaudio/BiquadFilter/no-dezippering.html is failing under Mac 10.10. Original change's description: > Remove Dezippering from BiquadFilter > > Remove dezippering from all of the attributes. The value will now > change immediately instead of gradually changing from the old value > to the new value. > > Chromium Feature: https://www.chromestatus.com/features/5287995770929152 > Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ > > Bug: 752986 > Test: BiquadFilter/dezipper.html > Change-Id: I86840159709158fd52a69a7c3c5f279267277d44 > Reviewed-on: https://chromium-review.googlesource.com/612104 > Commit-Queue: Raymond Toy <rtoy@chromium.org> > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532910} TBR=rtoy@chromium.org,hongchan@chromium.org Change-Id: I30c98f8aad3c8a1f7df22e55912a4f86d94d7dfa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 752986 Reviewed-on: https://chromium-review.googlesource.com/893531Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#532957}
-
Rouslan Solomakhin authored
Bug: 743173 Change-Id: Ie31e92bff4fda5907d45b931dd79caeac79b36ff Reviewed-on: https://chromium-review.googlesource.com/669319Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532956}
-
Gayane Petrosyan authored
Bug: None Change-Id: I47fc0e4a15e178072f65358ad8044def01ba1909 Reviewed-on: https://chromium-review.googlesource.com/889618Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#532955}
-
Yixin Wang authored
This reverts commit 5ef6e548. Reason for revert: net_unittests failing on android_cronet. Original change's description: > Reland "Make PUSH_PROMISE headers URL-parsing more robust and conform to HTTP/2 spec" > > Reland of https://chromium-review.googlesource.com/c/chromium/src/+/887970. > > MSAN use-of-uninitialized-value should be fixed. > > Change-Id: I392ad1a83a269b47ff0c8583f6c72e18a4a0e5b9 > Reviewed-on: https://chromium-review.googlesource.com/891302 > Commit-Queue: Yixin Wang <wangyix@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532669} TBR=rch@chromium.org,wangyix@chromium.org Change-Id: I19d5f50c17b052f72cfa6025bcea2b4770363666 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/893864Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/ab2621d3e2d2..c4e31092b13e $ git log ab2621d3e..c4e31092b --date=short --no-merges --format='%ad %ae %s' 2018-01-30 reed don't draw images with nonfinite dst bounds 2018-01-30 angle-skia-autoroll Roll skia/third_party/externals/angle2/ efb5a5c8f..6969132c1 (1 commit) 2018-01-30 reed handle clipping large triangles Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I2027c9d264d8b24f3058c671f38dedde548edf45 Reviewed-on: https://chromium-review.googlesource.com/893642 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532953}
-
Josh Karlin authored
Creates a new binary, subresource_indexing_tool, that takes an unindexed ruleset as input and writes an indexed ruleset as output. Bug: 793025 Change-Id: Ieeb10aab4ba80c83baf8058fe202e4d4fcd770e1 Reviewed-on: https://chromium-review.googlesource.com/891140 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#532952}
-
Reilly Grant authored
This change cleans up the logic in OnResolveProxy and its two helper functions (one of which is removed) so that it is clearer what logic is run only when a request is eligible for the data reduction proxy or only when the request will be made through the data reduction proxy. Duplicate checks are removed or the later ones turned into DCHECKs to clarify assumptions. Bug: 721403 Change-Id: I271a553e0c1406921c6a2a23ab21241ba3095df5 Reviewed-on: https://chromium-review.googlesource.com/887650 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Lei Zhang authored
Instead of a custom ClampInt() function. Change-Id: I7dc852b0c681053e7b90ce3d5ef05a699d0f12f3 Reviewed-on: https://chromium-review.googlesource.com/891943Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532950}
-
Mounir Lamouri authored
This is also allowing navigations with gesture to carry the flag such as middle click on links and CTRL+click. A side effect is to be able to prevent non-renderer initiated navigations to carry the flag such as reloads. Bug: 799136, 759448 Change-Id: I25836f8a4e9aca5a60dc095c6d0a81d480027124 Reviewed-on: https://chromium-review.googlesource.com/873450Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
-
spqchan authored
Currently, the extensions can go in an incorrect hover state when they're being reordered via drag and drop. This bug fixes it by preventing the buttons to enter the hover state when a button is dragged. Bug: 793572 Change-Id: I1275882b68bbafd901f5edeab4e5c9b93286e699 Reviewed-on: https://chromium-review.googlesource.com/874523Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532948}
-
Gabriel Charette authored
The mul/div operators are tricky. operator/ works when |a| is small enough (in absolute value) to deterministically not risk overflow. operator*() on the other hand doesn't because of a limitation in __builtin_mul_overflow. We could do some template hacking to make operator*(a) == operator/(1.0/a) when |a| is a constant expression. Bug: 761570 Change-Id: I9906edfc049017ad19872e4a586b2ec675404850 Reviewed-on: https://chromium-review.googlesource.com/886344Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#532947}
-
Matt Mueller authored
On android, adb is used to forward connections from the device to the host, but there isn't a way to reserve the source port before deciding which destination port on the host to forward it to. Change RemoteTestServer reserve a port for AIA & OCSP, and forward it to another port, like it already does on Fuchsia. Unlike Fuchsia, the second adb forwarding step is still required to forward the connection from device to host. Change-Id: I739543fd0036f189928b5c7ce31c4d9a520e1cf0 Reviewed-on: https://chromium-review.googlesource.com/887171Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#532946}
-
